Re: [edk2-devel] [PATCH v1] IntelFsp2Pkg: Add get and set FspSmmInit upd data pointer functions

["Ashraf Ali S" <ashraf.ali.s@intel.com>]

Reviewed-by: S, Ashraf Ali <ashraf.ali.s@intel.com>

Thanks.,
S, Ashraf Ali

-----Original Message-----
From: Chiu, Chasel <chasel.chiu@intel.com> 
Sent: Friday, August 25, 2023 9:37 AM
To: Zhang, Hongbin1 <hongbin1.zhang@intel.com>; devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Duggapu, Chinni B <chinni.b.duggapu@intel.com>; Ng, Ray Han Lim <ray.han.lim.ng@intel.com>; Zeng, Star <star.zeng@intel.com>; Kuo, Ted <ted.kuo@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>; Mohapatra, Susovan <susovan.mohapatra@intel.com>
Subject: RE: [PATCH v1] IntelFsp2Pkg: Add get and set FspSmmInit upd data pointer functions

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

Thanks,
Chasel


> -----Original Message-----
> From: Zhang, Hongbin1 <hongbin1.zhang@intel.com>
> Sent: Thursday, August 24, 2023 8:15 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Hongbin1 <hongbin1.zhang@intel.com>; Chiu, Chasel 
> <chasel.chiu@intel.com>; Desimone, Nathaniel L 
> <nathaniel.l.desimone@intel.com>; Duggapu, Chinni B 
> <chinni.b.duggapu@intel.com>; Ng, Ray Han Lim 
> <ray.han.lim.ng@intel.com>; Zeng, Star <star.zeng@intel.com>; Kuo, Ted 
> <ted.kuo@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>; 
> Mohapatra, Susovan <susovan.mohapatra@intel.com>
> Subject: [PATCH v1] IntelFsp2Pkg: Add get and set FspSmmInit upd data 
> pointer functions
> 
> FSP-SMM module need get and set FspSmmInit upd data pointer functions 
> to get and set upd settings.
> 
> Signed-off-by: Hongbin1 Zhang <hongbin1.zhang@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
> Cc: Ray Han Lim Ng <ray.han.lim.ng@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Ted Kuo <ted.kuo@intel.com>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> Cc: Susovan Mohapatra <susovan.mohapatra@intel.com>
> ---
>  IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c | 41
> ++++++++++++++++++++
>  IntelFsp2Pkg/Include/Library/FspCommonLib.h          | 22 +++++++++++
>  2 files changed, 63 insertions(+)
> 
> diff --git a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> index 6f6a086111..d33d01fe22 100644
> --- a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> +++ b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> @@ -372,6 +372,47 @@ GetFspSiliconInitUpdDataPointer (
>    return FspData->SiliconInitUpdPtr;
>  }
> 
> +/**
> +  This function sets the FspSmmInit UPD data pointer.
> +
> +  @param[in] SmmInitUpdPtr   FspSmmInit UPD data pointer.
> +**/
> +VOID
> +EFIAPI
> +SetFspSmmInitUpdDataPointer (
> +  IN VOID  *SmmInitUpdPtr
> +  )
> +{
> +  FSP_GLOBAL_DATA  *FspData;
> +
> +  //
> +  // Get the FSP Global Data Pointer
> +  //
> +  FspData = GetFspGlobalDataPointer ();
> +
> +  //
> +  // Set the FspSmmInit UPD data pointer.
> +  //
> +  FspData->SmmInitUpdPtr = SmmInitUpdPtr; }
> +
> +/**
> +  This function gets the FspSmmInit UPD data pointer.
> +
> +  @return FspSmmInit UPD data pointer.
> +**/
> +VOID *
> +EFIAPI
> +GetFspSmmInitUpdDataPointer (
> +  VOID
> +  )
> +{
> +  FSP_GLOBAL_DATA  *FspData;
> +
> +  FspData = GetFspGlobalDataPointer ();
> +  return FspData->SmmInitUpdPtr;
> +}
> +
>  /**
>    Set FSP measurement point timestamp.
> 
> diff --git a/IntelFsp2Pkg/Include/Library/FspCommonLib.h
> b/IntelFsp2Pkg/Include/Library/FspCommonLib.h
> index 13b67f8822..12d993b7cc 100644
> --- a/IntelFsp2Pkg/Include/Library/FspCommonLib.h
> +++ b/IntelFsp2Pkg/Include/Library/FspCommonLib.h
> @@ -192,6 +192,28 @@ GetFspSiliconInitUpdDataPointer (
>    VOID
>    );
> 
> +/**
> +  This function sets the smm init UPD data pointer.
> +
> +  @param[in] SmmInitUpdPtr   smm init UPD data pointer.
> +**/
> +VOID
> +EFIAPI
> +SetFspSmmInitUpdDataPointer (
> +  IN VOID  *SmmInitUpdPtr
> +  );
> +
> +/**
> +  This function gets the smm init UPD data pointer.
> +
> +  @return smm init UPD data pointer.
> +**/
> +VOID *
> +EFIAPI
> +GetFspSmmInitUpdDataPointer (
> +  VOID
> +  );
> +
>  /**
>    Set FSP measurement point timestamp.
> 
> --
> 2.37.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108031): https://edk2.groups.io/g/devel/message/108031
Mute This Topic: https://groups.io/mt/100950055/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-