From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 485FBD801E7 for ; Tue, 6 Aug 2024 05:47:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+nPo4K7/7HbzGm60vRJHRfOQMmz9ZpxIJ20JKdJ2jHY=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1722923247; v=1; b=YGY6HpJeACxGIr8r4vQO/7yMSil3eFaajOMBBoTiyyfCzLF6VbITlrDT4H1GP9I71bY77fAl pS6EByyiBjEIYxG8yoLI2hlCU5DNuPqFH/Hjg0T8xWWOYfV8NKMiLWpXOtUclCu2SMYNFUfHCFa DbjQg0m/w7sPv6/3f/B66ZUJHTDew4/kEEUkFSZNSAuXmwtupsM8PGRhdxwb4gNiEhfKRkc9O+/ XHaKg7g6m2NuVOvdAqFXJQnKzyIFzn9k29ahrixZ/RBURZvtloPk31Np4f+1lBg3lfJftLkv/6U 1Gi3/T/9UzAkQIgg48UOWaCiBCKBZpy6GUQR7qbGFBGxA== X-Received: by 127.0.0.2 with SMTP id DEuUYY7687511xHM0QSOME70; Mon, 05 Aug 2024 22:47:26 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mx.groups.io with SMTP id smtpd.web10.829.1722923240798540941 for ; Mon, 05 Aug 2024 22:47:21 -0700 X-CSE-ConnectionGUID: 3Q4A6buWQUyAoDfnJafewQ== X-CSE-MsgGUID: 2S7mvTQPTOWM5Mecy+4k1g== X-IronPort-AV: E=McAfee;i="6700,10204,11155"; a="31550547" X-IronPort-AV: E=Sophos;i="6.09,266,1716274800"; d="scan'208";a="31550547" X-Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2024 22:47:20 -0700 X-CSE-ConnectionGUID: 1Ivmo+3OSGC02eDNeIjY+w== X-CSE-MsgGUID: aAf2Gvx1T3C7ztJKKXv2EQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,266,1716274800"; d="scan'208";a="79652538" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Aug 2024 22:47:20 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 5 Aug 2024 22:47:19 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 5 Aug 2024 22:47:19 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 5 Aug 2024 22:47:07 -0700 X-Received: from DM4PR11MB5280.namprd11.prod.outlook.com (2603:10b6:5:38b::18) by SA2PR11MB4875.namprd11.prod.outlook.com (2603:10b6:806:11a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.21; Tue, 6 Aug 2024 05:47:05 +0000 X-Received: from DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::5fec:514e:f4f3:a8b4]) by DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::5fec:514e:f4f3:a8b4%5]) with mapi id 15.20.7828.023; Tue, 6 Aug 2024 05:47:05 +0000 From: "Ashraf Ali S" To: "Ck, Chitralekha" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH] IntelSiliconPkg: Add IgdOpRegion32.h to support IGD OpRegion v3.2 Thread-Topic: [PATCH] IntelSiliconPkg: Add IgdOpRegion32.h to support IGD OpRegion v3.2 Thread-Index: AQHa58H4B4CllojQ5EOXaCcEZ+lNNrIZtbuAgAACy6A= Date: Tue, 6 Aug 2024 05:47:05 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5280:EE_|SA2PR11MB4875:EE_ x-ms-office365-filtering-correlation-id: 95d65a18-7433-4462-acec-08dcb5db33c7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?OaN6iNUSMSNp+KRUkkARcLxxxsWDGhfYugHwkiiLe6P4tvwJgOTKXUpnKSfb?= =?us-ascii?Q?kCed17nv76rQ8AntlPgik24tU8LRhOY9DoEr5CWKFpOKgJbcajV+tNGlnx1L?= =?us-ascii?Q?pRb+mTEpc5c0DHWtQhrlRmNiau0vxap0AdYjiwGgfOUo+bATGfMzRt4xB5oA?= =?us-ascii?Q?8qSLq9hNqSqe+MHJSNWRKd4RqWoiIQGagckBs3QyQZ7svpiJxtIC8C6CIGrt?= =?us-ascii?Q?mkxvHX5raRdX3lo22KjcboEMlIR2pu/oPNpE4ivCaiAKRcPP/GQye6vyjVxR?= =?us-ascii?Q?DtJd4yulLfHg4uiN5+yHPQROYFQxid24aDr8Je/yJvjZQqSLRXflpArKcPZa?= =?us-ascii?Q?JvjLU7Gzu3iOMQGcLsXl3Ukcv3eVD8szN7lcucZ4esnLxztrqyzO74SjuUZ+?= =?us-ascii?Q?gHOy12IfK1FYvGtW8K+QEqA7xSZAUd6pdk3Eq9jhzmVLSAwpTV74e1U1qBM/?= =?us-ascii?Q?blcyupl0vRj4G3c3D6ffcApLH3+R3Bi+YQcyT+j/AZKdJwPtEjo3XlTLyRB/?= =?us-ascii?Q?14pZ/259v3bnx4vWpBUjO+rWqeivlKsNDmj4IOIJAEXzPqB7BuJp4HAlxSeU?= =?us-ascii?Q?HWWT5Jl9ZisrJ+GnbQeanLSBPWdFU26IAnZ9+ADbZlZbQOT2u1Vk00OMhffH?= =?us-ascii?Q?tHO5WLgf2WpgIpxoAUvHOUHHwDUCdUFPk+aUfHQ+R/aneFXKcdJ10LBWju5b?= =?us-ascii?Q?jVchYVPS93Z/tzKV2RHNpeGTvS4i5arV6ugmZupQmVsvJCNr+ipdKDhcAJik?= =?us-ascii?Q?aYyxn72wgzHJ86cYnDmtWTYvJ94989d8sO63yZY2i/xxwsc+5dox5o7fPXyY?= =?us-ascii?Q?MdYryjE3uWO751JfT4B2eU8+ooONTUJNGx4F7QFo/ZXytgCW/hRKhBJU9Kql?= =?us-ascii?Q?eQDZUetXajvfgJfpGN8ckgCXoXSQwDw921NfrirqPA5NDj2cpqrsDFiSss0J?= =?us-ascii?Q?69mdHOcxb4vDSBTrDzGGuWksQdEInatPkUPVmcumFseCN/9hWpUQJP1RoT1r?= =?us-ascii?Q?0Z46pMGONJis30gRS24dd6Gimf/21ndqyhseo/LZzXT+kcj0KlSnC+sts9oI?= =?us-ascii?Q?HRYJx0/NXL69Xk2Uj1r0jOwnGzZBfAfvRGPsrCSKa4TIWrY37ZiMF4uTUf1Y?= =?us-ascii?Q?L5aDEG4ykAMw6S45KtDFecYW4sDJolTdGHKFT5SSWDLnBzXuCqvRcGXLoyFE?= =?us-ascii?Q?Q8g5b6O52hjE7q08pdr8yYmbW0vuJxj1KuqqR3Y5k5Mc/Q1Tf6M2GGw2Y+EC?= =?us-ascii?Q?diejCRqGpfJCT49C/t9fi5ZeSm1kxBo8Em4ZmjDPIC8dvySE02RLYQMNb+NI?= =?us-ascii?Q?E31JvPi6yFtzAHKRemvADUbcinVetEhES8094PQx+gN9GtGL22F80cGUd1pz?= =?us-ascii?Q?sjJ+bh4=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EDrJHLRVVWb2lv00VYjsNm2HX1R4DeiyR8jvTmkS2OZ9Z8vbLLw5xbS92hFp?= =?us-ascii?Q?kEoRigORp+lKixiId3QChquzj2sCh55ODWyKAAiCNinVYYYeyUcCuVvrtwAy?= =?us-ascii?Q?O2gGYHNydclgr0w2+e2xclh89QKSZP22bnnfJP3XQdAH32a/WJWXYoGrwL22?= =?us-ascii?Q?KlUX5eHPDnPPUrnQHuezSGL8rbAqlizcpW/AZzyAWxV28DIIxYkeGByNkdBO?= =?us-ascii?Q?LX1NGy/rjrqBYoOeFGkAGrxLWmdRqH7X6DJOo2PxlQTRaA8DBh7RySBxjkFn?= =?us-ascii?Q?I7aqNW4Jivcf5svECctteaeSA8rJwVjMNI1Y06TuzdQTWVfb8FpDH2QJld2d?= =?us-ascii?Q?2+oiq7OIYyAS4/XvczwfMXLH4ANBgO4uRVe/YsGDSqFTPABbZ9t/cqbNRZRk?= =?us-ascii?Q?iyVgIYZvpKzXcqK5MR2qmkW0U6iZQ3zkX7Jo+YtCObCYkxM/eyDMn8vs7NAH?= =?us-ascii?Q?0AoVyJ8jeCPFZBZS1h9qf1L+/IviOqKXZ130ZTjL5H8IW2moD7PXUdcV6uSZ?= =?us-ascii?Q?bqIZDFekF/5MSFj5ldcIm2mNjGj8XHtNWEmquLiXDXLYjCjipZcotabeZAoT?= =?us-ascii?Q?aVcfYS+xGPEXCzMdmV6velndoX398xUKZNaWPHTTAZ+Y6sXz+ZEpAMTmr4Ow?= =?us-ascii?Q?j/ZtRakfc597rk1zC78hOAAwNnxQwOG8iNFrQ7I2sckB7kyjDBlZL56oWtkJ?= =?us-ascii?Q?vv+Q6aj12mxbjn5SWtg9Y5w6AHcyfivQIt6+gTytWdIUmW3HmTZ9FohHPwcz?= =?us-ascii?Q?tJZekoY+wow2S15BbkBdTOhrZdA36RVUN6gvUaT9uPaJE2FgMpN33IPCojsn?= =?us-ascii?Q?tuClewcY7/SH+wFMcp7xoqYh6Kklz81eTgsk148FjZcr+IizkuNilX8ITDfJ?= =?us-ascii?Q?OAgtx0LbnOG+wfgoERNhJ+31J9R1nHf58knxEhY6OqqSnaMZPkg/uhv/zJtd?= =?us-ascii?Q?5vBghhGks+DGx/oes6NapZ+NrHowmEv2TFas5xVcZnnh4oW/w+DydggxH+bs?= =?us-ascii?Q?FbDOviijXHoYOeg6egYQlZ20eDNk7inTx2K7J9pWoDq9CGa4eNAH4nd+r0uN?= =?us-ascii?Q?5Ar0eSKU28QUWLMHGBTnuNC+uOb24pMbIKy5v03QmiJJYW4T0Y48asQQX2eb?= =?us-ascii?Q?mscFhmPrllK9gqtahJfSjv9CM+eGXpp9OGj9HccnypAH8Hjst/Vz5iQh8K8a?= =?us-ascii?Q?5kzn8hGJHyClTxtO3DkbeDdJxh31vLFM6ELv3/1Oz8aUnovKomd0Qys/vhlI?= =?us-ascii?Q?W6RO60cbE1QOpierXkHIQ0xBPectt44QUT0tPpujTZ3LNYu3c4olc6QBAMhC?= =?us-ascii?Q?xFvj8lbSoaxlod50LdwufiU/wFth75gSFpELltjQwE+wKf2e21KAxd+ZScXA?= =?us-ascii?Q?pQPKN2fFB9E1ig5x3mrfPQF5uJ+gSHrj7LflGqL6GY8A1GCFZDlPNQinagxg?= =?us-ascii?Q?lDLy85CvtxBMkEmJljYpGgEot4mFxhnKd/TD9QAxslDml3/C5QU2OCWC3xFh?= =?us-ascii?Q?oBbj/AlHXcjj0ndmq3tpJlhpY07w7o+pQdPnAHZCshZRsgNPbA5Awi6bfGtA?= =?us-ascii?Q?W/MpooOv6OB4jJXE+EfXdwV5NldsaLnGJH59RQDE?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5280.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95d65a18-7433-4462-acec-08dcb5db33c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2024 05:47:05.0538 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3uZxKUr4Q/942niq6FZpt+y3tQNCsjZxw2t6taK3GrBDF/2rwn15pgC3JCwhqKIH50+fStVu08Fq9Si2IheHsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4875 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 05 Aug 2024 22:47:21 -0700 Resent-From: ashraf.ali.s@intel.com Reply-To: devel@edk2.groups.io,ashraf.ali.s@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: bsEOuVmk0N4a7rl1dXAyC8UTx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=YGY6HpJe; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) Reviewed-by: S, Ashraf Ali Approved the PR. Thanks., S, Ashraf Ali -----Original Message----- From: Ck, Chitralekha =20 Sent: Tuesday, August 6, 2024 11:07 AM To: devel@edk2.groups.io Cc: Ck, Chitralekha ; Chaganty, Rangasai V ; S, Ashraf Ali ; Ni, Ray = Subject: RE: [PATCH] IntelSiliconPkg: Add IgdOpRegion32.h to support IGD Op= Region v3.2 PR : https://github.com/tianocore/edk2-platforms/pull/177 -----Original Message----- From: Ck, Chitralekha Sent: Tuesday, August 6, 2024 11:01 AM To: devel@edk2.groups.io Cc: Ck, Chitralekha ; Ck; Chaganty, Rangasai V ; S, Ashraf Ali ; Ni, = Ray Subject: [PATCH] IntelSiliconPkg: Add IgdOpRegion32.h to support IGD OpRegi= on v3.2 - Backlight related fields in MBOX2 has uncalibrated brightness support - Valid Bit added for BCL in MBOX2 Signed-off-by: Ck, Chitralekha Cc: Rangasai V Chaganty Cc: Ashraf Ali S Cc: Ray Ni --- .../Include/IndustryStandard/IgdOpRegion32.h | 58 +++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/= IgdOpRegion32.h diff --git a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRe= gion32.h b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegi= on32.h new file mode 100644 index 00000000..657a1a6c --- /dev/null +++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion +++ 32.h @@ -0,0 +1,58 @@ +/** @file + IGD OpRegion definition from Intel Integrated Graphics Device=20 +OpRegion + Specification based on version 3.2. + + Copyright (c) 2024, Intel Corporation. All rights reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ +#ifndef _IGD_OPREGION_3_2_H_ +#define _IGD_OPREGION_3_2_H_ + +#include "IgdOpRegion30.h" + +#define IGD_OPREGION_HEADER_MBOX2_VER_3_2 BIT5 + +#pragma pack(1) + +/// +/// Backlight Brightness for LFP1 and LFP2 /// typedef union { + typedef struct { + UINT32 Brightness : 8; ///< Backlight Brightness + UINT32 Rsvd : 22; ///< Reserved Bit + UINT32 Ubs : 1; ///< Uncalibrated Brightness Support + UINT32 FValid : 1; ///< Field Valid Bit + } Bits; + UINT32 Data; +} IGD_BCL; + +/// +/// OpRegion Mailbox 2 - Backlight communication /// Offset 0x200, Size +0x100 /// typedef struct { + IGD_BCL BCL1; ///< Offset 0x200 Backlight Brightness for LFP1 + IGD_BCL BCL2; ///< Offset 0x204 Backlight Brightness for LFP2 + UINT32 CBL1; ///< Offset 0x208 Current User Brightness Level f= or LFP1 + UINT32 CBL2; ///< Offset 0x20C Current User Brightness Level f= or LFP2 + UINT32 BCM1[0x1E]; ///< Offset 0x210 Backlight Brightness Levels Dut= y Cycle Mapping Table for LFP1 + UINT32 BCM2[0x1E]; ///< Offset 0x288 Backlight Brightness Levels Dut= y Cycle Mapping Table for LFP2 +} IGD_OPREGION_MBOX2_VER_3_2; + + +/// +/// IGD OpRegion Structure +/// +typedef struct { + IGD_OPREGION_HEADER Header; ///< OpRegion header (Offset 0x0, Si= ze 0x100) + IGD_OPREGION_MBOX1_VER_3_0 MBox1; ///< Mailbox 1: Public ACPI=20 +Methods (Offset 0x100, Size 0x100) + IGD_OPREGION_MBOX2_VER_3_2 MBox2; ///< Mailbox 2: Backlight=20 +communication (Offset 0x200, Size 0x100) + IGD_OPREGION_MBOX3_VER_3_0 MBox3; ///< Mailbox 3: BIOS to Driver Notif= ication (Offset 0x300, Size 0x100) + IGD_OPREGION_MBOX4 MBox4; ///< Mailbox 4: Video BIOS Table (VB= T) (Offset 0x400, Size 0x1800) + IGD_OPREGION_MBOX5 MBox5; ///< Mailbox 5: BIOS to Driver Notif= ication Extension (Offset 0x1C00, Size 0x400) +} IGD_OPREGION_STRUCTURE_VER_3_2; +#pragma pack() + +#endif \ No newline at end of file -- 2.42.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120247): https://edk2.groups.io/g/devel/message/120247 Mute This Topic: https://groups.io/mt/107746663/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-