From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web08.6075.1665407763493316746 for ; Mon, 10 Oct 2022 06:16:04 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=DFviKiQo; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ashraf.ali.s@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665407763; x=1696943763; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=zRXaRj9HMcLHaChCkfOhrQe+GJ9ngFOnuGi8jrrhy7E=; b=DFviKiQorX4hZoNRf0dGNb1yvwxqk0CSYFSkhqWDXEixEN0ImZJaHT/R JaubLdl8gRBOpELJZ7NxKyJUT5Y7Ac/5HskSXGsyK/o4HHIQDroF7YcB8 4Gb/jK8bVigqOCFw19Sp/7jgpE2v0ZmWpnjwHHUn50HR1RrJgpnWzqDI6 lZzkNt6GJTbGxLvmMblfW9YxXYmyCskj166qDAD4WxBAXc7pPKMCBWdWk x0aDxqvBalF+0TscM+gUpGvz+dk/014JxoMDbSviTfE4kazbl77D7D1Jq sc3UNPijB5nQ/+THTROeRe+PyKXOYRkRmdxEUFLORt7wjVe2WcKh5u+0+ Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="283947491" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="283947491" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2022 06:16:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="659145130" X-IronPort-AV: E=Sophos;i="5.95,173,1661842800"; d="scan'208";a="659145130" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga001.jf.intel.com with ESMTP; 10 Oct 2022 06:15:52 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 10 Oct 2022 06:15:50 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 10 Oct 2022 06:15:50 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 10 Oct 2022 06:15:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G2eTwot2xEiAXKIltlh7ENZF46CRsQKtm+Y7SxRCDT0shDLbaPuKB8Ebt1gDZ6unwmZbU5DvbtZljLhpySXvsfWZjxhzjl0Zv64AEsSvTaXgXA5nUGMr9rXjoZhAIl1hdbrN/88drlulxV1Ju72Ayq2Ph5FGD8VhGeekwJwpxr0EQWMomHT8vDA+KlwUntze6P341donu3iJTKn+rAyYcu7qoG7wWu4tSa25/Xld64Fizs/76PyjBuFy/z/3nLkqATOaxbNAPHBPLd6YOC1nywrPhK9V4DUbzUs14QsSrVX+8NegCb9QCEn1rO8FGJYwEIwhyZ+I99e/cYyoA5h+5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p/RYOu2mlA8CnJ72xsZ0i5heVJ0UFStVrbqjmyonyfQ=; b=G873XaFJi2Kux00cwhiA1vxM8Lyf8ikZUVRFz6076/AWWxeTEOrDVj5XaqG6oiwc9m8wCPgQNlZlToQ8/vGKCWUw8FPv/8yTKbMEp6C+eWr7oXh8kfmRoou3bacNtyKZHrB2Fkje69U+mMP8u01/jgLd50lDpZBjM0nJPO53vY8Yo40mx2E2SWUGIXL1bmtVM9AzyrOGMbSj14YTbohp6G/z33hgEeDzOyAQOFXwDhTrldA90/jjzxrF1H2utLSBiZneNL/2DVPMttOpyzBLJRPIK417+1K3RHulNfRVId/IgVBnEKnOIhg+QrTfs8P2yvZI1feqMMQgkulxb8A5Ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5280.namprd11.prod.outlook.com (2603:10b6:5:38b::18) by IA1PR11MB6193.namprd11.prod.outlook.com (2603:10b6:208:3eb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Mon, 10 Oct 2022 13:15:49 +0000 Received: from DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::e9f9:c414:d783:db21]) by DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::e9f9:c414:d783:db21%7]) with mapi id 15.20.5709.015; Mon, 10 Oct 2022 13:15:48 +0000 From: "Ashraf Ali S" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" CC: "Oram, Isaac W" , "Chaganty, Rangasai V" , "Ni, Ray" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Read FV header length from header Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Read FV header length from header Thread-Index: AQHY2M5yeQa4Z6cIe0yblQfkgT1V664HoowA Date: Mon, 10 Oct 2022 13:15:48 +0000 Message-ID: References: <20221005152302.4445-1-mikuback@linux.microsoft.com> In-Reply-To: <20221005152302.4445-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5280:EE_|IA1PR11MB6193:EE_ x-ms-office365-filtering-correlation-id: 3b3b772d-9c9e-44c4-94ff-08daaac18c82 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0vzqM4fJKQEU8g2q7/lj1uLA6dNOWhGCdEck3iiEFFqlmIIO2P7d0BBR+JIaaMHVSdsxMVVpoZlizuVC2yfs3qAHldLF+oe7BVyy+c4/+JmiJp1Dx0yMc4VrpvBFypkIpO2AmqbRhFlYHF/j2NQ0eM1whaQbCp/F+tuKUTmlzGQLv6HprPLzMhrVb/3kcY27z9F5PI0WjDhduPx2W+P9kC0QGNguUbughGxZUzTiRAeAOJMzFYtvddvomwEfVLPZKGcgl+/J1aQKhS1s95LDP8mmz/DhelHm3idRTb9ar1vojq0W7VUznu12oEJVGXs9wOqdEXEBEsxCgEEMC0yekVTkYFeCdthrCNmQYhOusEDzBw5s1JvrNTXQnLuzs1GmiTrqJWHvkIgnHSQz67WaaPYUC8Jru7LdG8UV92LQf/MEX8R4wIhseHFXZvo7tsEG95BP9iEm9Fhd/zsTARzg/z3ct7G4VWMp6sxiZ/A8Z/1bkKoQbHKdmq51RmC1siIxo/Vwa/3zycq9AmPVTV5m6cZFhA2o43rJ4B8bdPbMhg9xHMkkvD3SrHc6Pcr+yHNIDjx8A/u1eZVcLOGGnzLbkCtNCP0+BvE4TSSYQ0rx12nXnRmnhFqOJjinVX0okZyTZYd5CXes84VKGgsDAYXSd7IQdRpYZTNQI6SFJhP6WNAwaIP7bv2GrBmMQDzCHvEJDpA8VJcEYVStc3oI6UzTRMXSYO4pKG3U7vTnaXY7W58adVuxn+n0tP/A68RWCYp3Q2mey/J/4kbm9JwZQ2FcY+ba0ErYjv0ozwhSeFSI9AtsQ4fSbNbaNI4B+RiveBgcnJc1LAsGTsbRi/XclawPoA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5280.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(376002)(136003)(346002)(366004)(451199015)(6506007)(966005)(71200400001)(5660300002)(52536014)(38070700005)(55016003)(186003)(478600001)(8936002)(86362001)(7696005)(38100700002)(107886003)(53546011)(83380400001)(41300700001)(2906002)(33656002)(26005)(122000001)(82960400001)(9686003)(8676002)(4326008)(64756008)(66899015)(66556008)(66946007)(76116006)(54906003)(316002)(66476007)(66446008)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?6ktR7Wx4H4MOk4XY2923vUS9khQcwXgevtEUFolYyGo6CGMj54W1XeH2hF?= =?iso-8859-1?Q?h/V1GpeD+kMNs6TMo5T3cdqOPlov9NdJBV27JKiOo67YqbfzcTdnltuiln?= =?iso-8859-1?Q?Z5galY0h6S3W5IWGbBVfrBsmfjLcZCCwhPdhlG39/kq8k55Kggg2M7G+yN?= =?iso-8859-1?Q?P7ArV95/EQ88Qg3ToemizUDxJc9I+zrrnmZ/PAN2O7JlPN9CSmhB4TQzOT?= =?iso-8859-1?Q?/YhlcwlZNdd6nbICc8jyfGTfaoTl0bWsroHQy4Gr9sknTDyzusgS7Usp7H?= =?iso-8859-1?Q?anl5MaCeoEc8SzY71URyWLOUmYlXKDweb8qVTnAYfVrDdQXlOwCKbxuYC5?= =?iso-8859-1?Q?4QUgX+JjGfMlNXSNWozUOm5+D2XoCDC1vM79rX1hlzMkF74mQfsrShacm/?= =?iso-8859-1?Q?KRw1JHyfs+LW1C1wyELkC1paZGsl+VkLDPha+XSNB8VjOvTBbxNN5YrIKF?= =?iso-8859-1?Q?uuEiQ4mCXFtVBfPmiFFKtWXK1haNLVUapPixpRZczTND6IkzkqUSqZo3RI?= =?iso-8859-1?Q?6mOZjUzw5Z8soa3lL/xIbfEF+X3caGJSVB/3WHYqS79xEE8M57EpmCLie9?= =?iso-8859-1?Q?24RNl+iPm9MFTbShyA3P2bzuz1DP4yTSMWfIizVGiAnu7UHBinfen/FQ3G?= =?iso-8859-1?Q?RtztCz8QhZYHK9q0FIwpZKyUJ3lz5vjnBrs9mjaKeqhUHVdo6+LMS7hI2K?= =?iso-8859-1?Q?YOvi/fcbLnHdE9voPdCtMrF3h6Z8Ra7sayPycRGAAV9O7zXfTpZgS5cSzQ?= =?iso-8859-1?Q?Xb7aeC/BBVaPb6dNybF3AhDpaCMwmpROzuIZY0aDj/aSivfz37tH/OZA03?= =?iso-8859-1?Q?hEnstxeqvMegleqnfHpYo9IJm1YZkGa0IHntaB6SJ2/hV/TOA3m49wpSuX?= =?iso-8859-1?Q?r7QhwrScBPVfc+aZEoYIClaIoRGh3qfnpAT34ppIyiEEt29/HZ/mljN/LI?= =?iso-8859-1?Q?Rh+tMPxIlaO5Lo1dT/ZUH9HFTpm9L9twQK3B3+dE3f9YTxp/g+6RPMEGE/?= =?iso-8859-1?Q?4kyXxkn17snyPW+coSxBFPLuW9Wo/+7Xxs3o/m1xCLpbwguCFso4WnwCkr?= =?iso-8859-1?Q?zbENJcSP6K4nTGLN9uO/+nwolaME4eWqjLbT2D/TdESiZMjolE6wISGLIJ?= =?iso-8859-1?Q?14uaoeppgFHO2/Azn49yE5PxXescQpFRubvIRuw3dk5axSa2c8X6WMs//X?= =?iso-8859-1?Q?g2u4bKygLfMDkCR8F9Z9nahsv2+JimHcgDazcnevwhk6tKj/7QSNBnv4zY?= =?iso-8859-1?Q?yOdJikMm83CzfXtHdlUio2sCugPBh+ANuWet1kb2gBrc3IbxJrZj8Rac/Y?= =?iso-8859-1?Q?/yUKv3EXNtABdb4iFM79vkZjCtLQp2cmpkjUGJXUtbCjE4cnY5FSaQNwSv?= =?iso-8859-1?Q?Ly5CZCyjistQpTqPSO69NQAimjw/GIA6BGcii9LdWhWP/Bu8au5xTn4epI?= =?iso-8859-1?Q?GZoaPQwS/9HiC/6sfUpR2TrAkGHK2b3TGFstKcOQL6ZfddqV9UDvLxU6tT?= =?iso-8859-1?Q?u1qbDzxfOIjnIm97UsrCoi1U2X7kfdMAwdgCKqHGbvlJr+npRP00LIbf0J?= =?iso-8859-1?Q?UIph2Na2mDi5vrWRTQEtDLKpYIKak6XAXTKNfwRFu5lksc9d8KcPLIiW6/?= =?iso-8859-1?Q?QUAFzddz/cjjYxyMa83OH9xop6w4o2C+YS?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5280.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b3b772d-9c9e-44c4-94ff-08daaac18c82 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2022 13:15:48.6937 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akj04xygQ9Mc/9r+hCC9J8VnQoJBib2oSjf5QUovnjpMiK+YmAbn/ZylCVhH6J8TezT/TcfdLti8b8rrikSLvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6193 Return-Path: ashraf.ali.s@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ashraf Ali S Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.=A0 -----Original Message----- From: devel@edk2.groups.io On Behalf Of Michael Kuba= cki Sent: Wednesday, October 5, 2022 8:53 PM To: devel@edk2.groups.io Cc: S, Ashraf Ali ; Oram, Isaac W ; Chaganty, Rangasai V ; Ni, Ray Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvb= Service: Read FV header length from header From: Michael Kubacki Bug Fix: Read the FV header length from the Firmware Volume Block (FVB) information structure as opposed to EFI_FIRMWARE_VOLUME_HEADER to acc= ount for a variable number of block map entries. Cc: Ashraf Ali S Cc: Isaac Oram Cc: Rangasai V Chaganty Cc: Ray Ni Signed-off-by: Michael Kubacki --- Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbI= nfo.c b/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo.c index 634a44218c7a..ab1cb2ef1622 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo. +++ c @@ -115,7 +115,7 @@ GetFvbInfo ( Status =3D mFvbMediaInfoGenerators[Index](&FvbMediaInfo); ASSERT_EFI_ERROR (Status); if (!EFI_ERROR (Status) && (FvbMediaInfo.BaseAddress =3D=3D FvBaseAddr= ess)) { - FvHeader =3D AllocateCopyPool (sizeof (EFI_FIRMWARE_VOLUME_HEADER), = &FvbMediaInfo.FvbInfo); + FvHeader =3D AllocateCopyPool (FvbMediaInfo.FvbInfo.HeaderLength,=20 + &FvbMediaInfo.FvbInfo); =20 // // Update the checksum value of FV header. -- 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94758): https://edk2.groups.io/g/devel/message/94758 Mute This Topic: https://groups.io/mt/94137814/6226280 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [ashraf.ali.s@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D