From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.4537.1668588557027391153 for ; Wed, 16 Nov 2022 00:49:17 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=FtFaYzpd; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ashraf.ali.s@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668588557; x=1700124557; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=iYTmKtCuzxKj2S/C+nps5A1gh1LY9gP5aF/4Ov82YD0=; b=FtFaYzpd42tHa4Uch2GnOPTmjHx63LPq5deyYqXlKmjXgHWyaoAGyC7g ++Hg0ANzHkVk9555C4SgxEQwNEVfVk3vjGPrSGMwhhxs0v//2KIetC90I KfeQ4io/x7r6XQWauU9Un0ojtN1z48RfcVmDb82k/vvEAS7lxA/CHf5Pe ItgiMOaim3egdNayyjpjFy2oglEm13ufsyieCgXASqf4iuH1BLhOcqlix ptcNvQKdbSVL63MvTXQsRhYa5FdnZKdtLkCC0HUGh3tPbxqI7xkKfG0s0 76rJTI6+4IJOwigFLtAK5qJtsZiyxzz/pIBl5AHVvbx+jdi+JSgSY0oTC g==; X-IronPort-AV: E=McAfee;i="6500,9779,10532"; a="314304664" X-IronPort-AV: E=Sophos;i="5.96,167,1665471600"; d="scan'208";a="314304664" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2022 00:49:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10532"; a="641558023" X-IronPort-AV: E=Sophos;i="5.96,167,1665471600"; d="scan'208";a="641558023" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 16 Nov 2022 00:49:15 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 16 Nov 2022 00:49:15 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 16 Nov 2022 00:49:15 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 16 Nov 2022 00:49:15 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 16 Nov 2022 00:49:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MbVQvqO5v1ddRuFnhAlyeBZKrSF/4xiDgeivDo9S7wh4VtAZNl7MWAZ9565Pia6QeQvHJGSfvc6dXg8aH/fZMa3GNrz9tsK9lUCdruhhPyJFQXKkXI+ea7WsER6aFZHd1+z6d2TFVWMd7pVsTFbffNZ/T0hxuIhMY+WA5c7+WwcRRCek56TyzZ+ZceTlKLQbH1m2ag9CFyPdCkhDk88AzcVq5+4OfSCMfczVrO2NaiMp0OVxEFQ3PNzNbpedHwtBWaiznXwNbE8M/wjeOw/qwQaGAVr+ECH5pOLRbfxyFMP/plCo9QnasMlxBvFpE1U0HK/NqUgP3NxTqlBOgFLlwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UWpfujOeb91s6VpuUuSh+2iEqCgjcBdbvxxmPR6TWpE=; b=gu6cglxN3fy8u+QvSvE5OiHmXQmBkPWdZDqwTndH1c1oen/xkuFpbCneRi323PzJUmfDLSkTyUrIVv7eSVEGr5V6JesZMnznEfWg9KwyTdlRpb7pU8uEsMjZVwc02rVSF4l3k9xwDkm5Gu28wKZ1I1F3THgX4H8/GL1ohSD03B0JMQhYUyVTmeyi7V9TxSG2IE5eL7Hk/6pi6s1ZBoukDATImvZnsRCr6vFNx1zhb2vzrPhX5NWNJWJxZJDa3ZHeYFKf+DtohfZkA5QDmrYXUlHLec1m4N6aKoDMjxx65diJIdZYJb+YOqw5fNZLGjKVKSjXyT8xCasPM7sLK3lnvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5280.namprd11.prod.outlook.com (2603:10b6:5:38b::18) by PH7PR11MB6056.namprd11.prod.outlook.com (2603:10b6:510:1d4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Wed, 16 Nov 2022 08:49:12 +0000 Received: from DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::2fc5:ebb9:bf89:5b23]) by DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::2fc5:ebb9:bf89:5b23%5]) with mapi id 15.20.5813.018; Wed, 16 Nov 2022 08:49:12 +0000 From: "Ashraf Ali S" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Chaganty, Rangasai V" , "Oram, Isaac W" Subject: Re: [Patch] IntelSiliconPkg/IntelVTdDmarPei: Fix CLANG detected incorrect return Thread-Topic: [Patch] IntelSiliconPkg/IntelVTdDmarPei: Fix CLANG detected incorrect return Thread-Index: AQHY+ZTcnxUb6t/N9kCOmrbkJxTixK5BPVEg Date: Wed, 16 Nov 2022 08:49:12 +0000 Message-ID: References: <20221116082418.259-1-michael.d.kinney@intel.com> In-Reply-To: <20221116082418.259-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5280:EE_|PH7PR11MB6056:EE_ x-ms-office365-filtering-correlation-id: d8356cda-2f47-4563-aef6-08dac7af6f33 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fS+pHZkFr0n2qiqvLmIzb41A6gU37wHzr6CSOiiFilyNw7y47PcJTdD4XqiEdJD/C1++VJyvxPSdnQX5jty4JfVgOy6hrhnMuJpUEV0M4mzVu0amaP6lxxwkB2+mAwt6Hv7XqzkFxVNn7pJMocLQfrxbARa/O/cT171wLgTEsghoxVY5++dbwrYOiHTmSVm71hURjBK3euR3YP48RUz5F91b8SF9LEnufbkAE3zWnBQTvpm2oal2SNndi533lXwrGIM9Rqv+3kC/qdeXTDQgZhLTJpG6+5Rfp5WKGE4Vs2kR+zlKnQu1hK0xNVN1FjDkjD18lDEeBbvxslRSYLjYhGl50c5C6Dh8bBqc6ku/r0WcA0ApKOc9Rpg7C2ItHHTTEOMd9m6PNSDrc7HLDD2pGuYhWVWnxOxhzfGgpPSsacq9wBDVInBKkgfvajJDiqDoaWrxC5llQ3msRXurakgn5ef2j1bWVlnc6Hm1RM6dZ5D0J1cS6ZsH8ezp6UpmTK/RTkVVXZsRBAUeg6p9J49BvLM2KOVm1TcoBA01dTMEhw2/bgv1xMSDSG/JSqPE43SgLsc0lCtGOW8JyeDxDlV4jEgg4+iU5cBcmsB6rasQvRekA93OxpgntGU1aGv3G6kBfhOgdNaMkkF60dSFFTwcfEONXGov0mQ4tFgGE/gA0Kk5MZ01RUqzjIXRA5IKCKoI7d/nxBxe3FkJsZzDUP4HP9YCrO7pUTWARVbi/IOWre/1bxpc2xSTYgbhuPubgPfRoZ/HZ7TNr9Oz50yEeWinsw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5280.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(39860400002)(366004)(346002)(376002)(136003)(396003)(451199015)(41300700001)(66946007)(53546011)(55236004)(8676002)(4326008)(107886003)(76116006)(66556008)(66476007)(66446008)(64756008)(186003)(71200400001)(86362001)(478600001)(33656002)(316002)(54906003)(110136005)(7696005)(9686003)(26005)(6506007)(83380400001)(82960400001)(38070700005)(2906002)(52536014)(55016003)(122000001)(8936002)(5660300002)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?sARquEAz1mJAC27S+XChdcg/9AvYvKWttIpzJLxM9TOcudbdyT2ygZgsUi?= =?iso-8859-1?Q?5rLNjBy/lNJxjKaoksVpqVvpMRmhwjZM2GvaOl1GI6suJde/yvQZGtgwrB?= =?iso-8859-1?Q?FyX/Q/0HJOuSo03F71D6N1vlN8BwwBe78XHN04Vs+9IDUZRhxto3GE0t6F?= =?iso-8859-1?Q?hZHOymv+QfPEVQsZh/2Braz2PSIfyyd2Ebytm53FMU2O84WuvbR2EPPStG?= =?iso-8859-1?Q?LzWZg4Nw8CTpTZhBWuo0JBM/1p8C+DqjXJ/NtXdnbp7BKQIYTGrogB+srP?= =?iso-8859-1?Q?yGzKQfR1Q21HbGQG2C55NtUEo+Vrm7nUOCT8ocvwUTMw+TkU2hz3YSU1lm?= =?iso-8859-1?Q?Lceqfw+ZkGnTHwQMtInoqzLAJ+rjcjIARZ/Oi+OFp/s5giHX/iWyvWztiK?= =?iso-8859-1?Q?SHt8CLLEkTpbjdurQ4gqPqg4ELZMgpwELTS458vLB3QTipRtnQbSDyjDsO?= =?iso-8859-1?Q?Qz369MdzKqAdhPK0poKjxaqVhZUhWulK22CYg8m5kdnxeh/zouDRjHT0VV?= =?iso-8859-1?Q?AwcKmoRJvLAVnsTRsoZXdfIqvvzDQdI5t4eACjpN3xtUYQKYNBpKPR+Zye?= =?iso-8859-1?Q?8fjCltJEITTEeb/bWAie+ACpoRxOi4HzCBSAMAIaejPGNVioEzPNupcYcQ?= =?iso-8859-1?Q?CHJBBQvo9e1AiIQSGBIqLX5NWF4NwSXhrroqMwOk7tRQtVfV7inMdvLBZ3?= =?iso-8859-1?Q?OKoAPUr2rXWVL43OX/oNvE4MjilnplxNtpladSs2A7JL0aJbABxhI94Iqk?= =?iso-8859-1?Q?tP7M/Tm492owL7up9QYgHdFC4cyQDLABA4+ZFxy/4WQTHi8F5nxcgYgsgl?= =?iso-8859-1?Q?XGg16VNES3LIUKLHQbZVXZy0iJnmTR9F/vGAkkDW391ODq2LUmmcNJCPlt?= =?iso-8859-1?Q?wIcvCb7jZzTRpublZton2zw1gne3ooVpCQZ/1SjgWOgtXq+m8X0ad9wS7k?= =?iso-8859-1?Q?RSX8l1sBdpSD283+yQeZ5DC88M9DGv9LH+yAsmpX8gJYq87z1otvvPsLxj?= =?iso-8859-1?Q?/Lh+GmhyTygYA6ONp8EEIgROrEi+dTPgOmClrRVQB0mvlPU07RKfKRZuhf?= =?iso-8859-1?Q?A/PWKFLH3yVQEyUMnrQrJzI6LWHX8a67C5Lnz8+Gh2yeDR72g4NhO1bwdB?= =?iso-8859-1?Q?QgGoV/Bcys4/FQk+bJFY16Of0N4x6vvsJxsdXB/hqZeNUPQ/4wiuAPPc6g?= =?iso-8859-1?Q?I8RIIs2pCxV/IMP9x0nBDjT+wPyR+XifkxEAfI3bydHj0l3yO/s+bs3IWi?= =?iso-8859-1?Q?JMRYoP5F70cXioZFZrNezjaX4tW3qSeWqEndJmSAJic0sIf91IsFasUC9X?= =?iso-8859-1?Q?IO0XUR+9Uj+Kmf5G+67/+lSxoAHChmbRyuCLAQ7PshIZfBOPtb7wQYxi+r?= =?iso-8859-1?Q?FZ0iNS+PZKTj+KrKy7RPN/vGuSxVl5XlL1G1NPPqmUhJcJMsWo/7m7u2tD?= =?iso-8859-1?Q?bKbu2T/VByO6O43cDfL7UFkhnjiG1vwj9wmXf7tqxblQiJ2372fknbAQno?= =?iso-8859-1?Q?QkbuKxXkOGpT/UL/LxSDHMyV9kphfd3U9kq8EDstMuwNKC/79LI3gHMLdp?= =?iso-8859-1?Q?tJjem/1Oj9dwtDE/eMWUphSfQmr+6GPr5r9TUF/wMdv/Qqyp7EP5dEmGEj?= =?iso-8859-1?Q?vYwI7Ff7fLbT49upE9n8Gxq3jNyBHZUtT+?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5280.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8356cda-2f47-4563-aef6-08dac7af6f33 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2022 08:49:12.4740 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9hIxWR9w78NL4MGlE0+AhA3fijOySK2Y19cR2qzgh3IGhuNI6/aozd/wQyp9xH5Z8yWD+w6TgWnCSg8IaM2BeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6056 Return-Path: ashraf.ali.s@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Reviewed-by: S, Ashraf Ali Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.=A0 -----Original Message----- From: Kinney, Michael D =20 Sent: Wednesday, November 16, 2022 1:54 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Oram, Isaac W ; S, Ashraf Ali Subject: [Patch] IntelSiliconPkg/IntelVTdDmarPei: Fix CLANG detected incorr= ect return CreateSecondLevelPagingEntryTable() has a return type of VTD_SECOND_LEVEL_P= AGING_ENTRY * and an error condition returns a value of NULL. Change return value of EFI_SUCCESS (value 0) to NULL to address CLANG compi= ler detection of incorrect return type. Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Isaac Oram Cc: Ashraf Ali S Signed-off-by: Michael D Kinney --- .../Feature/VTd/IntelVTdDmarPei/TranslationTable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/Tran= slationTable.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/= TranslationTable.c index a806c4c000..bb121a608e 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/Translation= Table.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/Translat +++ ionTable.c @@ -109,7 +109,7 @@ CreateSecondLevelPagingEntryTable ( BOOLEAN Is5LevelPaging; =20 if (MemoryLimit =3D=3D 0) { - return EFI_SUCCESS; + return NULL; } =20 Lvl4PagesStart =3D 0; -- 2.37.1.windows.1