From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 34B5C941153 for ; Thu, 14 Mar 2024 06:44:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=uaPpiD3/hLYbkhYN1xI12ckaV+BtBxhjnfJs4LMlGdE=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710398665; v=1; b=4NXXp0umojUUzioQ9ajP2LUWcdg9gwSyYh9JQNVjHLrlKCvq629Zos+YlDYhSSQWgClEpoCx G8hZen9cPALYNpytH1/wvMk57ylV6X6F965DbHB0+Zhl50Stpzos6QM6tSxZO3TdQXa+WYt/2jY X2tatOw61SCWmsd8ft9J0OcgoV59Jbh3Ev+Llh+tWKzNw/CXY+31iNeop5rb9BTmgzGlSd8gte4 2LFdnwYvc07IphihVUInYkMQ9Hs/T6NQdog87jP+llLFBNystuKhAfRwEV5kGC/REJFIL9iRaAA b5XWZPFaj2/l68F4B4TrtYGfSguMtc8Swkdegm7qfs/mQ== X-Received: by 127.0.0.2 with SMTP id rV2VYY7687511xOXXCuDTGUW; Wed, 13 Mar 2024 23:44:25 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mx.groups.io with SMTP id smtpd.web10.6339.1710398664802945331 for ; Wed, 13 Mar 2024 23:44:24 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,11012"; a="22659197" X-IronPort-AV: E=Sophos;i="6.07,124,1708416000"; d="scan'208";a="22659197" X-Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2024 23:44:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,124,1708416000"; d="scan'208";a="12115614" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Mar 2024 23:44:24 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 13 Mar 2024 23:44:23 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 13 Mar 2024 23:44:23 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 13 Mar 2024 23:44:22 -0700 X-Received: from DM4PR11MB5280.namprd11.prod.outlook.com (2603:10b6:5:38b::18) by SA0PR11MB4639.namprd11.prod.outlook.com (2603:10b6:806:70::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.14; Thu, 14 Mar 2024 06:44:15 +0000 X-Received: from DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::507d:aee0:b06b:77a5]) by DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::507d:aee0:b06b:77a5%5]) with mapi id 15.20.7386.017; Thu, 14 Mar 2024 06:44:15 +0000 From: "Ashraf Ali S" To: "Ni, Ray" , "devel@edk2.groups.io" , "Lin, Du" CC: "Chiu, Chasel" , "Chen, Gang C" , "Duggapu, Chinni B" , "Desimone, Nathaniel L" , "Zeng, Star" , "Mohapatra, Susovan" , "Kuo, Ted" Subject: Re: [edk2-devel] [PATCH v2] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit() Thread-Topic: [edk2-devel] [PATCH v2] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit() Thread-Index: AQHadbPdYU71G18kUEqWtC28E9PIO7E2ieAAgABAtuA= Date: Thu, 14 Mar 2024 06:44:15 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5280:EE_|SA0PR11MB4639:EE_ x-ms-office365-filtering-correlation-id: a72e93f0-4d01-4713-eae5-08dc43f22a60 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: ldFIaZKr1yeI0IaghZ+BWNFtF/2jdIxpjmdeabCtibikkGlNUhdVYAgFccCu3wCvs5Opw8Z6kKkLDK3CrGjLQxqvcDdFq0Su7cKsu2rUlITL787BUZVzvD2fOP3BZZ3MBp/uQW1VxIokTidDuT9WN0plWUIre0G6QitqQmhCimjqoih8td0uusYrHn/hOddf5sPkBjhx2y6dSI3GJzo3z/pTS9g5SmMojwmravsF3J7w+hMEvia76O6cNYEU9umb9VW4r9zYRShB2jy5r4cm3A5VcTqdzu6bFqwV7gCYEP5zppu+my8RCDApnZl7ijzq9U8Q5wBlrQZzVUvgwSGH6nAPgkHifus/pbK9nBf9Fk3jqvkd4b8J2mmx5pF7DOPs2uu+JJ2d2PbvUNAD7yqXXM8Fflx4Kd9nVSA4gmP+ma+eZthFzdM7In0dAFtFv029zqEyJItNOQEk2wpzRZ8kPIMM+QIhu7N3XVG1bYHKys4eAj5xDwRsCbQKrCKVpmmX2j7cTzFdW9WUBtuEGvn9jVLUeIF/Nas7cfv7mfaGBLaQ29fWvl2oaIR69/YVyQGaHaYrPiCAYjOkLKmhTEyG8RPrFIdmQoY8J0gHyA6ql7EA+9V6KsaCVkkvcxGPcpD8xgxInM62Jl9P3Esp8r4AZlO1bQuBuWTRyrmltnEQHwLZN12rrVBpVUXCzWrhM+KV x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yHK+sTfwXFlTLIs2rF+Qxh2W25YLYrIvzlYEUi+5ge0jN0317FrrGYvwAI0Y?= =?us-ascii?Q?F1IVZxtYmgSn2wrPjEAXyniJRIaJ5zY92Q3M9GKlOnbf56/iYo6SPkkza+zb?= =?us-ascii?Q?Ek+ql/VB7NsYtq3s8RlaJjcEiopVUJdBT4k1o5Igw5dNXChdbeaZUSt/7qHw?= =?us-ascii?Q?IHJgfqsqp8Gw8NmWbtRtiTUG2clos7UygH/ipnUsgPrOYwR2YEXYZfGKIhe3?= =?us-ascii?Q?QVHhGgkzMTTdkjSjsBh+7aoai4+M5+yCegtNdymnDQ031wmsudZhhTH2A1/+?= =?us-ascii?Q?ebYmQuHmEGmJeAf7K0NSTpUJQoxdXvE14oGI5KD33EyLN1vv8+RgcIFqghlA?= =?us-ascii?Q?t33EUliCoXGkM4Bd0ZkW2Tc3Fh4jm4TmqHV2OJi2GzdinvUdxjTVOThnmUbc?= =?us-ascii?Q?iYVPU/MEHR3Db5BEplynp77re/xJM6M0rR/3FNHlWIBcJhrjFuWbyuOuO6W6?= =?us-ascii?Q?WezQkbscreNqq6gayg5mQOeb5/vSSL8bYYQ41E3YPKSX57JfK1e6iTq4+dmz?= =?us-ascii?Q?PRyx5IIqCNSq17fcdoYeanB1Ipj9GM7FQ6oLPFiyUn93bpRyQzQTitzIq+CP?= =?us-ascii?Q?/Jq8mDukGPm2KYSiRG9vs/IVTZg9TvQ8vQarzA4L8Oj5taUFNu8brQJmOYxX?= =?us-ascii?Q?48mLXm8XRSwUpVfM4WNBxo6QYV1tYMDroSw6PKfIy4C8TIoAPFSPF5pVkKvp?= =?us-ascii?Q?e1K2xZfRYmVvFUA3/aPGpQcb8LPz2jjcBMpm2y8uK9u3gdQNe+SW5zDGsx3Z?= =?us-ascii?Q?jM7ZvB+Z/pVYDD8Szizg4pGoPhlfhPHjnPO/KbtxifDdkrIWFHAxx2xQovS/?= =?us-ascii?Q?e3+H/KbnIeCIsorU1PCCX3VOt3zP0WCF4bGTmTwbvgPiRJa5SG4TuLWABU6p?= =?us-ascii?Q?vrvPMob/FzwwRe6C6Mto6OfBDvavANZUAvFh0/KsdF6JvF4OpKDD8UOFjPJ/?= =?us-ascii?Q?6q5/XKHgNwyJjucbBEgOOYMfhppXbs/lIZ+YY2qLWWqFEnCq91DgPrZoPjan?= =?us-ascii?Q?YpDlPSOIY5LaifEjYCiGHoABBNGEbS43xbvEn5iR+QidlK4qs+JebwGdbKA5?= =?us-ascii?Q?y2VjgIA2TC05XQgS8HEpHnZw70NeL1SrjS7gFORNGXmmi5msmDLv9b04LM5v?= =?us-ascii?Q?lQNLwObez9Rns0ejev+gxUdnPBu5f9+0qCwTJUxOjIe2W9kBCYp4b/OOOrla?= =?us-ascii?Q?Zc9O7e5fqGdQH3ldaCnDVsGXagQ3R22N2DcZCxUEfe1mJxbsklEoltSFjAG1?= =?us-ascii?Q?rlcEt+vR6mHnNXCcrX9yVmScx+Yoz+jwSDO/MkPKZoqD7JNoiDoF1V/zKDHb?= =?us-ascii?Q?pKXe4U9xtlErkodm1B5jkbhwKWcWBdkfc0KAtWEMj9dszYLCiYQHSx8nzkYd?= =?us-ascii?Q?OJgB1kn9QQivcJQtgztYKGJdwAHxHq30PZ6EK+PtLiqpvQfFBW8giNQAWS6c?= =?us-ascii?Q?v29apjeGYGs+AGpPy/Zm1on+ntWzzqB/KSLYGDieqpApO7yx9vWIjnYHvpAy?= =?us-ascii?Q?kPW6LjqJ5yUoXyunzCFILC+95/givnT6OsNYh1tZjrSYx4sbnd9AvRvk/9dw?= =?us-ascii?Q?/STLZREVOy13CdPQUzfKJa8XydwxkOk/dhPLG+Wq?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5280.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a72e93f0-4d01-4713-eae5-08dc43f22a60 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2024 06:44:15.1359 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JtluwoFvM6fXR749FHciLCnjTPAIqmyIYFr6re/m6fL7iSH3HPydDOOXxA8futGbU56OQtlR7IsduT1TQOqDow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4639 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 13 Mar 2024 23:44:25 -0700 Reply-To: devel@edk2.groups.io,ashraf.ali.s@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1NkRN3cehpwomJOwL7euZY5px7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=4NXXp0um; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: S, Ashraf Ali Thanks., S, Ashraf Ali -----Original Message----- From: Ni, Ray =20 Sent: Thursday, March 14, 2024 8:22 AM To: devel@edk2.groups.io; Lin, Du Cc: S, Ashraf Ali ; Chiu, Chasel ; Chen, Gang C ; Duggapu, Chinni B ; Desimone, Nathaniel L ; Z= eng, Star ; Mohapatra, Susovan ; Kuo, Ted Subject: RE: [edk2-devel] [PATCH v2] IntelFsp2WrapperPkg: Error handling of= FspmWrapperInit() Reviewed-by: Ray Ni Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Du Lin > Sent: Thursday, March 14, 2024 10:02 AM > To: devel@edk2.groups.io > Cc: Lin, Du ; S, Ashraf Ali=20 > ; Chiu, Chasel ; Chen,=20 > Gang C ; Duggapu, Chinni B=20 > ; Desimone, Nathaniel L=20 > ; Zeng, Star ;=20 > Mohapatra, Susovan ; Kuo, Ted=20 > > Subject: [edk2-devel] [PATCH v2] IntelFsp2WrapperPkg: Error handling=20 > of > FspmWrapperInit() >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4701 >=20 > The error handling of FspmWrapperInit() is limited to ASSERT=20 > statements only, which only works in debug builds, but not in release=20 > builds. > Fix the issue by enhancing the error handling of FspmWrapperInit() to=20 > cover both debug builds and release builds. >=20 > Signed-off-by: Du Lin > Cc: Ashraf Ali S > Cc: Chasel Chiu > Cc: Chen Gang C > Cc: Duggapu Chinni B > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Susovan Mohapatra > Cc: Ted Kuo > --- > IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c | 8 > ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c > b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c > index ba0c742fea..7f1deb9542 100644 > --- a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c > +++ b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c > @@ -197,12 +197,20 @@ FspmWrapperInit ( >=20 > MeasurementExcludedFvPpi =3D AllocatePool (sizeof=20 > (*MeasurementExcludedFvPpi)); > ASSERT (MeasurementExcludedFvPpi !=3D NULL); > + if (MeasurementExcludedFvPpi =3D=3D NULL) { > + return EFI_OUT_OF_RESOURCES; > + } > + > MeasurementExcludedFvPpi->Count =3D 1; > MeasurementExcludedFvPpi->Fv[0].FvBase =3D PcdGet32 > (PcdFspmBaseAddress); > MeasurementExcludedFvPpi->Fv[0].FvLength =3D=20 > ((EFI_FIRMWARE_VOLUME_HEADER *)(UINTN)PcdGet32=20 > (PcdFspmBaseAddress))->FvLength; >=20 > MeasurementExcludedPpiList =3D AllocatePool (sizeof=20 > (*MeasurementExcludedPpiList)); > ASSERT (MeasurementExcludedPpiList !=3D NULL); > + if (MeasurementExcludedPpiList =3D=3D NULL) { > + return EFI_OUT_OF_RESOURCES; > + } > + > MeasurementExcludedPpiList->Flags =3D EFI_PEI_PPI_DESCRIPTOR_PPI |=20 > EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST; > MeasurementExcludedPpiList->Guid =3D=20 > &gEfiPeiFirmwareVolumeInfoMeasurementExcludedPpiGuid; > MeasurementExcludedPpiList->Ppi =3D MeasurementExcludedFvPpi; > -- > 2.44.0.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116733): https://edk2.groups.io/g/devel/message/116733 Mute This Topic: https://groups.io/mt/104919472/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-