From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.5846.1679144663786975437 for ; Sat, 18 Mar 2023 06:04:24 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=fYQcZk6v; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: ashraf.ali.s@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679144663; x=1710680663; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8cTGkMK6Wh83GXl5v3XQIvgYyZNq/I2DyW3XzNnYpJI=; b=fYQcZk6vktkGpEYjW70hKngJ2ef2RWYkm5chxg61XfMCoDAeQUup7D+D GgbsIynDFZENvPIV1YOCQa/gPEefMPVdIWyTHiGWTrZgmDNchhKi1OUs8 L4aHfNKe2r0FmjT3Icj74A0zCme6NrD+GCzoYQH0ZM4xjlssBe/WrTumI WxuUHGOpcYoDeCxV0JO8yKSs8Uo87W+mjeFUfUSHkO4mTXXDnaw9dqT1M UoarX6QZYuG3oEJzOxyNImctzfk4nf8BRx3tweIOvrRy0WYh+pc3ymd12 GRQtHFJmh4ZjmAnQ3IUQ+bHNGVRsCUCX4YyAt4lKwsbSxrNN7rpU1gGsV g==; X-IronPort-AV: E=McAfee;i="6600,9927,10652"; a="401008712" X-IronPort-AV: E=Sophos;i="5.98,271,1673942400"; d="scan'208";a="401008712" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2023 06:04:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10652"; a="680581601" X-IronPort-AV: E=Sophos;i="5.98,271,1673942400"; d="scan'208";a="680581601" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga002.jf.intel.com with ESMTP; 18 Mar 2023 06:04:23 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Sat, 18 Mar 2023 06:04:22 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Sat, 18 Mar 2023 06:04:22 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Sat, 18 Mar 2023 06:04:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hPkGJ1lG+s97OoCuWdlIsXyvqEUKHHnXxZCGKfHT/2mx9OW90JCrqAwPXKszyLyoNXL4upKDE3+zIk/ZiM/m13Ts28+K3o7dvXQWy84xarVpF6h2AJ50/cvFVPm/frYfezCqPoxf/DDtM86D+c8x51pG7XLVMn08U85jb4xFbYYIoRCzB6TDodcr6cW3V5rXWmsB3/nx7y6Wq2fl3np7WkJM5YdlSBpWXQ9J/cYX3+PLDpm7IlxwntDNkx3MwP7OF97+EUfDAFGTAT95RoFf+bgvNsMZoExtFVrxrk5Wb+68OFfhRYcZV9lQBpeuuz90ehgvX95A5ulst6EVm2Efkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wSacGaeUHut5jdaKH3kmtCf4wrg8d90Dn5FGtlbK334=; b=eQW7HhfAxUoL0yiewI3uRbL7+ab0bj4ZJRd1niekOLdvPNeB9unR0dYjrHG7Y25FnuaAkOrIUee2JJATTKINxihi8CizWyWRp/P3OEkNCwdpQtmTRZdocEz8tqZBCOE7qaDEgh72q51aBrtDBtFPvdwsNh2vkNF38TDQRQQMsI6V9Jm1b7MGfi8JxYMjU9PyVE8MTRyvWWcJHvSzDW4dBawx+6wnVAILTr62tKgrdN5Sej3TkvvzMPdJFNLOVJ9ge35dh1bxpf+vXUCPahtXalED19GrFmBFGt8yy0hpGrya6U+FT7tVBFsmrIDKK0LorcUuaTtRJTn/VywqbXXt1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5280.namprd11.prod.outlook.com (2603:10b6:5:38b::18) by SJ0PR11MB5646.namprd11.prod.outlook.com (2603:10b6:a03:303::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.36; Sat, 18 Mar 2023 13:04:20 +0000 Received: from DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::f57a:d49c:15f8:cdf6]) by DM4PR11MB5280.namprd11.prod.outlook.com ([fe80::f57a:d49c:15f8:cdf6%5]) with mapi id 15.20.6178.036; Sat, 18 Mar 2023 13:04:20 +0000 From: "Ashraf Ali S" To: "devel@edk2.groups.io" , "Chiu, Chasel" CC: "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings. Thread-Topic: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings. Thread-Index: AQHZWPTh3KU1pp7BHEGiMds5XkvCz68AgeJQ Date: Sat, 18 Mar 2023 13:04:20 +0000 Message-ID: References: <20230317172050.1228-1-chasel.chiu@intel.com> In-Reply-To: <20230317172050.1228-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5280:EE_|SJ0PR11MB5646:EE_ x-ms-office365-filtering-correlation-id: f0ba702e-9b5d-45b2-1808-08db27b149d9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 80Wfqhhszagodt2NCRfcazBUyvNcgSXho9A6DuCKb0DkLxJ5Ll6nhzHIvrrmVeOS/wiCfFUaIC4rt8FXmBrFXhZDQNOyps+vCsvoLzlyTw4GzEXJmi5x5FFIr5/RwcI/PX2IYuqV3ILfdOjT8zvMc2H5ECkcLTF8bt79p3NuOf5sDAx1OWeCxkQUcTiC8kChKcerTmI0UbJozElf/aitxVvBj5ghIcIuBtN0U7s+64TY4j3+NmzwljO4h6qLc60fm2U2XxD0UQggVtUB4goOu0YoZXYFzwZ4iJUpK2b1Mlj61+UXRPNlELDYU2UYQFOpUZmAsjqZJVHAqiba473wYUduTUiDQd3YyLq+1kevfOaa5Lyucetthgmy4/u3+FTE4RTuRPVP+32Uv2KuEAc10HKoLHXPMBMq1jnjORNLcB+I5EKzKvHtRFWKOWkLm9p2XFpRBNJWBnHCk3TS1b/z0/jkNb9FLww8LQf0hHr1WfFsQG2GsBIf2snyNiIemPLaIgITMaVBa/NCxxR49nqUKECHBxFz7CmV/tsanQiX1jT+t4eu0EHfVF5RFUoTNyGBGORUOFJbhUs1ujUUyHk4gUbPxAxt0jrZbayCvwC1ztTSzlBQys1fU6Dy/F0Zb3WdjBLSJ9upxP2x5v63xohoSnNg4dnzSeBUjpFMquT54YF6eF0n9cc7Akt584R0dgvMnizie0yorOMZqXCt64d2J93o0agKbf9GtgvH2Fq/fuQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5280.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(346002)(39860400002)(376002)(366004)(136003)(451199018)(86362001)(33656002)(55016003)(7696005)(71200400001)(19627235002)(316002)(66446008)(64756008)(76116006)(66946007)(66556008)(66476007)(4326008)(83380400001)(6636002)(478600001)(54906003)(8676002)(110136005)(53546011)(55236004)(186003)(107886003)(9686003)(6506007)(26005)(966005)(38100700002)(66899018)(38070700005)(5660300002)(52536014)(8936002)(2906002)(122000001)(41300700001)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mufRpTjRGxJtFUb1DxxEgJ91lKYlDHJpv7oWGuqoyk5AndEsky9jrTNQBhXQ?= =?us-ascii?Q?WRS8k8KwREAZmnZLam6xyY58Jt+G9bSrvLIxWI5Dmjlc6zfKE25+0QtwPdwi?= =?us-ascii?Q?Er+h73t6XcJenIPZWeOOvuWGu9y+36Wnt6z4C9LjdPNIxEa3ZhYS0tOhgWjo?= =?us-ascii?Q?IqhPoB+Pj6bUyjY6ILTXtjEF3vZPR34y7LcxpMYLbj9P4dXLEWnyHTNpAso0?= =?us-ascii?Q?rxFBbeduDlnrcTggIGsBpP+a3Ph/nx+X4SiElvPWHdhxVJHjqdRRFe+pqh3+?= =?us-ascii?Q?6s3teQE+p+8dNYeRkqZSVYzqR7Snrvt27XfKZfWw/jIVvnH95gQPVJAm115/?= =?us-ascii?Q?SFkGLRI+011O62ypTyYAYac3flsrlccPXdSWNzjvG6E5K283ZZ8TFSUSVmqJ?= =?us-ascii?Q?XrgTCD5ce5nEwpT11da+iqtp3HGavMIeAD6/eErvWzjNom6XfxGSOzqJnNxQ?= =?us-ascii?Q?6QlHne92B2PjTqlV0QmiNZU7XEpPLwkbiHElJYnpCZSiEQbaUKwTzH0HUkqW?= =?us-ascii?Q?UdM35g8fYhmqgfu5snnjEsBQnaZCSm4eToNCsvYEOd2NlxME7v5Ebrgz6X4n?= =?us-ascii?Q?ixFO3fMagFSepO+nywXKixiP0NrAxImKw4wYtk4GTSgcwYobRETfZESkeh1V?= =?us-ascii?Q?pquZdoiKyNTAGBZBtM/+NnwGKMuXLShoOm7bK043Y0Yhz+CFL8mIdNJCLTKI?= =?us-ascii?Q?Ngj1vyIqeL5HW8X6LtmSIV+VmzJDEV3EjXzwIjagQFBrqFq6uD2YYYirspdr?= =?us-ascii?Q?MEsA18gI2gJNSPalx95blS1eUXGpMdjrkHXkZPjH7iEcDYMNY9u380LfQAu7?= =?us-ascii?Q?2MGnEsjJdQ7MxPxKJsGcrygNUmrQyYRSmP8fpQISqwMqnHJytxKFw3txwX1V?= =?us-ascii?Q?WbgfSjDqI2KRkff6hMs6/E1UCNzbRx3CO3a4mTvNHvozoLOcqpPa4ColBKam?= =?us-ascii?Q?d1zCGoN/cvbKEIv/8KopLjs9qJKsVwsn2RB2OxfGFGjYj9M5H6rljzOCny/E?= =?us-ascii?Q?NMn6mG98kBntlxJ9nW+TG6qUoHP20QEbPMMa/ng91BCpzVJ2U61emxIi/A5m?= =?us-ascii?Q?8znXBPLdVlEVWBucgOgcP6R7YMMa19KyrZR7ulz47QkcmUl3/d1LtPr15T92?= =?us-ascii?Q?G6xyvIZUu0exuEv1DMY7Hv5ZZ5k6NqEbvB3pT4IF8zHG8Kc5kve+Q1LTT3e+?= =?us-ascii?Q?kbKbNFaaVDhyHo9yPxGiPPp1bbpXPJ5YeBlRTaXzbRDb6C0R+M/6N6umlrDV?= =?us-ascii?Q?j1BpFTNwxPx0N7uNvxTSuOYbEXlApTFeR/rgjDqY1fT55WEjqsEue8p+CLKL?= =?us-ascii?Q?luPNFRjfa9T67ydy7p8MiXdLlHbIkWPGXGKtgdKhV/ops+8ARSphiAmouBGr?= =?us-ascii?Q?jtiyMaJveYATrpIeQwAWz+tMMIOQeJ8FQ+/zx1o9SdSkmMk2L9HwBNTWu78k?= =?us-ascii?Q?d+nGyT8laNV2PALILcz8TGvZCHb4sxJzPwYBJaNkRtgaSGKgN5BuwWLhsOg/?= =?us-ascii?Q?OHocDAMPLxYr9ysr8XITpD8QGKcZbRI7+X90SGbN4hsmiV/Z0XVraWKc6S9A?= =?us-ascii?Q?kk85fN6OfXQbw+IRX1Kz5AnBrZ9ombpRCji3QbJ8?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5280.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0ba702e-9b5d-45b2-1808-08db27b149d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Mar 2023 13:04:20.4560 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CJ8ZG8IF2Tki5G2az5dzmmlDZwVS1IQQ8o2sVWxhosoj3jgj8RgrM3b7xjtqU9jQE0GAufUoAFTMSyl2+7LVlQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5646 Return-Path: ashraf.ali.s@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi., Chasel RAX holds the FsptImageBaseAddress, the AND operation is performed to clear= the upper 32bits of RAX registers. Don't we have to clear the upper 32bit of RAX registers? -----Original Message----- From: devel@edk2.groups.io On Behalf Of Chiu, Chasel Sent: Friday, March 17, 2023 10:51 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star Subject: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4377 Fix below warnings generated by NASM X64 build: /X64/FspHelper.iii:26: warning: signed dword value exceeds bounds /X64/FspHelper.iii:35: warning: signed dword value exceeds bounds /X64/FspApiEntryT.iii:320: warning: dword data exceeds bounds Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm | 4 ++-- IntelFsp2Pkg/FspSecCore/X64/FspHelper.nasm | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm b/IntelFsp2Pkg/F= spSecCore/X64/FspApiEntryT.nasm index cdebe90fab..56d6abaea6 100644 --- a/IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm +++ b/IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm @@ -317,7 +317,7 @@ Done: xor eax, eax cmp edx, 0 jnz Exit2- mov eax, 08000000000= 00000Eh+ mov rax, 0800000000000000Eh Exit2: jmp rbp@@ -464,7 +464= ,7 @@ ParamValid: ; Sec Platform Init ; CALL_YMM ASM_PFX(SecPlatformInit)- cmp = eax, 0+ cmp rax, 0 jnz TempRamInitExit ; Load microcoded= iff --git a/IntelFsp2Pkg/FspSecCore/X64/FspHelper.nasm b/IntelFsp2Pkg/FspSe= cCore/X64/FspHelper.nasm index 71624a3aad..ec9140b73c 100644 --- a/IntelFsp2Pkg/FspSecCore/X64/FspHelper.nasm +++ b/IntelFsp2Pkg/FspSecCore/X64/FspHelper.nasm @@ -23,7 +23,7 @@ ASM_PFX(AsmGetFspInfoHeader): global ASM_PFX(FspInfoHeaderRelativeOff) ASM_PFX(FspInfoHeaderRelativeOff)= : DD 0x12345678 ; This value must be patched by the bui= ld script- and rax, 0xffffffff+ mov eax, eax ; equa= l to and rax, 0xFFFFFFFF ret global ASM_PFX(AsmGetFspInfoHeaderNoStack)= @@ -32,5 +32,5 @@ ASM_PFX(AsmGetFspInfoHeaderNoStack): lea rcx, [ASM_PFX(FspInfoHeaderRelativeOff)] mov ecx, [rcx] s= ub rax, rcx- and rax, 0xffffffff+ mov eax, eax ; = equal to and rax, 0xFFFFFFFF jmp rdi--=20 2.35.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101356): https://edk2.groups.io/g/devel/message/101356 Mute This Topic: https://groups.io/mt/97678369/6226280 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [ashraf.ali.s@intel.com] = -=3D-=3D-=3D-=3D-=3D-=3D