From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DBDF2740038 for ; Fri, 19 Jan 2024 14:58:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DrxcTQB7dHoSStVJgna5nuMo/kFFf11+SqQj+L7Uajw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705676288; v=1; b=cw+BgU+oat2EsStVu2xXatTekFSHE3Z3drNyL7o/vqgPdBGdvVgifTC8KL3HyGSG9xmTprfa KGBqjz/nfvXYFh1xkL+wfkvWqyt0eYcetrTDJF9vW5FvrBMsRspiS64o2HYB+KXJnd+2QoYLQaU QRaUm0VJMlrjkF1QAfdLkIZ8= X-Received: by 127.0.0.2 with SMTP id TZwbYY7687511xTCXp8S8uHr; Fri, 19 Jan 2024 06:58:08 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mx.groups.io with SMTP id smtpd.web11.7219.1705568248652229986 for ; Thu, 18 Jan 2024 00:57:29 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10956"; a="13908126" X-IronPort-AV: E=Sophos;i="6.05,201,1701158400"; d="scan'208";a="13908126" X-Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2024 00:57:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,201,1701158400"; d="scan'208";a="26713030" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Jan 2024 00:57:25 -0800 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 18 Jan 2024 00:57:25 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 18 Jan 2024 00:57:24 -0800 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 18 Jan 2024 00:57:24 -0800 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 18 Jan 2024 00:57:24 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LCOiTFwutRZkoIAqZkskV+Ftq+8n1pONGWsGIDN0ZZRA0eJEGGNLz4ikwex03R92ntIX8vFLMIFBxa9UIv+0NmC4OJvTLjqLtYLDMRl58H5N/cmK8Xoxw0wFzXYcU4huwJYdDLTecdUXMeHQ/0AhcREByGK61M6mF2999cVvG8IQNaPRBqapNTJZKYTYDDs75dlsv2tHjSqPzrvFXMLlf2VqHhDgBCJzr2l/QeGedhgCK2+MCAyhXQECBrk83zaLG4AUaAIJwVdCLyIz0X4PtseoUJllrEM/5hH4x80TXg/bj+jmZT8xmsw8JlvPL7B8fUDMp1kPY/J05ZU2fgZRvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=px3GlPpciSDrm1evrWdC0BjzhY95Hk1PhSBVCPFaVlw=; b=Uh9GslL2YQH5255YDyXasPbjAOfhL6lEJ5R/jwgGBIdShwntmlQTtxYVr3qQAoUaNwHPkcOREGCF1VquPf+Ko3O8sRlJNHDucodkt44IEtqb9bH36/2VIF3KPPpr+qlfSsrPEGoWOXtf44hoH1cWPW4GWI8pBse91tV8Eat4oRPy5rUsC9TCw6jqsyHte21JcFgYRPSKHDxerwvhf/QtOEudaP/YrKBwO7VwIDGcgCY7v1dw0bLeMo4gX3cwMCrXrKlVTC/BbyGEL9F1KfpawZtTqd3NG+bhduQw+l2YMBTU/YH+PPYFIqtkK3I25fVuGvnef7YOaUZz6ISoWFg3/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from DM4PR11MB5295.namprd11.prod.outlook.com (2603:10b6:5:392::14) by PH7PR11MB5885.namprd11.prod.outlook.com (2603:10b6:510:134::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.23; Thu, 18 Jan 2024 08:57:16 +0000 X-Received: from DM4PR11MB5295.namprd11.prod.outlook.com ([fe80::ff10:db5:c848:7244]) by DM4PR11MB5295.namprd11.prod.outlook.com ([fe80::ff10:db5:c848:7244%7]) with mapi id 15.20.7202.024; Thu, 18 Jan 2024 08:57:16 +0000 From: "Pethaiyan, Madhan" To: "devel@edk2.groups.io" CC: "Gao, Liming" , "Kinney, Michael D" , "Xu, Wei6" , "Tan, Ming" , "S, Ashraf Ali" Subject: Re: [edk2-devel] [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition Thread-Topic: [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition Thread-Index: AQHaQf3r3hJ504ZIeEWQielSvUuqlLDfU+Vg Date: Thu, 18 Jan 2024 08:57:16 +0000 Message-ID: References: <2d53b710572890495a268f208027c8de1e9b7fea.1704696138.git.madhan.pethaiyan@intel.com> In-Reply-To: <2d53b710572890495a268f208027c8de1e9b7fea.1704696138.git.madhan.pethaiyan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5295:EE_|PH7PR11MB5885:EE_ x-ms-office365-filtering-correlation-id: 71e9414c-5580-46f7-06bc-08dc18037879 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: /FtHobB4bX5aav0CodSLny3b6l6DmdsfNKO7g73cfgiWK0tczPOvU0M5PvS/kZeIO/2srU55s4mAnGUIxwPMzv3R9U5X4mH1oavfO063FhUKLmpYg8p54TbJ9W+lkAK4AVarWIEjt9EKsHz1hDl5dQgdZN4HkRczLEZIqADc42I+CfxnvXpCfQETCNKs6ROcZT8cXTPoOBGYRUv14zXle2M7uK7lRsYSshgw19nU+Go/vSxOfP15tywAQS9FE6spAUnt3xe5VE8W9YTtjGD/ls1KeXdvQjz6ZoOpO6NwVwMpzAxf4lujrXUrwUUtLSA96b+aHEFXtLU6AHBuFw5voTTzW/tEtUaNywpGfmrnLxLh/zD7kgHSw70BfiBvNhabjkSI3AOrPnOeAD+T4MHov9jzt5lxqd83zAeI24VkXDWRy/eiPnwYcb4c+ulAcX/eL9j2AwuEBTUEkSq0ujssOJGQQh0Sa5GtoQI6BzTIuwcehggi2k0Pe/dMy8WU3k9KO6dKzo9YsZmbrBWp+QftJBeqNAW9/PD5y1wfaQ/1lxCyA7c0AbyrQVOwivvL9Yg0jp/hGNBCFwRPbRu7MvA+KEVL6HGWUw0wPAwnsdIsga6Jlfd5wtGCTZZZ/LEbmtcY x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?M7JW/yYIal8Xasv45Y0FrqyLSO+4n3gXdOHXXlRYiIUqtvgPUrtyB9TjN+kv?= =?us-ascii?Q?7qMpqG3NAFaYET8quTRGDQ7J9tuKNnl/B6m3Cyo3ESOqOlnAYXzUqBlsc1IH?= =?us-ascii?Q?Jf1FN2ErKHgtMiNC/HUO/Vj7F939gGYB8hpOdDFZO1LqOFfTtD1uSDx8vNAC?= =?us-ascii?Q?esgl9rbWnUJq76djofieMjw7RMv24khsQD0WSXZ4/l9yxxgMS2SYEUlHaWPT?= =?us-ascii?Q?VstMqnIytDZKJ87K8m5M6AbDjoNrSW+f5KjFYP7VD6pEJ6aKD3oD5Yby0tLR?= =?us-ascii?Q?O8EsocUNNH8TCO4QbzwRbhk16DdX5XBBaEZSHIhMmGixaq3s+84dE0trwumg?= =?us-ascii?Q?1QkfqmxqbA3yWnWfvNbpNXakkDmMIacgWBWlG5FMq9wN58iIPc/4az0mvvrt?= =?us-ascii?Q?znfzvvHoYnzefD8LVHRv3U2xEsXS4zrmMphGP4iObfm+ZcxKCyb1lCtKTKUK?= =?us-ascii?Q?BRJhPPO5+eHPyoqWTAXzjq+YYJjoL3127bLJ2QpqyKVeF/88pirSsjv1C7hB?= =?us-ascii?Q?cQgVa2LDQ0zLXaXGzRwIzHUKRRxQ4UngDRonHIXMEfye9QuVGUU8q0t4+GpG?= =?us-ascii?Q?MgyZ16VYdVtX39EOBCMBv/AbgE7sgOnNEBCwpiil6FSRd3PTOOQX9wCQrMMY?= =?us-ascii?Q?gIt6+rNrMXPfzUOucTzTorX5mtxWlFpd97E2lauRJ2UEi5ivKAsb3H3nCHtS?= =?us-ascii?Q?R5Fen3+ojijgJIbUOHao6UZSPh+SEfrtCKYwrvuRbLIYw5iXN2S2nuvepmW4?= =?us-ascii?Q?+jZS5yU9VbJpzfJmVztrnybEFF7zTOMMs6Px8ET5Y+qQ2Gm/sMnhKmlhQ4Qk?= =?us-ascii?Q?UlnnAOSDkUYx2Opz6jj+n4wocWzG6IMWmTsVNvr/XeG7w7XRKh7CaQm4ujiL?= =?us-ascii?Q?i/IsKMdoIfa0fYdGtKDsNQEqgCYM5Te2C6/UIUF3kq4DsritQjryFOVsyqis?= =?us-ascii?Q?r29hLlR4bh3ZlTCxCA/fLXfhC6XhHts1ZwVGT251GKGyHjfbtL/BZA9Bq/Q6?= =?us-ascii?Q?s9wugGgDGVhgAjnK+BB7QPJ5/ACcWvDro56HGHjxqIEaYtv+spTfgFBFfyLy?= =?us-ascii?Q?L2qQFLVv1thXvb8r6366eAVmoVs6oceH3HzfZWOiqoU5bXi61TaZ2TbTooVI?= =?us-ascii?Q?/Pa/XA9LOuxSwaGyGznylSV/puTefRK/0uJ/iZZoIY50kMTe9egrFvbrF+/A?= =?us-ascii?Q?D5uXxOskFsI4Wedu3HX8xyleqc/GcV3ushDV5R98RYqYZUPuo7haqf/WR35K?= =?us-ascii?Q?XWZZxCQyuz05iSaU2yvekLOyRNiJiQfvj0A8vcJcl/uIo0TmWO3zmcriQH9U?= =?us-ascii?Q?y0JA2jc5PiOIz0NhFd/UHHNRHTnrR8xPXsIKckQeP2MBbb9wP0sVc8YGS6aK?= =?us-ascii?Q?4dRNyDBS12TS1gZiRGvXR8vc8ce5OsxanyX33XLWsLkf2ZJyGAkwW5Ug6ZGQ?= =?us-ascii?Q?3kWkTNfRTumUfujvuMn0C5B0cnRLXf0bz6DOu9zRWXwGzAQ3cl6kVLBDvOQC?= =?us-ascii?Q?SVa6tfQAm8TxTAsU/7Db0fKlJjAOyUW9CuesXjYtI3UTbvHbYn+TSyqZxfk7?= =?us-ascii?Q?2a8ItLWnCP0xu9d2IFFcYwakF/6qHf8q2irgQB1k?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5295.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71e9414c-5580-46f7-06bc-08dc18037879 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2024 08:57:16.4378 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: A0xsWjeKWtas86F+dmOz27mxcMP2B8CjI2RllHADoL4dGmuRafl7o/Vm88xJHmx3ROYWQPsLYtVYjc6GUSwygrPXTwgBZbnotJFs1jocBXI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5885 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,madhan.pethaiyan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Vu5Xm1jQkQDSfJn7Q9Lr2RjRx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=cw+BgU+o; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi All, I had corrected the description, added the UEFI spec version and section de= tails . Please check and approve it=20 Thanks, P. Madhan -----Original Message----- From: Pethaiyan, Madhan =20 Sent: Monday, January 8, 2024 12:13 PM To: devel@edk2.groups.io Cc: Pethaiyan, Madhan ; Gao, Liming ; Kinney, Michael D ; Xu, Wei6 <= wei6.xu@intel.com> Subject: [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition From: "Pethaiyan, Madhan" UEFI Spec 2.10 , 23.1 Firmware Management Protocol , Added missing conditio= n check under GetImageInfo function, if the PackageVersionName is NULL retu= rn EFI_INVALID_PARAMETER Signed-off-by: Pethaiyan Madhan Cc: Liming Gao Cc: Michael D Kinney Cc: Wei6 Xu --- FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c in= dex 1e7ec4a09e..e87094f84c 100644 --- a/FmpDevicePkg/FmpDxe/FmpDxe.c +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c @@ -495,7 +495,7 @@ GetTheImageInfo ( // Confirm that buffer isn't null // if ( (ImageInfo =3D=3D NULL) || (DescriptorVersion =3D=3D NULL) || (Des= criptorCount =3D=3D NULL) || (DescriptorSize =3D=3D NULL) - || (PackageVersion =3D=3D NULL)) + || (PackageVersion =3D=3D NULL) || (PackageVersionName =3D=3D NULL)) { DEBUG ((DEBUG_ERROR, "FmpDxe(%s): GetImageInfo() - Pointer Parameter i= s NULL.\n", mImageIdName)); Status =3D EFI_INVALID_PARAMETER; -- 2.38.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114085): https://edk2.groups.io/g/devel/message/114085 Mute This Topic: https://groups.io/mt/103620853/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-