* [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
@ 2023-01-04 7:47 hunter.chang
2023-01-04 8:11 ` Ashraf Ali S
2023-01-05 7:05 ` Ni, Ray
0 siblings, 2 replies; 9+ messages in thread
From: hunter.chang @ 2023-01-04 7:47 UTC (permalink / raw)
To: devel; +Cc: Hunter Chang, Ray Ni, Rangasai V Chaganty, Isaac Oram,
Ashraf Ali S
From: Hunter Chang <hunter.chang@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4242
Define a macro for SmbiosFeaturePkg usage which named
INTEL_FVI_SMBIOS_TYPE and initialized to 0xDD in
IndustryStandard/FirmwareVersionInfo.h
Signed-off-by: Hunter Chang <hunter.chang@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
---
Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h
index b30bc3f9e7..466cb8e7d2 100644
--- a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h
+++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h
@@ -18,6 +18,7 @@
#include <IndustryStandard/SmBios.h>
#define INTEL_FIRMWARE_VERSION_INFO_GROUP_NAME "Firmware Version Info"
+#define INTEL_FVI_SMBIOS_TYPE 0xDD
#pragma pack(1)
--
2.26.2.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
2023-01-04 7:47 [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h hunter.chang
@ 2023-01-04 8:11 ` Ashraf Ali S
2023-01-05 7:05 ` Ni, Ray
1 sibling, 0 replies; 9+ messages in thread
From: Ashraf Ali S @ 2023-01-04 8:11 UTC (permalink / raw)
To: Chang, Hunter, devel@edk2.groups.io
Cc: Ni, Ray, Chaganty, Rangasai V, Oram, Isaac W
Reviewed-by: S, Ashraf Ali <ashraf.ali.s@intel.com>
-----Original Message-----
From: Chang, Hunter <hunter.chang@intel.com>
Sent: Wednesday, January 4, 2023 1:17 PM
To: devel@edk2.groups.io
Cc: Chang, Hunter <hunter.chang@intel.com>; Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
Subject: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
From: Hunter Chang <hunter.chang@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4242
Define a macro for SmbiosFeaturePkg usage which named INTEL_FVI_SMBIOS_TYPE and initialized to 0xDD in IndustryStandard/FirmwareVersionInfo.h
Signed-off-by: Hunter Chang <hunter.chang@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
---
Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h
index b30bc3f9e7..466cb8e7d2 100644
--- a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h
+++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVer
+++ sionInfo.h
@@ -18,6 +18,7 @@
#include <IndustryStandard/SmBios.h> #define INTEL_FIRMWARE_VERSION_INFO_GROUP_NAME "Firmware Version Info"+#define INTEL_FVI_SMBIOS_TYPE 0xDD #pragma pack(1) --
2.26.2.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
2023-01-04 7:47 [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h hunter.chang
2023-01-04 8:11 ` Ashraf Ali S
@ 2023-01-05 7:05 ` Ni, Ray
2023-01-05 7:54 ` hunter.chang
1 sibling, 1 reply; 9+ messages in thread
From: Ni, Ray @ 2023-01-05 7:05 UTC (permalink / raw)
To: Chang, Hunter, devel@edk2.groups.io
Cc: Chaganty, Rangasai V, Oram, Isaac W, S, Ashraf Ali
Which spec defines 0xDD?
> -----Original Message-----
> From: Chang, Hunter <hunter.chang@intel.com>
> Sent: Wednesday, January 4, 2023 3:47 PM
> To: devel@edk2.groups.io
> Cc: Chang, Hunter <hunter.chang@intel.com>; Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
> Subject: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
>
> From: Hunter Chang <hunter.chang@intel.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4242
>
> Define a macro for SmbiosFeaturePkg usage which named
> INTEL_FVI_SMBIOS_TYPE and initialized to 0xDD in
> IndustryStandard/FirmwareVersionInfo.h
>
> Signed-off-by: Hunter Chang <hunter.chang@intel.com>
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> ---
> Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h
> b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h
> index b30bc3f9e7..466cb8e7d2 100644
> --- a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h
> +++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h
> @@ -18,6 +18,7 @@
> #include <IndustryStandard/SmBios.h>
>
>
>
> #define INTEL_FIRMWARE_VERSION_INFO_GROUP_NAME "Firmware Version Info"
>
> +#define INTEL_FVI_SMBIOS_TYPE 0xDD
>
>
>
> #pragma pack(1)
>
>
>
> --
> 2.26.2.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
2023-01-05 7:05 ` Ni, Ray
@ 2023-01-05 7:54 ` hunter.chang
2023-01-05 9:39 ` Ni, Ray
0 siblings, 1 reply; 9+ messages in thread
From: hunter.chang @ 2023-01-05 7:54 UTC (permalink / raw)
To: Ni, Ray, devel@edk2.groups.io
Cc: Chaganty, Rangasai V, Oram, Isaac W, S, Ashraf Ali
It is from Sipkg.dec
gSiPkgTokenSpaceGuid.PcdFviSmbiosType|0xDD
0x00~0x7F are reserved for and defined by smbios spec
0x80~0xFF are available for system- and OEM-specific information
I think there is no spec define 0xDD.
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Thursday, January 5, 2023 3:05 PM
To: Chang, Hunter <hunter.chang@intel.com>; devel@edk2.groups.io
Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
Which spec defines 0xDD?
> -----Original Message-----
> From: Chang, Hunter <hunter.chang@intel.com>
> Sent: Wednesday, January 4, 2023 3:47 PM
> To: devel@edk2.groups.io
> Cc: Chang, Hunter <hunter.chang@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
> Subject: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in
> FirmwareVersionInfo.h
>
> From: Hunter Chang <hunter.chang@intel.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4242
>
> Define a macro for SmbiosFeaturePkg usage which named
> INTEL_FVI_SMBIOS_TYPE and initialized to 0xDD in
> IndustryStandard/FirmwareVersionInfo.h
>
> Signed-off-by: Hunter Chang <hunter.chang@intel.com>
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> ---
>
> Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersion
> Info.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersi
> onInfo.h
> b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersi
> onInfo.h
> index b30bc3f9e7..466cb8e7d2 100644
> ---
> a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersi
> onInfo.h
> +++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareV
> +++ ersionInfo.h
> @@ -18,6 +18,7 @@
> #include <IndustryStandard/SmBios.h>
>
>
>
> #define INTEL_FIRMWARE_VERSION_INFO_GROUP_NAME "Firmware Version Info"
>
> +#define INTEL_FVI_SMBIOS_TYPE 0xDD
>
>
>
> #pragma pack(1)
>
>
>
> --
> 2.26.2.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
2023-01-05 7:54 ` hunter.chang
@ 2023-01-05 9:39 ` Ni, Ray
2023-01-05 19:25 ` Isaac Oram
0 siblings, 1 reply; 9+ messages in thread
From: Ni, Ray @ 2023-01-05 9:39 UTC (permalink / raw)
To: Chang, Hunter, devel@edk2.groups.io
Cc: Chaganty, Rangasai V, Oram, Isaac W, S, Ashraf Ali
If it's not defined by any spec, it's probably not a good idea to put the definition in an industry header file.
> -----Original Message-----
> From: Chang, Hunter <hunter.chang@intel.com>
> Sent: Thursday, January 5, 2023 3:54 PM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; S, Ashraf Ali
> <ashraf.ali.s@intel.com>
> Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
>
> It is from Sipkg.dec
> gSiPkgTokenSpaceGuid.PcdFviSmbiosType|0xDD
>
> 0x00~0x7F are reserved for and defined by smbios spec
> 0x80~0xFF are available for system- and OEM-specific information
>
> I think there is no spec define 0xDD.
>
> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Thursday, January 5, 2023 3:05 PM
> To: Chang, Hunter <hunter.chang@intel.com>; devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; S, Ashraf Ali
> <ashraf.ali.s@intel.com>
> Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
>
> Which spec defines 0xDD?
>
> > -----Original Message-----
> > From: Chang, Hunter <hunter.chang@intel.com>
> > Sent: Wednesday, January 4, 2023 3:47 PM
> > To: devel@edk2.groups.io
> > Cc: Chang, Hunter <hunter.chang@intel.com>; Ni, Ray
> > <ray.ni@intel.com>; Chaganty, Rangasai V
> > <rangasai.v.chaganty@intel.com>; Oram, Isaac W
> > <isaac.w.oram@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
> > Subject: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in
> > FirmwareVersionInfo.h
> >
> > From: Hunter Chang <hunter.chang@intel.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4242
> >
> > Define a macro for SmbiosFeaturePkg usage which named
> > INTEL_FVI_SMBIOS_TYPE and initialized to 0xDD in
> > IndustryStandard/FirmwareVersionInfo.h
> >
> > Signed-off-by: Hunter Chang <hunter.chang@intel.com>
> >
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> > Cc: Isaac Oram <isaac.w.oram@intel.com>
> > Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> > ---
> >
> > Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersion
> > Info.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersi
> > onInfo.h
> > b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersi
> > onInfo.h
> > index b30bc3f9e7..466cb8e7d2 100644
> > ---
> > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersi
> > onInfo.h
> > +++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareV
> > +++ ersionInfo.h
> > @@ -18,6 +18,7 @@
> > #include <IndustryStandard/SmBios.h>
> >
> >
> >
> > #define INTEL_FIRMWARE_VERSION_INFO_GROUP_NAME "Firmware Version Info"
> >
> > +#define INTEL_FVI_SMBIOS_TYPE 0xDD
> >
> >
> >
> > #pragma pack(1)
> >
> >
> >
> > --
> > 2.26.2.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
2023-01-05 9:39 ` Ni, Ray
@ 2023-01-05 19:25 ` Isaac Oram
2023-01-06 1:00 ` Ni, Ray
0 siblings, 1 reply; 9+ messages in thread
From: Isaac Oram @ 2023-01-05 19:25 UTC (permalink / raw)
To: Ni, Ray, Chang, Hunter, devel@edk2.groups.io
Cc: Chaganty, Rangasai V, S, Ashraf Ali
Ray,
I think it is ok because this file is "Intel common definitions for an OEM defined SMBIOS table structure". We could say that the folder name is wrong or the whole file is in the wrong place. But this addition seems consistent with the rest of the file contents.
Regards,
Isaac
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Thursday, January 5, 2023 1:39 AM
To: Chang, Hunter <hunter.chang@intel.com>; devel@edk2.groups.io
Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
If it's not defined by any spec, it's probably not a good idea to put the definition in an industry header file.
> -----Original Message-----
> From: Chang, Hunter <hunter.chang@intel.com>
> Sent: Thursday, January 5, 2023 3:54 PM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram, Isaac
> W <isaac.w.oram@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
> Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE
> definition in FirmwareVersionInfo.h
>
> It is from Sipkg.dec
> gSiPkgTokenSpaceGuid.PcdFviSmbiosType|0xDD
>
> 0x00~0x7F are reserved for and defined by smbios spec 0x80~0xFF are
> available for system- and OEM-specific information
>
> I think there is no spec define 0xDD.
>
> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Thursday, January 5, 2023 3:05 PM
> To: Chang, Hunter <hunter.chang@intel.com>; devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram, Isaac
> W <isaac.w.oram@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
> Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE
> definition in FirmwareVersionInfo.h
>
> Which spec defines 0xDD?
>
> > -----Original Message-----
> > From: Chang, Hunter <hunter.chang@intel.com>
> > Sent: Wednesday, January 4, 2023 3:47 PM
> > To: devel@edk2.groups.io
> > Cc: Chang, Hunter <hunter.chang@intel.com>; Ni, Ray
> > <ray.ni@intel.com>; Chaganty, Rangasai V
> > <rangasai.v.chaganty@intel.com>; Oram, Isaac W
> > <isaac.w.oram@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
> > Subject: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition
> > in FirmwareVersionInfo.h
> >
> > From: Hunter Chang <hunter.chang@intel.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4242
> >
> > Define a macro for SmbiosFeaturePkg usage which named
> > INTEL_FVI_SMBIOS_TYPE and initialized to 0xDD in
> > IndustryStandard/FirmwareVersionInfo.h
> >
> > Signed-off-by: Hunter Chang <hunter.chang@intel.com>
> >
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> > Cc: Isaac Oram <isaac.w.oram@intel.com>
> > Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> > ---
> >
> > Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersi
> > on
> > Info.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVer
> > si
> > onInfo.h
> > b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVer
> > si
> > onInfo.h
> > index b30bc3f9e7..466cb8e7d2 100644
> > ---
> > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVer
> > si
> > onInfo.h
> > +++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/Firmwar
> > +++ eV
> > +++ ersionInfo.h
> > @@ -18,6 +18,7 @@
> > #include <IndustryStandard/SmBios.h>
> >
> >
> >
> > #define INTEL_FIRMWARE_VERSION_INFO_GROUP_NAME "Firmware Version Info"
> >
> > +#define INTEL_FVI_SMBIOS_TYPE 0xDD
> >
> >
> >
> > #pragma pack(1)
> >
> >
> >
> > --
> > 2.26.2.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
2023-01-05 19:25 ` Isaac Oram
@ 2023-01-06 1:00 ` Ni, Ray
2023-01-06 2:48 ` [edk2-devel] " Chang, Hunter
2023-01-06 5:48 ` Chang, Hunter
0 siblings, 2 replies; 9+ messages in thread
From: Ni, Ray @ 2023-01-06 1:00 UTC (permalink / raw)
To: Oram, Isaac W, Chang, Hunter, devel@edk2.groups.io
Cc: Chaganty, Rangasai V, S, Ashraf Ali
Isaac,
So, no public doc defines the SMBIOS entry: SMBIOS_TABLE_TYPE_OEM_INTEL_FVI?
Then, I am ok with the new addition 0xDD.
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Oram, Isaac W <isaac.w.oram@intel.com>
> Sent: Friday, January 6, 2023 3:26 AM
> To: Ni, Ray <ray.ni@intel.com>; Chang, Hunter <hunter.chang@intel.com>; devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
> Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
>
> Ray,
>
> I think it is ok because this file is "Intel common definitions for an OEM defined SMBIOS table structure". We could say that
> the folder name is wrong or the whole file is in the wrong place. But this addition seems consistent with the rest of the file
> contents.
>
> Regards,
> Isaac
>
> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Thursday, January 5, 2023 1:39 AM
> To: Chang, Hunter <hunter.chang@intel.com>; devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; S, Ashraf Ali
> <ashraf.ali.s@intel.com>
> Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
>
> If it's not defined by any spec, it's probably not a good idea to put the definition in an industry header file.
>
>
> > -----Original Message-----
> > From: Chang, Hunter <hunter.chang@intel.com>
> > Sent: Thursday, January 5, 2023 3:54 PM
> > To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
> > Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram, Isaac
> > W <isaac.w.oram@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
> > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE
> > definition in FirmwareVersionInfo.h
> >
> > It is from Sipkg.dec
> > gSiPkgTokenSpaceGuid.PcdFviSmbiosType|0xDD
> >
> > 0x00~0x7F are reserved for and defined by smbios spec 0x80~0xFF are
> > available for system- and OEM-specific information
> >
> > I think there is no spec define 0xDD.
> >
> > -----Original Message-----
> > From: Ni, Ray <ray.ni@intel.com>
> > Sent: Thursday, January 5, 2023 3:05 PM
> > To: Chang, Hunter <hunter.chang@intel.com>; devel@edk2.groups.io
> > Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram, Isaac
> > W <isaac.w.oram@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
> > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE
> > definition in FirmwareVersionInfo.h
> >
> > Which spec defines 0xDD?
> >
> > > -----Original Message-----
> > > From: Chang, Hunter <hunter.chang@intel.com>
> > > Sent: Wednesday, January 4, 2023 3:47 PM
> > > To: devel@edk2.groups.io
> > > Cc: Chang, Hunter <hunter.chang@intel.com>; Ni, Ray
> > > <ray.ni@intel.com>; Chaganty, Rangasai V
> > > <rangasai.v.chaganty@intel.com>; Oram, Isaac W
> > > <isaac.w.oram@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
> > > Subject: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition
> > > in FirmwareVersionInfo.h
> > >
> > > From: Hunter Chang <hunter.chang@intel.com>
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4242
> > >
> > > Define a macro for SmbiosFeaturePkg usage which named
> > > INTEL_FVI_SMBIOS_TYPE and initialized to 0xDD in
> > > IndustryStandard/FirmwareVersionInfo.h
> > >
> > > Signed-off-by: Hunter Chang <hunter.chang@intel.com>
> > >
> > > Cc: Ray Ni <ray.ni@intel.com>
> > > Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> > > Cc: Isaac Oram <isaac.w.oram@intel.com>
> > > Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> > > ---
> > >
> > > Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersi
> > > on
> > > Info.h | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVer
> > > si
> > > onInfo.h
> > > b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVer
> > > si
> > > onInfo.h
> > > index b30bc3f9e7..466cb8e7d2 100644
> > > ---
> > > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVer
> > > si
> > > onInfo.h
> > > +++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/Firmwar
> > > +++ eV
> > > +++ ersionInfo.h
> > > @@ -18,6 +18,7 @@
> > > #include <IndustryStandard/SmBios.h>
> > >
> > >
> > >
> > > #define INTEL_FIRMWARE_VERSION_INFO_GROUP_NAME "Firmware Version Info"
> > >
> > > +#define INTEL_FVI_SMBIOS_TYPE 0xDD
> > >
> > >
> > >
> > > #pragma pack(1)
> > >
> > >
> > >
> > > --
> > > 2.26.2.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
2023-01-06 1:00 ` Ni, Ray
@ 2023-01-06 2:48 ` Chang, Hunter
2023-01-06 5:48 ` Chang, Hunter
1 sibling, 0 replies; 9+ messages in thread
From: Chang, Hunter @ 2023-01-06 2:48 UTC (permalink / raw)
To: Ni, Ray, devel
[-- Attachment #1: Type: text/plain, Size: 23 bytes --]
Thanks for the review
[-- Attachment #2: Type: text/html, Size: 23 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
2023-01-06 1:00 ` Ni, Ray
2023-01-06 2:48 ` [edk2-devel] " Chang, Hunter
@ 2023-01-06 5:48 ` Chang, Hunter
1 sibling, 0 replies; 9+ messages in thread
From: Chang, Hunter @ 2023-01-06 5:48 UTC (permalink / raw)
To: Ni, Ray, Oram, Isaac W, devel@edk2.groups.io
Cc: Chaganty, Rangasai V, S, Ashraf Ali
Thanks for the review!
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Friday, January 6, 2023 9:01 AM
To: Oram, Isaac W <isaac.w.oram@intel.com>; Chang, Hunter <hunter.chang@intel.com>; devel@edk2.groups.io
Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
Isaac,
So, no public doc defines the SMBIOS entry: SMBIOS_TABLE_TYPE_OEM_INTEL_FVI?
Then, I am ok with the new addition 0xDD.
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Oram, Isaac W <isaac.w.oram@intel.com>
> Sent: Friday, January 6, 2023 3:26 AM
> To: Ni, Ray <ray.ni@intel.com>; Chang, Hunter
> <hunter.chang@intel.com>; devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; S, Ashraf
> Ali <ashraf.ali.s@intel.com>
> Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE
> definition in FirmwareVersionInfo.h
>
> Ray,
>
> I think it is ok because this file is "Intel common definitions for an
> OEM defined SMBIOS table structure". We could say that the folder
> name is wrong or the whole file is in the wrong place. But this addition seems consistent with the rest of the file contents.
>
> Regards,
> Isaac
>
> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Thursday, January 5, 2023 1:39 AM
> To: Chang, Hunter <hunter.chang@intel.com>; devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram, Isaac
> W <isaac.w.oram@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
> Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE
> definition in FirmwareVersionInfo.h
>
> If it's not defined by any spec, it's probably not a good idea to put the definition in an industry header file.
>
>
> > -----Original Message-----
> > From: Chang, Hunter <hunter.chang@intel.com>
> > Sent: Thursday, January 5, 2023 3:54 PM
> > To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
> > Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram,
> > Isaac W <isaac.w.oram@intel.com>; S, Ashraf Ali
> > <ashraf.ali.s@intel.com>
> > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE
> > definition in FirmwareVersionInfo.h
> >
> > It is from Sipkg.dec
> > gSiPkgTokenSpaceGuid.PcdFviSmbiosType|0xDD
> >
> > 0x00~0x7F are reserved for and defined by smbios spec 0x80~0xFF are
> > available for system- and OEM-specific information
> >
> > I think there is no spec define 0xDD.
> >
> > -----Original Message-----
> > From: Ni, Ray <ray.ni@intel.com>
> > Sent: Thursday, January 5, 2023 3:05 PM
> > To: Chang, Hunter <hunter.chang@intel.com>; devel@edk2.groups.io
> > Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Oram,
> > Isaac W <isaac.w.oram@intel.com>; S, Ashraf Ali
> > <ashraf.ali.s@intel.com>
> > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE
> > definition in FirmwareVersionInfo.h
> >
> > Which spec defines 0xDD?
> >
> > > -----Original Message-----
> > > From: Chang, Hunter <hunter.chang@intel.com>
> > > Sent: Wednesday, January 4, 2023 3:47 PM
> > > To: devel@edk2.groups.io
> > > Cc: Chang, Hunter <hunter.chang@intel.com>; Ni, Ray
> > > <ray.ni@intel.com>; Chaganty, Rangasai V
> > > <rangasai.v.chaganty@intel.com>; Oram, Isaac W
> > > <isaac.w.oram@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
> > > Subject: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE
> > > definition in FirmwareVersionInfo.h
> > >
> > > From: Hunter Chang <hunter.chang@intel.com>
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4242
> > >
> > > Define a macro for SmbiosFeaturePkg usage which named
> > > INTEL_FVI_SMBIOS_TYPE and initialized to 0xDD in
> > > IndustryStandard/FirmwareVersionInfo.h
> > >
> > > Signed-off-by: Hunter Chang <hunter.chang@intel.com>
> > >
> > > Cc: Ray Ni <ray.ni@intel.com>
> > > Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> > > Cc: Isaac Oram <isaac.w.oram@intel.com>
> > > Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> > > ---
> > >
> > > Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVer
> > > si
> > > on
> > > Info.h | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareV
> > > er
> > > si
> > > onInfo.h
> > > b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareV
> > > er
> > > si
> > > onInfo.h
> > > index b30bc3f9e7..466cb8e7d2 100644
> > > ---
> > > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareV
> > > er
> > > si
> > > onInfo.h
> > > +++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/Firmw
> > > +++ ar
> > > +++ eV
> > > +++ ersionInfo.h
> > > @@ -18,6 +18,7 @@
> > > #include <IndustryStandard/SmBios.h>
> > >
> > >
> > >
> > > #define INTEL_FIRMWARE_VERSION_INFO_GROUP_NAME "Firmware Version Info"
> > >
> > > +#define INTEL_FVI_SMBIOS_TYPE 0xDD
> > >
> > >
> > >
> > > #pragma pack(1)
> > >
> > >
> > >
> > > --
> > > 2.26.2.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-01-06 5:49 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-04 7:47 [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h hunter.chang
2023-01-04 8:11 ` Ashraf Ali S
2023-01-05 7:05 ` Ni, Ray
2023-01-05 7:54 ` hunter.chang
2023-01-05 9:39 ` Ni, Ray
2023-01-05 19:25 ` Isaac Oram
2023-01-06 1:00 ` Ni, Ray
2023-01-06 2:48 ` [edk2-devel] " Chang, Hunter
2023-01-06 5:48 ` Chang, Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox