From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.7758.1672984139979149838 for ; Thu, 05 Jan 2023 21:49:00 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=LD7iTyze; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: hunter.chang@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672984139; x=1704520139; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Cqp8FsxZkLUHSFB5pmqAhM7FzGxS33tvC5fQ9mljRR0=; b=LD7iTyzeaYiRlaib2UKHAk69f8n0YZ3a2SG+VCRSKVBOIh6pFDiEZx1h qKG5vJVZAykFA88P/Pe0iSW+rcSIqQEeYDjC4stOEpSOpQTdz5Mli08F4 RuNzn0p59gE+hme8hZpIRuB0bgIQynPENtbEhUWuUsSaSevXALybvlh1Y Oz0pQitQYsCtM2G5/7HgDO3T5q1eZ5+5NLGitsQ2u44+cv28RKpSvEaTr bBSz3UhcubyhBaNdriYa66uHWtb+mRi+zsPef9ZXSUAJ+bMXjNCJzUEKs DB1wjdi8f/OFWst4LfTfSvhqJOcJvwbuA1DlViIIi25hTuDRirfmaH5wq g==; X-IronPort-AV: E=McAfee;i="6500,9779,10581"; a="384716423" X-IronPort-AV: E=Sophos;i="5.96,304,1665471600"; d="scan'208";a="384716423" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2023 21:48:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10581"; a="688198944" X-IronPort-AV: E=Sophos;i="5.96,304,1665471600"; d="scan'208";a="688198944" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 05 Jan 2023 21:48:59 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 5 Jan 2023 21:48:58 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 5 Jan 2023 21:48:58 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 5 Jan 2023 21:48:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M9U+UpdLdSq1uB0MarJ7+EdzHW3nw0r841KRVhLE94RZmooDfwXaD3+eL0/Y9gAqYz+Gu8FBqOU8zY61hWjZW924EMdRKQzzo2RZfTFUXyfKQPqRXtv4G1Xe5RVKI6z8c1yLixmtD69Nm4NEAQ6SGLpyq86yiSrwNoLLmr/wJQlEkMlzvs8FsWYjy/2CILc1kWNhyyVN0mXH/TW5dI7eRLyvaaROM37OK2yBrn4/XeJD2SfnyrI7xxqVp92donEyFu2WcIimVvhtBfGwn5ewFO0eqWgdvrUYIQQkndhVv0BJzPo7xjQoyRR6vljPiNjk1nkmJQrwUQUphvdV9C/5lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XVBH76JwqRXtCAR124RK+n4Mf9cqgmV2o60HcpavjQs=; b=LF+NKiWE+niZ8EI7W35srTN7DV0bEOLp1AZlv0XprRrs9tVfcwTSFdHyTN6o6MNvEGSRUTSzxYGD0ALTOyUcmtrs137TAbn3hirFeRFX82Q6tih0M7LDxujAynG7FY4hE4JDt/UC6gOSDFaA+2rtGn6hH2LdPfAYNG84O60/3+IRmBw8mPQ3pImaHwIaAv5NUT6QjB9zhxCkxTlUEp8a9Ho230ta+DL7ysb0CSA/rAx5Mgj6ppqnPbKaI53aIeb0YmRhTJUi2CjmCQQrnM1MUBr4sNOiUAea7vCgaHHArykJexsc4XeziPCBIL8c01nNFrAg86GuZrA7rmKujvNBXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5360.namprd11.prod.outlook.com (2603:10b6:5:397::17) by MW4PR11MB6787.namprd11.prod.outlook.com (2603:10b6:303:209::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 05:48:51 +0000 Received: from DM4PR11MB5360.namprd11.prod.outlook.com ([fe80::2375:e328:422c:677c]) by DM4PR11MB5360.namprd11.prod.outlook.com ([fe80::2375:e328:422c:677c%2]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 05:48:51 +0000 From: "Chang, Hunter" To: "Ni, Ray" , "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "S, Ashraf Ali" Subject: Re: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h Thread-Topic: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h Thread-Index: AQHZIBFQb58xsQSLaEWznH8TFEFRL66PaAiAgAAGpHCAACRPAIAAo9eAgABdsYCAAEiGYA== Date: Fri, 6 Jan 2023 05:48:51 +0000 Message-ID: References: <20230104074715.1782-1-hunter.chang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5360:EE_|MW4PR11MB6787:EE_ x-ms-office365-filtering-correlation-id: 13454636-9ace-4489-043d-08daefa9b07e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: I6EIi4YMy64uoIfdJcMTVLSzkzqruuk0DmFm71g14n9tk8babLF51H/1EkJXdfI0bRpazSy74X2mWMQ2IBkkRV2Ied57p5k/tehH49A/BB9tGJneJs8ivgCpx9LIS88rt8SlQWGtDC4w8ke8kXpihzzq2lW4DkMPP7qmD+nnjq1z6/PkuGK0ZYu0845qq+Wgp2UY28vAB///cxScmjfx4Rx4SNSyGCW2iauzcXFdq9ZMbQXpd41Iz8CGSssypmq73NcLoqtxG9tWdtB47EQr6hEDasg82jB8p7XKZoeySX1a0OaHuZWmLmLjZ1cxCibFdmfx94zOmw5Tw69ZCy5OaBnkHPFPb1+41mG+cWSPYFA87udjcaqC/KNnqoW+vVTPHXUIA0lXkA00DRIxlAjGqgVWFMlib5e5sLX2HI4BpkfCFT9VoUKGzfiEQEMK8avv4LR+W0+0FisLNnIX4WvzrTQvjZOxil0n/nHBo3HaT6mAZTemQBMtKJixzNISJqwqRlU+plATTFQNP0YRtj6OxzdsCH3pm3gWQatA501tdh1KMoZGemfVono/p/q5LyX/sHUbfnygAruiymnxy9inB8zBjLQZRfI4jf0AGhXCtsdaRGfBCglp9S4GZxxlrolyZgMDDamtPoQyi8ZywwiYRVMUTIRxOlj8ONkwHOakT3W+5A6c0wNAJBE7SutgAE1Sd+/iCSCp4OjjO/KLic7/I+NMo5vs0DjaLF9jSMZtl+E= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5360.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(39860400002)(366004)(396003)(136003)(451199015)(186003)(26005)(9686003)(83380400001)(86362001)(55016003)(33656002)(38070700005)(122000001)(38100700002)(82960400001)(64756008)(54906003)(110136005)(2906002)(52536014)(4326008)(5660300002)(66946007)(8936002)(41300700001)(8676002)(76116006)(107886003)(66476007)(316002)(66556008)(478600001)(66446008)(71200400001)(7696005)(966005)(53546011)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?onBTDtrr6CUN6U67cATUg+p80cm+Q17nDxgrC35YD/5jnr2omWDnMtEkO4if?= =?us-ascii?Q?9HSxXXNFuNDdlFgOj0z16Nri/+dIunT5Z0Fl/LhoPxx5bjkVI8TBbf3I19O7?= =?us-ascii?Q?uzJndJtbqTc/gGuPVkRC4zvUoLN5gmxI/KsCG49Q7fee3+5LtNOAff8rc1Qq?= =?us-ascii?Q?TJhMtCWhI9Blcl+bwiBXey92YneMZMwiGP1W/vke+mAfTN8LUnt8+oa8dr//?= =?us-ascii?Q?GmLBXXwnhTIyGjEFsaWT8L2Zooar3Bm2TmUXe/wYQ6sUXCNQuA8g9uEokeUl?= =?us-ascii?Q?lgcQbL7Ueao3iDqLSEpUg5nZn7ApiNDUBAms0NqipsWhMCgd8M+p5U+1dcux?= =?us-ascii?Q?Cl3Jg4KOpxPDUVbYP0v/Kmh1zHV7prFIIedttJkzCnNFULn6wR/M8+ac6yNi?= =?us-ascii?Q?9sigKvyzc6ZgGVuAY47jiw2hpgCsagaBTy6HDONsmPqvPAMv5hYM7Lrf2bo6?= =?us-ascii?Q?iXFUUA/at2PMuUyXxDAbUec5ID6dEcN3ZFVeh1kBwoyL+YmPnTdBTQef3p4R?= =?us-ascii?Q?ShojNQo+t/dIIWMa5UByWSC8QGePmabkD6WquQFyW1lQVqGr7nDophBEhnuF?= =?us-ascii?Q?MM23SuXqsOanL59+HWxfRYlpZPgUWAJoowJAugKTry/qV0jr3bXVyAdHx/ne?= =?us-ascii?Q?jwyql3EFgg7qAD+37oT0TQNFtqlx5lrvSBfN74cee9aDh5skPPmlfWXR3ieQ?= =?us-ascii?Q?0mOtybioK8zBin6Vo6/ipMX/PsU8F/kMc2aqXkCC5MMygt1S+uEU9lJZll/9?= =?us-ascii?Q?FJAXDOYKLVtHQ8/8DvF0Zsgyiuq48hNTl8UggCQn+7D5prunQ8xg3QmH4KiJ?= =?us-ascii?Q?Wa1oyttKFfQBqoYnkkukUpbV+tjYfHrshCDauMLRY5o3KQvq92MD2oDGpmJU?= =?us-ascii?Q?g7UwyPB3o91MKZZ0VQCJmcEYZqVvg6husAO4bQkXEBTGjSSMoKuPxrdCu0AZ?= =?us-ascii?Q?FJbf/mBZdyeOTfRp2MXInwqdL0njbsCcSJ5tVKVGddI1rWKKFvrgfSCdrWnN?= =?us-ascii?Q?+WgkGD6f9+s9YcPn7gsHpIR0kaEgRejXd9CtVfDIaVU96t3Vr2z8b8Hz9pV0?= =?us-ascii?Q?wIV+Y/n/KlGE3AQ8jcl7AP5i4k9TARytkzO6Kim78PiPaHk6R5mPxSSEy+0l?= =?us-ascii?Q?9RYiIiUBUZua//FmnQyVldXbH3ZefHfmAj4dDdzmq6VTU14Du2Emmiya5ok1?= =?us-ascii?Q?Zb5EnjAp7EqR62qE3IB3vHuImhfuTYLzwYFqhbitxceoHhxYfYRDQUFwJuNJ?= =?us-ascii?Q?3UoR6NOb7lqMdsBSJOXhsNI/uvmL8B99U0JigkXy6izRGZwjxrbSxoW4BOtl?= =?us-ascii?Q?jsdj5LpuHRpU1XOwuWUWxWq2lQHb+0j27DVFBOkJz2Qn15B2dMl2W6EV6eT+?= =?us-ascii?Q?g59Nphc7Jq7jhV8gpXFeydyW92mWcCjpruUGYzOLYRatHCNp0LJ39TMuJimq?= =?us-ascii?Q?IOn44eSbTBj4atVrmwtAMJoG21vwEApPYKjBJyNebCQwXOYTmgkgW86071dh?= =?us-ascii?Q?QmMxuSw6eMhKTvZsrZzMe6syOv5ZHCmBKh4NuUFNsTqa5pb7y1dU2FQsJKjt?= =?us-ascii?Q?RKILqexe+l29rJT8ZznPJk6WvWTAB0gjSUFD+UeO?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5360.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 13454636-9ace-4489-043d-08daefa9b07e X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 05:48:51.5750 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QwXWYkLDov043Xmga5CtT6XSMoREf62TZJJ7M+Dq4X29DFoANj/opHLligR+33PjZB/gK3ESoUz7igyPLZTTFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6787 Return-Path: hunter.chang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the review! -----Original Message----- From: Ni, Ray =20 Sent: Friday, January 6, 2023 9:01 AM To: Oram, Isaac W ; Chang, Hunter ; devel@edk2.groups.io Cc: Chaganty, Rangasai V ; S, Ashraf Ali Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in = FirmwareVersionInfo.h Isaac, So, no public doc defines the SMBIOS entry: SMBIOS_TABLE_TYPE_OEM_INTEL_FVI= ? Then, I am ok with the new addition 0xDD. Reviewed-by: Ray Ni > -----Original Message----- > From: Oram, Isaac W > Sent: Friday, January 6, 2023 3:26 AM > To: Ni, Ray ; Chang, Hunter=20 > ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; S, Ashraf=20 > Ali > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE=20 > definition in FirmwareVersionInfo.h >=20 > Ray, >=20 > I think it is ok because this file is "Intel common definitions for an=20 > OEM defined SMBIOS table structure". We could say that the folder=20 > name is wrong or the whole file is in the wrong place. But this addition= seems consistent with the rest of the file contents. >=20 > Regards, > Isaac >=20 > -----Original Message----- > From: Ni, Ray > Sent: Thursday, January 5, 2023 1:39 AM > To: Chang, Hunter ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Oram, Isaac=20 > W ; S, Ashraf Ali > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE=20 > definition in FirmwareVersionInfo.h >=20 > If it's not defined by any spec, it's probably not a good idea to put the= definition in an industry header file. >=20 >=20 > > -----Original Message----- > > From: Chang, Hunter > > Sent: Thursday, January 5, 2023 3:54 PM > > To: Ni, Ray ; devel@edk2.groups.io > > Cc: Chaganty, Rangasai V ; Oram,=20 > > Isaac W ; S, Ashraf Ali=20 > > > > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE=20 > > definition in FirmwareVersionInfo.h > > > > It is from Sipkg.dec > > gSiPkgTokenSpaceGuid.PcdFviSmbiosType|0xDD > > > > 0x00~0x7F are reserved for and defined by smbios spec 0x80~0xFF are=20 > > available for system- and OEM-specific information > > > > I think there is no spec define 0xDD. > > > > -----Original Message----- > > From: Ni, Ray > > Sent: Thursday, January 5, 2023 3:05 PM > > To: Chang, Hunter ; devel@edk2.groups.io > > Cc: Chaganty, Rangasai V ; Oram,=20 > > Isaac W ; S, Ashraf Ali=20 > > > > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE=20 > > definition in FirmwareVersionInfo.h > > > > Which spec defines 0xDD? > > > > > -----Original Message----- > > > From: Chang, Hunter > > > Sent: Wednesday, January 4, 2023 3:47 PM > > > To: devel@edk2.groups.io > > > Cc: Chang, Hunter ; Ni, Ray=20 > > > ; Chaganty, Rangasai V=20 > > > ; Oram, Isaac W=20 > > > ; S, Ashraf Ali > > > Subject: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE=20 > > > definition in FirmwareVersionInfo.h > > > > > > From: Hunter Chang > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4242 > > > > > > Define a macro for SmbiosFeaturePkg usage which named=20 > > > INTEL_FVI_SMBIOS_TYPE and initialized to 0xDD in=20 > > > IndustryStandard/FirmwareVersionInfo.h > > > > > > Signed-off-by: Hunter Chang > > > > > > Cc: Ray Ni > > > Cc: Rangasai V Chaganty > > > Cc: Isaac Oram > > > Cc: Ashraf Ali S > > > --- > > > > > > Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVer > > > si > > > on > > > Info.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git > > > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareV > > > er > > > si > > > onInfo.h > > > b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareV > > > er > > > si > > > onInfo.h > > > index b30bc3f9e7..466cb8e7d2 100644 > > > --- > > > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareV > > > er > > > si > > > onInfo.h > > > +++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/Firmw > > > +++ ar > > > +++ eV > > > +++ ersionInfo.h > > > @@ -18,6 +18,7 @@ > > > #include > > > > > > > > > > > > #define INTEL_FIRMWARE_VERSION_INFO_GROUP_NAME "Firmware Version = Info" > > > > > > +#define INTEL_FVI_SMBIOS_TYPE 0xDD > > > > > > > > > > > > #pragma pack(1) > > > > > > > > > > > > -- > > > 2.26.2.windows.1