From: "Sun, Yi Y" <yi.y.sun@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Xu, Min M" <min.m.xu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"lersek@redhat.com" <lersek@redhat.com>,
Michael Roth <michael.roth@amd.com>,
Oliver Steffen <osteffen@redhat.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
"Aktas, Erdem" <erdemaktas@google.com>,
"Huang, Jiaqing" <jiaqing.huang@intel.com>
Subject: Re: [edk2-devel] [PATCH v3 1/4] OvmfPkg/Sec: Setup MTRR early in the boot process.
Date: Thu, 1 Feb 2024 09:49:36 +0000 [thread overview]
Message-ID: <DM4PR11MB54087C321B843CC0656D9ACFCE432@DM4PR11MB5408.namprd11.prod.outlook.com> (raw)
In-Reply-To: <ywe3t5edi3olqaio2kjrnrzzux7vcquvm2ozec7agivuciekdr@gja4zekxgcau>
> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Thursday, February 1, 2024 5:43 PM
> To: Sun, Yi Y <yi.y.sun@intel.com>
> Cc: Xu, Min M <min.m.xu@intel.com>; devel@edk2.groups.io;
> lersek@redhat.com; Michael Roth <michael.roth@amd.com>; Oliver Steffen
> <osteffen@redhat.com>; Yao, Jiewen <jiewen.yao@intel.com>; Tom
> Lendacky <thomas.lendacky@amd.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Aktas, Erdem <erdemaktas@google.com>;
> Huang, Jiaqing <jiaqing.huang@intel.com>
> Subject: Re: RE: [edk2-devel] [PATCH v3 1/4] OvmfPkg/Sec: Setup MTRR early
> in the boot process.
>
> On Thu, Feb 01, 2024 at 06:10:26AM +0000, Sun, Yi Y wrote:
> > Hi, all,
> >
> > Per our test, this issue only happens when the mdev/vdev is assigned
> > to VM. But PF(physical function)/VF(virtual function) assignment is
> > good. Per Jiaqing's investigation, it is because that the mdev/vdev
> > passthrough flow is different with PF/VF. For vdev/mdev passthrough to
> > VM, the enforce_cache_coherency was enabled after device bound to
> > iommufd. But it doesn't update the kvm coherency state after that.
> > This makes the memory type be UNCACHABLE which causes the reading is
> > very slow.
> >
> > So, what is your opinion to fix it? Which side to fix it is better,
> > ovmf or vfio? Thanks!
>
> Both? For OVMF it surely makes sense to properly setup MTRRs. And if the
> cache coherency behavior of vfio is not correct that should be fixed too of
> course.
>
Sounds good. Thanks!
BRs,
Yi Sun
> take care,
> Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114979): https://edk2.groups.io/g/devel/message/114979
Mute This Topic: https://groups.io/mt/104052591/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-02-01 23:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 13:04 [edk2-devel] [PATCH v3 0/4] OvmfPkg/Sec: Setup MTRR early in the boot process Gerd Hoffmann
2024-01-30 13:04 ` [edk2-devel] [PATCH v3 1/4] " Gerd Hoffmann
2024-01-30 19:22 ` Laszlo Ersek
2024-01-31 12:06 ` Laszlo Ersek
2024-02-01 5:20 ` Min Xu
2024-02-01 6:10 ` Sun, Yi Y
2024-02-01 9:43 ` Gerd Hoffmann
2024-02-01 9:49 ` Sun, Yi Y [this message]
2024-02-01 9:38 ` Gerd Hoffmann
2024-02-12 15:22 ` Gerd Hoffmann
2024-02-20 6:27 ` Min Xu
2024-02-20 8:15 ` Gerd Hoffmann
2024-04-11 6:56 ` Corvin Köhne
2024-04-11 8:12 ` Gerd Hoffmann
2024-04-15 1:04 ` Min Xu
2024-05-22 8:59 ` Corvin Köhne
2024-05-30 9:03 ` Gerd Hoffmann
2024-06-03 7:13 ` Corvin Köhne
2024-06-03 10:38 ` Gerd Hoffmann
2024-01-30 13:04 ` [edk2-devel] [PATCH v3 2/4] MdePkg/ArchitecturalMsr.h: add #defines for MTRR cache types Gerd Hoffmann
2024-01-30 17:49 ` Michael D Kinney
2024-01-30 19:23 ` Laszlo Ersek
2024-01-30 19:28 ` Laszlo Ersek
2024-01-30 13:04 ` [edk2-devel] [PATCH v3 3/4] UefiCpuPkg/MtrrLib.h: use cache type #defines from ArchitecturalMsr.h Gerd Hoffmann
2024-01-30 17:49 ` Michael D Kinney
2024-01-30 19:24 ` Laszlo Ersek
2024-01-30 19:26 ` Laszlo Ersek
2024-01-30 19:29 ` Laszlo Ersek
2024-01-30 13:04 ` [edk2-devel] [PATCH v3 4/4] OvmfPkg/Sec: " Gerd Hoffmann
2024-01-30 19:25 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB54087C321B843CC0656D9ACFCE432@DM4PR11MB5408.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox