public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Dandan Bi" <dandan.bi@intel.com>
To: "kun.q@outlook.com" <kun.q@outlook.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>,
	gaoliming <gaoliming@byosoft.com.cn>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	"Bi, Dandan" <dandan.bi@intel.com>
Subject: Is there any use case of FirmwarePerformanceStandaloneMm.inf now?
Date: Thu, 5 Aug 2021 11:44:38 +0000	[thread overview]
Message-ID: <DM4PR11MB5453179A968C2C7F6B425EAAEAF29@DM4PR11MB5453.namprd11.prod.outlook.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1865 bytes --]

Hi Kun,

I plan to make some change for FirmwarePerformanceSmm.inf, may also update the behavior of FirmwarePerformanceStandaloneMm.inf as they are sharing codes now.
And I saw you are the submitter of this driver. Could you help clarify following questions ? Thanks in advance.


  1.  Do you have the use case to leverage FirmwarePerformanceStandaloneMm.inf to collect Standalone MM performance data now?
  2.  Do you have any Library/module used by StandaloneMmCore to collect Standalone MM performance data and report the data to FirmwarePerformanceStandaloneMm like the SmmCorePerformanceLib used for SMM core?
  3.  I plan to move some logic from FirmwarePerformanceDataTableSmm to SmmCorePerformanceLib as below. Do you think is it ok just to remove them from FirmwarePerformanceStandaloneMm.inf now?

If there is not any module to report Standalone MM performance data to FirmwarePerformanceStandaloneMm.inf, I think it should be OK to remove them from FirmwarePerformanceStandaloneMm now.


Change:
SMM performance data collection now:

  1.  SmmCorePerformanceLib collect all the performance data in SMM and report the data to FirmwarePerformanceDataTableSmm through status code.
  2.  DxeCorePerformanceLib will communicate with FirmwarePerformanceDataTableSmm to get the SMM performance data and allocate performance table to store all the performance data.
Now I want to simplify the process to make DxeCorePerformanceLib communicate with SmmCorePerformanceLib directly to collect SMM performance data, so FirmwarePerformanceDataTableSmm don't need to get the SMM performance data from SmmCorePerformanceLib and register SMI handler for the communication with DxeCorePerformanceLib.
For FirmwarePerformanceStandaloneMm.inf, just remove this logic if there is no module to prepare MM performance data to it now.


Thanks,
Dandan

[-- Attachment #2: Type: text/html, Size: 12521 bytes --]

             reply	other threads:[~2021-08-05 11:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 11:44 Dandan Bi [this message]
2021-08-05 22:48 ` [edk2-devel] Is there any use case of FirmwarePerformanceStandaloneMm.inf now? Kun Qin
2021-08-06  1:41   ` Ni, Ray
2021-08-06  3:02     ` Dandan Bi
2021-08-06  2:32   ` Dandan Bi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR11MB5453179A968C2C7F6B425EAAEAF29@DM4PR11MB5453.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox