Re: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead code block

["Dandan Bi" <dandan.bi@intel.com>]

PR is created for this change:
https://github.com/tianocore/edk2/pull/1945




Thanks,
Dandan
> -----Original Message-----
> From: Bi, Dandan
> Sent: Friday, August 27, 2021 11:58 AM
> To: Wenyi Xie <xiewenyi2@huawei.com>; devel@edk2.groups.io; Wang, Jian
> J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Dong, Eric
> <eric.dong@intel.com>
> Cc: songdongkuang@huawei.com
> Subject: RE: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove
> dead code block
> 
> Reviewed-by: Dandan Bi <dandan.bi@intel.com>
> 
> 
> Thanks,
> Dandan
> 
> > -----Original Message-----
> > From: Wenyi Xie <xiewenyi2@huawei.com>
> > Sent: Thursday, August 26, 2021 9:16 AM
> > To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>; Wu,
> > Hao A <hao.a.wu@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Dong,
> > Eric <eric.dong@intel.com>
> > Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
> > Subject: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove
> dead
> > code block
> >
> > As the if statement outside has confirmed that
> > BlockData->Name == NULL, so the if statement inside
> > is always false.
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Dandan Bi <dandan.bi@intel.com>
> > Cc: Eric Dong <eric.dong@intel.com>
> > Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> > ---
> >  MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> > b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> > index d492b769d51c..17a914208c6d 100644
> > --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> > +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> > @@ -2871,9 +2871,6 @@ ParseIfrData (
> >          //
> >          if ((BlockData->Name == NULL) && ((BlockData->Offset +
> > BlockData-
> > >Width) > VarStorageData->Size)) {
> >            Status = EFI_INVALID_PARAMETER;
> > -          if (BlockData->Name != NULL) {
> > -            FreePool (BlockData->Name);
> > -          }
> >            FreePool (BlockData);
> >            goto Done;
> >          }
> > --
> > 2.20.1.windows.1