From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.5013.1630578510248733698 for ; Thu, 02 Sep 2021 03:28:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=tZ4rb+it; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: dandan.bi@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10094"; a="206283847" X-IronPort-AV: E=Sophos;i="5.84,372,1620716400"; d="scan'208";a="206283847" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2021 03:28:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,372,1620716400"; d="scan'208";a="510928847" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga001.jf.intel.com with ESMTP; 02 Sep 2021 03:28:29 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 2 Sep 2021 03:28:28 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 2 Sep 2021 03:28:28 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 2 Sep 2021 03:28:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RUFerBxAP4tqL53wpGl2qG95+zTTFi45uvbsPiOH1Jt5S64n+Z+eXFkI3DrG3PZ/87/JBJSUey0EHmIyVAsnmVbPbDGyjaICq4/kp3FEUl6J+IKmQBUg6laTvY0SIULu/4NZ+01itgUD1SLGJH+giqayBoF0OEHg/NrtoT8Dr4uauDCp1OTjCDD12JK6274gXBHD9aewoT8qxAwv0hnbb841nlk10ZB1mrkMyakDchwM7zuop0XQ3NGmY6JbbI8FzfOtRniUb4RhGvchj895M5SE218M+Na0Arnon/uQ6LtLAWyAGRhwGXRICiGOH06bjMDZ1HFmdiSRkpaydTfjlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1K4JKUNhQlbZVS3MPkNOlU6YYgTjvlAd8EbKfHUiIKY=; b=Wl1PKvR5XH6Lb0siv6P6PHNcVynHD44ZlI+UFSrBkmzXpzK+YV8AQRfwrlajIQaMtXheoGmHCWVyX1GZdvZpuW1pldzi8kxobAMDhe8OJOlf+XooHRsul22YNnDH1mD8j6PdE8qq5zSfWoZQb43gougJJrqCQy2TK83M/iO3CTHSC/M++eDbPcrpfuRuaC4q4vB4gggCCA2XRkQkEQf+WuNzrISvRu1Y6TdJUp/69wAjfiP4dyuI8ljgoxf65opb4/yqspZi8sbHlGiPQAGT+fx/U61ZIy9jS/uDCz0IbSuocf6CRO/lqHjnsDXU1QzVMhH2fncNOz7z/kAhxOqw9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1K4JKUNhQlbZVS3MPkNOlU6YYgTjvlAd8EbKfHUiIKY=; b=tZ4rb+itKVNrsszaFRJJYCiQmuXg9NEmWbrTbHkaMerjMSey6BuHKYofYPwIKbmKITrx0w/Ep29+FPL4M1CO4hJKR/BD/o4YK/SNTvWfRikT5OJpnA/s7BPsoUWE29zKRmnXoJUNB3fFEt4psqsVt8PhnCOk76WJypN0kFyCAWA= Received: from DM4PR11MB5453.namprd11.prod.outlook.com (2603:10b6:5:398::15) by DM5PR1101MB2283.namprd11.prod.outlook.com (2603:10b6:4:50::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Thu, 2 Sep 2021 10:28:27 +0000 Received: from DM4PR11MB5453.namprd11.prod.outlook.com ([fe80::bd58:ab3d:9e8b:55c4]) by DM4PR11MB5453.namprd11.prod.outlook.com ([fe80::bd58:ab3d:9e8b:55c4%4]) with mapi id 15.20.4436.025; Thu, 2 Sep 2021 10:28:27 +0000 From: "Dandan Bi" To: Wenyi Xie , "devel@edk2.groups.io" , "Wang, Jian J" , "Wu, Hao A" , "Dong, Eric" CC: "songdongkuang@huawei.com" Subject: Re: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead code block Thread-Topic: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead code block Thread-Index: AQHXmhivRW8cNH7DzEeIOaNc1i5Rx6uGuzjwgAnaS7A= Date: Thu, 2 Sep 2021 10:28:26 +0000 Message-ID: References: <1629940563-82195-1-git-send-email-xiewenyi2@huawei.com> <1629940563-82195-2-git-send-email-xiewenyi2@huawei.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2a5d6335-cc56-4b45-0e11-08d96dfc66cb x-ms-traffictypediagnostic: DM5PR1101MB2283: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1824; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0oS1PhCJccND8S9St+Ossa0Si8oInICmz55oMzwi3XWVAAViFLerSuc8PBn8gPGAfZknX2If0cG/KnF+F+4wCCSb8WmTHdb8qXZU0arR9xlxq4bvCTjEa3oSRRVTkJ0sK3waFTALVdaf2Du2ArFQdc3/uRRuPul6V5ZTwN5mnEzGdinilAuDfjtpV9AVaBGkeSDpo7rX8+IhGuc/PMu+l2ZUSudzQ3zGUKnhw/wc/Pb7gSh5kUP6RAMBmK4LsHoVV/Ye86YWN0BtK9OTEO1Fv5CZCXmC211tYlW1vA9HivINK7N1k7pEUPiWqW/kw/6/f5qoNIT0Sx0CMR2i77d02yH0Ph5SGoPoy0I8Z39v+fxTz5lNgZpSl0zdmeADlHCKCbIAftKXufSBembLaGywmL6kR4aAdzKveS0z8dFH3lkAgwVYNEWVvMIiBsPMq2JoB9TC9kQUg3KXSo3PZJqJtVgsNNBulhDs148Fg4VaDM6cpmPzLYaXwxy2QKYgu47ROGGP1jsxVd8SjF3KW0zwoun1O25Pc4HGZwhq8Dz7GkycgX32gEwS4v+xY7k/3NPy1ax4ZH/2fL3UlZc2hXAM2cZc4oNK6fV3IFxcyj+Zk4GrwyDvbWWEEMr7YW9Erx7acdesiY7ZfCh4lLFOoqAfXSI54QD2E5ye5zj8AsQAbe6cRKH07bnW/0wqYIDsMIs6ceJlfhwbErJ6uMkYTyLq/zgZsHho/wOcjsqIQTuYh29+83wftLPjc+n34q5m9f6GhAHcPdLDWTNKx6+ryRw3AWEA41FHfySjYdL6jU8+AOY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5453.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(396003)(136003)(376002)(346002)(38100700002)(52536014)(8676002)(4326008)(71200400001)(966005)(66476007)(8936002)(2906002)(33656002)(5660300002)(66946007)(316002)(86362001)(26005)(110136005)(122000001)(64756008)(478600001)(7696005)(9686003)(6506007)(38070700005)(186003)(55016002)(83380400001)(53546011)(66446008)(66556008)(76116006)(6636002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ytfGgbbx5jGYQpvnmBcoUMTIDe1X63TN0py7ykxfCTwtbbGznl+HnLgcbUaL?= =?us-ascii?Q?uv1Cw02TGBx6poW4YsePgbGGSRDJfXHhiFk2tSRt6Wl4mWia+e4lQvEATewu?= =?us-ascii?Q?6EXZF7cSly7DSl9xHHtuj1Y5wPTPDMQ2LJaJSLbTe4dtqFGXCFm0zrI/HOhR?= =?us-ascii?Q?/NqG8Xd+tnXuqKzw1JUdPBgk8lnGJ/vUmnorWnIcp85FzxUIioQXJ3lJArt7?= =?us-ascii?Q?ZFYSN+gBl6kuzW48Q0jADMOi0xFLtxv9fuPvRQtWKHQJDDlZB32s5yl0ZMW0?= =?us-ascii?Q?nn13dK51PuIWo+bwbS6/fdKMS0DoCJGEA2HEG8+Y4eTRHiYWtW0dAgnVlWpB?= =?us-ascii?Q?m345FazYjYXG9T7BRGk1bjZrA7RrfpVr1/l5+eLD1cz6Rio9GlbJKXuBeYSu?= =?us-ascii?Q?a/pKAvKfIJVuOdia8ObYWihLXBXCAbs2fRPDPHxKe/6zjg63OkiUXjDEQPzf?= =?us-ascii?Q?SjaFuog+bjoLExDmg4P5N1Rdr8Ld9vxNGBhgtGAl4f3FTE72KpcQERVH9Qr0?= =?us-ascii?Q?RCSgek486NarLs7/REXvoZpumuysXc5Kxs2eKTuwUY2jcH3/vVhxcIBYI1wy?= =?us-ascii?Q?ufmpKTstnvA3nWoPeG/1j73I9tf5AiPziBzWxGzgfBaVbp96YU0WoMma5bbQ?= =?us-ascii?Q?CBm/HIQx88JFD/mw+da5ubA43juU7dAYzXNzkJPyVuzkKhPpgBF/0Mx0cnNj?= =?us-ascii?Q?cNF8jNeWWDJHn4/anQxqpxp83m0+6CP7U9qtUIZWHdQ1LRV7HWyjBixaty/R?= =?us-ascii?Q?BlEBQecbppK13E5yZx1R53HdLqUHYS/56W3StX3FwhjlQzrfQCXgPZ93UogM?= =?us-ascii?Q?eSZr6N4jwzb03fBbTAwpQ+2Qq52BcGoTZCGaiUzWJ4VTMzxxll733RiIKP6D?= =?us-ascii?Q?Nfz7/SXDRyZjAfG42Iri2PCjHu5uwN1/3KP9riDPSuZfk2cqLnHaygQ05rCq?= =?us-ascii?Q?NUTwooDEz6MkjfbqeinlLYrvfdnIkenbe+YiGpBoAMdRXZoT+JURY0gG+xBx?= =?us-ascii?Q?dhKKfDe2MM6kkDjzvRlQZ6tACedO36b4k6tf748dCnm/opa6kB4Be9IDnNUz?= =?us-ascii?Q?rC97XoCJfixmame+UE80x1mv62E55k+gGjNh/Z4yxrUHi12A5tdpA1xsZdo5?= =?us-ascii?Q?3g1NbX2yLnKuTWiGfHAwKj4DVRkNRsF0Qlbc/JrDZAMSkdObxwph/uoKE5Vd?= =?us-ascii?Q?GVQRVLoFKvadqHhipElU5Vo8jeBpTCDj7Iv7qlWZcphkeveFGDADKB/uz0WX?= =?us-ascii?Q?6BA6SsgueSwn2Vo45eSHAPecJt4IHYo1NQTbzJNfSgdliGq0Yi2DHYXnsj/m?= =?us-ascii?Q?Inwh+Hr2QP7Bn+5UJ+lKJZXb?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5453.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a5d6335-cc56-4b45-0e11-08d96dfc66cb X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2021 10:28:27.2728 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IsyJeW/nDnVA3etevwtvN4cvUihoQKykUpjP0QsTVZp0zRLnSt6zxql4V+UVv5mk/WoAt2aQZxYWpVUMXa3kiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2283 Return-Path: dandan.bi@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable PR is created for this change: https://github.com/tianocore/edk2/pull/1945 Thanks, Dandan > -----Original Message----- > From: Bi, Dandan > Sent: Friday, August 27, 2021 11:58 AM > To: Wenyi Xie ; devel@edk2.groups.io; Wang, Jian > J ; Wu, Hao A ; Dong, Eric > > Cc: songdongkuang@huawei.com > Subject: RE: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove > dead code block >=20 > Reviewed-by: Dandan Bi >=20 >=20 > Thanks, > Dandan >=20 > > -----Original Message----- > > From: Wenyi Xie > > Sent: Thursday, August 26, 2021 9:16 AM > > To: devel@edk2.groups.io; Wang, Jian J ; Wu, > > Hao A ; Bi, Dandan ; Dong, > > Eric > > Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com > > Subject: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove > dead > > code block > > > > As the if statement outside has confirmed that > > BlockData->Name =3D=3D NULL, so the if statement inside > > is always false. > > > > Cc: Jian J Wang > > Cc: Hao A Wu > > Cc: Dandan Bi > > Cc: Eric Dong > > Signed-off-by: Wenyi Xie > > --- > > MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > > b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > > index d492b769d51c..17a914208c6d 100644 > > --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > > +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > > @@ -2871,9 +2871,6 @@ ParseIfrData ( > > // > > if ((BlockData->Name =3D=3D NULL) && ((BlockData->Offset + > > BlockData- > > >Width) > VarStorageData->Size)) { > > Status =3D EFI_INVALID_PARAMETER; > > - if (BlockData->Name !=3D NULL) { > > - FreePool (BlockData->Name); > > - } > > FreePool (BlockData); > > goto Done; > > } > > -- > > 2.20.1.windows.1