public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Dandan Bi" <dandan.bi@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>,
	"xiewenyi2@huawei.com" <xiewenyi2@huawei.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>
Cc: "songdongkuang@huawei.com" <songdongkuang@huawei.com>
Subject: Re: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/DxeCorePerformanceLib:Variable Initial
Date: Fri, 3 Dec 2021 09:43:53 +0000	[thread overview]
Message-ID: <DM4PR11MB545362B1C38A1036F96CBFEDEA6A9@DM4PR11MB5453.namprd11.prod.outlook.com> (raw)
In-Reply-To: <000a01d7e656$1f465d40$5dd317c0$@byosoft.com.cn>

Just created the pull request for this patch 
https://github.com/tianocore/edk2/pull/2234



Thanks,
Dandan

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> gaoliming
> Sent: Wednesday, December 1, 2021 9:53 AM
> To: devel@edk2.groups.io; xiewenyi2@huawei.com; Wang, Jian J
> <jian.j.wang@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> Cc: songdongkuang@huawei.com
> Subject: 回复: [edk2-devel] [PATCH EDK2 v1 1/1]
> MdeModulePkg/DxeCorePerformanceLib:Variable Initial
> 
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> 
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 wenyi,xie
> via
> > groups.io
> > 发送时间: 2021年11月30日 9:51
> > 收件人: devel@edk2.groups.io; jian.j.wang@intel.com;
> > gaoliming@byosoft.com.cn; dandan.bi@intel.com
> > 抄送: songdongkuang@huawei.com; xiewenyi2@huawei.com
> > 主题: [edk2-devel] [PATCH EDK2 v1 1/1]
> > MdeModulePkg/DxeCorePerformanceLib:Variable Initial
> >
> > SmmBootRecordDataSize is initialized in InternalGetSmmPerData, but
> > this function may fail. so to avoid using SmmBootRecordDataSize
> > without intialization, set it to 0 at first.
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Dandan Bi <dandan.bi@intel.com>
> > Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> > ---
> >
> MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
> > | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git
> >
> a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi
> b.
> > c
> >
> b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi
> b.
> > c
> > index 532b3f8c90e2..f8778c25188a 100644
> > ---
> >
> a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi
> b.
> > c
> > +++
> >
> b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi
> b.
> > c
> > @@ -1373,6 +1373,8 @@ UpdateBootPerformanceTable (
> >    UINTN                            AppendSize;
> >    UINT8                            *FirmwarePerformanceTablePtr;
> >
> > +  SmmBootRecordDataSize = 0;
> > +
> >    //
> >    // Get SMM performance data.
> >    //
> > --
> > 2.20.1.windows.1
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
> 


  reply	other threads:[~2021-12-03  9:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30  1:51 [PATCH EDK2 v1 0/1] MdeModulePkg/DxeCorePerformanceLib:Variable Initial wenyi,xie
2021-11-30  1:51 ` [PATCH EDK2 v1 1/1] " wenyi,xie
2021-12-01  1:52   ` 回复: [edk2-devel] " gaoliming
2021-12-03  9:43     ` Dandan Bi [this message]
2021-12-01  2:18   ` Dandan Bi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR11MB545362B1C38A1036F96CBFEDEA6A9@DM4PR11MB5453.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox