From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.17757.1628740031275986492 for ; Wed, 11 Aug 2021 20:47:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=BCdGLU0S; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: dandan.bi@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10073"; a="202459141" X-IronPort-AV: E=Sophos;i="5.84,314,1620716400"; d="scan'208";a="202459141" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 20:47:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,314,1620716400"; d="scan'208";a="673415043" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 11 Aug 2021 20:47:10 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 11 Aug 2021 20:47:09 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Wed, 11 Aug 2021 20:47:09 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 11 Aug 2021 20:47:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=APr9FwBhaFbB3mEsSn2B0yzolr/A3DHqKoZ+YiwxaaRbfrokjcO7yHk2vgfLtTNqT0zstHjAoyrm0kI8QEju4p1BmTGLXNa/Bh+zowallM/Pyrn1YhObUFKjWrq0T0sxvMeHanCkjxJbwdSdby2tBSGtwZtBJCNUzMOL/DREtCZXo0UC3vENcVLOAWygqsjYVB/0/H8IpAMMAD3HzGtASwG8+vIPXvHwott1mYDM2u9tvjoj0p548OzqZrSXKA0Ia0Ivk5fnoBSDyfyN388uhv3vd/ewgOHxZIHwtX4KYpBVD1ahY0wGxoGTMyykFzQeKraMAca9LSK4fl+jbqGwow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BZazfZdYPI4/n8PolRTZ3lYbCvl5LwxSog0KrUAKss8=; b=H46dbEtc9Z6+r7KTzecRCLj8vf11W566QoWnVN81NsoK8P8AfKMXG9qjP1POD6J5QMHixjCByzXAJ0BREXJBgtyiEJ8PrbaIsZwF89UWT5+uTSJe1a3vXHRKuEKAQY4aiGAdt6451nRKWJpenLi8yqZLbW2W4A1JbQIUf8Vdir0csToP/mBqZLkK0atc5L/8wkh+Vtifgjy3T+i2uokoOgAKuE898Rkq5JAMrllhsUwz3J1075oDpQ2VVm/3lMXgIrOLmR48ShGDB8tt0ZuMVdIS1b2/tPx8LJ8Pkj9vI3E3MWO/0sq0RMzXPtgLpIcMUEynUi5dbZo8YJU2Zsgf+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BZazfZdYPI4/n8PolRTZ3lYbCvl5LwxSog0KrUAKss8=; b=BCdGLU0SIAQHMOfT8x0efennWpltBRdXOzgj0/skLvvHaghpQlvgZXzwiHvdZdUVmcXix1lgOGgm8kLQ57ZXvoTwT/+rYufc74gqZbUc6zge9gk8YHTilwnMX+sOe3+Cph+ypd9pIIF5+eOPags2NjqEF4moshzZzRg91tdmNGM= Received: from DM4PR11MB5453.namprd11.prod.outlook.com (2603:10b6:5:398::15) by DM5PR11MB1978.namprd11.prod.outlook.com (2603:10b6:3:10d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.21; Thu, 12 Aug 2021 03:47:03 +0000 Received: from DM4PR11MB5453.namprd11.prod.outlook.com ([fe80::bd58:ab3d:9e8b:55c4]) by DM4PR11MB5453.namprd11.prod.outlook.com ([fe80::bd58:ab3d:9e8b:55c4%3]) with mapi id 15.20.4415.016; Thu, 12 Aug 2021 03:47:03 +0000 From: "Dandan Bi" To: "Yeh, GregX" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" , Liming Gao Subject: Re: [PATCH] MdeModulePkg PCD: FSP NotifyPhase APIs caused 100ms delay Thread-Topic: [PATCH] MdeModulePkg PCD: FSP NotifyPhase APIs caused 100ms delay Thread-Index: AQHXjMYph+Fj+bOtKE6c5AitKZra2KtvPMxQ Date: Thu, 12 Aug 2021 03:47:03 +0000 Message-ID: References: <20210809022732.1753-1-gregx.yeh@intel.com> In-Reply-To: <20210809022732.1753-1-gregx.yeh@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5a5d3c39-d9f9-42ab-4b9b-08d95d43d900 x-ms-traffictypediagnostic: DM5PR11MB1978: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bhxnIm6Wylc1HxyX40hkXkiumdPg01HBTqYROKWdkwjrBMjVlLFQkfiW4RJnxbtWiyNKn2VHNea4punpHt0xWStxg3g9YksMsXirY9RZE5DCxFtXuadePi61NpT1u6fwZOkx80ImZ5SCRZU3dyf+zWUEYGZukF0D+wAktYnY/7TENi0byP6Qpj5Xn2ZYo3V9s1ExsJPRi5iTcdgbXFnu5rvqXM0ixCKyo/oh9Cgqi/+Va9+eFTdDv93K1/IZX9EdjdgjTPx8naPdtj19scuu/zPL46r3oQKGOihEle2+f39z4HbCsOyu1JR07VO4PScdkLK6/H8fyS+Pjkh2ZlmbLYsdIFMUnfCN1X6RNc7nDrFS/48Gd90/5GwCCThTgIEnHan15CGRQA7VI6+KkVERSoxwc55BFwtD8WY9WZTlRnCE+3lUY4e0s8OpP1ljndU+kcQO6JnQySHfQtBKJMIrmnZJN8rpcgrD2b/WY/pWx4HMICNCEBL6zE+wck+Zk9pW9c3ZZGO+iVvhLIYxc8VPkxQSGlKY6NwrCRkk/xdFpwj7lhuF4bAS211i69bhCnV0YdPAwzDiK3Eco8Wh0Hsw/wriIP+Js+f2lJkrFsS1TL+d8F2etGHFhGddti+jD9Gbmf6wgN13H1tTbHSp+VAgJW4poJryVrmeKYFT+FNy7o8nF9Q6HKQbn7Lv6SOHlQyH5GVNNKdl+v1Dst+CIleWLoRNt9ySFof5gLYAVP6qqyOt7ruKDCDqYCPqPJ7ydlh13bbF5QgMF49pxXkHnLmSIOEVgBVacwOIU/6icD9rIVE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5453.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(366004)(136003)(346002)(396003)(66946007)(66446008)(53546011)(33656002)(966005)(478600001)(9686003)(66556008)(64756008)(38070700005)(55016002)(76116006)(66476007)(122000001)(71200400001)(83380400001)(5660300002)(86362001)(7696005)(4326008)(52536014)(8936002)(316002)(2906002)(8676002)(38100700002)(186003)(110136005)(6506007)(54906003)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ki9siD+cQV0bVomeQY7Mg+iEDxi/pbCGflGY78uZxAE0cq5jVxz9v5hcdN+W?= =?us-ascii?Q?GwlR28Qgy81vIFT0W4myEcoL4lA9iEOVYgKRO01D5kLr6cbX64NZ/GE85iCh?= =?us-ascii?Q?WZLmPO8BriIBC28sRiQsNB3WJqHX7i8Q4sg1IohcV8/xT19ErRpWajdrPRui?= =?us-ascii?Q?7cUa9013t3poF2yu7Q/Gunkry88mbv9O+D9CMqWti0EXStlUl9wbQTrn3LxE?= =?us-ascii?Q?/pty2MMAtn1THbfRnBXj9uUHsFGJX+yJMP5W/NEUvqKxWuvDa/iigzftQd+Z?= =?us-ascii?Q?gpi7dOeuesJSnzOl4skcI04JZfzgHCQRYIsUpJDYuEuOu2yfzJPFHIc+kEbk?= =?us-ascii?Q?x4eVtdp/Bqk+sh8u0Zrr+X3h8fjxxd2FTX6Al81DVr+iP1iDkXA5aMIifEwV?= =?us-ascii?Q?dIS0CoQJ5cMpvFjd+rYPnZibwmQJsEIIgYNiaruhQzpqkPwzegcu2py51l+Q?= =?us-ascii?Q?BqbCLMa6LzeS4XTCyQhZgLRtA47g4Bqpjp5hx2oVQkfHS7k+F5DCsqSbb82W?= =?us-ascii?Q?hwOHs6x8QHZMmr08i5XebiRCqJvQIq52hbQd/yCS7/WgM69G4jsDgvnUTVQx?= =?us-ascii?Q?BQ8KBCHVpfUka3SOArVn/NIc8OpfQkzmf32zjORAzepQo2lo9Wn7mlkTlYv0?= =?us-ascii?Q?mqVY65rW94cFOa+wIsfw2zOQVwv4CJuveYJwMd+QJ/U+0YhNhvYdzSpPgaiY?= =?us-ascii?Q?bC3vfO5a0EBaq6FTjsQlQ4zYgzVhmBG5eI/5lFiea/2CSZAPvkH8Vg7CJCJn?= =?us-ascii?Q?HgRbu94Lyuzp+z/uIZMag13ICog80hQqBrhxRP1jw1xgbGbpmChC1W6462HA?= =?us-ascii?Q?ZibRRtsoWcqU/ZYEl6nsTzpb9/phQlvbclL2jhvj1GoOPc1BJPWnV+zP/wP0?= =?us-ascii?Q?tvugujyvXLqiOQ1XrON+2MnMGw6P7iIW+9aGHNclvIiyNdG/JtGoM9aHqFCf?= =?us-ascii?Q?rTsM00V4LRmjllL/p3+ETtu7eKbBPkDrRYoDzoqJiMphVmlv3nPtMCY7WAou?= =?us-ascii?Q?PM7nMeFrb4WuhwRNl99PtUdmTMPwAhdz1OSdnDjfT20lR6jWuEk+n24bg6Q3?= =?us-ascii?Q?jIzu4SnfkHFmqTVB0kDb4VywTwb7XfRugoKRe+NFvVyJQCNSHHC7+4TqqJfV?= =?us-ascii?Q?D0tFI1uEUOkqEz+XrlB5ec/KkUQZGZJwrM8XViSfg26LLIx1BUDzwNZcnP0f?= =?us-ascii?Q?WVBy1c8dIs4GP/8aVD0LS6so4qaUV7jP8Or617CoREiD7Om/eakBmKzhPYgg?= =?us-ascii?Q?Gkv1zlf0do/pBaRsNS5K8Ecktyd3I0lNFkmgfYLAcNKxDx127By6uL4oSICi?= =?us-ascii?Q?R8I=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5453.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a5d3c39-d9f9-42ab-4b9b-08d95d43d900 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2021 03:47:03.3039 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Z6rels4g4oXL5AkyeMePra0ispYjSWuZtICei+JazyIOWjTgLZNY6m8eAdqNgXk3S9PJkiIBBwpJZRmPPcvO2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1978 Return-Path: dandan.bi@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Greg, One minor comment, could we update the subject to reflect what have done in= this patch for PCD module before submitting the patch?=20 With that addressed Reviewed-by: Dandan Bi Thanks, Dandan > -----Original Message----- > From: Yeh, GregX > Sent: Monday, August 9, 2021 10:28 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Bi, Dandan ; Liming Gao > Subject: [PATCH] MdeModulePkg PCD: FSP NotifyPhase APIs caused 100ms > delay >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3525 >=20 > After PciSegmentLib using Dynamic PCD for Pcie base address such long del= ay > found in FSP. The root cause is some of the PCD service PPIs not shadowed > to memory and flash cache may have been disabled in NotifyPhase stage. > Solution is to shadow all PCD service PPIs to memory. >=20 > Signed-off-by: GregX Yeh > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Dandan Bi > Cc: Liming Gao > --- > MdeModulePkg/Universal/PCD/Pei/Pcd.c | 71 > +++++++++++++++++++++++++++- > 1 file changed, 70 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Universal/PCD/Pei/Pcd.c > b/MdeModulePkg/Universal/PCD/Pei/Pcd.c > index 9c6346924f..f31e0be35f 100644 > --- a/MdeModulePkg/Universal/PCD/Pei/Pcd.c > +++ b/MdeModulePkg/Universal/PCD/Pei/Pcd.c > @@ -1,7 +1,7 @@ > /** @file All Pcd Ppi services are implemented here. -Copyright (c) 20= 06 - > 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 20= 21, > Intel Corporation. All rights reserved.
(C) Copyright 2016 Hewlett > Packard Enterprise Development LP
SPDX-License-Identifier: BSD-2- > Clause-Patent @@ -339,6 +339,75 @@ PcdPeimInit ( > { EFI_STATUS Status; + Status =3D PeiServicesRegisterForShadow > (FileHandle);+ if (Status =3D=3D EFI_ALREADY_STARTED) {+ //+ // Th= is is now > starting in memory, the second time starting.+ //+ > EFI_PEI_PPI_DESCRIPTOR *OldPpiList;+ EFI_PEI_PPI_DESCRIPTOR > *OldPpiList2;+ VOID *Ppi;+ VOID *Ppi2;++ OldPpiList =3D NULL;+ = Status =3D > PeiServicesLocatePpi (+ &gPcdPpiGuid,+ 0,+ > &OldPpiList,+ &Ppi+ );+ ASSERT_EFI_ERROR (= Status);++ if > (OldPpiList !=3D NULL) {+ Status =3D PeiServicesReInstallPpi (OldPpi= List, > &mPpiList[0]);+ ASSERT_EFI_ERROR (Status);+ }++ OldPpiList2 = =3D NULL;+ > Status =3D PeiServicesLocatePpi (+ &gGetPcdInfoPpiGuid,+ = 0,+ > &OldPpiList2,+ &Ppi2+ );+ ASSERT_EFI_ERROR= (Status);++ if > (OldPpiList2 !=3D NULL) {+ Status =3D PeiServicesReInstallPpi (OldPp= iList2, > &mPpiList2[0]);+ ASSERT_EFI_ERROR (Status);+ }++ OldPpiList = =3D NULL;+ > Status =3D PeiServicesLocatePpi (+ &gEfiPeiPcdPpiGuid,+ = 0,+ > &OldPpiList,+ &Ppi+ );+ ASSERT_EFI_ERROR (= Status);++ if > (OldPpiList !=3D NULL) {+ Status =3D PeiServicesReInstallPpi (OldPpi= List, > &mPpiList[1]);+ ASSERT_EFI_ERROR (Status);+ }++ OldPpiList2 = =3D NULL;+ > Status =3D PeiServicesLocatePpi (+ &gEfiGetPcdInfoPpiGuid,+= 0,+ > &OldPpiList2,+ &Ppi2+ );+ ASSERT_EFI_ERROR= (Status);++ if > (OldPpiList2 !=3D NULL) {+ Status =3D PeiServicesReInstallPpi (OldPp= iList2, > &mPpiList2[1]);+ ASSERT_EFI_ERROR (Status);+ }++ return Status= ;+ }+ > BuildPcdDatabase (FileHandle); //-- > 2.32.0.windows.1