* [PATCH EDK2 v1 0/1] MdeModulePkg/DxeCorePerformanceLib:Variable Initial
@ 2021-11-30 1:51 wenyi,xie
2021-11-30 1:51 ` [PATCH EDK2 v1 1/1] " wenyi,xie
0 siblings, 1 reply; 5+ messages in thread
From: wenyi,xie @ 2021-11-30 1:51 UTC (permalink / raw)
To: devel, jian.j.wang, gaoliming, dandan.bi; +Cc: songdongkuang, xiewenyi2
Main Changes :
1.Initiallize SmmBootRecordDataSize to 0.
Wenyi Xie (1):
MdeModulePkg/DxeCorePerformanceLib:Variable Initial
MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c | 2 ++
1 file changed, 2 insertions(+)
--
2.20.1.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH EDK2 v1 1/1] MdeModulePkg/DxeCorePerformanceLib:Variable Initial
2021-11-30 1:51 [PATCH EDK2 v1 0/1] MdeModulePkg/DxeCorePerformanceLib:Variable Initial wenyi,xie
@ 2021-11-30 1:51 ` wenyi,xie
2021-12-01 1:52 ` 回复: [edk2-devel] " gaoliming
2021-12-01 2:18 ` Dandan Bi
0 siblings, 2 replies; 5+ messages in thread
From: wenyi,xie @ 2021-11-30 1:51 UTC (permalink / raw)
To: devel, jian.j.wang, gaoliming, dandan.bi; +Cc: songdongkuang, xiewenyi2
SmmBootRecordDataSize is initialized in InternalGetSmmPerData,
but this function may fail. so to avoid using SmmBootRecordDataSize
without intialization, set it to 0 at first.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Dandan Bi <dandan.bi@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
---
MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
index 532b3f8c90e2..f8778c25188a 100644
--- a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
+++ b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
@@ -1373,6 +1373,8 @@ UpdateBootPerformanceTable (
UINTN AppendSize;
UINT8 *FirmwarePerformanceTablePtr;
+ SmmBootRecordDataSize = 0;
+
//
// Get SMM performance data.
//
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* 回复: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/DxeCorePerformanceLib:Variable Initial
2021-11-30 1:51 ` [PATCH EDK2 v1 1/1] " wenyi,xie
@ 2021-12-01 1:52 ` gaoliming
2021-12-03 9:43 ` Dandan Bi
2021-12-01 2:18 ` Dandan Bi
1 sibling, 1 reply; 5+ messages in thread
From: gaoliming @ 2021-12-01 1:52 UTC (permalink / raw)
To: devel, xiewenyi2, jian.j.wang, dandan.bi; +Cc: songdongkuang
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 wenyi,xie via
> groups.io
> 发送时间: 2021年11月30日 9:51
> 收件人: devel@edk2.groups.io; jian.j.wang@intel.com;
> gaoliming@byosoft.com.cn; dandan.bi@intel.com
> 抄送: songdongkuang@huawei.com; xiewenyi2@huawei.com
> 主题: [edk2-devel] [PATCH EDK2 v1 1/1]
> MdeModulePkg/DxeCorePerformanceLib:Variable Initial
>
> SmmBootRecordDataSize is initialized in InternalGetSmmPerData,
> but this function may fail. so to avoid using SmmBootRecordDataSize
> without intialization, set it to 0 at first.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> ---
> MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
> | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
> a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.
> c
> b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.
> c
> index 532b3f8c90e2..f8778c25188a 100644
> ---
> a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.
> c
> +++
> b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.
> c
> @@ -1373,6 +1373,8 @@ UpdateBootPerformanceTable (
> UINTN AppendSize;
> UINT8 *FirmwarePerformanceTablePtr;
>
> + SmmBootRecordDataSize = 0;
> +
> //
> // Get SMM performance data.
> //
> --
> 2.20.1.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/DxeCorePerformanceLib:Variable Initial
2021-11-30 1:51 ` [PATCH EDK2 v1 1/1] " wenyi,xie
2021-12-01 1:52 ` 回复: [edk2-devel] " gaoliming
@ 2021-12-01 2:18 ` Dandan Bi
1 sibling, 0 replies; 5+ messages in thread
From: Dandan Bi @ 2021-12-01 2:18 UTC (permalink / raw)
To: devel@edk2.groups.io, xiewenyi2@huawei.com, Wang, Jian J,
gaoliming@byosoft.com.cn
Cc: songdongkuang@huawei.com
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
Thanks,
Dandan
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> wenyi,xie via groups.io
> Sent: Tuesday, November 30, 2021 9:51 AM
> To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>;
> gaoliming@byosoft.com.cn; Bi, Dandan <dandan.bi@intel.com>
> Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
> Subject: [edk2-devel] [PATCH EDK2 v1 1/1]
> MdeModulePkg/DxeCorePerformanceLib:Variable Initial
>
> SmmBootRecordDataSize is initialized in InternalGetSmmPerData, but this
> function may fail. so to avoid using SmmBootRecordDataSize without
> intialization, set it to 0 at first.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> ---
>
> MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
> | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
> a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi
> b.c
> b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi
> b.c
> index 532b3f8c90e2..f8778c25188a 100644
> ---
> a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi
> b.c
> +++
> b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi
> b.c
> @@ -1373,6 +1373,8 @@ UpdateBootPerformanceTable (
> UINTN AppendSize;
> UINT8 *FirmwarePerformanceTablePtr;
>
> + SmmBootRecordDataSize = 0;
> +
> //
> // Get SMM performance data.
> //
> --
> 2.20.1.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/DxeCorePerformanceLib:Variable Initial
2021-12-01 1:52 ` 回复: [edk2-devel] " gaoliming
@ 2021-12-03 9:43 ` Dandan Bi
0 siblings, 0 replies; 5+ messages in thread
From: Dandan Bi @ 2021-12-03 9:43 UTC (permalink / raw)
To: devel@edk2.groups.io, gaoliming@byosoft.com.cn,
xiewenyi2@huawei.com, Wang, Jian J
Cc: songdongkuang@huawei.com
Just created the pull request for this patch
https://github.com/tianocore/edk2/pull/2234
Thanks,
Dandan
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> gaoliming
> Sent: Wednesday, December 1, 2021 9:53 AM
> To: devel@edk2.groups.io; xiewenyi2@huawei.com; Wang, Jian J
> <jian.j.wang@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> Cc: songdongkuang@huawei.com
> Subject: 回复: [edk2-devel] [PATCH EDK2 v1 1/1]
> MdeModulePkg/DxeCorePerformanceLib:Variable Initial
>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 wenyi,xie
> via
> > groups.io
> > 发送时间: 2021年11月30日 9:51
> > 收件人: devel@edk2.groups.io; jian.j.wang@intel.com;
> > gaoliming@byosoft.com.cn; dandan.bi@intel.com
> > 抄送: songdongkuang@huawei.com; xiewenyi2@huawei.com
> > 主题: [edk2-devel] [PATCH EDK2 v1 1/1]
> > MdeModulePkg/DxeCorePerformanceLib:Variable Initial
> >
> > SmmBootRecordDataSize is initialized in InternalGetSmmPerData, but
> > this function may fail. so to avoid using SmmBootRecordDataSize
> > without intialization, set it to 0 at first.
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Dandan Bi <dandan.bi@intel.com>
> > Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> > ---
> >
> MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
> > | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git
> >
> a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi
> b.
> > c
> >
> b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi
> b.
> > c
> > index 532b3f8c90e2..f8778c25188a 100644
> > ---
> >
> a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi
> b.
> > c
> > +++
> >
> b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLi
> b.
> > c
> > @@ -1373,6 +1373,8 @@ UpdateBootPerformanceTable (
> > UINTN AppendSize;
> > UINT8 *FirmwarePerformanceTablePtr;
> >
> > + SmmBootRecordDataSize = 0;
> > +
> > //
> > // Get SMM performance data.
> > //
> > --
> > 2.20.1.windows.1
> >
> >
> >
> >
> >
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-12-03 9:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-30 1:51 [PATCH EDK2 v1 0/1] MdeModulePkg/DxeCorePerformanceLib:Variable Initial wenyi,xie
2021-11-30 1:51 ` [PATCH EDK2 v1 1/1] " wenyi,xie
2021-12-01 1:52 ` 回复: [edk2-devel] " gaoliming
2021-12-03 9:43 ` Dandan Bi
2021-12-01 2:18 ` Dandan Bi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox