From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web09.22271.1639459571702505776 for ; Mon, 13 Dec 2021 21:26:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.com header.s=intel header.b=YSaZ/7v6; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: dandan.bi@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639459571; x=1670995571; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=3/iXoDoXHuD1nThNvdM37OY4is9GoiMymL2zGNS1tHY=; b=YSaZ/7v6bd75BrZeKwgC048S/DMvNtIk1Spd27YZy7rWROGr9OdyU1Bx wcu1mCNPMEvl7rgdtIVingfRRwo5cre9PNiLNPEEw/quf2WJrQU3SIOry JgKsG9EhxBEUF2v/6nYfpCMLC80nEUXSN/ZGoJupbvys6XPR4guIZKV5G w3qkVsxh12dQmGo128Od5MdhcGCMuIqeuSuZ9YrwkHmcbASI/TIx40xCb Z/h01jrz6TGCSDR5m/lw0jvFTJhZ0rbiUnHkksKleUlZoop2qF97TWKAf ezY78MNzyZWZrXnhvYveLxgcNdd+YilzpX8dUie5mm7hTLxM4VGiT+gMB A==; X-IronPort-AV: E=McAfee;i="6200,9189,10197"; a="238711640" X-IronPort-AV: E=Sophos;i="5.88,204,1635231600"; d="scan'208";a="238711640" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 21:26:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,204,1635231600"; d="scan'208";a="505223456" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga007.jf.intel.com with ESMTP; 13 Dec 2021 21:26:10 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 13 Dec 2021 21:26:09 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 13 Dec 2021 21:26:09 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.49) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 13 Dec 2021 21:26:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WF/TMgCFj+KBTY9k7zWBkthuid+xalPymTSBkifPPx3/TRqamYW2Am9pg0+GD1wCh+Y32CbIpjaEtF6c+A1JQzNhnmKOPartCwyXX1FaJ8rSturkmXGwInaO7pisQB5Dat/3S0f4tRcAz5IB+dvbSNLaFWpIxBV0EpXeqPVcp89sW3SXqQt79ai5wkqPRQgjaWlT8uuhxpQvJwEDh0UI2iBPzMVmTxfbty23vNVQAclHiHd9c7L5w4su114PH1NW8ju3SN21NJGycoMyNae8XDcHAqYdfBdMdBCIWmWmcjTTEDeecRRBCIzTOQZeXKGy+f2JPHHSAszr0L2x7Pp6jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nJqbGkHxeXWMZE9ObP3DozOPp6RMnjyUgBer52pWUVE=; b=LnTehI20kEomS9TuU1+2Knun32YrESguyWzep0lMNQyphZlmqYXPY/dccBtTvyW45ejhUHd5kW260HLsaexcLwbZfOVcEvmdSv5xnN0V08Y6mYxQPRJ9t2gYzYEq5J37C9BoHNP7s3moOFHUjTh0mbtVoHAOwuV7zj+oM+9P+z+d7B2ePs6fvO7dOmQSJ7jR6IRo+VOYRJwobu8zr4CBATnwoj5JEDfk9cgiQvUlbVTeSyWy0uNGvvOUpvAfFxQit+jA5pwZ92klowrA/TwWmkv6U+x9R4AdxYhmmwro/uYXtCYLWyx1FoWwBHGKNY7UjRCNzGi2LpOiloN4jw/gnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nJqbGkHxeXWMZE9ObP3DozOPp6RMnjyUgBer52pWUVE=; b=nbgAMzPOtvctyJfpQHh2K73wRKUEw9N3v9rS3sI1wLvkKumgnC43PEY9zj9cp+9/JCCQLc2zDjh5oQpJLpYEPzhueoohiDOi6RnkltCGd2vJNTYWBJ0nsaN6KWg/yilG4eb3X3X/i37vDUgtxYs0Y+dSp/Y82wZFzM8LwhYDHIQ= Received: from DM4PR11MB5453.namprd11.prod.outlook.com (2603:10b6:5:398::15) by DM5PR11MB1707.namprd11.prod.outlook.com (2603:10b6:3:14::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec 2021 05:26:08 +0000 Received: from DM4PR11MB5453.namprd11.prod.outlook.com ([fe80::98ee:aad:6b97:373b]) by DM4PR11MB5453.namprd11.prod.outlook.com ([fe80::98ee:aad:6b97:373b%7]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021 05:26:08 +0000 From: "Dandan Bi" To: "Ke, Bo-ChangX" , "devel@edk2.groups.io" , "Dong, Eric" CC: "Chaganty, Rangasai V" , "Gao, Liming" Subject: Re: [PATCH] [PATCH v2][Edk2 Platform] UserAuthFeaturePkg: Add boot menu return status code to trigger function. Thread-Topic: [PATCH] [PATCH v2][Edk2 Platform] UserAuthFeaturePkg: Add boot menu return status code to trigger function. Thread-Index: AQHX7ZiuV2+10A77BUi16UxHQi9sY6wxd10Q Date: Tue, 14 Dec 2021 05:26:07 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 88670a47-22c3-4be4-2b03-08d9bec23b74 x-ms-traffictypediagnostic: DM5PR11MB1707:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0/3xA6SaCxiybyUVcG7YaDL6WKp/i+oHa0rg1CqcYjyx8scf+m7YlQdDp17nTP2JFyqIFdhA+UCYpoaV+fcPWHnVQhP3KbIQxPzXSs3RRIWnJPU3902P+Fk6o5hvhP1/c9PYBax3BqACh0J/YdGbVlb9LuZo/4fqmEsfcEzBVa+3hgc7xShpAlAnHWW6hKFUjL0Ir7X6Xr4iPsQgQSHdIF/PK/5PTgcARp7FleiPqjrGlOxHcvbu+eCqnyOPAxxiPlkR2Qyd1ae9Q+eXftaekCy2sE0k4Ft/WqpFj1i38T9jvEDchNkxmNiBOrJ1P8dJb0rrHW5YseCSq/T7X3gzgE4rOX58HoChhYZC8oqZp6k64GcUmjXWnl3Sw276oWi2CH8pzmh/zWKKMN0ZROR0sdr/CZQamjq0gAMWkXHb3ZyvPhM7tECANwwXmZg8duaeE2FK2xgNvTIcsjknfYrCIYe6FQOWF5mFixXErb33QIzqJDoF4bT7KjuI1M5wzBy70B7vAxrjhNf+XXVQ3iVGkTQ8w6W8y7kSIzTA0tSrh+jGVTc9TFAWwgl8xSOCW4P/y9K2M3CIVCq9gntZ9JWhpyQWXWBLyO7ltKSN5C3/xhkxiwme/IIh9SBf0OIzazjcQwxnAuadxKMtrBDfpBS2ECxzmU5qsCXra3yD5NOiZDlvoUdRXW47i3QmIDqwi1IDfWGTeKVcS7yqM/REp8o1yKtuLcU4cObtYPg1eWOXhu2VcoC0sxyFQz87K5iTR6VnGrDnWHZtg4GRdy1qwFYcZkF6Off9vScxg//nHjNN5Vk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5453.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(52536014)(82960400001)(4326008)(2906002)(110136005)(54906003)(86362001)(9686003)(122000001)(6636002)(316002)(38100700002)(38070700005)(83380400001)(8676002)(8936002)(66476007)(64756008)(66556008)(33656002)(66946007)(186003)(5660300002)(71200400001)(26005)(53546011)(6506007)(66446008)(76116006)(7696005)(508600001)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cLrbqD9fLMQVLLh+OotjpDj4JdTHmsJctc9+57kC0q5J3R5eEJpZ0EvvywjW?= =?us-ascii?Q?gsfcaPhhLTAe2n6HFpHIYLRGN+QandDH7Xdk2XMJnZjigMWzhXQDmA1RudWu?= =?us-ascii?Q?YVdKUz3Nkjx6LY3D3FmuJ9X0FmkmjxxvDTd7Z8KsxHPnY3LVexBxnNwtZ2Iu?= =?us-ascii?Q?6BRT9JcGjwCu7526hYttP2lCdDFyF1g3LfGOdfaXgy/CRdNUhrpTc4O3NL0r?= =?us-ascii?Q?7XRCWFO820cTxQUu+ZUiA3qm/8tQVMyK1q+Nyzb46M+wW/ARpTmKBz70lhym?= =?us-ascii?Q?vyAOMM5EbxhifJwJuMBsreq9uYOQvu4sxHn5qLKAlNpy9+IKZW/1um29qdSu?= =?us-ascii?Q?+ynkUk8LmL1pkVYQn4SALr/M9VGL3Xj3lhIp3XamgjONMPtEvtcVntzFZKQB?= =?us-ascii?Q?f4pHCT2FMPiD9KZEBzlmzaPLmHJDPlyHO2Py1xLxPzelTKLH3lfUbYbfTwVK?= =?us-ascii?Q?/MFRubgckL2eTdC2+yP/Ge/l37dZHHtKpm/QeaFzsdcASLmxDcP/exFIuFGs?= =?us-ascii?Q?ZtIiiYqLyDy77ka7RCavKLGqVbFwsUfqM50aUVrnXZem76uhguxD6/pX0Ldl?= =?us-ascii?Q?8TogdU4aTUcMSm5W6ACU3+9/IgaW2qNEtcXgz79A1EsII0QeensCO2sX4+ip?= =?us-ascii?Q?DEdB/wg7j3udUNPGm7rU6guBBrYC2GOYShHu5x2ZxIc1GhaQiICmpGqnTyPM?= =?us-ascii?Q?EO/bbxzpZSaLNVWZdJLOgYgKwqay8HK9oSSOxEpUww068OhzN2Gdbh8zhK1c?= =?us-ascii?Q?r33V1mEF1C3NhVqgsfcD56nlmvzadLZn15fXHBIBHO6GqOnVn4KF8dzOkXcf?= =?us-ascii?Q?PaUF3PSXCoWzgHYTkJu+FxynnwX3qnRTF5N7gx77jMA51XO+aA67Dd3clnqa?= =?us-ascii?Q?nOS9MIT8r+Dmno27aM+OmuluvYm/gUowFUeVlT9FGbX+iO6/jE27508OzLlc?= =?us-ascii?Q?ZqVjldfTNjwEF8eXQCVWOQM3uuHiA50ffNJJf4Spd1gEC1Dxl54FaqBAwyoL?= =?us-ascii?Q?h4egfiN2KPs1kNdUfT9d0O8ApvQrVuV3jOU3g80cYFMVY6D7xe+NM0xPM6r7?= =?us-ascii?Q?mgubEeO4QJeXRX2AT61hL1NlIrVeJ2laP1UEn86UEsJEiZldKnDZR3z9solj?= =?us-ascii?Q?/cP9Lo3KTtA3FY1Emu+g8EivzFSE1QYWeRe3GjLE3aoEKh8xwrojXVre4rqs?= =?us-ascii?Q?U1vxCoX67i5eWQ0ebfeFzE8WMJ6dRGkUXM5ad73hVQ9R9Qwptja50A71jO9I?= =?us-ascii?Q?8QzAvNrtuaJeq9vj4m9EfceuhVlCn7buX8UI7cAb9Qcmubdf08+T21KB1Sk1?= =?us-ascii?Q?DtkQLWgTx/j+qNQVKuAXhBq1U+PGqbZh8A/ZDM0KBS01yPk1t/CH7a43oRj/?= =?us-ascii?Q?AjOiE9VBBft2EYU8Xtoimc9q2WUShbRwU4KyU0zDjWKNq27FUk9vBN8fY6oy?= =?us-ascii?Q?gvjeXdzcxHvpL/vqw7V83xjF17f1ahdOiuOWvLgfXo9AsRM9a9bddDNLOzwH?= =?us-ascii?Q?iFuxCD2gQAXn2mOcsCFVEk3cenUtmLBSZgQXelt9/Bx5vSapU7gd8yaevR/+?= =?us-ascii?Q?ri834F6EaaramaXMpz2B1W5u3jJQJWjm3CeOC3zj2hDtjY6EWHp2cS2Wf2/4?= =?us-ascii?Q?+Q=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5453.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88670a47-22c3-4be4-2b03-08d9bec23b74 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 05:26:07.9100 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: L0pw9lQaSmxqIOpl1c1eKPIzTY+K7Av55k4Za56L7qA+JgiJ1KgAvN7zRzopJnvNc7VkMi1x1JZawykuQmuF0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1707 Return-Path: dandan.bi@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, 1. Do you try to update PcdBootManagerMenuFile to point to BootManagerMenuA= pp.inf and the test again? I think following change may not meet above scenario as it will not rep= ort ready to boot status code in such case.=20 2. I am wondering could we reuse EFI_SW_PC_USER_SETUP status code or add a = new status code for BootManagerMenuApp.inf to do the HOOK. As the hot key may be different per platforms, hook different key press= ed seems not very reasonable. Thanks, Dandan > -----Original Message----- > From: Ke, Bo-ChangX > Sent: Friday, December 10, 2021 3:34 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Liming Gao > ; Bi, Dandan > Subject: [PATCH] [PATCH v2][Edk2 Platform] UserAuthFeaturePkg: Add boot > menu return status code to trigger function. >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3764 >=20 > BIOS password is not required when overriding boot device via F7 hotkey. > Add boot menu return status code in callback function for ReportStatusCod= e() > notification. >=20 > Signed-off-by: Bo Chang Ke > Cc: Sai Chaganty > Cc: Liming Gao > Cc: Dandan Bi > Cc: Bo Chang Ke > --- > .../UserAuthenticationDxe.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) >=20 > diff --git > a/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDx > eSmm/UserAuthenticationDxe.c > b/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDx > eSmm/UserAuthenticationDxe.c > index bba2057a96..382d891711 100644 > --- > a/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDx > eSmm/UserAuthenticationDxe.c > +++ > b/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthentication > +++ DxeSmm/UserAuthenticationDxe.c > @@ -13,6 +13,7 @@ EFI_EVENT mExitBootServicesEv= ent =3D > NULL; > EFI_RSC_HANDLER_PROTOCOL *mRscHandlerProtocol =3D NULL; > USER_AUTHENTICATION_PRIVATE_DATA *mUserAuthenticationData =3D > NULL; > EFI_SMM_COMMUNICATION_PROTOCOL *mSmmCommunication =3D > NULL; > +BOOLEAN mHotKeyF7pressed =3D FALSE; >=20 > EFI_GUID mUserAuthenticationVendorGuid =3D > USER_AUTHENTICATION_FORMSET_GUID; HII_VENDOR_DEVICE_PATH > mHiiVendorDevicePath =3D { @@ -352,10 +353,19 @@ CheckForPassword ( > IN EFI_STATUS_CODE_DATA *Data OPTIONAL > ) > { > - BOOLEAN PasswordSet; > + BOOLEAN PasswordSet; > + EFI_INPUT_KEY Key; > + EFI_STATUS Status =3D EFI_SUCCESS; >=20 > + Status =3D gST->ConIn->ReadKeyStroke (gST->ConIn, &Key); > + > + if (Key.ScanCode =3D=3D SCAN_F7 && IsPasswordInstalled()) { > + mHotKeyF7pressed =3D TRUE; > + } > if (((CodeType & EFI_STATUS_CODE_TYPE_MASK) =3D=3D EFI_PROGRESS_CODE) > && > - (Value =3D=3D (EFI_SOFTWARE_DXE_BS_DRIVER | > EFI_SW_PC_USER_SETUP))) { > + (((Value =3D=3D (EFI_SOFTWARE_DXE_BS_DRIVER | > EFI_SW_DXE_BS_PC_READY_TO_BOOT_EVENT)) && mHotKeyF7pressed) || > + (Value =3D=3D (EFI_SOFTWARE_DXE_BS_DRIVER | > EFI_SW_PC_USER_SETUP)))) { > + mHotKeyF7pressed =3D FALSE; > // > // Check whether enter setup page. > // > -- > 2.32.0.windows.1