From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web09.19051.1628752293314169559 for ; Thu, 12 Aug 2021 00:11:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=QjuAw4IZ; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: dandan.bi@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10073"; a="202458900" X-IronPort-AV: E=Sophos;i="5.84,315,1620716400"; d="scan'208";a="202458900" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2021 00:11:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,315,1620716400"; d="scan'208";a="503769448" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga001.jf.intel.com with ESMTP; 12 Aug 2021 00:11:31 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 12 Aug 2021 00:11:31 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 12 Aug 2021 00:11:31 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 12 Aug 2021 00:11:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zdfj3OPlZw2ZB0z9YTcg6In6SBUX/61tE7xbk2ZZozMu2nCzktDvMSESx26xwzcsKSgTCsy6ORV9oysWBuDpEINj/JwNePdTWR1TXhW8zV0A2ICtb/0uhQaBBNC37xTBW+0V6m59uwN+Jclw9VpldxABCs7wqhaKQ1YRj0h+zUh9vEnKsDu0PFg6BoPF/HabgRrKCnzODFAhSuiBAycdPEX/AspXNRW+M62OrQJD5brSHtaV6nLkU0NUfWoJuIVS6B4zOfRKoOaPiK6WbSgauivNm1pxu4f/IQGREYcItYLV7hsXQvpJ3tUjlaktS0sXnsrwRPvFRYie6eU+q9aUfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rLyrgm4FG9TyxGalFdWiQOeHhN6YlBt6quMTIRfAl9w=; b=XZsYLpilFCq7HSgg8hKXpNSM2/asmXBq8RE7qk7Z/VnHSWUvrVevd4toubefYT50GaNrWHEN6IKIiK1Ilc9Oyk1yx9PfciZnozNlgyhAA4/ENaIn/UUnZ2TXdNZjHiqpyjNXNSpRKhYeMJQZznJbNwQt/yWTt6oWsR3dw+cmA3p1E8dmK55SOlJViNbdQ3ZQVg9fifZIs6mV6skdKZSzCAF73I5zip/L+NJZSpOpZVQLqJvwRiKC5Taw0k7hdw+/Pq11GZ5NnlkwqEAl8LZSvcqH8mhkO31kR1DzWLvazFq+bdAgJnbcOmh3pokOoJILcDoaB4KVoj94NbYvDzklCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rLyrgm4FG9TyxGalFdWiQOeHhN6YlBt6quMTIRfAl9w=; b=QjuAw4IZ2zwOXsGtWYLMoYfRIOR6fOR2pTI8PqcYaAGdsXfSP+N1URqcHMGXomwsBEtmgobAuelR1GO5ZjeVckiv0JgkU6AzfOx1d2u9/MiX1khZaMxDcKuR9qBlZYVWFTe8Jkbw+o8ilKHrEzPJlK7g31/NUIbDNL8uuV71Dkc= Received: from DM4PR11MB5453.namprd11.prod.outlook.com (2603:10b6:5:398::15) by DM5PR11MB1404.namprd11.prod.outlook.com (2603:10b6:3:c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.15; Thu, 12 Aug 2021 07:11:29 +0000 Received: from DM4PR11MB5453.namprd11.prod.outlook.com ([fe80::bd58:ab3d:9e8b:55c4]) by DM4PR11MB5453.namprd11.prod.outlook.com ([fe80::bd58:ab3d:9e8b:55c4%3]) with mapi id 15.20.4415.016; Thu, 12 Aug 2021 07:11:29 +0000 From: "Dandan Bi" To: "Yeh, GregX" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" , Liming Gao Subject: Re: [PATCH] MdeModulePkg PCD: FSP NotifyPhase APIs caused 100ms delay Thread-Topic: [PATCH] MdeModulePkg PCD: FSP NotifyPhase APIs caused 100ms delay Thread-Index: AQHXjMYph+Fj+bOtKE6c5AitKZra2KtvPMxQgAA6ywCAAAB6kA== Date: Thu, 12 Aug 2021 07:11:29 +0000 Message-ID: References: <20210809022732.1753-1-gregx.yeh@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 72793a8e-066b-46e4-ce82-08d95d606832 x-ms-traffictypediagnostic: DM5PR11MB1404: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xc1lVAwe9VVpkUxf+wVsF1QCn0Km+diwKvp54qPW6FgPUXbVvK4zHEyFpq3LRaPH3cpV1jLWctOC0kgcXQK6K5W7/iiE/3Xlj1QW6pqwkUsOku209R4KhfXOKySIS224nlL6w64A2xrX15MPU1bKZakgniVcalzsNdWci3Bh/EbBwZ6C+9t96HWufrtoDQccvUUpuWv74nBYxCLCW3Fn9qsK8shC1nAwX0U/zZtWBahYLPFc/aZ0O3bzp+W4M0SNIUk8yS14RwdCSC6JTzXmhsiO1ftXZSBBewPeqHGaNMVIqVgu8Xnm5UyWT5EOt3g7ZZ1rwlkwlihaneciKcAmkmCSeqNFAWKoaRF5OVVBBROn25QM2IObLq5EY2bXqhnAwoj+2acJKmLw8qpRcd4jmk0OaRV2hw0ocE5yxvupX9D6npZmpklel1dNwubkHmzCM2ZpBiEKHYbcs4MjfO6zR/1sjIj6zvX5RdDIwp7M6WpSjCE0bhsBCSniDWUQW6wIu1TO1EWedtAFhejPnCKlAGCG5GHhH5O0dlyHhrKPb1Z88Rq5jZmprd9l7h2+/HuzqP790sKhg3s9si5LJBeoypoXeAYCeWskdkV31laUV/92d+xgaHsaNzLoe2i4OamzswGr1PiufjvpYebqxbv4vSBjddKBzqxy5JsbxDHReFAhaHYn6yfvCgbRIhpsNbhqzAtLDKdhP1rT6MoDCw3uIKHHmDUlv25beDt2qst5x7GLCQaf7AztoZHK4n7ur95mTzMBhOjncuy8NDKTeMXCoLkivLWudPRmzlD1MHHl438= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5453.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(346002)(366004)(136003)(39860400002)(86362001)(316002)(2906002)(5660300002)(7696005)(4326008)(52536014)(55016002)(38070700005)(53546011)(83380400001)(9686003)(6506007)(76116006)(71200400001)(38100700002)(966005)(66946007)(66446008)(26005)(122000001)(33656002)(478600001)(64756008)(66476007)(66556008)(54906003)(8936002)(186003)(110136005)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yiUq2AMQPRY4Ji2REuMgDcnstWckXPpSrOp/sraoAbqLiYCEemzpdeeykK+3?= =?us-ascii?Q?slx6O1oYtOsVRinefdtvPwZP0zj7KPknGmR5hBbobhWiJqLv1ZTxuBAaWBxp?= =?us-ascii?Q?p/xYtlmjdrN6ZfSyNj0u4rRvV7hJgugVtdvPChpRIHMxoN8U3VfQCzfM+7HY?= =?us-ascii?Q?/oZ+ebqY5Z//0ClxiF4KMi7n+zgk7YdAdSCI+BAYt7TjbiaC1i3ea2fmjlaa?= =?us-ascii?Q?Qo/R9pMCw4lLI9jP7a9699p7vONaoNVuGbKAkTBgrT35B/PLlxTen8Ha0Npg?= =?us-ascii?Q?I1tgnYUm4nfLvEHmMmHihnafAMQhmWXzutkVuptn2Uqr2GxHxRM8SRGl2z69?= =?us-ascii?Q?XAXZYeE/BFo6ib+RkOBfmbuFNaCfr4z3NA9eCmfy9kuE52hxtVyQe5W4yGQa?= =?us-ascii?Q?AWb3/v01gX7kwhh9H5sQJODMFQv3O/YR7YTVbhRBERmhFw38anDD/EM0fzLB?= =?us-ascii?Q?+UKuFs20yTriNp9CVmdOfMJBLoen0dFkHzLZySrubfmVyMbCbRVRKy0xZWqA?= =?us-ascii?Q?LvW722btFxZ4yY8WHKFQXuD4J7HILXUl14Qip4Ck+RX1PLsLaLRwNc36vrYj?= =?us-ascii?Q?7+g0mWfckzd23k2KYVyReBA7S9IdFDlUH0ygr1bwVE4dnc8z7YwpBylwVBoa?= =?us-ascii?Q?bwl3ObspYlqHOL9B2/9hdcBEE5DwA866Jfgk20tsPmkU4eLk5/CjH++0nVSy?= =?us-ascii?Q?4nP32swMd+PSygPZKUOrtH4qhmvzRJKfuIqE574Yq+RxylViulnz8Yv5PD25?= =?us-ascii?Q?7A+NwkCxxLZB02snNvEebVlPgvayboP/CfW2BZt0wjsDPjf9eAncR0mFw/61?= =?us-ascii?Q?Gqdu5pmtCQy4dDfHUU/+FYexAWQRLMzrjmbCIjHhWMCGxYnFXyYCmyc72ScC?= =?us-ascii?Q?oQj3hcJ/UAfLO2bb6XhDVj+5uWTHPOBYMUtf+FBr1/lc2WhQ4IZIatCUvN2x?= =?us-ascii?Q?+tMYYIICfc71vSHuwNjlMhUQJ2gs6d/KTVryjQayKxupwsZEUqHWW3uc6bH0?= =?us-ascii?Q?pE+Vt9apfP0NnmtPakk37nME3xZxG8Q14+pTcQNtKRiQXrV1J/DTKFstMZin?= =?us-ascii?Q?ezTUOckXgS48244YNQTNaUfQzwSz61pLbMG9yNBOlYuy3ScRy/I4nD8t0Mmf?= =?us-ascii?Q?+Rciz6R7LodvzeHX0eoBcVk8sq8iS2YjQ4lZezwrZcUs2H//QrLDVIbjDHYk?= =?us-ascii?Q?V/Mg4Sehu7PrdGP3Wmqv50C4G8O97H3QNM4TwKF4NrnusNyokF/XeR2iYOvx?= =?us-ascii?Q?YTkBUzF9B7Uvtbc3mA9rJh9AnvQdx78IUxT7X2bdmorJhME4kqN96ziGlLPE?= =?us-ascii?Q?gc6mdadU4OL+IUanyuN/9V8o?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5453.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72793a8e-066b-46e4-ce82-08d95d606832 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2021 07:11:29.4994 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1vxqNPe/yl+U0GmLephzHGjo8JV+8ayOGEk7hSfl1VwwPC+jdPtMfKWobfU7GIq9/CHZeoXVzEDfv0J66jxWJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1404 Return-Path: dandan.bi@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable You may send a new one with R-B, then can submit the new updated one. Thanks, Dandan > -----Original Message----- > From: Yeh, GregX > Sent: Thursday, August 12, 2021 3:06 PM > To: Bi, Dandan ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Liming Gao > Subject: RE: [PATCH] MdeModulePkg PCD: FSP NotifyPhase APIs caused > 100ms delay >=20 > Hi Dandan, >=20 > So I need create new patch file with new subject then send-email again? >=20 > Thanks, > Greg >=20 > -----Original Message----- > From: Bi, Dandan > Sent: Thursday, August 12, 2021 11:47 AM > To: Yeh, GregX ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Liming Gao > Subject: RE: [PATCH] MdeModulePkg PCD: FSP NotifyPhase APIs caused > 100ms delay >=20 > Hi Greg, >=20 > One minor comment, could we update the subject to reflect what have done > in this patch for PCD module before submitting the patch? > With that addressed Reviewed-by: Dandan Bi >=20 >=20 >=20 > Thanks, > Dandan >=20 > > -----Original Message----- > > From: Yeh, GregX > > Sent: Monday, August 9, 2021 10:28 AM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J ; Wu, Hao A > > ; Bi, Dandan ; Liming Gao > > > > Subject: [PATCH] MdeModulePkg PCD: FSP NotifyPhase APIs caused 100ms > > delay > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3525 > > > > After PciSegmentLib using Dynamic PCD for Pcie base address such long > > delay found in FSP. The root cause is some of the PCD service PPIs not > > shadowed to memory and flash cache may have been disabled in > NotifyPhase stage. > > Solution is to shadow all PCD service PPIs to memory. > > > > Signed-off-by: GregX Yeh > > Cc: Jian J Wang > > Cc: Hao A Wu > > Cc: Dandan Bi > > Cc: Liming Gao > > --- > > MdeModulePkg/Universal/PCD/Pei/Pcd.c | 71 > > +++++++++++++++++++++++++++- > > 1 file changed, 70 insertions(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/Universal/PCD/Pei/Pcd.c > > b/MdeModulePkg/Universal/PCD/Pei/Pcd.c > > index 9c6346924f..f31e0be35f 100644 > > --- a/MdeModulePkg/Universal/PCD/Pei/Pcd.c > > +++ b/MdeModulePkg/Universal/PCD/Pei/Pcd.c > > @@ -1,7 +1,7 @@ > > /** @file All Pcd Ppi services are implemented here. -Copyright (c) = 2006 - > > 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - > > 2021, Intel Corporation. All rights reserved.
(C) Copyright 2016 > > Hewlett Packard Enterprise Development LP
SPDX-License-Identifier: > > BSD-2- Clause-Patent @@ -339,6 +339,75 @@ PcdPeimInit ( > > { EFI_STATUS Status; + Status =3D PeiServicesRegisterForShadow > > (FileHandle);+ if (Status =3D=3D EFI_ALREADY_STARTED) {+ //+ // = This is now > > starting in memory, the second time starting.+ //+ > > EFI_PEI_PPI_DESCRIPTOR *OldPpiList;+ EFI_PEI_PPI_DESCRIPTOR > > *OldPpiList2;+ VOID *Ppi;+ VOID *Ppi2;++ OldPpiList =3D NULL;+= Status > =3D > > PeiServicesLocatePpi (+ &gPcdPpiGuid,+ 0,+ > > &OldPpiList,+ &Ppi+ );+ ASSERT_EFI_ERROR= (Status);++ if > > (OldPpiList !=3D NULL) {+ Status =3D PeiServicesReInstallPpi (OldP= piList, > > &mPpiList[0]);+ ASSERT_EFI_ERROR (Status);+ }++ OldPpiList2 = =3D > NULL;+ > > Status =3D PeiServicesLocatePpi (+ &gGetPcdInfoPpiGuid,+ = 0,+ > > &OldPpiList2,+ &Ppi2+ );+ ASSERT_EFI_ERR= OR (Status);++ > if > > (OldPpiList2 !=3D NULL) {+ Status =3D PeiServicesReInstallPpi (Old= PpiList2, > > &mPpiList2[0]);+ ASSERT_EFI_ERROR (Status);+ }++ OldPpiList = =3D > NULL;+ > > Status =3D PeiServicesLocatePpi (+ &gEfiPeiPcdPpiGuid,+ = 0,+ > > &OldPpiList,+ &Ppi+ );+ ASSERT_EFI_ERROR= (Status);++ if > > (OldPpiList !=3D NULL) {+ Status =3D PeiServicesReInstallPpi (OldP= piList, > > &mPpiList[1]);+ ASSERT_EFI_ERROR (Status);+ }++ OldPpiList2 = =3D > NULL;+ > > Status =3D PeiServicesLocatePpi (+ &gEfiGetPcdInfoPpiGuid= ,+ > 0,+ > > &OldPpiList2,+ &Ppi2+ );+ ASSERT_EFI_ERR= OR (Status);++ > if > > (OldPpiList2 !=3D NULL) {+ Status =3D PeiServicesReInstallPpi (Old= PpiList2, > > &mPpiList2[1]);+ ASSERT_EFI_ERROR (Status);+ }++ return Stat= us;+ }+ > > BuildPcdDatabase (FileHandle); //-- > > 2.32.0.windows.1