* [PATCH EDK2 v1 0/1] MdeModulePkg/HiiDatabaseDxe:remove dead code
@ 2021-08-26 1:16 wenyi,xie
2021-08-26 1:16 ` [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead code block wenyi,xie
0 siblings, 1 reply; 4+ messages in thread
From: wenyi,xie @ 2021-08-26 1:16 UTC (permalink / raw)
To: devel, jian.j.wang, hao.a.wu, dandan.bi, eric.dong
Cc: songdongkuang, xiewenyi2
Main Changes :
1.remove dead code block.
Wenyi Xie (1):
MdeModulePkg/HiiDatabaseDxe:remove dead code block
MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ---
1 file changed, 3 deletions(-)
--
2.20.1.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead code block
2021-08-26 1:16 [PATCH EDK2 v1 0/1] MdeModulePkg/HiiDatabaseDxe:remove dead code wenyi,xie
@ 2021-08-26 1:16 ` wenyi,xie
2021-08-27 3:58 ` Dandan Bi
0 siblings, 1 reply; 4+ messages in thread
From: wenyi,xie @ 2021-08-26 1:16 UTC (permalink / raw)
To: devel, jian.j.wang, hao.a.wu, dandan.bi, eric.dong
Cc: songdongkuang, xiewenyi2
As the if statement outside has confirmed that
BlockData->Name == NULL, so the if statement inside
is always false.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
---
MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
index d492b769d51c..17a914208c6d 100644
--- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
+++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
@@ -2871,9 +2871,6 @@ ParseIfrData (
//
if ((BlockData->Name == NULL) && ((BlockData->Offset + BlockData->Width) > VarStorageData->Size)) {
Status = EFI_INVALID_PARAMETER;
- if (BlockData->Name != NULL) {
- FreePool (BlockData->Name);
- }
FreePool (BlockData);
goto Done;
}
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead code block
2021-08-26 1:16 ` [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead code block wenyi,xie
@ 2021-08-27 3:58 ` Dandan Bi
2021-09-02 10:28 ` Dandan Bi
0 siblings, 1 reply; 4+ messages in thread
From: Dandan Bi @ 2021-08-27 3:58 UTC (permalink / raw)
To: Wenyi Xie, devel@edk2.groups.io, Wang, Jian J, Wu, Hao A,
Dong, Eric
Cc: songdongkuang@huawei.com
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
Thanks,
Dandan
> -----Original Message-----
> From: Wenyi Xie <xiewenyi2@huawei.com>
> Sent: Thursday, August 26, 2021 9:16 AM
> To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
> <hao.a.wu@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Dong, Eric
> <eric.dong@intel.com>
> Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
> Subject: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead
> code block
>
> As the if statement outside has confirmed that
> BlockData->Name == NULL, so the if statement inside
> is always false.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> ---
> MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> index d492b769d51c..17a914208c6d 100644
> --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> @@ -2871,9 +2871,6 @@ ParseIfrData (
> //
> if ((BlockData->Name == NULL) && ((BlockData->Offset + BlockData-
> >Width) > VarStorageData->Size)) {
> Status = EFI_INVALID_PARAMETER;
> - if (BlockData->Name != NULL) {
> - FreePool (BlockData->Name);
> - }
> FreePool (BlockData);
> goto Done;
> }
> --
> 2.20.1.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead code block
2021-08-27 3:58 ` Dandan Bi
@ 2021-09-02 10:28 ` Dandan Bi
0 siblings, 0 replies; 4+ messages in thread
From: Dandan Bi @ 2021-09-02 10:28 UTC (permalink / raw)
To: Wenyi Xie, devel@edk2.groups.io, Wang, Jian J, Wu, Hao A,
Dong, Eric
Cc: songdongkuang@huawei.com
PR is created for this change:
https://github.com/tianocore/edk2/pull/1945
Thanks,
Dandan
> -----Original Message-----
> From: Bi, Dandan
> Sent: Friday, August 27, 2021 11:58 AM
> To: Wenyi Xie <xiewenyi2@huawei.com>; devel@edk2.groups.io; Wang, Jian
> J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Dong, Eric
> <eric.dong@intel.com>
> Cc: songdongkuang@huawei.com
> Subject: RE: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove
> dead code block
>
> Reviewed-by: Dandan Bi <dandan.bi@intel.com>
>
>
> Thanks,
> Dandan
>
> > -----Original Message-----
> > From: Wenyi Xie <xiewenyi2@huawei.com>
> > Sent: Thursday, August 26, 2021 9:16 AM
> > To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>; Wu,
> > Hao A <hao.a.wu@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Dong,
> > Eric <eric.dong@intel.com>
> > Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
> > Subject: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove
> dead
> > code block
> >
> > As the if statement outside has confirmed that
> > BlockData->Name == NULL, so the if statement inside
> > is always false.
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Dandan Bi <dandan.bi@intel.com>
> > Cc: Eric Dong <eric.dong@intel.com>
> > Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> > ---
> > MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> > b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> > index d492b769d51c..17a914208c6d 100644
> > --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> > +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> > @@ -2871,9 +2871,6 @@ ParseIfrData (
> > //
> > if ((BlockData->Name == NULL) && ((BlockData->Offset +
> > BlockData-
> > >Width) > VarStorageData->Size)) {
> > Status = EFI_INVALID_PARAMETER;
> > - if (BlockData->Name != NULL) {
> > - FreePool (BlockData->Name);
> > - }
> > FreePool (BlockData);
> > goto Done;
> > }
> > --
> > 2.20.1.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-02 10:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-26 1:16 [PATCH EDK2 v1 0/1] MdeModulePkg/HiiDatabaseDxe:remove dead code wenyi,xie
2021-08-26 1:16 ` [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead code block wenyi,xie
2021-08-27 3:58 ` Dandan Bi
2021-09-02 10:28 ` Dandan Bi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox