From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web08.3639.1630036708425603443 for ; Thu, 26 Aug 2021 20:58:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=yYRIc63I; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: dandan.bi@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10088"; a="205095607" X-IronPort-AV: E=Sophos;i="5.84,355,1620716400"; d="scan'208";a="205095607" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2021 20:58:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,355,1620716400"; d="scan'208";a="685294369" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga006.fm.intel.com with ESMTP; 26 Aug 2021 20:58:27 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 26 Aug 2021 20:58:27 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 26 Aug 2021 20:58:26 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 26 Aug 2021 20:58:26 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 26 Aug 2021 20:58:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mto/TLp12wK85dWIF0kocPX0WQ2m51tr8cl1kVFZfUh0eWGCLONpHrXTDqrcBB0FzY/DJ7JK6Yk8H4h4bt01zVHd0oSBPiX38QA3pGJ5TZjl2tasSJQ1hRFL513d9/lgcZw7J4RBU7GM7HVg7JJYcGb9Has7OMSLHdLXRzFft84IbSObz3Ql3KYjzj3Qy44lZ4IrM+0UFbIuF9lZl+L+EG1xh5kt4+2ksat12etWRx71Plwx7ikrrUuJmQt56RzFEUlOix+4EV8GKc8yiWz1AydSY4lgg2X6eY95kk87pG5CK7EgfNoI2i6phA4iKY5Uu7u83/26OZ5AAqMUgreKxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GzMiQpu43Bx1ybf3zupsWn6WVHdzeKLrTcIp2VyM8z4=; b=FexeyQ46tWwuoxdgaBwZWo3GmO+iXdMeBqxMBceAieNOmwwgfzkPSAPYK+pF8Wi9l086n4UhfxR5GH6l7Pl3/Nr9ktHZ0F1NJjoryF+w7dOyhXVQabXDZXQ9PXUofVNUTFel/8IL7bTVqDaqmepDQf29Eqvl2+EVc1trmbg2v7f//hC8UTveEjHL7wW37EQadYX6IJIXUd76NrSAqDo7k8zoedCb/8/CsY3axzADvNHJz/x6ZHeKUr3uvIeamht7yl/WBA707xb5NgPLmDyP5J+AGEUg+5dDabQ1KCBzNnMEfXqr+B5Cp8FBChYaGNUe40/L9gex5zj9rz2gQTZEIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GzMiQpu43Bx1ybf3zupsWn6WVHdzeKLrTcIp2VyM8z4=; b=yYRIc63IOpxnD6mVYHVNYX/QwGrt9fBGR7NCZpM2jAvWidTClUvfe0ZNAL6govAmvYaXay1hGLQXEWnWnLrJ6RwTBKmNKHPFOmssyKbL5kb4WOJc72pOj3UdeUVkGAWJgR9zHsbMEfWvZdplItzR2W+VLLqQMDuVF6xA7fQKIOo= Received: from DM4PR11MB5453.namprd11.prod.outlook.com (2603:10b6:5:398::15) by DM4PR11MB5261.namprd11.prod.outlook.com (2603:10b6:5:388::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19; Fri, 27 Aug 2021 03:58:26 +0000 Received: from DM4PR11MB5453.namprd11.prod.outlook.com ([fe80::bd58:ab3d:9e8b:55c4]) by DM4PR11MB5453.namprd11.prod.outlook.com ([fe80::bd58:ab3d:9e8b:55c4%4]) with mapi id 15.20.4436.025; Fri, 27 Aug 2021 03:58:25 +0000 From: "Dandan Bi" To: Wenyi Xie , "devel@edk2.groups.io" , "Wang, Jian J" , "Wu, Hao A" , "Dong, Eric" CC: "songdongkuang@huawei.com" Subject: Re: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead code block Thread-Topic: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead code block Thread-Index: AQHXmhivRW8cNH7DzEeIOaNc1i5Rx6uGuzjw Date: Fri, 27 Aug 2021 03:58:25 +0000 Message-ID: References: <1629940563-82195-1-git-send-email-xiewenyi2@huawei.com> <1629940563-82195-2-git-send-email-xiewenyi2@huawei.com> In-Reply-To: <1629940563-82195-2-git-send-email-xiewenyi2@huawei.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a7e6fe53-08a3-4d95-509a-08d9690eec00 x-ms-traffictypediagnostic: DM4PR11MB5261: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:431; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hqjM6xccYIIXi0Sf9/LyI2LaGZmIQ7zS7brZoYoMNef/I6UcKgf6h06nMz4/rAX6w5BAig2rg2IQfoxVKjfSw1YNDAZbArlPpQudpkHQI+izMGnhTx1M4Y2LMQ9my5wrKJNuxATJRs6SEXT3XkRB+gRHMB5gXYRDC2d8kDe0f3b89vqQkioODRaWCfxBSxJWQ++DNymqgZ2kiKFbd/kQ8OMc3gJizLIjz4quYXrh2cEYvfQsBl8PR2k21WEYXxCLpdhwRp4f8H5VpbY2e0nIfD0s1jhdIvoE/hNL/rAcXoYZ9FugFcDhpFrd5UC3KxR/O2Aab64jzOJEsegrCfk+MSzlvx2S1fJYPXg8kXOz4qSxr1sfJfiICc0cfw0AMC3/8XoaZPd9dU269ypxlXhsuKsjgMlmgsjnhDCvTvhAOu39/O40CzWiVotyF3+29x54EoJMDo7qjImdFfE3ZQ0QjmHg3BWDQTXskgpKPThIfkz2zGEzRzpuB+Y5HvRT5ESmMRVLvPfnZ06Zi3j59Q8mAzmCm+vcbDjLkhU8++JBG0WXfBLoTYlp1mGHCCBynTizWrDcwqKOhn2VCJYXbbuBu3BRIZOB7idsRPa6TmfZlLwsdPys7LvjtVhqh26GSZqwS1mnHDFkXMC0Z9i6ucgKAp6h8DFq/Vo9Ds19kPz51627UPKcozFDfQ41cZjgWK/sCE4EmnGnIwdTK7yS6ZHPFQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB5453.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(86362001)(64756008)(66476007)(7696005)(66946007)(53546011)(508600001)(66556008)(26005)(186003)(6506007)(5660300002)(2906002)(66446008)(76116006)(83380400001)(52536014)(9686003)(38100700002)(55016002)(122000001)(8676002)(316002)(8936002)(6636002)(38070700005)(110136005)(4326008)(33656002)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xF1DRpsJDJiD6MrexpL1SLbKCVFdQ+XbnCUJ8OClrgSXipGDSUX+vfzWXY/P?= =?us-ascii?Q?RbOJ9TVyj3yMUND9m+laczbaGT2Sgqpof2oAaeD5H1g+/eUNDPwbKCGvzxwb?= =?us-ascii?Q?nvdUEtKFjMPUgibaFjgoWjhmWaOGS5kyPBvcie7t4gGc8fiGKPf2mBCywgwT?= =?us-ascii?Q?KK4UASdFyBDtR+usO+myDCT6nO/43rg39uIJNxUu/gVEMOOlkLVN9Ps2a2Ia?= =?us-ascii?Q?BZQ4tpQnUmFVfEdvdTWnLxCRLSNhMwxqUwR5PMquWej5VXrx0EyrPwYJkMCD?= =?us-ascii?Q?TSL3NPI0yZFSzq1s0+5ikQBxhBwA3HOr8j6m3twebyCYhfOThCd369JSYNWE?= =?us-ascii?Q?Zw4aiT3B3suNDHJk8yZGPV8GxVnpRv7ylUyexKt1BMjO9hCY0cnkIdjcmcgR?= =?us-ascii?Q?HFGpfHfCbsqrdI6fT6zxi5P3JRYtgM439nxbt/bAzB/EbCLzDpQjnHBfHKAX?= =?us-ascii?Q?Z+mY4J5Vvw70YJQd2igdZG6gJcG/Kgj2z8AnrM5P//p6xC9jSaC2lhy5n9C+?= =?us-ascii?Q?m8X+a1Jk01P1qco7a4Wuw7u2gbXgsbJVXmEi5cdkxDu2HW9pkQlwjsExw1vV?= =?us-ascii?Q?gdbI/HZszDtxi0fZeUCey5t9qM2KOt7asO3ZhnSTyFvE/gfsmAPtM7EimdXu?= =?us-ascii?Q?8rVi49hC5wDsCPBNh+Wi0kO2JWLxJ3qUVzz8HcLIX6GeJeWTK4Voj4mUYqYH?= =?us-ascii?Q?jdcWx2a1M52trxsvOW75ju8mxa+umBBZTORB0rETTuiID+1ya4YZTVvmFSuc?= =?us-ascii?Q?9ZEXrvn+/Oqa2MMkoXWsTuCJGQj0BuVs1sZvu3J0bvSKBuiqkfKDWKVCL4nL?= =?us-ascii?Q?xMZkTilqdv0pEo16+86SeZ88mE1hz4FlsSjICIHuSZzTVs8jK11UQ/6DYOzt?= =?us-ascii?Q?hA+U6UpSn+lqvXru6THIdcp9ED3UVtd5av/dmQFFeuHwXIc3oGiv25pJoXot?= =?us-ascii?Q?CEpL/rVgynPyyW+8SRTzpV7xXsQh5vlUCEnuuE4j9kUuc+qPTPJixprZQ+ph?= =?us-ascii?Q?ElCasXk+Zl1i9Oje1PJLleGx6E21TIcr4Z6syGl6UziKzOfG9BY/FLNBfVc9?= =?us-ascii?Q?qI+hZHzsLrSrNA3V0OLZUhsRLW9HGp68RkRhLwJ/KXBgrI+9isVHM+L9yLJH?= =?us-ascii?Q?b9D1AHWuGDilAyix2THaWk/bb21Et3GGSj0ROH84gQ96d+cnVo3HgyYcwcvE?= =?us-ascii?Q?qezYsR94iDI4EcFtITMBcWjYMUqnSJd30YLVG1ChN+s9lkcE/tC4kuw7upA5?= =?us-ascii?Q?EOra9mLDwNdUr8bNziDLBNPjYBx4zw1Po7pCQ8ml7OR0EN4tsU9lZK0U7blk?= =?us-ascii?Q?I45tadYjUqnkt2Qfrj7H2i/z?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5453.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7e6fe53-08a3-4d95-509a-08d9690eec00 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Aug 2021 03:58:25.8363 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 28mEaD9HJ43U1yX54uose7dcetIPLpHnCg/4MLNixdiUOSALqx1e1ZE3cvrMMuifNSMDsLNpaVMrcp6qkAWxIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5261 Return-Path: dandan.bi@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Dandan Bi Thanks, Dandan > -----Original Message----- > From: Wenyi Xie > Sent: Thursday, August 26, 2021 9:16 AM > To: devel@edk2.groups.io; Wang, Jian J ; Wu, Hao A > ; Bi, Dandan ; Dong, Eric > > Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com > Subject: [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseDxe:remove dead > code block >=20 > As the if statement outside has confirmed that > BlockData->Name =3D=3D NULL, so the if statement inside > is always false. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Dandan Bi > Cc: Eric Dong > Signed-off-by: Wenyi Xie > --- > MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > index d492b769d51c..17a914208c6d 100644 > --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c > @@ -2871,9 +2871,6 @@ ParseIfrData ( > // > if ((BlockData->Name =3D=3D NULL) && ((BlockData->Offset + Block= Data- > >Width) > VarStorageData->Size)) { > Status =3D EFI_INVALID_PARAMETER; > - if (BlockData->Name !=3D NULL) { > - FreePool (BlockData->Name); > - } > FreePool (BlockData); > goto Done; > } > -- > 2.20.1.windows.1