* [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute @ 2024-05-09 4:04 Du Lin 2024-05-10 2:52 ` Ni, Ray 0 siblings, 1 reply; 5+ messages in thread From: Du Lin @ 2024-05-09 4:04 UTC (permalink / raw) To: devel; +Cc: Du Lin, Liming Gao, Ray Ni Add a new entry into GCD attribute conversion table to convert EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE to EFI_MEMORY_SP. Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Ray Ni <ray.ni@intel.com> Signed-off-by: Du Lin <du.lin@intel.com> --- MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c index fe1bbd6974..99364508cd 100644 --- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c +++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c @@ -92,6 +92,7 @@ GCD_ATTRIBUTE_CONVERSION_ENTRY mAttributeConversionTable[] = { { EFI_RESOURCE_ATTRIBUTE_TESTED, EFI_MEMORY_TESTED, FALSE }, { EFI_RESOURCE_ATTRIBUTE_PERSISTABLE, EFI_MEMORY_NV, TRUE }, { EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE, EFI_MEMORY_MORE_RELIABLE, TRUE }, + { EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE, EFI_MEMORY_SP, TRUE }, { 0, 0, FALSE } }; -- 2.44.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118712): https://edk2.groups.io/g/devel/message/118712 Mute This Topic: https://groups.io/mt/105995670/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute 2024-05-09 4:04 [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute Du Lin @ 2024-05-10 2:52 ` Ni, Ray 2024-05-29 13:05 ` Du Lin 0 siblings, 1 reply; 5+ messages in thread From: Ni, Ray @ 2024-05-10 2:52 UTC (permalink / raw) To: Lin, Du, devel@edk2.groups.io; +Cc: Liming Gao [-- Attachment #1: Type: text/plain, Size: 1836 bytes --] Reviewed-by: Ray Ni <ray.ni@intel.com> Thanks, Ray ________________________________ From: Lin, Du <du.lin@intel.com> Sent: Thursday, May 9, 2024 12:04 To: devel@edk2.groups.io <devel@edk2.groups.io> Cc: Lin, Du <du.lin@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com> Subject: [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute Add a new entry into GCD attribute conversion table to convert EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE to EFI_MEMORY_SP. Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Ray Ni <ray.ni@intel.com> Signed-off-by: Du Lin <du.lin@intel.com> --- MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c index fe1bbd6974..99364508cd 100644 --- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c +++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c @@ -92,6 +92,7 @@ GCD_ATTRIBUTE_CONVERSION_ENTRY mAttributeConversionTable[] = { { EFI_RESOURCE_ATTRIBUTE_TESTED, EFI_MEMORY_TESTED, FALSE }, { EFI_RESOURCE_ATTRIBUTE_PERSISTABLE, EFI_MEMORY_NV, TRUE }, { EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE, EFI_MEMORY_MORE_RELIABLE, TRUE }, + { EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE, EFI_MEMORY_SP, TRUE }, { 0, 0, FALSE } }; -- 2.44.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118784): https://edk2.groups.io/g/devel/message/118784 Mute This Topic: https://groups.io/mt/105995670/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #2: Type: text/html, Size: 4493 bytes --] ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute 2024-05-10 2:52 ` Ni, Ray @ 2024-05-29 13:05 ` Du Lin 2024-05-30 5:01 ` 回复: " gaoliming via groups.io 0 siblings, 1 reply; 5+ messages in thread From: Du Lin @ 2024-05-29 13:05 UTC (permalink / raw) To: devel@edk2.groups.io; +Cc: Liming Gao, Ni, Ray, Lin, Du [-- Attachment #1: Type: text/plain, Size: 2483 bytes --] A pull request has been created for this patch: https://github.com/tianocore/edk2/pull/5691. BRs, Lin, Du From: Ni, Ray <ray.ni@intel.com> Sent: Friday, May 10, 2024 10:53 AM To: Lin, Du <du.lin@intel.com>; devel@edk2.groups.io Cc: Liming Gao <gaoliming@byosoft.com.cn> Subject: Re: [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute Reviewed-by: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>> Thanks, Ray ________________________________ From: Lin, Du <du.lin@intel.com<mailto:du.lin@intel.com>> Sent: Thursday, May 9, 2024 12:04 To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> Cc: Lin, Du <du.lin@intel.com<mailto:du.lin@intel.com>>; Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> Subject: [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute Add a new entry into GCD attribute conversion table to convert EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE to EFI_MEMORY_SP. Cc: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>> Cc: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>> Signed-off-by: Du Lin <du.lin@intel.com<mailto:du.lin@intel.com>> --- MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c index fe1bbd6974..99364508cd 100644 --- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c +++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c @@ -92,6 +92,7 @@ GCD_ATTRIBUTE_CONVERSION_ENTRY mAttributeConversionTable[] = { { EFI_RESOURCE_ATTRIBUTE_TESTED, EFI_MEMORY_TESTED, FALSE }, { EFI_RESOURCE_ATTRIBUTE_PERSISTABLE, EFI_MEMORY_NV, TRUE }, { EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE, EFI_MEMORY_MORE_RELIABLE, TRUE }, + { EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE, EFI_MEMORY_SP, TRUE }, { 0, 0, FALSE } }; -- 2.44.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119342): https://edk2.groups.io/g/devel/message/119342 Mute This Topic: https://groups.io/mt/105995670/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #2: Type: text/html, Size: 7963 bytes --] ^ permalink raw reply related [flat|nested] 5+ messages in thread
* 回复: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute 2024-05-29 13:05 ` Du Lin @ 2024-05-30 5:01 ` gaoliming via groups.io 2024-05-31 3:50 ` Du Lin 0 siblings, 1 reply; 5+ messages in thread From: gaoliming via groups.io @ 2024-05-30 5:01 UTC (permalink / raw) To: devel, du.lin; +Cc: 'Ni, Ray', osde [-- Attachment #1: Type: text/plain, Size: 3049 bytes --] Lin: I see there is some discussion. Have you made the agreement with this change? Thanks Liming 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Du Lin 发送时间: 2024年5月29日 21:05 收件人: devel@edk2.groups.io 抄送: Liming Gao <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com>; Lin, Du <du.lin@intel.com> 主题: Re: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute A pull request has been created for this patch: https://github.com/tianocore/edk2/pull/5691. BRs, Lin, Du From: Ni, Ray <ray.ni@intel.com <mailto:ray.ni@intel.com> > Sent: Friday, May 10, 2024 10:53 AM To: Lin, Du <du.lin@intel.com <mailto:du.lin@intel.com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> Cc: Liming Gao <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> > Subject: Re: [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute Reviewed-by: Ray Ni <ray.ni@intel.com <mailto:ray.ni@intel.com> > Thanks, Ray _____ From: Lin, Du <du.lin@intel.com <mailto:du.lin@intel.com> > Sent: Thursday, May 9, 2024 12:04 To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> > Cc: Lin, Du <du.lin@intel.com <mailto:du.lin@intel.com> >; Liming Gao <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >; Ni, Ray <ray. ni@intel.com <mailto:ray.ni@intel.com> > Subject: [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute Add a new entry into GCD attribute conversion table to convert EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE to EFI_MEMORY_SP. Cc: Liming Gao <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> > Cc: Ray Ni <ray.ni@intel.com <mailto:ray.ni@intel.com> > Signed-off-by: Du Lin <du.lin@intel.com <mailto:du.lin@intel.com> > --- MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c index fe1bbd6974..99364508cd 100644 --- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c +++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c @@ -92,6 +92,7 @@ GCD_ATTRIBUTE_CONVERSION_ENTRY mAttributeConversionTable[] = { { EFI_RESOURCE_ATTRIBUTE_TESTED, EFI_MEMORY_TESTED, FALSE }, { EFI_RESOURCE_ATTRIBUTE_PERSISTABLE, EFI_MEMORY_NV, TRUE }, { EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE, EFI_MEMORY_MORE_RELIABLE, TRUE }, + { EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE, EFI_MEMORY_SP, TRUE }, { 0, 0, FALSE } }; -- 2.44.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119378): https://edk2.groups.io/g/devel/message/119378 Mute This Topic: https://groups.io/mt/106383242/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #2: Type: text/html, Size: 10046 bytes --] ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute 2024-05-30 5:01 ` 回复: " gaoliming via groups.io @ 2024-05-31 3:50 ` Du Lin 0 siblings, 0 replies; 5+ messages in thread From: Du Lin @ 2024-05-31 3:50 UTC (permalink / raw) To: devel@edk2.groups.io, gaoliming@byosoft.com.cn Cc: Ni, Ray, osde@linux.microsoft.com, Lin, Du [-- Attachment #1.1: Type: text/plain, Size: 3711 bytes --] Liming - It is still under discussion. I’m checking if this patch can be reviewed and merged first. You may find more details in the attached email. BRs, Lin, Du From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming via groups.io Sent: Thursday, May 30, 2024 1:02 PM To: devel@edk2.groups.io; Lin, Du <du.lin@intel.com> Cc: Ni, Ray <ray.ni@intel.com>; osde@linux.microsoft.com Subject: 回复: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute Lin: I see there is some discussion. Have you made the agreement with this change? Thanks Liming 发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 Du Lin 发送时间: 2024年5月29日 21:05 收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> 抄送: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Lin, Du <du.lin@intel.com<mailto:du.lin@intel.com>> 主题: Re: [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute A pull request has been created for this patch: https://github.com/tianocore/edk2/pull/5691. BRs, Lin, Du From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> Sent: Friday, May 10, 2024 10:53 AM To: Lin, Du <du.lin@intel.com<mailto:du.lin@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>> Subject: Re: [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute Reviewed-by: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>> Thanks, Ray ________________________________ From: Lin, Du <du.lin@intel.com<mailto:du.lin@intel.com>> Sent: Thursday, May 9, 2024 12:04 To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> Cc: Lin, Du <du.lin@intel.com<mailto:du.lin@intel.com>>; Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> Subject: [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute Add a new entry into GCD attribute conversion table to convert EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE to EFI_MEMORY_SP. Cc: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>> Cc: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>> Signed-off-by: Du Lin <du.lin@intel.com<mailto:du.lin@intel.com>> --- MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c index fe1bbd6974..99364508cd 100644 --- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c +++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c @@ -92,6 +92,7 @@ GCD_ATTRIBUTE_CONVERSION_ENTRY mAttributeConversionTable[] = { { EFI_RESOURCE_ATTRIBUTE_TESTED, EFI_MEMORY_TESTED, FALSE }, { EFI_RESOURCE_ATTRIBUTE_PERSISTABLE, EFI_MEMORY_NV, TRUE }, { EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE, EFI_MEMORY_MORE_RELIABLE, TRUE }, + { EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE, EFI_MEMORY_SP, TRUE }, { 0, 0, FALSE } }; -- 2.44.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119404): https://edk2.groups.io/g/devel/message/119404 Mute This Topic: https://groups.io/mt/106402173/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- [-- Attachment #1.2: Type: text/html, Size: 11826 bytes --] [-- Attachment #2: Type: message/rfc822, Size: 13598 bytes --] From: "Lin, Du" <du.lin@intel.com> To: Oliver Smith-Denny <osde@linux.microsoft.com>, "devel@edk2.groups.io" <devel@edk2.groups.io>, "mikuback@linux.microsoft.com" <mikuback@linux.microsoft.com> Cc: Liming Gao <gaoliming@byosoft.com.cn>, "Kinney, Michael D" <michael.d.kinney@intel.com>, "Ni, Ray" <ray.ni@intel.com>, "Lin, Du" <du.lin@intel.com> Subject: Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg: Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE attribute Date: Fri, 31 May 2024 03:44:31 +0000 Message-ID: <17D475FA267430AD.21428@groups.io> Is there any feedback from CXL stakeholders? It is OK if more time is needed to check with CXL stakeholders. But looks like we all agree that the GCD attribute conversion table shall be updated to convert EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE to EFI_MEMORY_SP. So could we review and merge the conversion table update first, while we are waiting for the feedback from CXL stakeholders? If you agree, a pull request has been created for the conversion table update: https://github.com/tianocore/edk2/pull/5691. BRs, Lin, Du -----Original Message----- From: Oliver Smith-Denny <osde@linux.microsoft.com> Sent: Friday, May 24, 2024 5:05 AM To: devel@edk2.groups.io; Lin, Du <du.lin@intel.com>; mikuback@linux.microsoft.com Cc: Liming Gao <gaoliming@byosoft.com.cn>; Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com> Subject: Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg: Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE attribute On 5/23/2024 2:17 AM, Du Lin wrote: > Thanks for the quick response. > > Agree that the PI and UEFI specs are vague on SP. That is also why I opted to minimize code changes to DXE core for SP support in patch https://edk2.groups.io/g/devel/message/118712. > > Would it make more sense to let the caller determine if SP memory is available for UEFI via EFI resource types (e.g., EFI_RESOURCE_SYSTEM_MEMORY vs EFI_RESOURCE_MEMORY_RESERVED)? > > CDAT can be read in PEI phase via DOE method and CDAT is important to support CXL 2.0. I believe CDAT spec is referencing EFI_MEMORY_TYPE and Memory Attributes defined in UEFI spec section 7.2. "EfiConventionalMemory Type with EFI_MEMORY_SP Attribute" may suggest that the memory type shall be EfiConventionalMemory and the attribute shall have SP set when reporting the memory to OS. And the concern is whether this combination can still be supported if we always mark resource HOBs with SP set as EfiGcdMemoryTypeReserved. Thanks for the clarification. I agree that it makes sense to let the resource HOB creator determine whether UEFI will put this in system memory or reserved memory. DxeCore at that point could decide to not allocate any memory with the EFI_MEMORY_SP attribute (or it could decide it doesn't care). We are meeting with some CXL stakeholders to make sure there is no concern with changing this patch and then we will respin this. Thanks, Oliver -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119402): https://edk2.groups.io/g/devel/message/119402 Mute This Topic: https://groups.io/mt/106165072/8327890 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [du.lin@intel.com] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-31 3:51 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-05-09 4:04 [edk2-devel] [PATCH] MdeModulePkg: Update GCD attribute conversion to support SP attribute Du Lin 2024-05-10 2:52 ` Ni, Ray 2024-05-29 13:05 ` Du Lin 2024-05-30 5:01 ` 回复: " gaoliming via groups.io 2024-05-31 3:50 ` Du Lin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox