From: "Steven Shi" <steven.shi@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"mhaeuser@posteo.de" <mhaeuser@posteo.de>,
"Yang, JiyangX" <jiyangx.yang@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Sami Mujawar <sami.mujawar@arm.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"Supreeth Venkatesh" <supreeth.venkatesh@arm.com>,
Vitaly Cheptsov <vit9696@protonmail.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: To support CLANGPDB build
Date: Thu, 14 Oct 2021 09:02:46 +0000 [thread overview]
Message-ID: <DM4PR11MB55490EC4B5AB54FC7716D5A98CB89@DM4PR11MB5549.namprd11.prod.outlook.com> (raw)
In-Reply-To: <71754204-38e7-09c5-3d83-ba090d393552@posteo.de>
[-- Attachment #1: Type: text/plain, Size: 4860 bytes --]
Hi Marvin,
How about we limit the -fno-pie option only apply on IA32 and X64 like below?
diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.inf b/StandaloneMmPkg/Core/StandaloneMmCore.inf
[BuildOptions]
GCC:*_*_*_CC_FLAGS = -fpie
GCC:*_*_*_DLINK_FLAGS = -Wl,-z,text,-Bsymbolic,-pie
+ CLANGPDB:*_*_ IA32_CC_FLAGS= -fno-pie
+ CLANGPDB:*_*_ X64_CC_FLAGS= -fno-pie
diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf
[BuildOptions]
GCC:*_*_*_CC_FLAGS = -fpie
+ CLANGPDB:*_*_ IA32_CC_FLAGS= -fno-pie
+ CLANGPDB:*_*_ X64_CC_FLAGS= -fno-pie
Thanks
Steven Shi
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Marvin
> Häuser
> Sent: Thursday, October 14, 2021 4:05 PM
> To: Yang, JiyangX <jiyangx.yang@intel.com>; devel@edk2.groups.io
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar
> <sami.mujawar@arm.com>; Yao, Jiewen <jiewen.yao@intel.com>; Supreeth
> Venkatesh <supreeth.venkatesh@arm.com>; Vitaly Cheptsov
> <vit9696@protonmail.com>; Shi, Steven <steven.shi@intel.com>
> Subject: Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: To support
> CLANGPDB build
>
> Hey Jiyang,
>
> NO! Please do not. :)
> Yes, this fixes build, but the AARCH64 core (I did not check ARM)
> depends on self-relocation as it is loaded in-place at a location
> unknown at compile-time. PIE helps ensure there are no relocations in
> .text among other things. I know CLANGPDB does not support
> ARM/AARCH64
> yet, but if it is added, this may generate binaries with more dangerous
> relocations, which means the chance of executing an instruction that
> requires relocation without relocating first (relocation is done in C
> code now!) is significantly higher. We do not need PIE for IA32 or X64
> at all (or more specifically, we only need it for ARM-based
> architectures as of now), so I prefer my patch which makes that
> explicit. Though we can theoretically use your solution when limited to
> non-ARM architectures if you really dislike my patch that much.
>
> I'd prefer to hear from the ARM core maintainers before making any move.
>
> Best regards,
> Marvin
>
> On 14.10.21 05:12, Jiyang Yang wrote:
> > the flag "-fpie" is passed for all builds with a GCC family toolchain,
> > including CLANGPDB, but CLANGPDB does not support this flag, it will
> > report "clang: error: unsupported option '-fpie' for target
> > 'x86_64-unknown-windows-gnu'". So we add the CLANGPDB option "-fno-
> pie"
> > later to overwrite it.
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>>
> > Cc: Sami Mujawar <sami.mujawar@arm.com<mailto:sami.mujawar@arm.com>>
> > Cc: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
> > Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com<mailto:supreeth.venkatesh@arm.com>>
> > Cc: Vitaly Cheptsov <vit9696@protonmail.com<mailto:vit9696@protonmail.com>>
> > Cc: Marvin Häuser <mhaeuser@posteo.de<mailto:mhaeuser@posteo.de>>
> > Cc: Steven Shi <steven.shi@intel.com<mailto:steven.shi@intel.com>>
> > Signed-off-by: Jiyang Yang <jiyangx.yang@intel.com<mailto:jiyangx.yang@intel.com>>
> > ---
> > StandaloneMmPkg/Core/StandaloneMmCore.inf | 2
> ++
> >
> StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmC
> oreEntryPoint.inf | 1 +
> > 2 files changed, 3 insertions(+)
> >
> > diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.inf
> b/StandaloneMmPkg/Core/StandaloneMmCore.inf
> > index 56042b7b39f4..3213142523f4 100644
> > --- a/StandaloneMmPkg/Core/StandaloneMmCore.inf
> > +++ b/StandaloneMmPkg/Core/StandaloneMmCore.inf
> > @@ -79,3 +79,5 @@
> > [BuildOptions]
> > GCC:*_*_*_CC_FLAGS = -fpie
> > GCC:*_*_*_DLINK_FLAGS = -Wl,-z,text,-Bsymbolic,-pie
> > + CLANGPDB:*_*_*_CC_FLAGS = -fno-pie
> > + CLANGPDB:*_*_*_DLINK_FLAGS =
> > diff --git
> a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMm
> CoreEntryPoint.inf
> b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMm
> CoreEntryPoint.inf
> > index 1762586cfa02..ef69e07d2c07 100644
> > ---
> a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMm
> CoreEntryPoint.inf
> > +++
> b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMm
> CoreEntryPoint.inf
> > @@ -56,3 +56,4 @@
> >
> > [BuildOptions]
> > GCC:*_*_*_CC_FLAGS = -fpie
> > + CLANGPDB:*_*_*_CC_FLAGS = -fno-pie
>
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 11360 bytes --]
next prev parent reply other threads:[~2021-10-14 9:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 3:12 [PATCH v1 0/1] StandaloneMmPkg: To support CLANGPDB build jiyangx.yang
2021-10-14 3:12 ` [PATCH v1 1/1] " Jiyang Yang
2021-10-14 8:05 ` Marvin Häuser
2021-10-14 9:02 ` Steven Shi [this message]
2021-10-14 9:08 ` [edk2-devel] " Marvin Häuser
2021-10-14 9:09 ` Ard Biesheuvel
2021-10-14 9:13 ` Marvin Häuser
2021-10-14 13:14 ` Steven Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB55490EC4B5AB54FC7716D5A98CB89@DM4PR11MB5549.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox