From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.38515.1683934827407799583 for ; Fri, 12 May 2023 16:40:27 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=FQJCxa+v; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: guo.dong@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683934827; x=1715470827; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=7MKke4M/NQOV2Xiwp2FaYco1d7f1PAqXyNvfOG4XPZI=; b=FQJCxa+vkRAMjY1SAoi7jqjVi14aYH7Lpsuu0TfN5uYf4voPKg3XWrPJ 0qpmdbk5tjL7M2tm4WmXP+d0q/gE41NcAfcri6v4cGpqnDZOYLXvkGsvB XF1kzKuDCdYPZRtofnf3Uc7903srvHt4JrDiC5Fg0D7E4FlfxhQZ0Wld7 t2WQ4lVoA7uX6RLrqern1fAPSlfjQ/UBwhzoVuALYggzD7jaQ2Y0BYRgN eHUvC2TglxPZ+WOU+7MJ20bokGJ9xigT3LFjzdG4m8UtdUiMcfIW6q+hP vOw7qlLkBqwp8rU8JbH2S4w5fgrDApKLAtH2ijSAymeqpp4Phbdagts02 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10708"; a="348396391" X-IronPort-AV: E=Sophos;i="5.99,269,1677571200"; d="scan'208";a="348396391" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2023 16:40:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10708"; a="694414991" X-IronPort-AV: E=Sophos;i="5.99,269,1677571200"; d="scan'208";a="694414991" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga007.jf.intel.com with ESMTP; 12 May 2023 16:40:26 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 12 May 2023 16:40:26 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 12 May 2023 16:40:25 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 12 May 2023 16:40:25 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.47) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 12 May 2023 16:40:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NIZqlvlDsyFsbTsvh4XBiGJDzxJI6hPJzR3lY1jRLyz8EIzUl/nAgEUGl6mK6EtjxOdg4JxVooLK95od8+ZYA/iKT4GbXiNBhL80yGMieYRrtuHAsLofgbmRINscYW5hT+yr71IO1VTxx0pjk/fqtG6zcPY9IJm9ZaDxfW9umG9hR8XtXok4tGBtaByBKPJIopr+xp/8u2E+7e6EH6YTyHiiU+2iwZbBrgLYeRr9fx1MYRWfxJEx4k8PXEkxbHV6Ki4wu4lhNIu98IP7rWyeSSfDq31u9IY7Ah8orN3t57G2na1DlCGsXezYQxD3VfWo5vMpEcDE5bPyB7Tf6B15nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xWGk+qIitZv+x5jYET1NTtYqQIqPudEIKD+qlUxY1kY=; b=DTNcRmWfu2lzf5DjtQc/uJnRNx+y2QzSIdtP/jKmg8iU28kNuEcjSXjIDwogiJVz7mkVMBDaJeUcrtZTCEh4rbGhevI5Uao64tmNc5xdC/2LYKgq5a/kc6ep3bRG5VYoREQqLa+od9FyUBcm7W1j6OW0PyTGLNfX4Xqm6VdsW9atzeam9ToPkLHUi8mYWbJwO4k6KzOJvccsiUMiKYKdAelBrL2L4RQivrI+jI0enZsHX8868u4P7qW6KJkIO2bioM2uklzo8KotbiH4WvDJx2hcskok/2Fkhositl+0LBOIc0p+Tpv0Sa8OzHMXU80s+JlCwH88+kkg4J8+4C1iJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB6262.namprd11.prod.outlook.com (2603:10b6:8:a7::22) by CY8PR11MB7746.namprd11.prod.outlook.com (2603:10b6:930:86::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.24; Fri, 12 May 2023 23:40:23 +0000 Received: from DM4PR11MB6262.namprd11.prod.outlook.com ([fe80::ac7b:f4d1:4de7:443c]) by DM4PR11MB6262.namprd11.prod.outlook.com ([fe80::ac7b:f4d1:4de7:443c%7]) with mapi id 15.20.6387.018; Fri, 12 May 2023 23:40:23 +0000 From: "Guo Dong" To: "devel@edk2.groups.io" , "Gao, Liming" CC: "Ni, Ray" , "Rhodes, Sean" , "Lu, James" , "Guo, Gua" Subject: Re: [edk2-devel][PATCH V2] UefiPayloadPkg: Fix boot shell issue for universal UEFI payload Thread-Topic: [edk2-devel][PATCH V2] UefiPayloadPkg: Fix boot shell issue for universal UEFI payload Thread-Index: AQHZhSNSx9lapglXSUuMDoUrED2bgK9XStBA Date: Fri, 12 May 2023 23:40:22 +0000 Message-ID: References: <175E86BB586C3E96.27409@groups.io> In-Reply-To: <175E86BB586C3E96.27409@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB6262:EE_|CY8PR11MB7746:EE_ x-ms-office365-filtering-correlation-id: 617a83d7-95c2-4dee-e9d9-08db5342410e x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zSOEwOLzhEAzKrJUY4gcoucgV9MpR+1XxPaMDSfhC+79uSDJP2nxB/eJd+3iWjzl0DtEdo/GB4qQq65jzojkr+r/W3RJqqhRbO+QHCTRVWnHRSP6Wiin97i7gOC/mRuMzgaK6qHBkB36is0l4tDqGWNecaGG2tmsSaYpCFB2p42AUQz6smH4pyCn8ZMFQ2uwUFpLknUOpQnd0vX8oUM1z+PY+WjDK+j0DlvI+P3FIkLO8GlQLEPqn8VQHfXvZ2Ac53Uy2VXujov26sv+gmabmI90o12nkzoh06KYQLhq+HWrgcd9KC35X6ubyDifMXDuW8qHbu7NPcTdrS5aMWsiNFcMD8/dHZrIefv/zmY47Hn3C45Raq7h8glBWqNlcptWVOk4xDah8rJxIQkYC7DuKRZShf/EmLtYQDpmrzJd0SdIOiuRRc0bNVLnjhG1SLJofVaCFj5gvAr3liG3UVWm8mWNzBjNtL9xCtL0w3l9u0Rx+jePv3GpzgEp2bZ2/tojwao6p4Bb+uoQKbiTBS5I0CiJvpghnub933KwtU9wK5kmMHiQH2hA6os0Sg9P5H50V0sgfTHqxXlYXdv2y06n11BU18kMyOlpoI5IGBVjwlwkKHUEu3+juTyJUHLqdtik7j8xiHZLF5LOJc6WWdPjhQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6262.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(346002)(376002)(396003)(136003)(451199021)(966005)(82960400001)(122000001)(52536014)(9686003)(53546011)(26005)(6506007)(186003)(83380400001)(55016003)(107886003)(2906002)(33656002)(8676002)(5660300002)(8936002)(76116006)(478600001)(110136005)(7696005)(38070700005)(54906003)(71200400001)(41300700001)(316002)(86362001)(66446008)(66556008)(66946007)(4326008)(64756008)(66476007)(38100700002)(66899021);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yKTmQQEfkLknkM+rO37ASGmwQ8eXtGDfRXhCPHQyI7Xbr1XH9flJSDBkl4wT?= =?us-ascii?Q?HzZ/NYJZCh0vH2Vu7uJiOVQAeguZ2k0eULFRUxOC4F9LDWHsXwCE2iY1lh+E?= =?us-ascii?Q?n+VeOFQO3Bywta4a+NoEKMPvJTZpWPQKZDKXysTTLC24MOULs0DEE8RRKJFt?= =?us-ascii?Q?cfseDOTiAwLd4gGGj0APC2Cy5+k3ZNMRwFC62DlYKS5+J/sv8r7GcCriTptN?= =?us-ascii?Q?bF3N+sqokAg0cjvlbBL9nRP0WEYDADomcIDzaSa+3H65YMG742AgOWeBB8MV?= =?us-ascii?Q?mhiRaDQFPgEPof/Ku5XF6JyhS1K+7dZG1sfLtR3Uigk9tG6YUJ/xVOo/FUYm?= =?us-ascii?Q?PW/Ti5++RfQPT1lRU9TaRcZrSrSTHomhcUilFAxXgzfrJV7nseam7rWa4OVp?= =?us-ascii?Q?HTAaf8CwNmEaNUfA3c+XvpGAYEXlw2IOOmZeq7v8SXqnhFI8PmUtufEfIkcd?= =?us-ascii?Q?e4yKYWj4XNLa0Ph5016w+JtYegvueqdTmLwbXi2RTuOpONH6AXI9JPNcYndh?= =?us-ascii?Q?A2JWC5qfAmhMEdOVvI+XQGae5cBGX5kOuVBIDWArSQ4rCfa+lN43Hmn64vfj?= =?us-ascii?Q?jKA8cQTYy5M6LV7D45cQ8KGcfrcfrsvwCUZRay8NKVyrraPhViukw58IC2Lr?= =?us-ascii?Q?x5+ExjrU2UByg4HNqMFD1R94Ax7No1C3B05HiPaXEu9RdeAs1f94UHKFgA67?= =?us-ascii?Q?8t4WxiypS7R73ZbSQ7VDvpbAlRL/6E9kE0KZUiLhUQeXv+7OmCy5NAOUOjya?= =?us-ascii?Q?WtC7DZnwizU2YC9aYSMM1guBp7lItjKa5GmVpIxrDfko1CX+nORS9rikPFmB?= =?us-ascii?Q?BKMiapK8Jkc2vVxfJRBBnuhsppm+BAxv7RgOcV4UcGkmzTvedUwPtXPN3zq4?= =?us-ascii?Q?Rw4/wH+/gCqu/sdhDOrENj8T82PRJpHmE815ijTxx+MwvFqhVq55Jg9hMw5f?= =?us-ascii?Q?Iv/QtEjQc+RoNHg7SqRZXm9EOVUN/78U+SFwCrgaZY484JCM0jUf2qqJ06BJ?= =?us-ascii?Q?0iB4oPN6nvU+QTvPUV196oBf4VbZwSqVITrJMfafdftunJiLI2dcKttwpZRV?= =?us-ascii?Q?ToMOMxOyMUy3E9wKqVEVuDyuFdc/4eymYz/vDa1pZVBYFJdnMdMBZAWGMry8?= =?us-ascii?Q?zqrveFHg9KxN1UxxRShBptAR4veb2jrd+pJqDUzCv3HLeVhh3N+gFDrM672B?= =?us-ascii?Q?HHUeubWiIrtZhQbOiVotE0DoJH6M5nfb79xZcv/ZmOijTae1q7rcmZgsvDa8?= =?us-ascii?Q?dAeWIpE91GfN+Mu+E6POcQNcqg6X796lHwjfHx+OelLP3Fvvno62SefjbQ5V?= =?us-ascii?Q?Qvbfu8l9vg2I/hpwYGFcpSfUKXoyuw39XxXqjXUwLUGwGqwtTKL/Sz/hGth9?= =?us-ascii?Q?2Fje4Xtg0hWDkE+xJSCyUtg8JWYKl4pCxlPFgTr8q6Ra6A0N4ptE+sgMuO2j?= =?us-ascii?Q?ANs6feyNtT0bW2Tj8ITnEfk9sVFBrFc3Ab+MWxtHly4Yix+ajHwr9mJKBhQG?= =?us-ascii?Q?8zgiCw9Jgjj/tO4uVxFZjC9JuQZRHNmHaARotmqvINqxdjMmkYt6cqHbOx3b?= =?us-ascii?Q?DmAwFx2D9wSWk1CVZZQ=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6262.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 617a83d7-95c2-4dee-e9d9-08db5342410e X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2023 23:40:22.6926 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xZLpVFCd+a5+XSYXNgnP70IQ3XXIjVFHEyn6fHlg67P1zCbN2qHKI1GB4y7n8hnlyKfVHyZu0JnPxo65OMu0Wg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7746 Return-Path: guo.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, I know EDK2 is code freeze now. This patch fixes the UEFI payload boot to s= hell bug and it got reviewed and should have no impact to other packages. Do you think we could merge it for this stable release? https://github.com/tianocore/edk2/pull/4377 Thanks, Guo -----Original Message----- From: devel@edk2.groups.io On Behalf Of Guo Dong Sent: Friday, May 12, 2023 3:44 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Rhodes, Sea= n ; Lu, James ; Guo, Gua Subject: [edk2-devel][PATCH V2] UefiPayloadPkg: Fix boot shell issue for un= iversal UEFI payload From: Guo Dong After moving BDS driver to a new FV for universal UEFI payload, the shell b= oot option path is not correct since it used the BDS FV instead of DXE FV i= n its device path. This patch would find the correct FV by reading shell file. It also removed PcdShellFile by using gUefiShellFileGuid. Signed-off-by: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Reviewed-by: James Lu Reviewed-by: Gua Guo --- UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c |= 82 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++------- UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf |= 5 +++-- UefiPayloadPkg/UefiPayloadPkg.dec |= 3 --- 3 files changed, 78 insertions(+), 12 deletions(-) diff --git a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootMana= ger.c b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c index 62637ae6aa..1660d6c330 100644 --- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c +++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager. +++ c @@ -2,7 +2,7 @@ This file include all platform action which can be customized by IBV/O= EM. -Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved.
= +Copyright (c) 2015 - 2023, Intel Corporation. All rights reserved.
SPD= X-License-Identifier: BSD-2-Clause-Patent **/@@ -11,6 +11,7 @@ SPDX-Licens= e-Identifier: BSD-2-Clause-Patent #include "PlatformConsole.h" #include #include +#include /** Signal EndOfD= xe event and install SMM Ready to lock protocol.@@ -89,6 +90,77 @@ Platform= FindLoadOption ( return -1; } +/**+ Get the FV device path for the shell file.++ @retur= n A pointer to device path structure.+**/+EFI_DEVICE_PATH_PROTOCOL *+BdsG= etShellFvDevicePath (+ VOID+ )+{+ UINTN FvHandl= eCount;+ EFI_HANDLE *FvHandleBuffer;+ UINTN = Index;+ EFI_STATUS Status;+ EFI_FIRMW= ARE_VOLUME2_PROTOCOL *Fv;+ UINTN Size;+ UINT32 = AuthenticationStatus;+ EFI_DEVICE_PATH_PROTOCOL = *DevicePath;+ EFI_FV_FILETYPE FoundType;+ EFI_FV_FILE_= ATTRIBUTES FileAttributes;++ Status =3D EFI_SUCCESS;+ gBS->Locate= HandleBuffer (+ ByProtocol,+ &gEfiFirmwareVolume2ProtocolGu= id,+ NULL,+ &FvHandleCount,+ &FvHandleBuffer+ = );++ for (Index =3D 0; Index < FvHandleCount; Index++) {+ Size =3D= 0;+ gBS->HandleProtocol (+ FvHandleBuffer[Index],+ = &gEfiFirmwareVolume2ProtocolGuid,+ (VOID **)&Fv+ );+ = Status =3D Fv->ReadFile (+ Fv,+ &gUefi= ShellFileGuid,+ NULL,+ &Size,+ = &FoundType,+ &FileAttributes,+ = &AuthenticationStatus+ );+ if (!EFI_ERROR (Status)) = {+ //+ // Found the shell file+ //+ break;+ }+ }++ = if (EFI_ERROR (Status)) {+ if (FvHandleCount) {+ FreePool (FvHandl= eBuffer);+ }++ return NULL;+ }++ DevicePath =3D DevicePathFromHandl= e (FvHandleBuffer[Index]);++ if (FvHandleCount) {+ FreePool (FvHandleBu= ffer);+ }++ return DevicePath;+}+ /** Register a boot option using a fi= le GUID in the FV. @@ -109,15 +181,11 @@ PlatformRegisterFvBootOption ( EFI_BOOT_MANAGER_LOAD_OPTION *BootOptions; UINTN = BootOptionCount; MEDIA_FW_VOL_FILEPATH_DEVICE_PATH FileNod= e;- EFI_LOADED_IMAGE_PROTOCOL *LoadedImage; EFI_DEVICE_PATH_PRO= TOCOL *DevicePath; - Status =3D gBS->HandleProtocol (gImageHandl= e, &gEfiLoadedImageProtocolGuid, (VOID **)&LoadedImage);- ASSERT_EFI_ERROR= (Status);- EfiInitializeFwVolDevicepathNode (&FileNode, FileGuid); Dev= icePath =3D AppendDevicePathNode (- DevicePathFromHandle (L= oadedImage->DeviceHandle),+ BdsGetShellFvDevicePath (), = (EFI_DEVICE_PATH_PROTOCOL *)&FileNode ); @@ = -248,7 +316,7 @@ PlatformBootManagerAfterConsole ( // // Register UEFI Shell //- PlatformRegisterFvBootOption (PcdGetP= tr (PcdShellFile), L"UEFI Shell", LOAD_OPTION_ACTIVE);+ PlatformRegisterFv= BootOption (&gUefiShellFileGuid, L"UEFI Shell", LOAD_OPTION_ACTIVE); if = (FixedPcdGetBool (PcdBootManagerEscape)) { Print (diff --git a/UefiPayl= oadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf b/UefiPayl= oadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf index f9626175e2..a3951b7a7e 100644 --- a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.= inf +++ b/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerL +++ ib.inf @@ -1,7 +1,7 @@ ## @file # Include all platform action which can be customized by IBV/OEM= . #-# Copyright (c) 2012 - 2021, Intel Corporation. All rights reserved.+# Copyright (c) 2012 - 2023, Intel Corporation. All rights reserved. # SPDX-License-Identifier: BSD-2-Clause-Patent # ##@@ -32,6 +32,7 @@ MdePkg/MdePkg.dec MdeModulePkg/MdeModulePkg.dec UefiPayloadPkg/UefiP= ayloadPkg.dec+ ShellPkg/ShellPkg.dec [LibraryClasses] BaseLib@@ -52,6 += 53,7 @@ [Guids] gEfiEndOfDxeEventGroupGuid gEdkiiBootManagerMenuFileGuid+ gUe= fiShellFileGuid [Protocols] gEfiGenericMemTestProtocolGuid ## CONSUMES@= @ -69,7 +71,6 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow gEfiMdeModulePkgTokenSpace= Guid.PcdConOutColumn gEfiMdeModulePkgTokenSpaceGuid.PcdConInConnectOnDema= nd- gUefiPayloadPkgTokenSpaceGuid.PcdShellFile gEfiMdePkgTokenSpaceGuid.= PcdUartDefaultBaudRate gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits = gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParitydiff --git a/UefiPayloadPkg/Ue= fiPayloadPkg.dec b/UefiPayloadPkg/UefiPayloadPkg.dec index a23a7b5a78..8d111f3a90 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dec +++ b/UefiPayloadPkg/UefiPayloadPkg.dec @@ -67,9 +67,6 @@ gUefiPayloadPkgTokenSpaceGuid.PcdPayloadFdMemSize|0|UINT3= 2|0x10000002 ## Save bootloader parameter gUefiPayloadPkgTokenSpaceGuid.PcdBootloaderPa= rameter|0|UINT64|0x10000004 -## FFS filename to find the shell application.= -gUefiPayloadPkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E,= 0x9E, 0x1c, 0x4f, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }|VOID*|0= x10000005- ## Used to help reduce fragmentation in the EFI memory map gUefi= PayloadPkgTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x19|UINT32|0x10= 000012 gUefiPayloadPkgTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS|0x04|UIN= T32|0x10000013-- 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104812): https://edk2.groups.io/g/devel/message/104812 Mute This Topic: https://groups.io/mt/98859456/1781375 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D