Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report

["Guillermo Antonio Palomino Sosa" <guillermo.a.palomino.sosa@intel.com>]

Hi guys, can we submit the pull request or do you have comments on it?
https://github.com/tianocore/edk2-basetools/pull/88

Thanks


-----Original Message-----
From: Palomino Sosa, Guillermo A 
Sent: Tuesday, February 28, 2023 10:00 PM
To: Ni, Ray <ray.ni@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io; ardb@kernel.org
Cc: Chen, Christine <Yuwei.Chen@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Oram, Isaac W <isaac.w.oram@intel.com>; Sean Brogan <sean.brogan@microsoft.com>
Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report

It takes same time as original build report to be generated as it constructed using the same data structures as build report. So I think its OK to not have it enabled by default.

Patch is ready in the pull request to be reviews.



-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Tuesday, February 28, 2023 6:52 PM
To: Palomino Sosa, Guillermo A <guillermo.a.palomino.sosa@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io; ardb@kernel.org
Cc: Chen, Christine <yuwei.chen@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Oram, Isaac W <isaac.w.oram@intel.com>; Sean Brogan <sean.brogan@microsoft.com>
Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report

What's the status of this patch?
Does report generation take time? If no, why not generate them by default without individual flag control.
I really like the feature to generate "compile_commands.json"

> -----Original Message-----
> From: Palomino Sosa, Guillermo A <guillermo.a.palomino.sosa@intel.com>
> Sent: Tuesday, February 28, 2023 7:42 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; 
> devel@edk2.groups.io; ardb@kernel.org
> Cc: Ni, Ray <ray.ni@intel.com>; Chen, Christine 
> <yuwei.chen@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, 
> Liming <gaoliming@byosoft.com.cn>; Oram, Isaac W 
> <isaac.w.oram@intel.com>; Sean Brogan <sean.brogan@microsoft.com>
> Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile 
> information in build report
> 
> I have updated the pull based on Sean feedback. I added following 
> fields to
> module_report.json:
> * LibraryClass
> * ModuleEntryPointList
> * ConstructorList
> * DestructorList
> 
> I have also added commit from Ard based on this request to fix build issue:
> https://github.com/tianocore/edk2-basetools/pull/88
> 
> Thanks
> 
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Monday, February 27, 2023 4:36 PM
> To: devel@edk2.groups.io; ardb@kernel.org; Palomino Sosa, Guillermo A 
> <guillermo.a.palomino.sosa@intel.com>
> Cc: Ni, Ray <ray.ni@intel.com>; Chen, Christine 
> <yuwei.chen@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, 
> Liming <gaoliming@byosoft.com.cn>; Oram, Isaac W 
> <isaac.w.oram@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; 
> Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile 
> information in build report
> 
> Hi Guillermo,
> 
> Can you please look at Ards PR and make sure his fix is included in your PR.
> 
> Also, please work with Christine and Bob to see what is going on with 
> the Code Coverage check.  We do want it to be easy for all community 
> members to submit change requests.  We may need support from the 
> edk2-bastools maintainers to help with CI issues and help with changes to address.
> 
> Thanks,
> 
> Mike
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard 
> > Biesheuvel
> > Sent: Monday, February 27, 2023 10:58 AM
> > To: devel@edk2.groups.io; Palomino Sosa, Guillermo A 
> > <guillermo.a.palomino.sosa@intel.com>
> > Cc: Ni, Ray <ray.ni@intel.com>; Kinney, Michael D 
> > <michael.d.kinney@intel.com>; Chen, Christine 
> > <yuwei.chen@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, 
> > Liming <gaoliming@byosoft.com.cn>; Oram, Isaac W 
> > <isaac.w.oram@intel.com>; Sean Brogan <sean.brogan@microsoft.com>
> > Subject: Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile 
> > information in build report
> >
> > On Mon, 27 Feb 2023 at 18:40, Guillermo Antonio Palomino Sosa 
> > <guillermo.a.palomino.sosa@intel.com> wrote:
> > >
> > > Hi. I have submitted a pull request to edk2-basetools repository:
> > > https://github.com/tianocore/edk2-basetools/pull/88
> > > This is the feature request for it:
> > > https://github.com/tianocore/edk2-basetools/issues/87
> > > I'm also attaching the patch here:
> > > (0001-BaseTools-Generate-compile-information-in-build-repo.patch)
> > >
> > > On a side note, seems like tip of edk2-basetools is broken due 
> > > this
> commit that makes direct import of Common package:
> > > https://github.com/tianocore/edk2-
> basetools/commit/8e6018d3ea4c1aae7
> > > 185f589d129cea14a5d89fd
> > > edk2-basetools\edk2basetools\GenFds\SubTypeGuidSection.py:
> > > import Common.LongFilePathOs as os
> > >
> > >
> >
> > I sent a fix and a PR for this about a month ago:
> >
> > https://github.com/tianocore/edk2-basetools/pull/86
> >
> > but CodeCov seems to take issue with it, for reasons I don't 
> > understand (and I can't be bothered to spend more time on yet 
> > another CI automation pass that adds to my workload rather than 
> > reduce it)
> >
> >
> > 
> >