From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.29393.1654501618412565361 for ; Mon, 06 Jun 2022 00:46:59 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=UchB2a7A; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: eric.dong@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654501618; x=1686037618; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=gyU9OvhyWqy3VVVBmM0VCcW3HnMA41CpPBv2whhiyE4=; b=UchB2a7AqSjoP/Mtu+xNuH9vyGjVol64t1Bw1kudGGU4UX2BY5HpyZ9g El8MORGBpQXbd70M/wmtgHxeKdPTYnq9l7ABJY52JNnxOQZTwM0IZ9Qss ymfvsLQO+nRydWcIUzbLElsTlp3Gj7E1JhokVn3KRHnRvUBjRDb3gk4Hd whj0Iomxrt6h9F78HZO3FMwsTY2pPtR2OyGtFHqDKfotifzalcnrIo5ns ZlHI+hE7PJaUHmTiERE1+qcuHUXB3PR3wgjnGOElDDoxuiTAYyvIdvufb o7CQMCR9zff0ghqijP9t4zKIBDfoU/xRXLdy7lfPjrC783gMT2yuaLxCk w==; X-IronPort-AV: E=McAfee;i="6400,9594,10369"; a="256472411" X-IronPort-AV: E=Sophos;i="5.91,280,1647327600"; d="scan'208";a="256472411" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2022 00:46:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,280,1647327600"; d="scan'208";a="708969553" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga004.jf.intel.com with ESMTP; 06 Jun 2022 00:46:55 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 6 Jun 2022 00:46:55 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 6 Jun 2022 00:46:54 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 6 Jun 2022 00:46:54 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 6 Jun 2022 00:46:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PLG7M3GTyb4iiZN2O6SdVX/Z3EpgBtzODRde3MAb6uQeq2/rn59zmVdE8v+qzITkryKA/v5XRwy/91vx6awlEqEoRoPmpgwGujLcFJH+5qx+lrEWRaN1ZPP8PfoNKz3zV6rbPNoR0jdZeP81lNtKSmQ5QVdhJZ9xOwdOw224eBN2XDnM63WnD8vBueT4GakxId4/CcO/LjA+Lq9ARIwOSzFKW8G/+VYN4+mUPhySYXL/Nrq97OGqGypc76iWi4pzk22DhAHa97QxwXMmYI1TuA6wgdYozgwSeOpgQr8eHRn/MSFNG5ExLm0u5L/Jqj+Xj1MvKvsZHx8skIV+o2zcog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dbV8IE5h2iwRtbaf+3gdql8hNsjHIsDXWcZfmLLhyNg=; b=Biw0ntkR24ze6XoIFYFJAVwlvY5ojfx24Svh7/uwCFDUQiyMNPcWDAI0EfECPkNa+QWYktfw3kj5QOhgn3NUqQXsdsWgtOutd233eR6vVnZ3J6Y406w7lzyYglvkaNRArqAunoTW3OP0gWVlrJSF5zRfdu92GvHPGfDujQ5OgPjI9RpiYJANk48lKu552FtUbLDxecuKUg5Ts4NJmcT/6UNmN5qneMmQSX/EmGUr4vNIIWFdkycCssbBf/Nf8ss5Ib6OUxwgo+w+41eEw6IOpWx/VmV0LrZanLPL4zq8ziDT7V38fNJcSgHoIpJSha1+HceBpqXQYAd7YWW06UJgSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB6480.namprd11.prod.outlook.com (2603:10b6:8:8d::17) by MWHPR1101MB2320.namprd11.prod.outlook.com (2603:10b6:301:53::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.15; Mon, 6 Jun 2022 07:46:52 +0000 Received: from DM4PR11MB6480.namprd11.prod.outlook.com ([fe80::d125:7372:7128:a152]) by DM4PR11MB6480.namprd11.prod.outlook.com ([fe80::d125:7372:7128:a152%7]) with mapi id 15.20.5314.013; Mon, 6 Jun 2022 07:46:52 +0000 From: "Dong, Eric" To: "Ni, Ray" , "devel@edk2.groups.io" Subject: Re: [PATCH 2/5] CpuException: Init global variables in-place Thread-Topic: [PATCH 2/5] CpuException: Init global variables in-place Thread-Index: AQHYbFQltb5L/MaEGEKcSXqCM45wcK1CGnhA Date: Mon, 6 Jun 2022 07:46:52 +0000 Message-ID: References: <20220520141549.108-1-ray.ni@intel.com> <20220520141549.108-3-ray.ni@intel.com> In-Reply-To: <20220520141549.108-3-ray.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2248e872-1b1b-421d-7e25-08da4790b8c4 x-ms-traffictypediagnostic: MWHPR1101MB2320:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8ZvngqPyT4sQhAP0LY721uYkKmFu59PyIhmeMbGBdSxSm7coCiqOKXSavu75ZlfRrMiioPdyTIOX29bntD6nuuRoEPLUNvOGCYurcaUigG16gt5XpFl3l5J6z1bS63FbLkwwScwrN5WWTuN/gJbPexLv1TloMX+VNle/eXmxGh/jcubXvW5UOnWoXlguhoEy6O/ht2n0ZGhaUl3c3ju4z+z9cCsgnINV/tY8iiBNimvpc+sDk9EqEYbQQeAFkmOzVeR5GgdzorlVFd8YVf6HoKmPxDUNIIINB99DRcjLxHJpTycnvXPPIiGbdwDrXDLYuNC0nT1nEBKO+thFvT2Mg7G32PnAiH4Q8+jFRSYY/xkqsPl078PVesG0q6mHsDG88gMdj+iP0xfhAxhWg8w/frP8p9cQx5I5Q+6+XoJa59QVjNRKLdAYrTe1TDmReJJY2a7WZDGBAahoNCoYkatA+gbBuhMyMo7cUXRj8Ln8X4eIryMUXIQ+H1Jdipp/dlI53WufdzcVZPp7iKndlfEkYDfiPY4YYnwWgCX3gKKdhB+7k2oH+Zoqw0Goh0YixUtTIaV35HC9XBmwGCRtIqzxZKyg8sXGQW2bDbAx+RKj9SEpz/W4XaHBEnuKifGQyWfjc4ezRykTf2qinvc+YigTjOm01DNHkg8+eaLho2TXrVltAzGl7BA9H3bXApf2bmOcn2C3VRi+OJX1ZloUyaMewA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6480.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(55016003)(82960400001)(7696005)(66446008)(38070700005)(64756008)(2906002)(76116006)(5660300002)(122000001)(53546011)(6506007)(9686003)(26005)(66556008)(66476007)(8676002)(110136005)(38100700002)(83380400001)(186003)(66946007)(316002)(86362001)(52536014)(8936002)(508600001)(33656002)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sHUuMuHOE0Np9g8ZCZNRI4kobYgu5iYUiYdmApDaxCztRBA6l7QGsBeCWpc/?= =?us-ascii?Q?aTkuJc+if5t2C5P4QxVuRGHud+YXfopdd1I8u5mp+M45TZYKgF7eqv/h841n?= =?us-ascii?Q?dv346+pV9sGHPwD3U4UJ27x/0o139CRRh0Y0dQ9K3NoPKCEA8uMDKOZ1nmUU?= =?us-ascii?Q?H32/dR60GnDJjKYedSetrsF7yj5Dhr2Zc4t33pFtP+UNJqBj3KFjgUPN0CNW?= =?us-ascii?Q?J/mVKQqmMHfKlCrO73XnfTiiyTStgdKS+Q6giFOJzmX6JO9ZhfP8aIMshb21?= =?us-ascii?Q?WFP6sHPuxLj8AuFaKog6+VllSdHDE/QZqcVTes5yJrhjddUT54Mc0AkWT/Ph?= =?us-ascii?Q?C2+cPDcmHvsCXrQYr2xrvfhhNI6jFkuc/gKd3HgqgtQ4Q1aUxpFfWC6TeVeW?= =?us-ascii?Q?sjNVOMI/R2hQEEjnLLedDUSOGocoPnQ5w2Vh2C1PucASBgYxg88AGt7NOsPs?= =?us-ascii?Q?GNA4z/b0e1kVROv4Vtec+wKHE3jpamRKUclcIpaPqyB8okxrRSIZN7DESlUy?= =?us-ascii?Q?z1FvX3k3lryCIlzwfiWM5WB24EiZWXCYoKvyKnAE4JomNkjYijAWPAhITymV?= =?us-ascii?Q?rjfkFlHiwS1dXPnJECPxF4W/JzULeKtsT/YxolUw6opFG6osyfEZlmjsK8HR?= =?us-ascii?Q?Gvl1c66/rRAaWMCcf0hF4W4AkfC0UlO3XpaIzas7ZJbywUVmtupeCZTcz08Z?= =?us-ascii?Q?xdxIOm+Jk8/07iNVEfCbMXVX4exVV5UzFGsWPc/RYkhDr6rQ5JsCfxwhzYC4?= =?us-ascii?Q?FQ7yh7g1aB6nzwSJgNQFTyLhDL0cpPKE4o8wAptvV3T3TYghwMYgGasEcOh2?= =?us-ascii?Q?Vq3YQB7z+KeDiGlftPVfEiNXFmZNVFm2qSAMFhGNA0KvcYK+s5dwHcRYYuSX?= =?us-ascii?Q?5NpHHF98oL5VYv8/N6Nw3MNdhd0+seVIsNMMDB1GP3sD6deR5rGXcTsH8Ojr?= =?us-ascii?Q?JcysM1F+isQEJAq6z7kXxZ2I7PMeksSzhC8Xrqnt6n6pSCANElv48QuWY/tR?= =?us-ascii?Q?tw/YW5okwQr62mq+8s3uK0jG4RbHnhKjEHnvZ0O6tYl02eNbf8xtBM2+u36l?= =?us-ascii?Q?RV8u0V36ApzW3Hb0irgXMVLa02mmTA4F5Fjeon8YvWcwyzbufcBJWCDdsRWV?= =?us-ascii?Q?yILuOe0QcZQNk25FDio/j5wWTOqERthtY2nixk4iU309Dcu2byXwyNE+37aw?= =?us-ascii?Q?hsnYnOSNOszYk95Ef175S14eFwmrtgVYvRENI1Ac7H6n1qCzn0L5T6rhjp81?= =?us-ascii?Q?9Md2ZsPKBXpAIL0SSQW79G4aSeVEtTyRYy9uLGnVq7U8lkN3f/2CP+SQc9XV?= =?us-ascii?Q?5meREquUUsOpiq5xK1GqbogXJ6QQH9MdU3xDaeBQEgk0in03WtHGvwVOeJp/?= =?us-ascii?Q?74iOePykoAPpFLlh2meywn2ai6qYummj/4l3YZ8Z4p8Dzn5j6XGtpjzpAwnV?= =?us-ascii?Q?DA+TwVRTcEi/OYGzVJt6ogHNdhffEEoXkPEtinqeAGbgG22LLQN+LSmtun0K?= =?us-ascii?Q?FFH3w4fyOTlB7GAo14nVDZB5eJAlFH3jR3q55VdkSCJGRh5Gocfgl+TVDeXu?= =?us-ascii?Q?y5yLZum/zELeAvKDdm6aadmMmxoVM5yb4eRX2mFgnbrdeyw/gLpKvgkVYRSR?= =?us-ascii?Q?1P1hAyckVyU+f4Y1WnOIyk6TYIcy6DPWxIJkofKl9HIzpaMs5fZj9K+QgbMq?= =?us-ascii?Q?YzWLkJloKCjzh7tXnNKCuhmtJ466g0D4lHGvLBsSYUJR2ErkkwMp6Z4jt/7P?= =?us-ascii?Q?xsXLbmswLw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6480.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2248e872-1b1b-421d-7e25-08da4790b8c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2022 07:46:52.6782 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5jrGOuhk4W8wHH/TMYKLYup2//sdLRoWq6I0y2gwpU4a02ceyNkkyCFfuhNVHw4P0NK9xpDTrRrJG+kLsHr0Ig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2320 Return-Path: eric.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Acked-by: Eric Dong -----Original Message----- From: Ni, Ray =20 Sent: Friday, May 20, 2022 10:16 PM To: devel@edk2.groups.io Cc: Dong, Eric Subject: [PATCH 2/5] CpuException: Init global variables in-place Additionally removed two useless global variables: "SPIN_LOCK mDisplayMessageSpinLock" from SMM instance. "UINTN mEnabledInterruptNum" from DXE instance. Signed-off-by: Ray Ni Cc: Eric Dong --- .../Library/CpuExceptionHandlerLib/DxeException.c | 11 ++++++----- .../L= ibrary/CpuExceptionHandlerLib/SmmException.c | 14 ++++++-------- 2 files changed, 12 insertions(+), 13 deletions(-) diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeException.c b/Uef= iCpuPkg/Library/CpuExceptionHandlerLib/DxeException.c index 5083c4b8e8..da5b96d6c6 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeException.c +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeException.c @@ -16,9 +16,12 @@ CONST UINTN mDoFarReturnFlag =3D 0; RESERVED_VECTORS_DATA mReservedVectorsData[CPU_EXCEPTION_NUM]; EFI_C= PU_INTERRUPT_HANDLER mExternalInterruptHandlerTable[CPU_EXCEPTION_NUM];-UI= NTN mEnabledInterruptNum =3D 0;--EXCEPTION_HANDLER_DAT= A mExceptionHandlerData;+EXCEPTION_HANDLER_DATA mExceptionHandlerData = =3D {+ 0, // To be fixed+ 0, // To be fixed+ mReservedVectorsData,+ = mExternalInterruptHandlerTable+}; UINT8 mNewStack[CPU_STACK_SWITCH_EXCEP= TION_NUMBER * CPU_KNOWN_GOOD_STACK_SIZE];@@ -62,8 +65,6 @@= InitializeCpuExceptionHandlers ( IN EFI_VECTOR_HANDOFF_INFO *VectorInfo OPTIONAL ) {- mExceptionHandl= erData.ReservedVectors =3D mReservedVectorsData;- mExceptionHandl= erData.ExternalInterruptHandler =3D mExternalInterruptHandlerTable; Initi= alizeSpinLock (&mExceptionHandlerData.DisplayMessageSpinLock); return Ini= tializeCpuExceptionHandlersWorker (VectorInfo, &mExceptionHandlerData); }di= ff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c b/UefiC= puPkg/Library/CpuExceptionHandlerLib/SmmException.c index 77ee74579f..9f0af4120a 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmException.c @@ -11,14 +11,14 @@ CONST UINTN mDoFarReturnFlag =3D 1; -//-// Spin lock for CPU information= display-//-SPIN_LOCK mDisplayMessageSpinLock;- RESERVED_VECTORS_DATA = mReservedVectorsData[CPU_EXCEPTION_NUM]; EFI_CPU_INTERRUPT_HANDLER mExter= nalInterruptHandlerTable[CPU_EXCEPTION_NUM];-EXCEPTION_HANDLER_DATA mEx= ceptionHandlerData;+EXCEPTION_HANDLER_DATA mExceptionHandlerData =3D {+= 0, // To be fixed+ 0, // To be fixed+ mReservedVectorsData,+ mExte= rnalInterruptHandlerTable+}; /** Common exception handler.@@ -58,8 +58,6= @@ InitializeCpuExceptionHandlers ( IN EFI_VECTOR_HANDOFF_INFO *VectorInfo OPTIONAL ) {- mExceptionHandl= erData.ReservedVectors =3D mReservedVectorsData;- mExceptionHandl= erData.ExternalInterruptHandler =3D mExternalInterruptHandlerTable; Initi= alizeSpinLock (&mExceptionHandlerData.DisplayMessageSpinLock); return Ini= tializeCpuExceptionHandlersWorker (VectorInfo, &mExceptionHandlerData); }--= =20 2.35.1.windows.2