From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.24457.1654849203456252141 for ; Fri, 10 Jun 2022 01:20:05 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=erC418Ay; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: eric.dong@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654849203; x=1686385203; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=3Q8qR+7abvg1dvtBAkl1OrfjhNuQwjlw6s1DE+2NqxI=; b=erC418AyLG+epaHf95fjls+9z84OHjuz99m7s7YmBeKLVW9ht5Z+YEhL Somj9eYbPFli6X70LmMS2z5sOIXKkVEsgk8PdPanuI8NHSuAHWiaww9gi WyHNw2ceM/ARs7RQTeBiC2OtJ+8wBNQPtAOVUHW2/WOL5RkqHI03qZhK7 NJlQ6+/m3qOPXsMuvpZ9zPEUpKZ38dVrBb686j5imqRPnWWudf5aEXlNV 8/sGeUNQ7vokFd6nqBuTlbVyNB9m5Ka5LEf+1iq2sh7tR4Sjw4SB4LXX1 zDxPACwadKc+Yv1/h8Ym+dC4fJYObqcGi9nACKLN5Tz5TMPZCeO1I2bSu Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10373"; a="341621243" X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="341621243" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2022 01:20:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="533985765" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga003.jf.intel.com with ESMTP; 10 Jun 2022 01:20:02 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 10 Jun 2022 01:20:02 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 10 Jun 2022 01:20:01 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 10 Jun 2022 01:20:01 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 10 Jun 2022 01:20:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CCrOAcE4RDPVYdJ9LWYxBt8AZS9qOSv1gcPyYGhbUjCo9uLd7QHSvb7bY1C7u3IkX5lrj1MKVdo1GaJfz3hpf+2l7zwcdMtp9ZlfxiIRFFWdemrWOd3OP+2Mp4+//RLRosELunS/zNke+yHUhI/jY/CmeIYZaIb5/KXFJFZQx9QU7g7RxMbQPn24eN3gxexz+wBAPd0zILBjy+hGSCgoq8weg+/nc773zz82u13Pj7gwcqRYuHEFjJ503CVa9K6F5seroD8UY2wr/L8JNsekCceykact+CErOnmb/1QaKiDeQ96g5SGQnUfOgYLRA95kSUFV9MwP4aM5vqJQ/ycRrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L+B+Si/BbmBzXKA7gw7chIDRwa9vqOILhwENHB9rqb0=; b=JtL3Q3FbDfbKHDFQfPNLT0PGAM9LlQvmFm4UQV0eXvjdW2cAYMDqLp1x0K3LCHyVEehgUsn90kpw/jzyvBo7HiV35QwIRoTua3E6oqNzpSWniFJoIrqgm9SDSZugDt7ESjCW7foPSCdgDYEUleIl6usT7z/Qc+jn1KMkn0CQWUBMl6xN//ry3ZjJ/YDCf+hYcJ3Tdbpj6zGiF7k8PXJgb/RlNgY63/yi9dpSAk+cmK8UUvUnXpYK4erp61hQXgqEEnTbp/NLecu67Zfxl7nJ3ub2DeZZQJ6e9dZdh/4JT5kIA/6+wPW16jkI8HO+lImXlc9PBNQxcBPtnrnqqC/zBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB6480.namprd11.prod.outlook.com (2603:10b6:8:8d::17) by BL3PR11MB6507.namprd11.prod.outlook.com (2603:10b6:208:38e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.12; Fri, 10 Jun 2022 08:19:59 +0000 Received: from DM4PR11MB6480.namprd11.prod.outlook.com ([fe80::4bf:8f7b:7f94:17c4]) by DM4PR11MB6480.namprd11.prod.outlook.com ([fe80::4bf:8f7b:7f94:17c4%6]) with mapi id 15.20.5332.013; Fri, 10 Jun 2022 08:19:59 +0000 From: "Dong, Eric" To: "devel@edk2.groups.io" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH v3 0/5] MpInitLib code refactoring Thread-Topic: [edk2-devel] [PATCH v3 0/5] MpInitLib code refactoring Thread-Index: AQHYaPSXcM3/39tTFUmKt1s3QfVpi61Ic5sw Date: Fri, 10 Jun 2022 08:19:59 +0000 Message-ID: References: <20220516071412.359-1-ray.ni@intel.com> In-Reply-To: <20220516071412.359-1-ray.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1aed29c4-f0fb-412c-578b-08da4aba02b8 x-ms-traffictypediagnostic: BL3PR11MB6507:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ASDr9U03ylk9yVyHqGi5JFu6BcQ7cz+M7c8tVpCgVsapVX7/PQWVm8zsYxLXO9Xw8KwPblWT7zheuNxEa5VMZV1f6oKe8OybtYoR0251+gQ3v/mNUtTB6lmjMMEr4DWpLljecXxiFFQFBgWnUvQ4+8InulU+6XcPWEi873Pq+/UscbNlA2S8i5bbtTA+ISXxnPBf8q/YfvaIjmSF9jWBwjfxSssyymgEP5De3+y5RRvJz8222dximmIfw1neB2Q7A5qnk+VUiTwAoDdvER8uzG1OkQCw603afcy87GP8a9NTqjxfTbvLqHrcrirgRdu7nNUC3Sb2Yax8ZAdVLKTPG0TtoASWGpWcOqlDWtWHrrERZTFg1Wc87iuqSlig++/AgdSoBKNDSX+n+aypWmBh9aVJr9QwMLWmg9uzSytlg5mSz4dESU2HfIIvlwj5vWooiq7EBN5z+sibiBurkp17DogByIQQQgE3Ehz704yNiEK5lpBZQE8dDr9MSuAYzzzy3FyHDX7Oxp4BJuefMcsXEy3lO28qiTSY50OVrGXgChTqHSGhDwFV8ydHujDwZytrWvV/nZ8f/jVdlV4R1puQ6T8uJUS3jPDTmY2q8vv+M9L20dV8KS0XBL8X0b5iIKxnLMJVQvN3sEZEbad3exQEERDTe5ej/q0a4A9Ikt0YXWQOC6xL9CQJdDeRqw2230rMxYz9xIYImTcGgjAtlV3NYBiUKnRf8VEV6YfiVwtNlwM/dVzXn0l9EBvMGiYYEQI9JVJze/zHkD+VMmezLhmVkC/+rUGUb8tRlo4PVrvZNyzJQkeRjIC2i7ilbTCjO18d7mgaWIgJl/Ue2RDGu+fvdg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6480.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(6029001)(366004)(8936002)(52536014)(86362001)(6506007)(38070700005)(966005)(186003)(53546011)(9686003)(71200400001)(7696005)(2906002)(26005)(5660300002)(19627235002)(33656002)(64756008)(508600001)(6636002)(110136005)(82960400001)(76116006)(38100700002)(83380400001)(55016003)(66946007)(8676002)(316002)(66476007)(122000001)(66556008)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NIBx6gsW2/vDhmXkZ0qARISLyOed9g/pGAyyfc2qg6IXv8DgIxqqeLh8eE1v?= =?us-ascii?Q?kFAT3QPuLC/LNmiG3PkOVnYn8DHs0Lft2ic07NDuN2IPlp9+LKEkmnYpVRey?= =?us-ascii?Q?/dCypYSztoGyIx1JEqrXPfFLx1sJQdWKsLYycaFcFErz3RVtP2eRAf+oUBY6?= =?us-ascii?Q?6+XobAdm0TWK4WrLPQuCyPUPGIwXHUv2vtcbCsiKc2ElccNrKrJwE6ASgRlK?= =?us-ascii?Q?e4+opRBK85cUTruuQdghBu8PTnpNCNwNFNv/R6yISWxe9JdXXXCigN9Cn0Y9?= =?us-ascii?Q?9Di8ZmR1Fn5N2emwkN6/Ih5RfqsyMDfl0tmaBr/6n/XbALU2vZgIujoEWwDY?= =?us-ascii?Q?c9Ip4U/s6673s89zVEn33+gFZs3a588KUlPfu4ceyYgP1mEFePJ6qhh1f2dt?= =?us-ascii?Q?aPNaWs3Y1Rn3n9NhD1X04PT5aicC8L/BQMhN6RZAhIQYMtqjFnZ3MTVtYvE/?= =?us-ascii?Q?N7mOxFnXIkSelgvMBk7xx1k9WCeTyE815SbLw1UF1Qyzf1pnsZtKcBlRxcca?= =?us-ascii?Q?e3dG6vIgQCoAdLkDAH+yzTIFO+3wi/Bs3bRGVU9jIzJdVpROdpZd+O0/g+Sn?= =?us-ascii?Q?Ku8zeeFRFbfVL9GIlzXOOCt+r/m38zSfxtYoFOPwrW1dZ5B2LGaeh+dHXvtf?= =?us-ascii?Q?LHWkZ9hTnWOfusXcFoREdwI/sdXsMyFDRoPYhM0QmyL5sUhrm277oadAXySU?= =?us-ascii?Q?Sty1mtlt5phBM6LMuQb+juEU2KnLRp6m+w6c7yRy417U+iwAai2GOIrM0+JU?= =?us-ascii?Q?xRx8rLMuwFoFwQwGEFwiHaTxBcRfOojXfcAmcArOz7VsJ9ODZiPsOi0pfQfo?= =?us-ascii?Q?ewf0kgjT8EvnkWAoFZi+iyiqxMWw+b3RkgYqkEkF/m9VovvUYrggtEiHw7si?= =?us-ascii?Q?cNf1zjw/pla/4Oi0clxcZjz/jHNIPV/hSsq2X+LEW+MrL+tLysdOy+Q1M2kE?= =?us-ascii?Q?9r7r9hgkSCYI+mBEkz3g9DBjC/vefrMZ7zOpChPTiUUPKJVOUDR/MFE/61Mf?= =?us-ascii?Q?1+73S021LMYT8ZrSbBDPFBQryRfpkob7aZr7oBZ3VpTs4CPFO0csB540Skxt?= =?us-ascii?Q?3Wykj4IFULxW7doMNq80ZeuzSN7xJ5yb5HNrlmSWYBaBp6Irj8MQ2dWeODZ3?= =?us-ascii?Q?n1Yc62PjAV333qj8oZmKa4UOWn4ij+28TcnVbhYp7P/ADRLQ0XXZ/35fO/ZN?= =?us-ascii?Q?k2+HzsBzImIk/K0sY2jjGUYQHF7g1+t7WmrLB4RUFI1tR9iqI/CMqnrhXtim?= =?us-ascii?Q?yUPv0Qz7oYQr7wavhpnZ1uVBM0To7rCxOXqd3WqKcBqyxv4RJA8+w6aixf3R?= =?us-ascii?Q?Uv7UpqbzWorqEn14DQ2lD5bf+evXmJgzmykg4HP5BSN6rhxBI52H4kzCZGB6?= =?us-ascii?Q?j1MVClquF1UlC0i5c1Eduyw7KMl3i9XnCPTvxLndAIKPK7K9BL9Lvo+ZMHbz?= =?us-ascii?Q?ksJyqaeh7Qqe43KywgqmMJ/GtFncMLtcm/WWcaVHrVkPO0y7oVoEKrVifwQe?= =?us-ascii?Q?5z/koYCzNluRIiJHwOlAoQlXP6jurvT6ucvS8Q6VjowUnRrhCCiw4Nt/0DWF?= =?us-ascii?Q?l7s8as+hDC8n5lnRUMfytLK8RTs+Qje+pFDnU9PP/S721GBLN6RngMdOxCw8?= =?us-ascii?Q?zhjNb8c6w1g9awsz3vJSghq90GXPHiFsIe7da8rqATG12jc7MEIzMSuvQMn2?= =?us-ascii?Q?4nhLx26YOixqzpLgtDEcPFCLy5oJiXURuxcIcMhiizuFSxudakBOMRyDH+1i?= =?us-ascii?Q?6hsvdNgR7w=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6480.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1aed29c4-f0fb-412c-578b-08da4aba02b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2022 08:19:59.6198 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ut6p/fGmxWcMEdG7ULOo+OkRuREjQWNb5qXFOuirJUqPSkNrNqmwyqzHHmzdpED4s3cWS4lyoaF4nHlcAOl75g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6507 Return-Path: eric.dong@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Eric Dong for this serial. Thanks, Eric -----Original Message----- From: devel@edk2.groups.io On Behalf Of Ni, Ray Sent: Monday, May 16, 2022 3:14 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v3 0/5] MpInitLib code refactoring v2: Updated 3/5: "Put SEV logic in separate file" patch. Added 5/5: "Move the Above1Mb vector allocation to MpInitLibInitialize" p= atch. v3: v2 was sent to wrong mailing list "edk2-devel@lists.01.org". v3 is created to send to correct mailing list. All code changes are in https://github.com/niruiyu/edk2/tree/refactormp3. Ray Ni (5): MpInitLib: Allocate code buffer for PEI phase MpInitLib: remove unneeded global ASM_PFX MpInitLib: Put SEV logic in separate file MpInitLib: Only allocate below 1MB memory for 16bit code MpInitLib: Move the Above1Mb vector allocation to MpInitLibInitialize UefiCpuPkg/Library/MpInitLib/AmdSev.c | 6 +- UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 +- .../Library/MpInitLib/Ia32/MpFuncs.nasm | 13 +- UefiCpuPkg/Library/MpInitLib/MpEqu.inc | 6 +- UefiCpuPkg/Library/MpInitLib/MpLib.c | 124 ++++++------- UefiCpuPkg/Library/MpInitLib/MpLib.h | 6 +- UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 15 +- UefiCpuPkg/Library/MpInitLib/X64/AmdSev.nasm | 148 +++++++++++++++ UefiC= puPkg/Library/MpInitLib/X64/MpFuncs.nasm | 169 +----------------- 9 files changed, 233 insertions(+), 256 deletions(-) -- 2.35.1.windows.2