From: "Ni, Ray via groups.io" <ray.ni=intel.com@groups.io>
To: Sean Rhodes <noreply@github.com>
Cc: "Dong, Guo" <guo.dong@intel.com>,
"Tong, Justin" <justin.tong@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [tianocore/edk2] 83a86f: UefiPayloadPkg: Allow boot timeout to be configured
Date: Mon, 24 Feb 2025 05:30:56 +0000 [thread overview]
Message-ID: <DM4PR11MB8226F5DCD5C603F82B54F0F28CC02@DM4PR11MB8226.namprd11.prod.outlook.com> (raw)
In-Reply-To: <tianocore/edk2/push/refs/heads/master/063e19-83a86f@github.com>
[-- Attachment #1: Type: text/plain, Size: 1979 bytes --]
Sean,
I do not think the change that makes PcdPlatformBootTimeOut as DynamicHii PCD in UefiPayloadPkg is correct.
When VARIABLE_SUPPORT is not "EMU" or "SPI", UPL does not include any variable manipulation logic.
Defining a PCD to a variable seems not make sense.
Thanks,
Ray
________________________________
From: Sean Rhodes via edk2-commits <edk2-commits@lists.sourceforge.net>
Sent: Monday, February 24, 2025 5:32
To: edk2-commits@lists.sourceforge.net <edk2-commits@lists.sourceforge.net>
Subject: [tianocore/edk2] 83a86f: UefiPayloadPkg: Allow boot timeout to be configured
Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: 83a86f465ccb1a792f5c55e721e39bb97377fd2d
https://github.com/tianocore/edk2/commit/83a86f465ccb1a792f5c55e721e39bb97377fd2d
Author: Sean Rhodes <sean@starlabs.systems>
Date: 2025-02-23 (Sun, 23 Feb 2025)
Changed paths:
M UefiPayloadPkg/UefiPayloadPkg.dsc
Log Message:
-----------
UefiPayloadPkg: Allow boot timeout to be configured
This patch moves `PcdPlatformBootTimeOut` from `[PcdsDynamicExDefault]`
to `[PcdsDynamicHii]`, allowing the boot timeout to be configured through
HII, rather than being a compile-time setting.
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
To unsubscribe from these emails, change your notification settings at https://github.com/tianocore/edk2/settings/notifications
_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#121138): https://edk2.groups.io/g/devel/message/121138
Mute This Topic: https://groups.io/mt/111353434/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 5202 bytes --]
parent reply other threads:[~2025-02-24 5:31 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <tianocore/edk2/push/refs/heads/master/063e19-83a86f@github.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB8226F5DCD5C603F82B54F0F28CC02@DM4PR11MB8226.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox