Re: [edk2-devel] [tianocore/edk2] 83a86f: UefiPayloadPkg: Allow boot timeout to be configured

Re: [edk2-devel] [tianocore/edk2] 83a86f: UefiPayloadPkg: Allow boot timeout to be configured

[Ni, Ray via groups.io]

[-- Attachment #1: Type: text/plain, Size: 1979 bytes --]

Sean,
I do not think the change that makes PcdPlatformBootTimeOut as DynamicHii PCD in UefiPayloadPkg is correct.

When VARIABLE_SUPPORT is not "EMU" or "SPI", UPL does not include any variable manipulation logic.
Defining a PCD to a variable seems not make sense.

Thanks,
Ray

________________________________
From: Sean Rhodes via edk2-commits <edk2-commits@lists.sourceforge.net>
Sent: Monday, February 24, 2025 5:32
To: edk2-commits@lists.sourceforge.net <edk2-commits@lists.sourceforge.net>
Subject: [tianocore/edk2] 83a86f: UefiPayloadPkg: Allow boot timeout to be configured

  Branch: refs/heads/master
  Home:   https://github.com/tianocore/edk2
  Commit: 83a86f465ccb1a792f5c55e721e39bb97377fd2d
      https://github.com/tianocore/edk2/commit/83a86f465ccb1a792f5c55e721e39bb97377fd2d
  Author: Sean Rhodes <sean@starlabs.systems>
  Date:   2025-02-23 (Sun, 23 Feb 2025)

  Changed paths:
    M UefiPayloadPkg/UefiPayloadPkg.dsc

  Log Message:
  -----------
  UefiPayloadPkg: Allow boot timeout to be configured

This patch moves `PcdPlatformBootTimeOut` from `[PcdsDynamicExDefault]`
to `[PcdsDynamicHii]`, allowing the boot timeout to be configured through
HII, rather than being a compile-time setting.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>



To unsubscribe from these emails, change your notification settings at https://github.com/tianocore/edk2/settings/notifications


_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#121138): https://edk2.groups.io/g/devel/message/121138
Mute This Topic: https://groups.io/mt/111353434/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 5202 bytes --]