From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.57]) by mx.groups.io with SMTP id smtpd.web11.14847.1685716628011053145 for ; Fri, 02 Jun 2023 07:37:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=U0oKExH7; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.244.57, mailfrom: hong-chih.hsueh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ViZDTfqvjyytfEqT9cQ+tcrH+tn1Pd0vfrNTP4bPhhZICVIFTRQe0ejDqoU89qirkd9FoTMN1MjJjhQ7Bc96n+aGzyEmN+OjFqeQiKEBCqcI/nJeUo2Tw/iUZ0LQTvjlwIhi/GohUsJx0mEiKZoB0O5jFIsdUsgAv9ZtKO+i9zQ7Yrh1bAgNgh1CKkE7H0c2emsqol2GWnyiWmKz4HT2AVUnmmDSCdlxnj2xTCXwgOouKUcQTSFN3LH5pZKkQNJbhV8und8hxlntSeTsAZNGZa7BWRrqG59pQyjPHl++JdvYE4kbcies/Ijy5ppgn94cCDnwsJbkd3011AaotjOvVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t7JUs/HP2ox5NtSc7VqW5wxkwt/eV8FOYlowRahw2kU=; b=aRanrqxnhfg5HTGbX+00XKN3X1rT9/07ZkQRfGmzvYGn4ZhlLPk46Vo2l5GpSKJhCL41PSaekOVSzfYZfUi3WNw6T2H5A69m9snbUY/rvchoU/82Ssd5dlzpqJqAjyw9ZlqXzEAcm0zPrS6el9LdBbgTYe8XCfXmhqxjeMBA3nXxQdvAX4u5mj0GQ0u3CHpEqJUk6X/aeipuFvYZJq/zaIVO7MknOmc7wwxou+wsQMjV29AZDx4SHMUZV3nUfQPdZzciKA/Njhl2eMhVW2/vqmgDGlb5XMQZHr+wGC+TWe3+d0x5hmSeLyaAPZtcQ+z88zMfpc5AqBJ61K1T5wF+gQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t7JUs/HP2ox5NtSc7VqW5wxkwt/eV8FOYlowRahw2kU=; b=U0oKExH7uPcbZQHPTUO890nUEbUESyRqzQwD9BBU2T+ITlGNjhzNZVot2EaWZT4vc+bDokecBVYuuBAtdes8f1XU9hfNUAaQHBCkzUiNXd73tHLr70MUx0x+JcVDi49dTaUhXDQYwAZX81EoWoWGVGK9xNF+U/AT8yI992pi0tQ= Received: from DM4PR12MB5295.namprd12.prod.outlook.com (2603:10b6:5:39f::23) by IA0PR12MB7751.namprd12.prod.outlook.com (2603:10b6:208:430::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.24; Fri, 2 Jun 2023 14:37:05 +0000 Received: from DM4PR12MB5295.namprd12.prod.outlook.com ([fe80::37db:7696:555:f16c]) by DM4PR12MB5295.namprd12.prod.outlook.com ([fe80::37db:7696:555:f16c%6]) with mapi id 15.20.6455.024; Fri, 2 Jun 2023 14:37:04 +0000 From: hong-chih.hsueh@amd.com To: "Wu, Hao A" , "He, Jiangang" , "devel@edk2.groups.io" CC: "Chang, Abner" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Index: AQHZjZZaV7BbhnVZq0iPydyT7MTxHa9zxQ6AgAC9swCAAmLBgIAAvkib Date: Fri, 2 Jun 2023 14:37:04 +0000 Message-ID: References: <28f72c221f0c7f84e6d992b434565107cdb718b4.1684858126.git.Hong-Chih.Hsueh@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-06-02T14:37:06.463Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5295:EE_|IA0PR12MB7751:EE_ x-ms-office365-filtering-correlation-id: f6ae3ffc-0aed-450e-837a-08db6376d5db x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WmaAoZMHxRrqm1ArSh1cdtvbpSr8T0OeSEga234dxsRlLzQt/XJUZNe0zD/m/7R3ksOhprlWMeMGvjRdoPBWtIvm1HqvrX7PNHjWOdKFeUNqBnz4ogXz9W943V68qeVOEphpCqm69q1Qm/DkOD1FeV0FZ+D4aDDdtMPTlhkikGNpygr3xkqIG6qhuYZK4TwE9uHJpotRdw0Rb1KkKDc9YqIhMDst8RcSrSubWVNNKHK+uZ4RT8UYFygpr4HK5Se/PrJtBRvj/hDCXKDdpxm8lrUX7mijDRXD5JOuEfyW4zpBlVBeqXgue5NBpvWQGHFUaf/5TeR3uIluICgBfaPe8VIqlhyCOe+uPL24Bjwbq7zpIFllJAKqa9YD1YTcVOvWuvbrKX8xJ5qjNJYAQ+3G3+Zi7Mx0Q2LXqck0q5ltKBXoGTBT07TBFS5AhZMP+LlztcUs1GFnkf6rFoGM+PS0Q/PKLcB43gicB+EEPEFDiEWhvShxvDaLVIZtQR07/5pFh55XPi+w2PlViqv0EtVwJQeYLNq+/UfrMb1YoqaAhEW+bd+5WKRo+SZgkQRDaab29CBPYbpGtQ9MJCEUFMZY4IcMyB5zWaVMkOMomSPVCn0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5295.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(136003)(396003)(366004)(39860400002)(451199021)(2906002)(7696005)(83380400001)(316002)(41300700001)(38070700005)(53546011)(9686003)(26005)(186003)(6506007)(8676002)(8936002)(52536014)(33656002)(5660300002)(966005)(86362001)(55016003)(122000001)(38100700002)(110136005)(19627405001)(478600001)(4326008)(166002)(71200400001)(66899021)(66446008)(66946007)(64756008)(66556008)(66476007)(76116006)(91956017);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YcdkixNzJ/uDT7f51g7MKhIcrcOQq/yrtCnyH+fZVRTuHhUJyWQdc6BMGEw8?= =?us-ascii?Q?A9hxXJInaNWMRtcQB57ootR6bTmvkCSFitskVh/1nAg7Kpk3YOnh0RncDHTy?= =?us-ascii?Q?vygCmCLzJ+bREBw9et5xhVkrRpvak6ajtZw/+o/67WKsRdNGN0raRhJyErNB?= =?us-ascii?Q?Rat7yRWo4dC06UG+uuEtzUxXnYqoq7+VATWN+kiVFgFXfY2IzcNBjZcLJsgN?= =?us-ascii?Q?o/5mDoWZgZTCLmKUXcH9opErCQecG5WDyShcQKtq++4VExh2DF95yDh5YUm3?= =?us-ascii?Q?xPow+ED+ww//vnN0PjBLtzHwIy3LYIA4RDXjgNuqCsWXsF2lb89i0/W9OLvR?= =?us-ascii?Q?uTccsejW78Rscn3MA/VuytyobmNdaUnXFkxLeu1mt/XphIAMVcnxaoP8Uwxe?= =?us-ascii?Q?Qyqolak1R2XoKMAmle60xtLumEJOyA6hDs85tukYxtSWbPc4MMxO9HnknoYs?= =?us-ascii?Q?optDSEdh+4zlHp3rC3UZfypG40PsINJe11Kt52GwWcPx/oJeMcX7woIFyYEk?= =?us-ascii?Q?wK1NUs78QHyHuT5651kuRAPEL9p2VFvoLtyfAYCFZBgqYJdcBJN3UnE7VR8j?= =?us-ascii?Q?RR2stv88CwF66s9c7tbBDn38Nm+BiyanWYRhxYdVOTlu4mhnbtAD2IuvEL45?= =?us-ascii?Q?guMgZDz92yuVp7lbTuXuXLaUbFsGu9JXjb8waHHJ7LUCRBE324Nig41tcllz?= =?us-ascii?Q?fXmSvdizT9Jq3DBAK09XPF3l3sABeuYkoXS1S8c7kpunDEvd6Jesp7v051nZ?= =?us-ascii?Q?42puf75HIbe6gXg57h4mF0XeFHVtVGNqTBELT+aSDR2BWNwyOZCY6GaH1M06?= =?us-ascii?Q?f4d0iUh9rJrodhyGHC6la4feejUQYLn6vYxc6w1Y3LlojRG/HVFIuv7sCASS?= =?us-ascii?Q?hbIMDG98A0F3LJYXh7DPH5GYxffq6jvfDl4Y1xXVjhA5RlpkCXGJgc/L4dX3?= =?us-ascii?Q?YI3UqFG5/fOZf1tQfNmLVqSQH+jpjNpxsqdLI2/esDluJm7bQaH6G8hDUfnO?= =?us-ascii?Q?LB3+Ti/+b++5ZtMnaTdpPpOOhx/x4wTJA1K0Wjg1246paBoVorntooa0R2dN?= =?us-ascii?Q?EhGnX/VlktJbBaQNFMJOJozmTl/kOlkq3ldFiOzErqlFb1phqss+/Qr8YOKy?= =?us-ascii?Q?OIfVLNpozhte8GWM+XwC0kx15IKd1250EdJltAPbjhw67hBLM3tpx5bogLlg?= =?us-ascii?Q?T4gTscOaVqxAhHf9pZlo73nsVk3axPvpCGi1aZVL/Ko/YFEmj+jot3v044r2?= =?us-ascii?Q?pBFGLKDC4AwoUl8CnMxXjzjiB4cQg+IW18P2rWI/ZNa6IAPnXe84tnuhIr7V?= =?us-ascii?Q?EkBObuNWrMvzurWs1/VX95p1bWTufTbxEPVhg5wXEZqQMGZe6Tf7z/77TyYH?= =?us-ascii?Q?ibFCiLU6Xb6Gn20CRDlf5dORv9C2j+nXKZ8c988KVqEM9eGwPfqEhawUqrWv?= =?us-ascii?Q?ehOxLLv3u8B7TZH/tpaXLTaUBlHQdCPdtW5/TEivhHyxPDsmRBfoQL2jHlAz?= =?us-ascii?Q?K/+eAKw/avBnjIIfQ6V+bwCPQk2pOd0HqI2iexTQ1pDD1Ol9B74hrs24cvps?= =?us-ascii?Q?sOFFw2FsCMB2EBGJz04=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5295.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6ae3ffc-0aed-450e-837a-08db6376d5db X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2023 14:37:04.7834 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HMD8UdzM7J/mtOwPNDVABmTsJUm+SqrTo++7VYIH8BisGfjQkYNRBs9+gGB8d1PpkOxhnsoNITsDlBW6vcoAVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7751 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DM4PR12MB5295315E35E8CFF5F8EC3B01B94EADM4PR12MB5295namp_" --_000_DM4PR12MB5295315E35E8CFF5F8EC3B01B94EADM4PR12MB5295namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Hao, Thank you for your review. I already created a pull request for this commit, may I know how to proceed= to merge it into master? https://github.com/tianocore/edk2/pull/4424 Regards, Neo ________________________________ From: Wu, Hao A Sent: Thursday, June 1, 2023 10:14 PM To: He, Jiangang ; devel@edk2.groups.io ; Hsueh, Hong-Chih (Neo) Cc: Chang, Abner Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Thanks. Reviewed-by: Hao A Wu Best Regards, Hao Wu > -----Original Message----- > From: He, Jiangang > Sent: Wednesday, May 31, 2023 10:49 PM > To: Wu, Hao A ; devel@edk2.groups.io; Hsueh, Hong- > Chih (Neo) > Cc: Chang, Abner > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port = in > AhciPei PEIM > > [AMD Official Use Only - General] > > We did crisis recovery and Opal HD password unlock from S3 resume from > SATA HD test on two different version of AHCI host controllers. > > Thanks, > Jiangang > -----Original Message----- > From: Wu, Hao A > Sent: Tuesday, May 30, 2023 10:30 PM > To: devel@edk2.groups.io; Hsueh, Hong-Chih (Neo) Chih.Hsueh@amd.com> > Cc: He, Jiangang ; Chang, Abner > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port = in > AhciPei PEIM > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Thanks, the code changes look good to me. > May I know what tests have been performed for the patch? > > Best Regards, > Hao Wu > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Neo > > Hsueh via groups.io > > Sent: Wednesday, May 24, 2023 1:07 AM > > To: devel@edk2.groups.io > > Cc: jiangang.he@amd.com; abner.chang@amd.com; Neo Hsueh > Chih.Hsueh@amd.com> > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port > > in AhciPei PEIM > > > > If there is no port multiplier, PortMultiplierPort should be converted > > to 0 to follow AHCI spec. > > The same logic already applied in AtaAtapiPassThruDxe driver. > > > > Signed-off-by: Neo Hsueh > > --- > > MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > index cd55272c96..7bd04661d0 100644 > > --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > @@ -3,6 +3,7 @@ > > mode at PEI phase. > > > > Copyright (c) 2019, Intel Corporation. All rights reserved.
> > + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > > + reserved.
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @@ -92,6 +93,15 @@ AhciPassThruExecute ( { > > EFI_STATUS Status; > > > > + if (PortMultiplierPort =3D=3D 0xFFFF) { > > + // > > + // If there is no port multiplier, PortMultiplierPort will be 0xFF= FF > > + // according to UEFI spec. Here, we convert its value to 0 to foll= ow > > + // AHCI spec. > > + // > > + PortMultiplierPort =3D 0; > > + } > > + > > switch (Packet->Protocol) { > > case EFI_ATA_PASS_THRU_PROTOCOL_ATA_NON_DATA: > > Status =3D AhciNonDataTransfer ( > > -- > > 2.40.0.windows.1 > > > > > > > >=20 > > --_000_DM4PR12MB5295315E35E8CFF5F8EC3B01B94EADM4PR12MB5295namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - General]


Hi Hao,

Thank you for your review.

I already created a pull request for this commit, may I know how to proceed= to merge it into master?

https://github.com/tianocore/edk2/pull/4424


Regards,
Neo
From: Wu, Hao A <hao.a.w= u@intel.com>
Sent: Thursday, June 1, 2023 10:14 PM
To: He, Jiangang <Jiangang.He@amd.com>; devel@edk2.groups.io &= lt;devel@edk2.groups.io>; Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd= .com>
Cc: Chang, Abner <Abner.Chang@amd.com>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM
 
[AMD Official Use Only - General]

Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding.


Thanks.
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu

> -----Original Message-----
> From: He, Jiangang <Jiangang.He@amd.com>
> Sent: Wednesday, May 31, 2023 10:49 PM
> To: Wu, Hao A <hao.a.wu@intel.com>; devel@edk2.groups.io; Hsueh,= Hong-
> Chih (Neo) <Hong-Chih.Hsueh@amd.com>
> Cc: Chang, Abner <Abner.Chang@amd.com>
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier po= rt in
> AhciPei PEIM
>
> [AMD Official Use Only - General]
>
> We did crisis recovery and Opal HD password unlock from S3 resume from=
> SATA HD test on two different version of AHCI host controllers.
>
> Thanks,
> Jiangang
> -----Original Message-----
> From: Wu, Hao A <hao.a.wu@intel.com>
> Sent: Tuesday, May 30, 2023 10:30 PM
> To: devel@edk2.groups.io; Hsueh, Hong-Chih (Neo) <Hong-
> Chih.Hsueh@amd.com>
> Cc: He, Jiangang <Jiangang.He@amd.com>; Chang, Abner
> <Abner.Chang@amd.com>
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier po= rt in
> AhciPei PEIM
>
> Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding.
>
>
> Thanks, the code changes look good to me.
> May I know what tests have been performed for the patch?
>
> Best Regards,
> Hao Wu
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf= Of Neo
> > Hsueh via groups.io
> > Sent: Wednesday, May 24, 2023 1:07 AM
> > To: devel@edk2.groups.io
> > Cc: jiangang.he@amd.com; abner.chang@amd.com; Neo Hsueh <Hong-=
> > Chih.Hsueh@amd.com>
> > Subject: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier p= ort
> > in AhciPei PEIM
> >
> > If there is no port multiplier, PortMultiplierPort should be conv= erted
> > to 0 to follow AHCI spec.
> > The same logic already applied in AtaAtapiPassThruDxe driver.
> >
> > Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com>
> > ---
> >  MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 +++++++= +++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > index cd55272c96..7bd04661d0 100644
> > --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > @@ -3,6 +3,7 @@
> >    mode at PEI phase.
> >
> >    Copyright (c) 2019, Intel Corporation. All righ= ts reserved.<BR>
> > +  Copyright (C) 2023 Advanced Micro Devices, Inc. All right= s
> > + reserved.<BR>
> >
> >    SPDX-License-Identifier: BSD-2-Clause-Patent > >
> > @@ -92,6 +93,15 @@ AhciPassThruExecute (  {
> >    EFI_STATUS  Status;
> >
> > +  if (PortMultiplierPort =3D=3D 0xFFFF) {
> > +    //
> > +    // If there is no port multiplier, PortMultip= lierPort will be 0xFFFF
> > +    // according to UEFI spec. Here, we convert i= ts value to 0 to follow
> > +    // AHCI spec.
> > +    //
> > +    PortMultiplierPort =3D 0;
> > +  }
> > +
> >    switch (Packet->Protocol) {
> >      case EFI_ATA_PASS_THRU_PROTOCOL_ATA= _NON_DATA:
> >        Status =3D AhciNonDataT= ransfer (
> > --
> > 2.40.0.windows.1
> >
> >
> >
> >
> >

--_000_DM4PR12MB5295315E35E8CFF5F8EC3B01B94EADM4PR12MB5295namp_--