From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id D78D0AC15C8 for ; Tue, 30 Apr 2024 18:24:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=A1e2XhuMZiMDO79kpPW7E90NX7QF9TAwV8d2ht+EHb0=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1714501495; v=1; b=fMcn94NhuWBxSKjh/G/FogrfjrsnQiNhg2LKgb3QxALAoZQLwadI04JKpuIRD6vXlV03LFD/ 9nCu1I2mQiCqhYMgQn3YDL55G7OJtX0oHghzdOxy3Dpc+20j4uFE2OonVDm2hn8kDCxDRZC+zgu xPZXaFqABd5gwnhzlkp56yS8Wzjy102O/4ZSmuJraOTP2EdqV5C/XBSoif17QwUB3QBuG6dohWM X1R9ZdsFgsq097w0uRhdT7CHoSKRsIcnS8gPIKQLq/nIg6mvnz3Dl+edhtqAoSn08wOfZcYs8Ea QiOOAiwjsPXDGt2XPdle+f6C7m/vFgqcUO5Y5+5fRR3Ww== X-Received: by 127.0.0.2 with SMTP id uo4bYY7687511xapuIoeB3Z4; Tue, 30 Apr 2024 11:24:55 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.84]) by mx.groups.io with SMTP id smtpd.web11.23245.1714501494420584887 for ; Tue, 30 Apr 2024 11:24:54 -0700 X-Received: from DM4PR12MB5295.namprd12.prod.outlook.com (2603:10b6:5:39f::23) by SJ0PR12MB7008.namprd12.prod.outlook.com (2603:10b6:a03:486::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.36; Tue, 30 Apr 2024 18:24:50 +0000 X-Received: from DM4PR12MB5295.namprd12.prod.outlook.com ([fe80::ae1e:59d6:5c7b:7a97]) by DM4PR12MB5295.namprd12.prod.outlook.com ([fe80::ae1e:59d6:5c7b:7a97%7]) with mapi id 15.20.7519.035; Tue, 30 Apr 2024 18:24:50 +0000 From: "Hsueh, Hong-Chih (Neo) via groups.io" To: Laszlo Ersek , "devel@edk2.groups.io" , "ray.ni@intel.com" CC: "Ding, Feng (Sunnyvale)" , "He, Jiangang" , "Chang, Abner" , "gaoliming@byosoft.com.cn" Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug Thread-Topic: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug Thread-Index: AQHaZaw/OBiDqgpsQU6rqLQR8WQKTrEbGkMAgGZw/wQ= Date: Tue, 30 Apr 2024 18:24:49 +0000 Message-ID: References: <3a640aa0f5555ccc327588ef7bb8d4ba5941442d.1708619173.git.Hong-Chih.Hsueh@amd.com> In-Reply-To: Accept-Language: en-US X-Mentions: ray.ni@intel.com X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-04-30T18:24:48.911Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5295:EE_|SJ0PR12MB7008:EE_ x-ms-office365-filtering-correlation-id: e084c7df-3edb-4e6c-9ee5-08dc6942d27e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?iso-8859-1?Q?rtNSxHgfOog2Sk3oFsd8gtevQR3Na9imXjZLOk0oEFGyce9ixHFFKTlRFA?= =?iso-8859-1?Q?PJucB+4Hd+YYh410C7c+R/OLx0Bll9hr2sPCy7z4By6ahgwa3a3ocQCEgg?= =?iso-8859-1?Q?DXE4A8ufQSEtPB0X6kZlJ96jWIDiNRl+fNKg04NCJFDxao5S5Qw1o0PhW1?= =?iso-8859-1?Q?ztTFjOx+HRwmbRxk1tYSqHvOdoTKkGqRHxWWmNP4ncvamkSTwiU6VDZ6qO?= =?iso-8859-1?Q?RB7l6XPKtlmW1WbKj26yilJ4+60rI1qzFhkUk1BLN/gElxyasLdsGLMm0Q?= =?iso-8859-1?Q?PyvYgglVqH52JkfmiEkUE8gN8Zz97jxg9niMnF5HgTrATD+x1vu8j7+mxb?= =?iso-8859-1?Q?tVyd9utBrGFSd6J2a3SdyJ4mOLtD8PPHQuGU81/c2l/IKGVbkHgBbmIPaG?= =?iso-8859-1?Q?g9uCzSPtTYdcQh6CoRe/bGT4WIPZAf30wzucxzdMC7Vtsa4Bc99RTaPYAa?= =?iso-8859-1?Q?fEZA9RinubyB3nKmW/9Gwuj7DBhfMKGC+VmN1FCdGW+p7DUxxJU/f1NXZU?= =?iso-8859-1?Q?L0yFpOrnYo7dof1xxYYnBzmmPWrjq5VzF7L7pYrIWwT6yW0HNU1gOAFBwn?= =?iso-8859-1?Q?Tq4RLoHZRq++F+s+hT0rkPs4nLH89iZz1g7mH9HaMiw52nN1GQZ+k97s2n?= =?iso-8859-1?Q?m14bCc6LfLFpy4DzWvJk9esQPT351NxmCaqz4zfFa9a8mG4c0TtMTJzCLI?= =?iso-8859-1?Q?QHYVgYxUIX6RRt7SGpPDgGd6fMBZUKh2tctm6qT3tYmjpAwenQAXolPigb?= =?iso-8859-1?Q?UxUfVvmFcHhJlgcspiPZN51FdTCgMhHilLHwyNmUxFo23+wlDbJaDIWVny?= =?iso-8859-1?Q?/IKIs7pNKoo/txLEg3MGDWpx3y52DegW3353YHt4dySGD5dGVwk0Derjg9?= =?iso-8859-1?Q?Pakgyzx6b8uzS362iMq93o/gtyIQ++W9KukgZYwmS1ifL4ZE2jpxjtz4xr?= =?iso-8859-1?Q?jNcoeiM09dPO1ON1Ibb0SUz4hDCJJeoGrteV97zTkvbvvQ+SNPdXKQROmT?= =?iso-8859-1?Q?1XGCHryy7KWpRLVPk9EyQtyGDCMlQ/rZJRUsaWpzLXj3/W2ULjzA5JVV0o?= =?iso-8859-1?Q?Wt9BXPYeJf7468e1beCTizv1fomDjseBHI/zppSP6hXtikBmmwp8NQDEEp?= =?iso-8859-1?Q?E6iIz/VFEIeQFLsWWTOvpdwj1voT+S9Trwyb2fK/yCNLclSOe2oL2kGY2Q?= =?iso-8859-1?Q?3aKavCWPdWsD+0bBsZ9geTKhAkqNVRKP3RSZATjN9EIY4qU53+gaV+F2Bh?= =?iso-8859-1?Q?/cR41bytC38gl4QuUxpzbPkTtNtBuyY7caHc3xtPv19WnR/y3oSWvPRErs?= =?iso-8859-1?Q?fBxLwU9Nx546J6zwjdeDyvM8RnJguEwusq1at91QVjBGpCyKfQK/rkRzmN?= =?iso-8859-1?Q?0Q5DmUkGk8m0IFmtdSpkiDkgbyWtFLxw=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ROVOElUlwFtUjeuYt4rlhv2R6Cvoe86B9Q+TJ4nS4lO60lzkJ1Z184Igk7?= =?iso-8859-1?Q?7Bss+pwvvsJIV8DDdBdq0PBRsh3cb5lHkFItRKRefDe14rgQyE+j2eIi2n?= =?iso-8859-1?Q?bJ/+QLO+kkH4cPlh8kAdrOW2c4NtWC1y2HkwiWk/BLrp94IUJ0NL5+WHNw?= =?iso-8859-1?Q?JYB2Ean9CRhQ+C5/jg69g9bABiG66LC2l2ZmzJPFL4eWwdd9RSqT7it3bB?= =?iso-8859-1?Q?/Yn3kso+JPyP97h7mHuM/tNE+beyv6IxjcwWTJ6Uuk6Vv1PVVtlSimEigl?= =?iso-8859-1?Q?lk2vj4QAFZHUfkHzfQM0QOrZ1U4PLTkx+cBZa7dlf/DjbQLLaON9FcxRFW?= =?iso-8859-1?Q?/eN3EbvyJekcl7FE7ndDx3w4ekOaI7HTx+/eRPRXHh7Mhwg7ZDy4k98U9M?= =?iso-8859-1?Q?6JhNm0Mo6bsxodt4SqnTrcnA17veISEh7uXDzr6uSs6d81pWseJli+84NN?= =?iso-8859-1?Q?8AMmkUwJ//qsPV++QaodM0Qi8VQ9dLznJ77Ae4HaI7t7sHwirYfKugpIon?= =?iso-8859-1?Q?qvVYq24WUXf3fdLAeR4ma4KuUd1oAlAOWURaSMti8eidZJnWpGTT2hKmIl?= =?iso-8859-1?Q?Wz6i4zlkZrYcRDye4jYfuOhz4DdBKor+WycJGDSuf6ejuEAuBkDpZynPxB?= =?iso-8859-1?Q?1TEPosrk4qt4vJX4qUVGyEBlt0Z4y/SJs+L6vwEDuzHi+iTU867SUbsnf6?= =?iso-8859-1?Q?4eDHtLSrzeDdp5oK9sf0Endo6YSKSfFrpHtRIjdnpuX380W7tqT4nnoyAP?= =?iso-8859-1?Q?V5tUW+TL7op7BcG4bE3rb1B8gu/4psmzG6Xn5/lk6qDVMe0drJ8hISKLvl?= =?iso-8859-1?Q?+GKHyWQEkabck8JkZDucQ/daj3aw85HbIJ9wALsGQ2Pr6WoXrjPyu8HsBd?= =?iso-8859-1?Q?bpZNXfu9+WQZaCeRrXM45VpWsen6JYz/iDRt6/OS55RXrRc/ToWSy8WZNW?= =?iso-8859-1?Q?U1BfvcT1VC795IHk/PwGlLbK6W6VkHie/OCLNH/rtmiR81O5WKLePKgAhP?= =?iso-8859-1?Q?CljCTxcPI+IlxrQ0CTbnMYhJT9cHrhv2HtCh8Qn9JtFvgokef3UDCVLFFW?= =?iso-8859-1?Q?ouVwqJQSyRKCmlpdYDSwWn6lPXZbIl3jdDJ4LZcaD+X20p7+QPCx+kFGmu?= =?iso-8859-1?Q?y4xH2Zw30lroVxt2NMK/pU1rUqFEpCxIQWghy4Lk7wrW35NfdH9/uszNR5?= =?iso-8859-1?Q?Voo6U0ojvcZRvkifuzrdbPm3HLJceKKtgk3lnXb5Z0NNAzqtwJcDplk6wQ?= =?iso-8859-1?Q?qken5oN9VMqoprj+DqNfs6Xx/CI4PaEEdcJnONo2/lIxEdq/WVE6QoMc8F?= =?iso-8859-1?Q?eZJLVO1ncRbSfETIW6TzMfur0td78D3DY+k0JqLZ06NrlJUjeW/anYM69A?= =?iso-8859-1?Q?aAtCHkw7RTvo/Be35IFj617hcQV3DmCqmyOomNf4gRxIPkEnhoqV7qfOjt?= =?iso-8859-1?Q?vzeKXiMT39O1b3QIEgJM1ok4e7J/XW0Ds79HsLBBalfOhOCMJ27bkDzD2r?= =?iso-8859-1?Q?Y0ILEji5OLlmoygYhL9dB5Vv0LMmI5kdp993YDiXWRIWYJ/mHnZ9+BsAnW?= =?iso-8859-1?Q?jJwQmMIB+HCLP5EaCP4eHj8w7sg/vwO9a4/rSc0z7uj/o5mJBDhW2rBJR5?= =?iso-8859-1?Q?7qGHjVvWEResI=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5295.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e084c7df-3edb-4e6c-9ee5-08dc6942d27e X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2024 18:24:49.9427 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WAtYcnu3AAgs1wGP2jN7p0oaljH/kwQVggSKJOeYWPUlLoXbhbEE184ZeHNjVmZQqHtC4yYuPLCL9GYNMWhUlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7008 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 30 Apr 2024 11:24:54 -0700 Resent-From: hong-chih.hsueh@amd.com Reply-To: devel@edk2.groups.io,hong-chih.hsueh@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: JVwT9xSi6InXxZVRrY8q7CeZx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DM4PR12MB52954E4384665127ADBFFBE9B91A2DM4PR12MB5295namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=fMcn94Nh; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_DM4PR12MB52954E4384665127ADBFFBE9B91A2DM4PR12MB5295namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi @ray.ni@intel.com, Sorry you bother you, may I have your feedback for this patch? If it looks good to you could you help to give me an R-b ? Thank you. Regards, Neo ________________________________ From: Laszlo Ersek Sent: Sunday, February 25, 2024 7:59 AM To: Hsueh, Hong-Chih (Neo) ; devel@edk2.groups.io = Cc: Ding, Feng (Sunnyvale) ; He, Jiangang ; Chang, Abner ; ray.ni@intel.com ; gaoliming@byosoft.com.cn Subject: Re: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak = upon bridge hot-unplug Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. On 2/22/24 17:28, Neo Hsueh wrote: > A USB4 or TBT bridge can be plugged or unplugged on USB4 port. The action= s require PciHotPlugRequestNotify to add a root bridge or remove a root bri= dge completely. > In the plug-unplug-plug scenerio, PciHotPlugRequestNotify will return wit= h no-action on second plug because bridge tree shows configured. > Destroy Pci Device Tree in function PciHotPlugRequestNotify for unplug ev= ent to fix this issue. > > Cc: Feng Ding > Cc: Jiangang He > Signed-off-by: Neo Hsueh > --- > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c b/MdeModulePk= g/Bus/Pci/PciBusDxe/PciEnumerator.c > index 3f8c6e6da7..2b7af60e0a 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c > @@ -2103,6 +2103,8 @@ PciHotPlugRequestNotify ( > } > } > > + DestroyPciDeviceTree (Bridge); > + > // > // End for > // This looks convincing to me, but I don't now nearly enough about PciBusDxe internals (resource management in particular) to confidently approve this patch. I can give an Acked-by: Laszlo Ersek but the patch should not be merged until Ray provides an R-b. Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118446): https://edk2.groups.io/g/devel/message/118446 Mute This Topic: https://groups.io/mt/104511503/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_DM4PR12MB52954E4384665127ADBFFBE9B91A2DM4PR12MB5295namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - General]


Hi @ray.ni@intel.com,

Sorry you bother you, may I have your feedback for this patch?
If it looks good to you could you help to give me an R-b ?

Thank you.

Regards,
Neo

From: Laszlo= Ersek <lersek@redhat.com>
Sent: Sunday, February 25, 2024 7:59 AM
To: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>; dev= el@edk2.groups.io <devel@edk2.groups.io>
Cc: Ding, Feng (Sunnyvale) <feng1.ding@amd.com>; He, Jian= gang <Jiangang.He@amd.com>; Chang, Abner <Abner.Chang@amd.com>;= ray.ni@intel.com <ray.ni@intel.com>; gaoliming@byosoft.com.cn <ga= oliming@byosoft.com.cn>
Subject: Re: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hie= rarchy leak upon bridge hot-unplug
 
Caution: This message originated from an Ex= ternal Source. Use proper caution when opening attachments, clicking links,= or responding.


On 2/22/24 17:28, Neo Hsueh wrote:
> A USB4 or TBT bridge can be plugged or unplugged on USB4 port. The act= ions require PciHotPlugRequestNotify to add a root bridge or remove a root = bridge completely.
> In the plug-unplug-plug scenerio, PciHotPlugRequestNotify will return = with no-action on second plug because bridge tree shows configured.
> Destroy Pci Device Tree in function PciHotPlugRequestNotify for unplug= event to fix this issue.
>
> Cc: Feng Ding <feng1.ding@amd.com>
> Cc: Jiangang He <jiangang.he@amd.com>
> Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com>
> ---
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c b/MdeModul= ePkg/Bus/Pci/PciBusDxe/PciEnumerator.c
> index 3f8c6e6da7..2b7af60e0a 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c
> @@ -2103,6 +2103,8 @@ PciHotPlugRequestNotify (
>        }
>      }
>
> +    DestroyPciDeviceTree (Bridge);
> +
>      //
>      // End for
>      //

This looks convincing to me, but I don't now nearly enough about
PciBusDxe internals (resource management in particular) to confidently
approve this patch. I can give an

Acked-by: Laszlo Ersek <lersek@redhat.com>

but the patch should not be merged until Ray provides an R-b.

Laszlo

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118446) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_DM4PR12MB52954E4384665127ADBFFBE9B91A2DM4PR12MB5295namp_--