From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web10.2751.1685729519466609106 for ; Fri, 02 Jun 2023 11:11:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=Frgdlesj; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.236.41, mailfrom: hong-chih.hsueh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=McfJ8M/xPANxn66z7+sBRXzqAuf7TUUwP+QR3wPFFy9/rPnvUtwDhwRx4G6+YhRDxG+Av0RtfS8M26NqeqyePgx1ymRIHM2/4Zrzc4yyABpQmQm6iufbBkAKA+rNLMlmKvJIkaDZjC1GBjBhgjpMHnzmFUZuzuJu/yXEQ+OX3Nb5oL78J7M4d1W8G774x/YW/TUiJiEBPqlgj5NgcIS/1w03/cEr9smmixeRlSuD7CB9hrS0IVHrtz2yuocY4WiqtJYOFPFWKZZRWZvZwr3I+QoFfsJH1SrKDlI5AZYVOkA59Wl+heYw+sn2scvdtJZCR9DKCCiWBeoy+KLBQasKiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nU6K5AF3b7WFlciDr21KVfMEz2VetYzM1Y/veWbXkPk=; b=CgqHCxyNYjR6se6YZqUckHMD7B5utiIyUKXRNSePGSHeT2GVIxYb8SSuRCIijPFOSta1VLD76osaZ+8wWHOwc8/dqDEUodOf95ITWa9bc90mz7Ng6hvZC0q+UNcdnd2lePZSpd/+GIGHe0/ZVl2Ukd6LcxI7AhAg3Nz1QWwXkHoqzG8PuUXwH0MB9dsM8RqQgS1lIicXOLM32I/B7x/Bwo3F0GYYnwjjh6Re5GWZxjV7oCoxkGo1KJe9Xjd72Dr0vrKBnxuovf1GfKhVBYSzaM97rYvhKQgishgH9w+lIKq0Ar5RcGAfOyMSXcb9UMTuYMJyfE0Lrldro2DfGEGMQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nU6K5AF3b7WFlciDr21KVfMEz2VetYzM1Y/veWbXkPk=; b=FrgdlesjcyhaOL81iUXzuGbTyfRfjn2IKDlaEHJTZlHAftUdiB4h1VtgUjmbC6ErYaD/f8qrF03tghAKf+C3NSANbrhHf/3CfTxJFUFKV2+OdlZa6MVdYyprEw3hygpnmYZPjIaLCnODQ3YUHxu9SD0xrDq4QYmHiCNZfJTm7VU= Received: from DM4PR12MB5295.namprd12.prod.outlook.com (2603:10b6:5:39f::23) by PH8PR12MB7328.namprd12.prod.outlook.com (2603:10b6:510:214::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.21; Fri, 2 Jun 2023 18:11:55 +0000 Received: from DM4PR12MB5295.namprd12.prod.outlook.com ([fe80::37db:7696:555:f16c]) by DM4PR12MB5295.namprd12.prod.outlook.com ([fe80::37db:7696:555:f16c%6]) with mapi id 15.20.6455.024; Fri, 2 Jun 2023 18:11:55 +0000 From: "Hsueh, Hong-Chih (Neo)" To: "Chang, Abner" , "Wu, Hao A" , "He, Jiangang" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Index: AQHZjZZaV7BbhnVZq0iPydyT7MTxHa9zxQ6AgAC9swCAAmLBgIAAvkibgAAgZICAABvTMg== Date: Fri, 2 Jun 2023 18:11:55 +0000 Message-ID: References: <28f72c221f0c7f84e6d992b434565107cdb718b4.1684858126.git.Hong-Chih.Hsueh@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-06-02T18:11:56.552Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR12MB5295:EE_|PH8PR12MB7328:EE_ x-ms-office365-filtering-correlation-id: f47de5b2-504b-4db7-5a54-08db6394d972 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2L7I+llmj7CponguTD2LszfONmVjHvk8rbukzKKyhx0Q8KmJBaXkSEcs9V6yBoCCmHFl5dMG0tV5q4knfHzgPscAFoeV3vNQdeZDE1NFEm5c+N8SAu5iZ4wXIMutD3dMcHMvNp78X43Xy+DvDbUL5wqwSBPM9tkdfR42JiUVvHpcKjZANnz5q3ji1R/R/mUnox91MGo1OBcBJeQjR6PS7v4HYI82WxAh8zg0OoEn+gDNZOdRSWU6tF135Vjanr0WHnD7HvYcdz0iRkFR6iF+q2jnXhxFi3MMTCWx7wS5k8saARzdoYyibNpU6JuEMWyQ3adgB8BTYgXitFRgrs/5GpXgTdwFZidpaSGWa1XePKHlNjUTgEK/L08npvdzW/90wcqN4MU+RV7o42+G4DukbOEEkP8oXoxx4VuGkY6b4X9/Y7jAS7K9Fvdc98yy4Hslk3rSmXfH6LYkkdw5w9Vt8UP5z7XOkbGmbliWFyF3HkKVoDyR8m5tBYtMUUn4+nvKn62Btbz941Ym3SYLDoQnQOjZgKxc5BLYyEFkzVBzr+McNCn48Gls1MYIJWv9hWciHJmvCSqkFTjtVwuRizK9jErUw/+UxiLE4Lpkv6qFqhEN9mru5aRIDI0PbWI3zAanf9ybtE194+68AR0VKzBpgg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5295.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(346002)(396003)(366004)(376002)(451199021)(66446008)(66946007)(53546011)(64756008)(66556008)(5660300002)(76116006)(7696005)(41300700001)(19627405001)(478600001)(8676002)(8936002)(52536014)(966005)(86362001)(33656002)(26005)(66899021)(71200400001)(316002)(6506007)(66476007)(110136005)(9686003)(186003)(38070700005)(83380400001)(2906002)(166002)(55016003)(38100700002)(122000001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?9lseWiLveffYKtfm45ZUmbFDIYvtG7ABzPL7M2e5PiLIQd05jSZXsfDV?= =?Windows-1252?Q?11BDj69SNHI5B1KVKKjCfFhSPJjojv+eTspXBTzjUsr1LAMUBpfL0/5F?= =?Windows-1252?Q?Pz69zF8ssylomIca2WOfVfrAgEn0lDAjIdEO7WimZ4eNWbkgP4gQXhPG?= =?Windows-1252?Q?tasBXD8ugNZm4D8A8IejrxhP0O0G1KeRefb6hltf6HqZOGiu3+5o39M1?= =?Windows-1252?Q?O8ahXs8Q8nTJWDXv4s+5qy3YwxcESeML4doWbWLVrSUm5JyrVjdymD09?= =?Windows-1252?Q?9NZV3GtRLm3KJLPNd8dGHLTmVgtHmJswIh/ZMGGriSUH+mDJB81olkba?= =?Windows-1252?Q?vbQ28rQKIrQHvZ0B7EPyi+MJCj9mOQYKZImm2ux8c55QpbJV3b3ToFyy?= =?Windows-1252?Q?x/tpeX9cevaH9bziZQSOvV9MncnPZdRiWtgCCrdZh/9ZcdxUFDguRyiG?= =?Windows-1252?Q?amNZclDAJOwHMPumiV4vK2qIWG7MAOcJRFQ+ojI1EEXk08Sosoe3aA2R?= =?Windows-1252?Q?8VJ2capn3wtyfkHKEPAirWRStk7uxrS/LgvzB26iplRqoC1t6KUZecIP?= =?Windows-1252?Q?gob7wdUMoBxGzDh05qjDwGlsB9k04zynwbtpXrb2AzvMtl/RruXLqxId?= =?Windows-1252?Q?gl8KTbTJAsCQ/i1442b3CAWRRMQmcoXkFTG5o6oyxLmF68+JYO6URCdV?= =?Windows-1252?Q?vMnHUb+zKTiInE5DwiNkUeR7o3rYK3a3Yg8YqTYdXSQ4Kh8Y1jNTyAWt?= =?Windows-1252?Q?B7SAoQqTaFl9lKsBA3pa54E67jkb5irW4KiU9aWnYNs1wNIW7F0bTN12?= =?Windows-1252?Q?TCRq35EKK6KAX/GvpdS1uSkeZt1lfOvKWaMmn0uTvA91r/RCpeKBG1zf?= =?Windows-1252?Q?3P2AW2sN+4nRDClX5T7+3aHXQj3uK6++AD0LKYZM4TWeKt7bR49WZBlh?= =?Windows-1252?Q?nYWfk7pJ9QpB7Uz6LgF8WD/bs0WoPEYoEx76fiEQQFTBopBRu2H6AbPc?= =?Windows-1252?Q?FNo7OD1khhSkJCz8SbrnruTzhzkr9+ZmzgpHJCyNQQR7z3zMQRhiqx+a?= =?Windows-1252?Q?K7yU9Dc/C0Mlve+qVf3yoQ0T1+U18LD0cKjArNoeDt0po9+kQsOnXG3D?= =?Windows-1252?Q?xvWgoGRIu3aMBr9/6sXdW7rGzelPXsBZ06+HPS+inkQdyZVSIXhFa46I?= =?Windows-1252?Q?HG896RsyBuf3/D2Xlq9JqG/6NNlHgjKifsMWwqL0SiEhziKX/1WreOXm?= =?Windows-1252?Q?FnNa15vR3grsH+SP1DWP1mKfm6mFvRHCZrJf5FuyiTLyESVSAQvyh17M?= =?Windows-1252?Q?8kDbVb03lVyWajqVsxESiwo4swbRKuSI8gkL07jp0LF5JTsM3k4IyWpV?= =?Windows-1252?Q?jc0ENBMOs5IvrpIBxj1GjDuGO2Uo3Ajulo0rRJ47xix4CfpuZnCvYQd3?= =?Windows-1252?Q?GVRD5wz+hf6wp9Fe5t2FCLd9NyEN2nJx53YOZCcjsi0SA+GIcCLSZjJ/?= =?Windows-1252?Q?X157QNSl8BPVO5czo1IzgT1XhPh2yZOyR/f2Gjxl3TehQ6tvF8XVR4O8?= =?Windows-1252?Q?g25unfnpshENhECaeRJQFd7Gc4w8OdExDNqeiOZ8Zjg2O7fdmx3J6Sa5?= =?Windows-1252?Q?IVJXtqXM0dcH8LZ9PRcYxB++aNt+IP0cikoHQhh46KmWw0v/jas6+Kba?= =?Windows-1252?Q?4TjGGTb5i8U=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5295.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f47de5b2-504b-4db7-5a54-08db6394d972 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2023 18:11:55.7250 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 58rpzebgHGVqHhR0C+eYZnMRflo7q/xVlff+gYhFJ+vpLpjE8Sh+HvtFPp09zHqkGcUDSoqfkNFLo3/Rx9GjrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7328 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DM4PR12MB52955514E3791082D390E4E3B94EADM4PR12MB5295namp_" --_000_DM4PR12MB52955514E3791082D390E4E3B94EADM4PR12MB5295namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Abner, Thank you for your feedback. I updated the commit and re-create the PR as b= elow: https://github.com/tianocore/edk2/pull/4471 Regards, Neo ________________________________ From: Chang, Abner Sent: Friday, June 2, 2023 11:31 AM To: Hsueh, Hong-Chih (Neo) ; Wu, Hao A ; He, Jiangang ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Hi Leo, Please add Hao=92s RB in the commit message below your signed-off-by, thus = we know this patch has been reviewed. I also suggest to update your commit subject to =93MdeModulePkg/Bus: Fix po= rt multiplier port in AhciPei PEIM=94. Please resend the PR with above updates, then Hao will add =93Push=94 label= to this PR once your change passed CI. Thanks Abner From: Hsueh, Hong-Chih (Neo) Sent: Friday, June 2, 2023 10:37 PM To: Wu, Hao A ; He, Jiangang ; dev= el@edk2.groups.io Cc: Chang, Abner Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Hi Hao, Thank you for your review. I already created a pull request for this commit, may I know how to proceed= to merge it into master? https://github.com/tianocore/edk2/pull/4424 Regards, Neo ________________________________ From: Wu, Hao A > Sent: Thursday, June 1, 2023 10:14 PM To: He, Jiangang >; devel@e= dk2.groups.io >; Hsueh, Hong-Chih (Neo) > Cc: Chang, Abner > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Thanks. Reviewed-by: Hao A Wu > Best Regards, Hao Wu > -----Original Message----- > From: He, Jiangang > > Sent: Wednesday, May 31, 2023 10:49 PM > To: Wu, Hao A >; devel@edk2= .groups.io; Hsueh, Hong- > Chih (Neo) > > Cc: Chang, Abner > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port = in > AhciPei PEIM > > [AMD Official Use Only - General] > > We did crisis recovery and Opal HD password unlock from S3 resume from > SATA HD test on two different version of AHCI host controllers. > > Thanks, > Jiangang > -----Original Message----- > From: Wu, Hao A > > Sent: Tuesday, May 30, 2023 10:30 PM > To: devel@edk2.groups.io; Hsueh, Hong-Chih (= Neo) Chih.Hsueh@amd.com> > Cc: He, Jiangang >; Chang= , Abner > > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port = in > AhciPei PEIM > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Thanks, the code changes look good to me. > May I know what tests have been performed for the patch? > > Best Regards, > Hao Wu > > > -----Original Message----- > > From: devel@edk2.groups.io > On Behalf Of Neo > > Hsueh via groups.io > > Sent: Wednesday, May 24, 2023 1:07 AM > > To: devel@edk2.groups.io > > Cc: jiangang.he@amd.com; abner.chang@amd.co= m; Neo Hsueh > Chih.Hsueh@amd.com> > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port > > in AhciPei PEIM > > > > If there is no port multiplier, PortMultiplierPort should be converted > > to 0 to follow AHCI spec. > > The same logic already applied in AtaAtapiPassThruDxe driver. > > > > Signed-off-by: Neo Hsueh > > > --- > > MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > index cd55272c96..7bd04661d0 100644 > > --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > @@ -3,6 +3,7 @@ > > mode at PEI phase. > > > > Copyright (c) 2019, Intel Corporation. All rights reserved.
> > + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > > + reserved.
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @@ -92,6 +93,15 @@ AhciPassThruExecute ( { > > EFI_STATUS Status; > > > > + if (PortMultiplierPort =3D=3D 0xFFFF) { > > + // > > + // If there is no port multiplier, PortMultiplierPort will be 0xFF= FF > > + // according to UEFI spec. Here, we convert its value to 0 to foll= ow > > + // AHCI spec. > > + // > > + PortMultiplierPort =3D 0; > > + } > > + > > switch (Packet->Protocol) { > > case EFI_ATA_PASS_THRU_PROTOCOL_ATA_NON_DATA: > > Status =3D AhciNonDataTransfer ( > > -- > > 2.40.0.windows.1 > > > > > > > >=20 > > --_000_DM4PR12MB52955514E3791082D390E4E3B94EADM4PR12MB5295namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - General]


Hi Abner,

Thank you for your feedback. I updated the commit and re-create the PR as b= elow:
https://github.com/tianocore/edk2/pull/4471

Regards,
Neo

From: Chang, Abner <= ;Abner.Chang@amd.com>
Sent: Friday, June 2, 2023 11:31 AM
To: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>; Wu, Hao = A <hao.a.wu@intel.com>; He, Jiangang <Jiangang.He@amd.com>; dev= el@edk2.groups.io <devel@edk2.groups.io>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM
 

[AMD Official Use Only - General]


Hi Leo,

Please add Hao=92s RB in the commit message below your signed-off-by, thus = we know this patch has been reviewed.

I also suggest to update your commit subject to =93MdeModulePkg/Bus:= Fix port multiplier port in AhciPei PEIM=94.

 

Please resend the PR with above updates, then Hao will add =93Push=94 label= to this PR once your change passed CI.

 

Thanks

Abner

 

 

 

From: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>
Sent: Friday, June 2, 2023 10:37 PM
To: Wu, Hao A <hao.a.wu@intel.com>; He, Jiangang <Jiangang.= He@amd.com>; devel@edk2.groups.io
Cc: Chang, Abner <Abner.Chang@amd.com>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

[AMD Official Use Only - General]

 

Hi Hao,

 

Thank you for your review.

 

I already created a pull req= uest for this commit, may I know how to proceed to merge it into master?

 

 

 

Regards,

Neo

From: Wu, Hao A <hao.a.wu@intel.com>
Sent: Thursday, June 1, 2023 10:14 PM
To: He, Jiangang <Jiangang.He@amd.com>= ; devel@edk2.groups.io <devel@edk2.groups.io&= gt;; Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd= .com>
Cc: Chang, Abner <Abner.Chang@amd.com>=
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

[AMD Official Use Only - General]

Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding.


Thanks.
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu

> -----Original Message-----
> From: He, Jiangang <Jiangang.He@amd.com>=
> Sent: Wednesday, May 31, 2023 10:49 PM
> To: Wu, Hao A <hao.a.wu@intel.com>; devel@edk2.groups.io; Hsueh, Hong-
> Chih (Neo) <Hong-Chih.Hsueh@amd.com>=
> Cc: Chang, Abner <Abner.Chang@amd.com><= br> > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier po= rt in
> AhciPei PEIM
>
> [AMD Official Use Only - General]
>
> We did crisis recovery and Opal HD password unlock from S3 resume from=
> SATA HD test on two different version of AHCI host controllers.
>
> Thanks,
> Jiangang
> -----Original Message-----
> From: Wu, Hao A <hao.a.wu@intel.com>
> Sent: Tuesday, May 30, 2023 10:30 PM
> To: devel@edk2.groups.io; Hsueh, Hong-Chih (Neo) <Hong-
> Chih.Hsueh@amd.com>
> Cc: He, Jiangang <Jiangang.He@amd.com>;= Chang, Abner
> <Abner.Chang@amd.com>
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier po= rt in
> AhciPei PEIM
>
> Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding.
>
>
> Thanks, the code changes look good to me.
> May I know what tests have been performed for the patch?
>
> Best Regards,
> Hao Wu
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io&= gt; On Behalf Of Neo
> > Hsueh via groups.io
> > Sent: Wednesday, May 24, 2023 1:07 AM
> > To: devel@edk2.groups.io
> > Cc: jiangang.he@amd.com; abner.chang@amd.com; Neo Hsueh <Hong-
> > Chih.Hsueh@amd.com>
> > Subject: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier p= ort
> > in AhciPei PEIM
> >
> > If there is no port multiplier, PortMultiplierPort should be conv= erted
> > to 0 to follow AHCI spec.
> > The same logic already applied in AtaAtapiPassThruDxe driver.
> >
> > Signed-off-by: Neo Hsueh <Hong-Chih.Hs= ueh@amd.com>
> > ---
> >  MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 +++++++= +++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > index cd55272c96..7bd04661d0 100644
> > --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > @@ -3,6 +3,7 @@
> >    mode at PEI phase.
> >
> >    Copyright (c) 2019, Intel Corporation. All righ= ts reserved.<BR>
> > +  Copyright (C) 2023 Advanced Micro Devices, Inc. All right= s
> > + reserved.<BR>
> >
> >    SPDX-License-Identifier: BSD-2-Clause-Patent > >
> > @@ -92,6 +93,15 @@ AhciPassThruExecute (  {
> >    EFI_STATUS  Status;
> >
> > +  if (PortMultiplierPort =3D=3D 0xFFFF) {
> > +    //
> > +    // If there is no port multiplier, PortMultip= lierPort will be 0xFFFF
> > +    // according to UEFI spec. Here, we convert i= ts value to 0 to follow
> > +    // AHCI spec.
> > +    //
> > +    PortMultiplierPort =3D 0;
> > +  }
> > +
> >    switch (Packet->Protocol) {
> >      case EFI_ATA_PASS_THRU_PROTOCOL_ATA= _NON_DATA:
> >        Status =3D AhciNonDataT= ransfer (
> > --
> > 2.40.0.windows.1
> >
> >
> >
> >
> >

--_000_DM4PR12MB52955514E3791082D390E4E3B94EADM4PR12MB5295namp_--