public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v1 1/1] .python/SpellCheck: Increase SpellCheck plugin max failures
@ 2020-04-09 21:30 Michael Kubacki
  2020-04-14  2:43 ` [edk2-devel] " Zhang, Shenglei
  2020-04-17 18:45 ` Sean
  0 siblings, 2 replies; 3+ messages in thread
From: Michael Kubacki @ 2020-04-09 21:30 UTC (permalink / raw)
  To: devel; +Cc: Bob Feng, Bret Barkelew, Liming Gao, Michael D Kinney,
	Sean Brogan

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2593

Increases the maximum number of failures in the SpellCheck plugin so
that more issues can be caught in a single pass.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 .pytool/Plugin/SpellCheck/cspell.base.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.pytool/Plugin/SpellCheck/cspell.base.yaml b/.pytool/Plugin/SpellCheck/cspell.base.yaml
index 5f4c174c77c0..aa15170c013c 100644
--- a/.pytool/Plugin/SpellCheck/cspell.base.yaml
+++ b/.pytool/Plugin/SpellCheck/cspell.base.yaml
@@ -22,6 +22,8 @@
     ],
     "minWordLength": 5,
     "allowCompoundWords": false,
+    "maxNumberOfProblems": 200,
+    "maxDuplicateProblems": 200,
     "ignoreWords": [
         "muchange"
     ],
-- 
2.16.3.windows.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [PATCH v1 1/1] .python/SpellCheck: Increase SpellCheck plugin max failures
  2020-04-09 21:30 [PATCH v1 1/1] .python/SpellCheck: Increase SpellCheck plugin max failures Michael Kubacki
@ 2020-04-14  2:43 ` Zhang, Shenglei
  2020-04-17 18:45 ` Sean
  1 sibling, 0 replies; 3+ messages in thread
From: Zhang, Shenglei @ 2020-04-14  2:43 UTC (permalink / raw)
  To: devel@edk2.groups.io, michael.kubacki@outlook.com
  Cc: Feng, Bob C, Bret Barkelew, Gao, Liming, Kinney, Michael D,
	Sean Brogan

Reviewed-by: Shenglei Zhang <shenglei.zhang@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael Kubacki
> Sent: Friday, April 10, 2020 5:31 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Gao, Liming <liming.gao@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan
> <sean.brogan@microsoft.com>
> Subject: [edk2-devel] [PATCH v1 1/1] .python/SpellCheck: Increase
> SpellCheck plugin max failures
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2593
> 
> Increases the maximum number of failures in the SpellCheck plugin so
> that more issues can be caught in a single pass.
> 
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  .pytool/Plugin/SpellCheck/cspell.base.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/.pytool/Plugin/SpellCheck/cspell.base.yaml
> b/.pytool/Plugin/SpellCheck/cspell.base.yaml
> index 5f4c174c77c0..aa15170c013c 100644
> --- a/.pytool/Plugin/SpellCheck/cspell.base.yaml
> +++ b/.pytool/Plugin/SpellCheck/cspell.base.yaml
> @@ -22,6 +22,8 @@
>      ],
>      "minWordLength": 5,
>      "allowCompoundWords": false,
> +    "maxNumberOfProblems": 200,
> +    "maxDuplicateProblems": 200,
>      "ignoreWords": [
>          "muchange"
>      ],
> --
> 2.16.3.windows.1
> 
> 
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [PATCH v1 1/1] .python/SpellCheck: Increase SpellCheck plugin max failures
  2020-04-09 21:30 [PATCH v1 1/1] .python/SpellCheck: Increase SpellCheck plugin max failures Michael Kubacki
  2020-04-14  2:43 ` [edk2-devel] " Zhang, Shenglei
@ 2020-04-17 18:45 ` Sean
  1 sibling, 0 replies; 3+ messages in thread
From: Sean @ 2020-04-17 18:45 UTC (permalink / raw)
  To: Michael Kubacki, devel

[-- Attachment #1: Type: text/plain, Size: 54 bytes --]

Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>

[-- Attachment #2: Type: text/html, Size: 104 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-17 18:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-09 21:30 [PATCH v1 1/1] .python/SpellCheck: Increase SpellCheck plugin max failures Michael Kubacki
2020-04-14  2:43 ` [edk2-devel] " Zhang, Shenglei
2020-04-17 18:45 ` Sean

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox