From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.92.20.66]) by mx.groups.io with SMTP id smtpd.web11.13865.1586452173859797623 for ; Thu, 09 Apr 2020 10:09:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@outlook.com header.s=selector1 header.b=cfu9MDNG; spf=pass (domain: outlook.com, ip: 40.92.20.66, mailfrom: michael.kubacki@outlook.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U62mQSFEt5o1Shy4IghGkbJtDzmu2SoPLyyaYei3g+SJUYRStZjf4yt5j3wbGTTBapPd91LcnTX4yFUiFlQYYBOVIzU45UCstiUy/cazcIsRs9IhHBAq+CPwJ+2Y7HouxCr+8DP2HfWicUqFZdU3r581LAWDXsxYAph1MJn0QlmvqGWkLAGqlrpT7Qzwob7zN8l652bA+exqJHyApLByvqba9zbo1OLptBVA6OxunqnsDMnOA5Ow+DmkTqtVuKDBzLi4ZkD5Iqu8OuL+/s2TZLouRXltnW4XCMfGizbdxOT1Yhw/v/2DTHw4RaI3pKGfKvuh34367YVmPHZoJFZXUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0p8rQVmCFGTYWsjIasAl15dvlsMxEhZSeTWyo3jGJgI=; b=BuhfpPD6Lk0LP7j1chcYRa4aQg7yVmU5oLftnS4r9yTa2MLrfLQ62LHCJntfEHnapPE7xrBXE9SmPAMWorslr1I15ytSEyhCMB57q2iVb3bdgcllFmAxld0XRSxuyW1cVgXKPNurzVX0RJnH5aO9X3FSgRb8KWWKpPWibbUFHPnoxeOoMphCPp+y03XnQl6ftfXvr6vuhYPe+ZcLEwaPaeqDw+hv8J4wcfhZ/d1OWwBm4L/btfLxD8+g13Dy0Mjxy+ciN7w0CwCQ44jHCRYXgELh5Bkft2AXDfoEpvTXyElVUgF2+gfMsNBLRn1rfwo1+AAkybdf2kgJCkNoc6zVmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=outlook.com; dmarc=pass action=none header.from=outlook.com; dkim=pass header.d=outlook.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0p8rQVmCFGTYWsjIasAl15dvlsMxEhZSeTWyo3jGJgI=; b=cfu9MDNGEzL4dYFi3bJ9n6q4NmbyxweJmcNtnhoxGDruVDPKUFqJEzXTG0EBsQ3pkGiR30yefdZYyRxxT8hDBfgvnxAGpqQRN5XBwgIDGMpyhgc0UqglUbhV2dhol9cRAEfJwoZumvkBQ0i5axQPBN8ZQT0pq7xlDzLTlobnVyVk3HPtWko4YxBHAs893A3SbnIGiZiX/avRI+1PS0VzFuI5NvtvZ5E52dDfVaZbUbdGZIiq+s8CbUF3KT/wGHJ3jyGXr7nPvbgZjLO71T1+BU8hLM+fRSpDW7lMt64mJkKMpvg8cwdz3ZE9jFDWCR9CemtbMQN+Qoi0PIKVf/Oa9A== Received: from BN8NAM11FT063.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4b::48) by BN8NAM11HT162.eop-nam11.prod.protection.outlook.com (2a01:111:e400:fc4b::481) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15; Thu, 9 Apr 2020 17:09:32 +0000 Received: from DM5PR07MB3435.namprd07.prod.outlook.com (2a01:111:e400:fc4b::43) by BN8NAM11FT063.mail.protection.outlook.com (2a01:111:e400:fc4b::366) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Thu, 9 Apr 2020 17:09:32 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:F68FF1FE93BF5567E14B3D99BBD55FACA1CBFE0F472549447182EDDAB79EDCAB;UpperCasedChecksum:9A9EBD4AD6995394765DEC905336506575A5A5E70E52109CC82959E9907FFF6E;SizeAsReceived:8289;Count:50 Received: from DM5PR07MB3435.namprd07.prod.outlook.com ([fe80::801e:fde0:da7d:191f]) by DM5PR07MB3435.namprd07.prod.outlook.com ([fe80::801e:fde0:da7d:191f%6]) with mapi id 15.20.2900.015; Thu, 9 Apr 2020 17:09:32 +0000 Subject: Re: [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI To: Laszlo Ersek , Leif Lindholm Cc: devel@edk2.groups.io, Ard Biesheuvel References: <20200408181327.4324-1-michael.kubacki@outlook.com> <20200409092345.GZ14075@vanye> <81bf053e-d35b-67a6-5869-73087b9fc857@redhat.com> From: "Michael Kubacki" Message-ID: Date: Thu, 9 Apr 2020 10:09:30 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 In-Reply-To: <81bf053e-d35b-67a6-5869-73087b9fc857@redhat.com> X-ClientProxiedBy: CO2PR18CA0049.namprd18.prod.outlook.com (2603:10b6:104:2::17) To DM5PR07MB3435.namprd07.prod.outlook.com (2603:10b6:4:67::14) Return-Path: michael.kubacki@outlook.com X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.124.238.121] (131.107.159.121) by CO2PR18CA0049.namprd18.prod.outlook.com (2603:10b6:104:2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.18 via Frontend Transport; Thu, 9 Apr 2020 17:09:31 +0000 X-Microsoft-Original-Message-ID: X-TMN: [C9H6NVerWeZnkDk5uLPSkmm/oSfko9RF0Q92+EyVxfg=] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 50 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: b442702e-e342-4cd2-fd13-08d7dca8c53c X-MS-TrafficTypeDiagnostic: BN8NAM11HT162: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GySBVoksqE6jh0cCJh71U7oOjBQKu1sOdqYS4nc+E0/peO9fSy3INaK8PnSqkzQYW1aBTcpa4hlLKnAAdiHG4q+Ipl1HfWXSbgitHNv6MonDb33mOj3rQYGqqQx3AvlHr8qFU918TuoepgS62Lyhu97zyUz72dK/lDYixP0KDmqK4EKvHI7v15DZveIVgA67TsTHXYPZ8yPKNIW8ut6mmvDQSkV5MZT7QskjnAX2UNA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR07MB3435.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901; X-MS-Exchange-AntiSpam-MessageData: pgYGgxFn0+tf/9/JFdXEoFykFLzuqF3mRmUexGN8Q0YFX90S5B0kUf0eycdqNJ+BzCWb9bSO2hEaKeGhBQoWiuWfaqtqTLIdfd8QfmN3NenCDH1h4qLe9GCPDvfmUmm1s2+SZqaNbktuxYVIFuoeHw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b442702e-e342-4cd2-fd13-08d7dca8c53c X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2020 17:09:32.0517 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8NAM11HT162 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Thanks for looking into this. I agree per case (c) that I should add my S-o-b. I will plan to add both mine and Sean's S-o-b in v2 of the series. Thanks, Michael On 4/9/2020 6:18 AM, Laszlo Ersek wrote: > On 04/09/20 11:23, Leif Lindholm wrote: >> On Thu, Apr 09, 2020 at 11:17:31 +0200, Laszlo Ersek wrote: >>> Hi Michael, >>> >>> On 04/08/20 20:13, michael.kubacki@outlook.com wrote: >>>> From: Sean Brogan >>>> >>>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 >>>> >>>> Add new Azure Pipeline definitions to build and run ArmVirtPkg with: >>>> * Ubuntu GCC5 >>>> Add PyTool based build of ArmVirtPkg >>>> Add extdep for managing the iasl dependency >>>> Add ArmVirtPkg.ci.yaml for Core CI >>>> Add README-pytools for details and instructions >>>> >>>> Cc: Laszlo Ersek >>>> Cc: Ard Biesheuvel >>>> Cc: Leif Lindholm >>>> Signed-off-by: Sean Brogan >>> >>> The commit message is missing your Signed-off-by. You can & should >>> keep Sean's of course, but since you are submitting it, I think yours >>> (too) is required, per "Developer Certificate of Origin" in >>> "Readme.md". >> >> Michael cannot attest for Sean's legal opinions about this >> contribution, only Sean can do that. > > Not so sure about that (see below), but here I'm not questioning that. > >> The attribution of authorship is already covered by the From: tag. > > Agreed. > > My point is that Michael is technically partaking in the contribution of > this patch, even if he's only forwarding (upstreaming) Sean's patch > verbatim. Therefore the language in "Readme.md" applies to him as a > contributor: > >> # Code Contributions >> To make a contribution to a TianoCore project, follow these steps. >> [...] >> 2. Your commit message must include your `Signed-off-by` signature >> [...] >> >> # Developer Certificate of Origin >> >> Your change description should use the standard format for a >> commit message, and must include your `Signed-off-by` signature. >> >> [...] >> >> By making a contribution to this project, I certify that: >> >> (a) The contribution was created in whole or in part by me and I >> have the right to submit it under the open source license >> indicated in the file; or >> >> (b) The contribution is based upon previous work that, to the best >> of my knowledge, is covered under an appropriate open source >> license and I have the right under that license to submit that >> work with modifications, whether created in whole or in part >> by me, under the same open source license (unless I am >> permitted to submit under a different license), as indicated >> in the file; or >> >> (c) The contribution was provided directly to me by some other >> person who certified (a), (b) or (c) and I have not modified >> it. >> >> [...] > > So, two points: > - under case (c), I do think Michael would attest for Sean's legal > opinions, > - even if it's not case (c) that applies, a Signed-off-by is needed from > Michael, for one of the other cases. > > The DCO that's included in "Readme.md" spells out the following goal (or > "spirit"): > >> In order to keep track of who did what, all patches contributed must >> include a statement that to the best of the contributor's knowledge >> they have the right to contribute it under the specified license. > > If we don't include an S-o-b from Michael on the patch, his > participation in the upstreaming of this code change will disappear > entirely. The Committer field will refer to the mergify bot, the Author > field will refer (correctly) to Sean, and the [f]act of Michael posting > the patch to the list will be lost from the git history. > > The one S-o-b that we could technically do without, IMO, is Sean's. > > Laszlo >