From: "Michael Kubacki" <michael.kubacki@outlook.com>
To: devel@edk2.groups.io
Cc: Chao Zhang <chao.b.zhang@intel.com>,
Dandan Bi <dandan.bi@intel.com>, Hao A Wu <hao.a.wu@intel.com>,
Jian J Wang <jian.j.wang@intel.com>,
Liming Gao <liming.gao@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Ray Ni <ray.ni@intel.com>,
Sean Brogan <sean.brogan@microsoft.com>
Subject: [PATCH v1 0/7] Add linked list iteration macros to BaseLib.h
Date: Thu, 9 Apr 2020 13:05:07 -0700 [thread overview]
Message-ID: <DM5PR07MB34355F0C3D2063545701A297E9C10@DM5PR07MB3435.namprd07.prod.outlook.com> (raw)
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1959
The macros EFI_LIST_FOR_EACH and EFI_LIST_FOR_EACH_SAFE have been
duplicated across several drivers such as:
* EhciPei
* EhciDxe
* HddPasswordDxe
* RamDiskDxe
* UfsPassThruDxe
* XhciDxe
These macros have proven useful and established a commonly used pattern
for linked list iteration.
This patch series consolidates the definitions to a single definition in
BaseLib.h so they are maintained alongside other pre-existing generic
linked list macros and functions.
Note: Another commonly used generic linked list macro is EFI_LIST_CONTAINER.
I'm considering consolidating that to BaseLib.h as well but that is not
done in this patch series since it satisfies a separate use case than the
iteration macros and the change can be made independently.
On a separate note, shallow threading might not work on this patch series
due to changes made by the SMTP server. Please bear with me while I am
investigating if this can be changed.
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Michael Kubacki (7):
MdePkg/BaseLib: Add linked list iteration macros
MdeModulePkg/EhciDxe: Use BaseLib linked list iteration macros
MdeModulePkg/EhciPei: Use BaseLib linked list iteration macros
MdeModulePkg/XhciDxe: Use BaseLib linked list iteration macros
MdeModulePkg/UfsPassThruDxe: Use BaseLib linked list iteration macros
MdeModulePkg/RamDiskDxe: Use BaseLib linked list iteration macros
SecurityPkg/HddPassword: Use BaseLib linked list iteration macros
MdeModulePkg/Bus/Pci/EhciDxe/EhciDebug.c | 3 ++-
MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c | 11 ++++----
MdeModulePkg/Bus/Pci/EhciDxe/EhciUrb.c | 5 ++--
MdeModulePkg/Bus/Pci/EhciPei/EhciSched.c | 3 ++-
MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c | 5 ++--
MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 9 ++++---
MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 3 ++-
MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 3 ++-
MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c | 3 ++-
MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c | 9 ++++---
MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskProtocol.c | 5 ++--
SecurityPkg/HddPassword/HddPasswordDxe.c | 13 +++++-----
MdeModulePkg/Bus/Pci/EhciDxe/Ehci.h | 15 +----------
MdeModulePkg/Bus/Pci/EhciPei/EhcPeim.h | 15 +----------
MdeModulePkg/Bus/Pci/XhciDxe/Xhci.h | 9 +------
MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.h | 9 +------
MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.h | 15 +----------
MdePkg/Include/Library/BaseLib.h | 27 ++++++++++++++++++++
SecurityPkg/HddPassword/HddPasswordDxe.h | 7 +----
19 files changed, 75 insertions(+), 94 deletions(-)
--
2.16.3.windows.1
next reply other threads:[~2020-04-09 20:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 20:05 Michael Kubacki [this message]
2020-04-10 1:43 ` [PATCH v1 0/7] Add linked list iteration macros to BaseLib.h Wu, Hao A
2020-04-10 1:48 ` Michael Kubacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR07MB34355F0C3D2063545701A297E9C10@DM5PR07MB3435.namprd07.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox