[edk2-platforms][PATCH v1 1/1] .gitignore: Match contents to edk2

[edk2-platforms][PATCH v1 1/1] .gitignore: Match contents to edk2

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

The .gitignore file is currently missing a few key items like the
Build directory. This change updates the contents to match the edk2
file for a similar experience on the two repos.

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 .gitignore | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/.gitignore b/.gitignore
index 58200d4d732e..1dd30c141066 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1 +1,7 @@
+Build/
+.DS_Store
+*_extdep/
+*.pyc
 __pycache__/
+tags/
+.vscode/
-- 
2.28.0.windows.1

回复: [edk2-platforms][PATCH v1 1/1] .gitignore: Match contents to edk2

[gaoliming]

Michael:
  Do you meet with the case that its output directory is generated into
edk2-platforms\Build?

Thanks
Liming
> -----邮件原件-----
> 发件人: michael.kubacki@outlook.com <michael.kubacki@outlook.com>
> 发送时间: 2020年10月27日 1:44
> 收件人: devel@edk2.groups.io
> 抄送: Leif Lindholm <leif@nuviainc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>;
> Liming Gao <gaoliming@byosoft.com.cn>
> 主题: [edk2-platforms][PATCH v1 1/1] .gitignore: Match contents to edk2
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> The .gitignore file is currently missing a few key items like the
> Build directory. This change updates the contents to match the edk2
> file for a similar experience on the two repos.
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  .gitignore | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 58200d4d732e..1dd30c141066 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -1 +1,7 @@
> +Build/
> +.DS_Store
> +*_extdep/
> +*.pyc
>  __pycache__/
> +tags/
> +.vscode/
> --
> 2.28.0.windows.1

Re: 回复: [edk2-platforms][PATCH v1 1/1] .gitignore: Match contents to edk2

[Michael Kubacki]

Hi Liming,

Sorry for the confusion. It appears I was doing a non-standard flow with 
a directory link that brought in the Build directory and looking at my 
directory later, I didn't see real harm in adding it to the file.

I am fine to remove it in a v2 if you'd like.

Thanks,
Michael

On 10/26/2020 11:24 PM, gaoliming wrote:
> Michael:
>    Do you meet with the case that its output directory is generated into
> edk2-platforms\Build?
> 
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: michael.kubacki@outlook.com <michael.kubacki@outlook.com>
>> 发送时间: 2020年10月27日 1:44
>> 收件人: devel@edk2.groups.io
>> 抄送: Leif Lindholm <leif@nuviainc.com>; Michael D Kinney
>> <michael.d.kinney@intel.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>;
>> Liming Gao <gaoliming@byosoft.com.cn>
>> 主题: [edk2-platforms][PATCH v1 1/1] .gitignore: Match contents to edk2
>>
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> The .gitignore file is currently missing a few key items like the
>> Build directory. This change updates the contents to match the edk2
>> file for a similar experience on the two repos.
>>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>> ---
>>   .gitignore | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/.gitignore b/.gitignore
>> index 58200d4d732e..1dd30c141066 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -1 +1,7 @@
>> +Build/
>> +.DS_Store
>> +*_extdep/
>> +*.pyc
>>   __pycache__/
>> +tags/
>> +.vscode/
>> --
>> 2.28.0.windows.1
> 
> 
> 

回复: [edk2-devel] 回复: [edk2-platforms][PATCH v1 1/1] .gitignore: Match contents to edk2

[gaoliming]

Michael:
  If no real usage case, I don't suggest to add Build into . gitignore.

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+66673+4905953+8761045@groups.io
> <bounce+27952+66673+4905953+8761045@groups.io> 代表 Michael
> Kubacki
> 发送时间: 2020年10月28日 7:02
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: 'Leif Lindholm' <leif@nuviainc.com>; 'Michael D Kinney'
> <michael.d.kinney@intel.com>; 'Ard Biesheuvel' <ard.biesheuvel@arm.com>
> 主题: Re: [edk2-devel] 回复: [edk2-platforms][PATCH v1 1/1] .gitignore:
> Match contents to edk2
> 
> Hi Liming,
> 
> Sorry for the confusion. It appears I was doing a non-standard flow with
> a directory link that brought in the Build directory and looking at my
> directory later, I didn't see real harm in adding it to the file.
> 
> I am fine to remove it in a v2 if you'd like.
> 
> Thanks,
> Michael
> 
> On 10/26/2020 11:24 PM, gaoliming wrote:
> > Michael:
> >    Do you meet with the case that its output directory is generated into
> > edk2-platforms\Build?
> >
> > Thanks
> > Liming
> >> -----邮件原件-----
> >> 发件人: michael.kubacki@outlook.com <michael.kubacki@outlook.com>
> >> 发送时间: 2020年10月27日 1:44
> >> 收件人: devel@edk2.groups.io
> >> 抄送: Leif Lindholm <leif@nuviainc.com>; Michael D Kinney
> >> <michael.d.kinney@intel.com>; Ard Biesheuvel
> <ard.biesheuvel@arm.com>;
> >> Liming Gao <gaoliming@byosoft.com.cn>
> >> 主题: [edk2-platforms][PATCH v1 1/1] .gitignore: Match contents to edk2
> >>
> >> From: Michael Kubacki <michael.kubacki@microsoft.com>
> >>
> >> The .gitignore file is currently missing a few key items like the
> >> Build directory. This change updates the contents to match the edk2
> >> file for a similar experience on the two repos.
> >>
> >> Cc: Leif Lindholm <leif@nuviainc.com>
> >> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> >> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> >> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> >> ---
> >>   .gitignore | 6 ++++++
> >>   1 file changed, 6 insertions(+)
> >>
> >> diff --git a/.gitignore b/.gitignore
> >> index 58200d4d732e..1dd30c141066 100644
> >> --- a/.gitignore
> >> +++ b/.gitignore
> >> @@ -1 +1,7 @@
> >> +Build/
> >> +.DS_Store
> >> +*_extdep/
> >> +*.pyc
> >>   __pycache__/
> >> +tags/
> >> +.vscode/
> >> --
> >> 2.28.0.windows.1
> >
> >
> >
> 
> 
> 
>