From: "RichardHo [何明忠]" <richardho@ami.com>
To: gaoliming <gaoliming@byosoft.com.cn>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "'Andrew Fish'" <afish@apple.com>,
"'Leif Lindholm'" <quic_llindhol@quicinc.com>,
"'Michael D Kinney'" <michael.d.kinney@intel.com>,
"'Michael Kubacki'" <michael.kubacki@microsoft.com>,
"'Leif Lindholm'" <leif@nuviainc.com>,
"'Zhiguang Liu'" <zhiguang.liu@intel.com>,
"'Hao A Wu'" <hao.a.wu@intel.com>, "'Ray Ni'" <ray.ni@intel.com>,
"TonyLo [羅金松]" <TonyLo@ami.com>,
"'Demeter, Miki'" <miki.demeter@intel.com>
Subject: Re: 回复: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support
Date: Fri, 2 Sep 2022 09:04:40 +0000 [thread overview]
Message-ID: <DM5PR10MB1660AD4C71D9AB3016BAAF05B07A9@DM5PR10MB1660.namprd10.prod.outlook.com> (raw)
In-Reply-To: <006e01d8bea3$d701dd80$85059880$@byosoft.com.cn>
[-- Attachment #1: Type: text/plain, Size: 10652 bytes --]
Hi Liming,
See the Binding.jpg that is NetworkCommon driver boot flow.
Below is NetworkCommon driver to do
#1 Install UNDI protocol
#2 Respond normal Cdb flag or attribute in UNDI API
#3 Provide device API hook if the device has specific command or setting.
Ex: UndiGetState routine in PxeFunciton.c. if device has provide the UsbEthUndiGetState routine. (Nic->UsbEth->UsbEthUndi.UsbEthUndiGetState != NULL)
It could to invoke the UsbEthUndiGetState to override original status or state.
Thanks,
Richard
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: 2022年9月2日 4:13 PM
To: RichardHo [何明忠] <RichardHo@ami.com>; devel@edk2.groups.io
Cc: 'Andrew Fish' <afish@apple.com>; 'Leif Lindholm' <quic_llindhol@quicinc.com>; 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Michael Kubacki' <michael.kubacki@microsoft.com>; 'Leif Lindholm' <leif@nuviainc.com>; 'Zhiguang Liu' <zhiguang.liu@intel.com>; 'Hao A Wu' <hao.a.wu@intel.com>; 'Ray Ni' <ray.ni@intel.com>; TonyLo [羅金松] <TonyLo@ami.com>; 'Demeter, Miki' <miki.demeter@intel.com>
Subject: 回复: [EXTERNAL] 回复: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support
Richard:
ReadMe introduces the module behavior. But, it doesn't provide the code design. So, I want to confirm whether NetworkCommon driver support PXE.
Thanks
Liming
> -----邮件原件-----
> 发件人: RichardHo [何明忠] <RichardHo@ami.com>
> 发送时间: 2022年9月1日 11:47
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: 'Andrew Fish' <afish@apple.com>; 'Leif Lindholm'
> <quic_llindhol@quicinc.com>; 'Michael D Kinney'
> <michael.d.kinney@intel.com>; 'Michael Kubacki'
> <michael.kubacki@microsoft.com>; 'Leif Lindholm' <leif@nuviainc.com>;
> 'Zhiguang Liu' <zhiguang.liu@intel.com>; 'Hao A Wu'
> <hao.a.wu@intel.com>; 'Ray Ni' <ray.ni@intel.com>; TonyLo [羅金松]
> <TonyLo@ami.com>; 'Demeter, Miki' <miki.demeter@intel.com>
> 主题: RE: [EXTERNAL] 回复: [edk2-devel] [PATCH] UsbNetworkPkg: add USB
> network devices support
>
> Hi Liming,
>
> Please see more information in ReadMe.md for your question.
>
> Thanks,
> Richard
>
>
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: 2022年8月31日 5:47 PM
> To: devel@edk2.groups.io; RichardHo [何明忠] <RichardHo@ami.com>
> Cc: 'Andrew Fish' <afish@apple.com>; 'Leif Lindholm'
> <quic_llindhol@quicinc.com>; 'Michael D Kinney'
> <michael.d.kinney@intel.com>; 'Michael Kubacki'
> <michael.kubacki@microsoft.com>; 'Leif Lindholm' <leif@nuviainc.com>;
> 'Zhiguang Liu' <zhiguang.liu@intel.com>; 'Hao A Wu'
> <hao.a.wu@intel.com>; 'Ray Ni' <ray.ni@intel.com>; TonyLo [羅金松]
> <TonyLo@ami.com>; 'Demeter, Miki' <miki.demeter@intel.com>
> Subject: [EXTERNAL] 回复: [edk2-devel] [PATCH] UsbNetworkPkg: add USB
> network devices support
>
>
> **CAUTION: The e-mail below is from an external source. Please
> exercise caution before opening attachments, clicking links, or
> following guidance.**
>
> Richard:
> Thanks for your contribution. This is new feature. Can you submit
> feature request to
> https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz
> il
> la.tianocore.org%2F&data=05%7C01%7Crichardho%40ami.com%7C5f95
> 0debbf01487623db08da8b35b846%7C27e97857e15f486cb58e86c2b3040f93
> %7C1%7C0%7C637975360096010785%7CUnknown%7CTWFpbGZsb3d8eyJW
> IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
> 3000%7C%7C%7C&sdata=zl%2F13Q5OOLBzRtb37HvG5j0i6x6fh%2BCIo
> 0fqkWnbaJU%3D&reserved=0? If you have no account in
> https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz
> il
> la.tianocore.org%2F&data=05%7C01%7Crichardho%40ami.com%7C5f95
> 0debbf01487623db08da8b35b846%7C27e97857e15f486cb58e86c2b3040f93
> %7C1%7C0%7C637975360096010785%7CUnknown%7CTWFpbGZsb3d8eyJW
> IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
> 3000%7C%7C%7C&sdata=zl%2F13Q5OOLBzRtb37HvG5j0i6x6fh%2BCIo
> 0fqkWnbaJU%3D&reserved=0, you can ask help for 'Demeter, Miki'
> <miki.
> demeter@intel.com>.
>
> For the code, what's the purpose of
> UsbNetworkPkg/NetworkCommon/PxeFunction.c? Does NetworkCommon support
> PXE?
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 RichardHo
> > [何明忠] via groups.io
> > 发送时间: 2022年8月31日 10:31
> > 收件人: devel@edk2.groups.io
> > 抄送: Andrew Fish <afish@apple.com>; Leif Lindholm
> > <quic_llindhol@quicinc.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Michael Kubacki
> > <michael.kubacki@microsoft.com>; Leif Lindholm <leif@nuviainc.com>;
> > Zhiguang Liu <zhiguang.liu@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>; Hao A Wu <hao.a.wu@intel.com>; Ray Ni
> > <ray.ni@intel.com>; TonyLo [羅金松] <TonyLo@ami.com>
> > 主题: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices
> > support
> >
> > UsbNetworkPkg provides network functions for USB ACM, USB NCM, and
> USB
> > RNDIS network device.
> >
> > Signed-off-by: Richard Ho <richardho@ami.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
> > Acked-by: Liming Gao <gaoliming@byosoft.com.cn>
> > Acked-by: Leif Lindholm <quic_llindhol@quicinc.com>
> > Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
> > Reviewed-by: Ray Ni <ray.ni@intel.com>
> > Reviewed-by: Tony Lo <tonylo@ami.com>
> > ---
> > UsbNetworkPkg/Config/UsbNetworkPkg.inc.dsc | 9 +
> > .../Config/UsbNetworkPkgComponentsDxe.inc.dsc | 20 +
> > .../Config/UsbNetworkPkgComponentsDxe.inc.fdf | 21 +
> > .../Config/UsbNetworkPkgDefines.inc.dsc | 23 +
> > .../Include/Protocol/UsbEthernetProtocol.h | 872 +++++++++
> > UsbNetworkPkg/NetworkCommon/ComponentName.c | 264 +++
> > UsbNetworkPkg/NetworkCommon/DriverBinding.c | 583 ++++++
> > UsbNetworkPkg/NetworkCommon/DriverBinding.h | 263 +++
> > UsbNetworkPkg/NetworkCommon/NetworkCommon.inf | 43 +
> > UsbNetworkPkg/NetworkCommon/PxeFunction.c | 1734
> > +++++++++++++++++
> > UsbNetworkPkg/ReadMe.md | 65 +
> > UsbNetworkPkg/ReleaseNotes.md | 11 +
> > UsbNetworkPkg/UsbCdcEcm/ComponentName.c | 170 ++
> > UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.c | 504 +++++
> > UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.h | 211 ++
> > UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.inf | 41 +
> > UsbNetworkPkg/UsbCdcEcm/UsbEcmFunction.c | 861 ++++++++
> > UsbNetworkPkg/UsbCdcNcm/ComponentName.c | 170 ++
> > UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.c | 508 +++++
> > UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h | 245 +++
> > UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.inf | 41 +
> > UsbNetworkPkg/UsbCdcNcm/UsbNcmFunction.c | 946
> +++++++++
> > UsbNetworkPkg/UsbNetworkPkg.dec | 32 +
> > UsbNetworkPkg/UsbRndis/ComponentName.c | 172 ++
> > UsbNetworkPkg/UsbRndis/UsbRndis.c | 848 ++++++++
> > UsbNetworkPkg/UsbRndis/UsbRndis.h | 569 ++++++
> > UsbNetworkPkg/UsbRndis/UsbRndis.inf | 41 +
> > UsbNetworkPkg/UsbRndis/UsbRndisFunction.c | 1587
> > +++++++++++++++
> > 28 files changed, 10854 insertions(+) create mode 100644
> > UsbNetworkPkg/Config/UsbNetworkPkg.inc.dsc
> > create mode 100644
> > UsbNetworkPkg/Config/UsbNetworkPkgComponentsDxe.inc.dsc
> > create mode 100644
> > UsbNetworkPkg/Config/UsbNetworkPkgComponentsDxe.inc.fdf
> > create mode 100644
> > UsbNetworkPkg/Config/UsbNetworkPkgDefines.inc.dsc
> > create mode 100644
> > UsbNetworkPkg/Include/Protocol/UsbEthernetProtocol.h
> > create mode 100644
> > UsbNetworkPkg/NetworkCommon/ComponentName.c
> > create mode 100644 UsbNetworkPkg/NetworkCommon/DriverBinding.c
> > create mode 100644 UsbNetworkPkg/NetworkCommon/DriverBinding.h
> > create mode 100644
> > UsbNetworkPkg/NetworkCommon/NetworkCommon.inf
> > create mode 100644 UsbNetworkPkg/NetworkCommon/PxeFunction.c
> > create mode 100644 UsbNetworkPkg/ReadMe.md create mode 100644
> > UsbNetworkPkg/ReleaseNotes.md create mode 100644
> > UsbNetworkPkg/UsbCdcEcm/ComponentName.c
> > create mode 100644 UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.c
> > create mode 100644 UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.h
> > create mode 100644 UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.inf
> > create mode 100644 UsbNetworkPkg/UsbCdcEcm/UsbEcmFunction.c
> > create mode 100644 UsbNetworkPkg/UsbCdcNcm/ComponentName.c
> > create mode 100644 UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.c
> > create mode 100644 UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h
> > create mode 100644 UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.inf
> > create mode 100644 UsbNetworkPkg/UsbCdcNcm/UsbNcmFunction.c
> > create mode 100644 UsbNetworkPkg/UsbNetworkPkg.dec create mode
> > 100644 UsbNetworkPkg/UsbRndis/ComponentName.c
> > create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.c create
> mode
> > 100644 UsbNetworkPkg/UsbRndis/UsbRndis.h create mode 100644
> > UsbNetworkPkg/UsbRndis/UsbRndis.inf
> > create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndisFunction.c
> >
> >
> >
>
>
>
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is
> intended to be read only by the individual or entity to whom it is
> addressed or by their designee. If the reader of this message is not
> the intended recipient, you are on notice that any distribution of
> this message, in any form, is strictly prohibited. Please promptly
> notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
[-- Attachment #2: Binding.png --]
[-- Type: image/png, Size: 10210 bytes --]
next prev parent reply other threads:[~2022-09-02 9:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 2:31 [PATCH] UsbNetworkPkg: add USB network devices support RichardHo [何明忠]
2022-08-31 2:55 ` Wu, Hao A
2022-08-31 9:46 ` 回复: [edk2-devel] " gaoliming
2022-09-01 3:46 ` RichardHo [何明忠]
2022-09-01 4:19 ` Chang, Abner
2022-09-02 8:13 ` 回复: [EXTERNAL] " gaoliming
2022-09-02 9:04 ` RichardHo [何明忠] [this message]
2022-08-31 12:15 ` Rebecca Cran
-- strict thread matches above, loose matches on Subject: below --
2022-09-02 5:24 RichardHo [何明忠]
2022-09-06 15:05 ` [edk2-devel] " Rebecca Cran
2022-09-07 5:31 ` RichardHo [何明忠]
2022-09-23 5:03 ` 回复: " gaoliming
2022-09-23 5:54 ` RichardHo [何明忠]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR10MB1660AD4C71D9AB3016BAAF05B07A9@DM5PR10MB1660.namprd10.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox