* [PATCH 3/3] MinPlatformPkg: Add a Lib for MinPlatformPkg.
@ 2020-12-16 8:47 Yanming Zhu
2020-12-17 0:37 ` [edk2-devel] " Chiu, Chasel
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yanming Zhu @ 2020-12-16 8:47 UTC (permalink / raw)
To: devel; +Cc: Liming Gao
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3036
MinDsdt is missing a LibraryClasses dependency for
MemoryAllocationLib,so I add it for this.
Cc:Chasel Chiu <chasel.chiu@intel.com>
Cc:Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc:Liming Gao <gaoliming@byosoft.com.cn>
Cc:Eric Dong <eric.dong@intel.com>
Signed-off-by: Yanming Zhu <zhuyanming@byosoft.com.cn>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
---
Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
index 1066f13c..3437bc48 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
+++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
@@ -31,6 +31,7 @@
UefiBootServicesTableLib
UefiRuntimeServicesTableLib
BaseMemoryLib
+ MemoryAllocationLib
[Protocols]
gEfiAcpiTableProtocolGuid ## CONSUMES
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 3/3] MinPlatformPkg: Add a Lib for MinPlatformPkg.
2020-12-16 8:47 [PATCH 3/3] MinPlatformPkg: Add a Lib for MinPlatformPkg Yanming Zhu
@ 2020-12-17 0:37 ` Chiu, Chasel
2020-12-19 3:21 ` Nate DeSimone
2021-01-20 0:20 ` Nate DeSimone
2 siblings, 0 replies; 4+ messages in thread
From: Chiu, Chasel @ 2020-12-17 0:37 UTC (permalink / raw)
To: devel@edk2.groups.io, zhuyanming@byosoft.com.cn; +Cc: Liming Gao
Change looks good, next time please use below subject for MinPlatform changes:
--subject-prefix="edk2-platforms: PATCH"
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yanming
> Zhu
> Sent: Wednesday, December 16, 2020 4:47 PM
> To: devel@edk2.groups.io
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [PATCH 3/3] MinPlatformPkg: Add a Lib for
> MinPlatformPkg.
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3036
>
> MinDsdt is missing a LibraryClasses dependency for MemoryAllocationLib,so I
> add it for this.
>
> Cc:Chasel Chiu <chasel.chiu@intel.com>
> Cc:Nate DeSimone <nathaniel.l.desimone@intel.com> Cc:Liming Gao
> <gaoliming@byosoft.com.cn> Cc:Eric Dong <eric.dong@intel.com>
>
> Signed-off-by: Yanming Zhu <zhuyanming@byosoft.com.cn>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> ---
> Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> index 1066f13c..3437bc48 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> @@ -31,6 +31,7 @@
> UefiBootServicesTableLib
> UefiRuntimeServicesTableLib
> BaseMemoryLib
> + MemoryAllocationLib
>
> [Protocols]
> gEfiAcpiTableProtocolGuid ## CONSUMES
> --
> 2.28.0.windows.1
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 3/3] MinPlatformPkg: Add a Lib for MinPlatformPkg.
2020-12-16 8:47 [PATCH 3/3] MinPlatformPkg: Add a Lib for MinPlatformPkg Yanming Zhu
2020-12-17 0:37 ` [edk2-devel] " Chiu, Chasel
@ 2020-12-19 3:21 ` Nate DeSimone
2021-01-20 0:20 ` Nate DeSimone
2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2020-12-19 3:21 UTC (permalink / raw)
To: devel@edk2.groups.io, zhuyanming@byosoft.com.cn; +Cc: Liming Gao
Hi Yanming,
As Chasel noted, I don't believe this is actually a part of a patch series, I believe it is a single patch. Please be careful to mark your patches correctly in the future.
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yanming
> Zhu
> Sent: Wednesday, December 16, 2020 12:47 AM
> To: devel@edk2.groups.io
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [PATCH 3/3] MinPlatformPkg: Add a Lib for
> MinPlatformPkg.
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3036
>
> MinDsdt is missing a LibraryClasses dependency for MemoryAllocationLib,so I
> add it for this.
>
> Cc:Chasel Chiu <chasel.chiu@intel.com>
> Cc:Nate DeSimone <nathaniel.l.desimone@intel.com> Cc:Liming Gao
> <gaoliming@byosoft.com.cn> Cc:Eric Dong <eric.dong@intel.com>
>
> Signed-off-by: Yanming Zhu <zhuyanming@byosoft.com.cn>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> ---
> Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> index 1066f13c..3437bc48 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> @@ -31,6 +31,7 @@
> UefiBootServicesTableLib
> UefiRuntimeServicesTableLib
> BaseMemoryLib
> + MemoryAllocationLib
>
> [Protocols]
> gEfiAcpiTableProtocolGuid ## CONSUMES
> --
> 2.28.0.windows.1
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 3/3] MinPlatformPkg: Add a Lib for MinPlatformPkg.
2020-12-16 8:47 [PATCH 3/3] MinPlatformPkg: Add a Lib for MinPlatformPkg Yanming Zhu
2020-12-17 0:37 ` [edk2-devel] " Chiu, Chasel
2020-12-19 3:21 ` Nate DeSimone
@ 2021-01-20 0:20 ` Nate DeSimone
2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2021-01-20 0:20 UTC (permalink / raw)
To: devel@edk2.groups.io, zhuyanming@byosoft.com.cn; +Cc: Liming Gao
Pushed: https://github.com/tianocore/edk2-platforms/commit/c6d565e
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yanming
> Zhu
> Sent: Wednesday, December 16, 2020 12:47 AM
> To: devel@edk2.groups.io
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [PATCH 3/3] MinPlatformPkg: Add a Lib for
> MinPlatformPkg.
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3036
>
> MinDsdt is missing a LibraryClasses dependency for MemoryAllocationLib,so I
> add it for this.
>
> Cc:Chasel Chiu <chasel.chiu@intel.com>
> Cc:Nate DeSimone <nathaniel.l.desimone@intel.com> Cc:Liming Gao
> <gaoliming@byosoft.com.cn> Cc:Eric Dong <eric.dong@intel.com>
>
> Signed-off-by: Yanming Zhu <zhuyanming@byosoft.com.cn>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> ---
> Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> index 1066f13c..3437bc48 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> @@ -31,6 +31,7 @@
> UefiBootServicesTableLib
> UefiRuntimeServicesTableLib
> BaseMemoryLib
> + MemoryAllocationLib
>
> [Protocols]
> gEfiAcpiTableProtocolGuid ## CONSUMES
> --
> 2.28.0.windows.1
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-20 0:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-16 8:47 [PATCH 3/3] MinPlatformPkg: Add a Lib for MinPlatformPkg Yanming Zhu
2020-12-17 0:37 ` [edk2-devel] " Chiu, Chasel
2020-12-19 3:21 ` Nate DeSimone
2021-01-20 0:20 ` Nate DeSimone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox