From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.28725.1613955997484794891 for ; Sun, 21 Feb 2021 17:06:37 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=c5C6UIuF; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: heng.luo@intel.com) IronPort-SDR: llHzd+7YAH6zcx9P4O01YuBbgelWehZLwY128ZWjaY2rLMiP/EA2Azs25McfUesHuw3WN4eStR S7RU/0czPOrA== X-IronPort-AV: E=McAfee;i="6000,8403,9902"; a="183577879" X-IronPort-AV: E=Sophos;i="5.81,195,1610438400"; d="scan'208";a="183577879" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2021 17:06:36 -0800 IronPort-SDR: C3Rt5VMNUrRi0H8YWZO/R/2yLwAPOipeCRW358Qkf6CXRYlPwvszHQP0BO1Os87yIbT0ePTVFa oyOXHQJqyDQQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,195,1610438400"; d="scan'208";a="402314581" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga008.jf.intel.com with ESMTP; 21 Feb 2021 17:06:36 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 21 Feb 2021 17:06:36 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 21 Feb 2021 17:06:36 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Sun, 21 Feb 2021 17:06:36 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Sun, 21 Feb 2021 17:06:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OnSZJwMHQD8CxMZdxutXan83y3+BNdRu0gO6LgksSoOeNRocj81TD6E+2H0pQ7Ovf5xVSb1ud8Wxnm7NEuepCg75omSgo51By5dAdERBvPlhlN5j3l9bUj0V8pLaS1tfVyk+XjNgDZKfdAG4DrL3bsvf+bAd/y4CYsXiIDI3kvzxrLY6N/bJ0oLOzNHIBAF/g9jci0aY8eC68TStC0bIpM9sVL3znAzRJ7+cP0DC6Kzjx0+9alDVd2bfYB3Qv0FELMMzHC73EpiLGWXujlC2akCv46YjveDd9NcI7byv+Q39f4ecq+ZYjgo+wU/LuuTici1c6xFV5GxtdYQR1MBUWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2NBUYASCzhptwNwAf45gUFTMnZI5kebGf80qwv5+nSI=; b=k84wvxz1uzTBSDuHNVjnHcNr/Vy30WUbatwGiaJ6D6wrD6XzjIoeiUV+fFkkiIVFwLx+xE5Bz+aHxtFSJc19/rjMSotaOxQ4JsAgYnHGxoG7HcaFKT1HizjE2zWrvXuyf4w/oZhtP9hZSgUqF78MFigwQINpJsEZbjPXJpH69IkHwevXPtu3oZp5tx0tMO/+4lV2cJx/zpH/xLgxX2HUpwOys0NP6gpDwLgHkmsD53E7rcSYNa+4J+hrkQYZwc4O0Mhjxsm7y3bzVjBp6Ez4t+rFOLroS5Vi6CdG2ky0sSE55qg9RUExBJNR8TDsgI5unQB7O8YqM7LRtNOoMoWyrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2NBUYASCzhptwNwAf45gUFTMnZI5kebGf80qwv5+nSI=; b=c5C6UIuFIIOJA1nqRvLu5ytwsg1gM3dLwvhTydgrtIIK+AP3gynIxlauzY9x5X+Fcegzt9G8Ps+X9wVwPxTk1QuWF1x+TbVR5fvMyT9CTDJt7ONDxaUAWJ+Uwh5BZ/DmGMku2P9nyF5rsw0tOAHiAIS1WYI5RLSFy2hpl89ij3E= Received: from DM5PR1101MB2362.namprd11.prod.outlook.com (2603:10b6:3:9d::16) by DM6PR11MB4330.namprd11.prod.outlook.com (2603:10b6:5:1dc::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.29; Mon, 22 Feb 2021 01:06:34 +0000 Received: from DM5PR1101MB2362.namprd11.prod.outlook.com ([fe80::755a:8a81:4583:1554]) by DM5PR1101MB2362.namprd11.prod.outlook.com ([fe80::755a:8a81:4583:1554%3]) with mapi id 15.20.3846.043; Mon, 22 Feb 2021 01:06:34 +0000 From: "Heng Luo" To: Takuto Naito , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" Subject: Re: [PATCH v2 1/2] TigerlakeOpenBoardPkg: Fix build errors with GCC5 Thread-Topic: [PATCH v2 1/2] TigerlakeOpenBoardPkg: Fix build errors with GCC5 Thread-Index: AQHXCGO1BfqDSggY70u+3MsPz3R28qpjWomg Date: Mon, 22 Feb 2021 01:06:34 +0000 Message-ID: References: <20210221151020.40242-1-naitaku@gmail.com> <20210221151020.40242-2-naitaku@gmail.com> In-Reply-To: <20210221151020.40242-2-naitaku@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a478789c-32b7-48e9-e399-08d8d6ce18e9 x-ms-traffictypediagnostic: DM6PR11MB4330: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: h3gkbjQHiE4EOIvDKjNJsc/ZzWYQn3iFC4cYS+M5wEEcWnqf/n5m4nkLY8o+khR2tA9Yf8uvmOE9K4CWJsApn6wHIeDvAAEkQdIeEGYnLySMoiqP/dvQQO1SisuaVI2J1JrYrwLbuMq3SPd7SitpcfyjqoRL8+0mYmr0vvNRaGeEhf/Rgw0d0ZCTReKU2KLy363TglmWOjGW8AozuY0eAXxlkmVkEV0gQIN5i3syr3i4fgbIT3s6vnWFvEl6g46bkoxrisn9a47H4CCMwgCv+JDTq01RYGrCrGmhtJ9nxrT44MLlrPTBpkCpDCAsLVuo1pP0pzosiryS+73dYR8YUUm6H2c+WU3wLxbSyMIzGNyw+um7GG84LNjnDobpW5CrGkrYAwHz+x9NVcL0OrNG+8Nm3OLfUl7fKlBSSrigR/jA4qE8YCv5M/keGe25aL+kzzO9LsY7Gyp9EGOqWgEmhirLZ8+lIOOs/FGD9VFFFK1fi6GW6eKGPCPjzl6dWGlgGZWlA8QD+BOWTDfPxASKS+ljn6vzYixSyjaHorto5ek4eFvC9A9/8ysxOPPEZI/tmlMZkoT1Mm1rInwpRIJPit+680UYS732vO4Is5IAuJw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR1101MB2362.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(366004)(396003)(376002)(346002)(136003)(478600001)(52536014)(110136005)(86362001)(83380400001)(33656002)(53546011)(5660300002)(966005)(316002)(54906003)(66556008)(66476007)(76116006)(186003)(26005)(4326008)(64756008)(66446008)(66946007)(2906002)(7696005)(71200400001)(8676002)(19627235002)(8936002)(9686003)(107886003)(6506007)(55016002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?KYaXdW9zLXMw1SqILOY3Vz9pCZb4HBGjUA3DNoTwSjtc5BRERnnDXu1H2iKF?= =?us-ascii?Q?BEGEYzZMQxQDaeVpxMzlaSH9uGqKHxwp/f/7YXc33h7RMoULH2ls5PEONx86?= =?us-ascii?Q?9c6wjEGTXRhGCKvGmZEmSl0gudkWUBkKn053Y+EyaGadyhAOVkBi77vowd0X?= =?us-ascii?Q?0JTNRs8d7kHRv39MoPqWqffXR3EIyeHoVyuOJYjnfD/GSnbzWwopo2/iH/1R?= =?us-ascii?Q?OHao4LiiHLp8xxFryML3lxCuqYoCLQvCV/m4LGCHEb4fRms60bs3BqqUnHxt?= =?us-ascii?Q?mOlozCRidDQQ/RRz67vuY40/mvoNTAuOWUbSvYDwpV0M+nGX6JSWHufBey8S?= =?us-ascii?Q?NANhSFu2BMt+pbq6VQhyLIqD9gk5QTRBTzvT+YBZOqR3xKHYgJkQKWGuHNOH?= =?us-ascii?Q?4aJJc2Dsl2qlLQzPjTICiYQ8FSLgk9ptGPicEDOKSr62N8owaLPgUJ7B4iKj?= =?us-ascii?Q?4fjv88rIW/dDwV2R7kkeA6WL2aclGYMG+QVdnVHNmFkdi5XUf8qE5NQYA2C9?= =?us-ascii?Q?xPrlFDh5iREudnCmUeVQafgJD6xlIp9A2f+bO2fsn3n6vY7bhnUWNFjPNAM9?= =?us-ascii?Q?MmcmL3WoGSruXiYWgItY0amo80ZPvSjqqfnD/UN9bgfKKMPQyrxCQWMZF1bS?= =?us-ascii?Q?1A9sqx9qFjrOFmFBW+uchxjuOPxfyhqKCS+9+eP/pAatwShNVnaIPQxAsMDv?= =?us-ascii?Q?WA7mUSRwshH6CMro6t11n2+Ct1Cb3FPJZuwUNtXbrjbDS4hJyWvUubUgC3Po?= =?us-ascii?Q?ZN5wg4W17TAE5pBFp8adP2Vwa6LXwdxKNPTDPXyaeDpQXpoQZhsOdrCdCUcH?= =?us-ascii?Q?DjiouYLaQTK07qNEwmiLvGLRDXYArArUvollcQdo0YHmERMyfF/gOw0I/fni?= =?us-ascii?Q?wPMRT4U2XDAnT0dvFtEERfHS3Cu4fcZHTPb82wbkdGZm2pRr6kFgWC3qQkoF?= =?us-ascii?Q?MDASL65Ht8vz81Cj6N+/+KhVMR7rS33O5vUhIIMyKHg81a+/hQY5OkKTtH7k?= =?us-ascii?Q?ggt8DBKqLLBnqXr+19KGaad2BUf932SOtg+0k8f/sd1LWvWf986V4C/vztBa?= =?us-ascii?Q?bPmbrV4KNT3a2N4KuEOTO8dkIkMcRfSVGejHsCaRt1djD5kvojKYAqUbDR5v?= =?us-ascii?Q?Q7QMVl2jFRw0ezlR0nrnnyFPKGTi5B11tYit7Tt7uINJ/bzUx19yqNVqN26C?= =?us-ascii?Q?In/EFnYri/zuKtEUXoNDhdDWbnmWjjy0H2oZDLyU27dK2QVB6UFmNKIsiwqo?= =?us-ascii?Q?AlmNnxZH9D9J/oi3HXqqh6yAf0VKXHX+GIpE9qi7oN/7KrchVRcTDXDc1aaX?= =?us-ascii?Q?z72SnmZk11a/TWDYBxX7bJLz?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2362.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a478789c-32b7-48e9-e399-08d8d6ce18e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2021 01:06:34.0984 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /ChCtwDer4u5KZNsTCzAiNZWLeHxHNcEHncJrau0aLxl5Nb7oYL5WFyBYBhLdvg5niarK0niNq0ToiqVa8BDqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4330 Return-Path: heng.luo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Heng Luo > -----Original Message----- > From: Takuto Naito > Sent: Sunday, February 21, 2021 11:10 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L ; Luo, Heng > Subject: [PATCH v2 1/2] TigerlakeOpenBoardPkg: Fix build errors with GCC5 >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3224 >=20 > - Fix the path of TigerLakeFspBinPkg > - Fix misuse of RETURN_ERROR > - Remove unused function CheckNationalSio. >=20 > Cc: Sai Chaganty > Cc: Nate DeSimone > Cc: Heng Luo > Signed-off-by: Takuto Naito > --- >=20 > Notes: > v2: > - Split the v1 patch into 2 patches, > One is for Platform/Intel/TigerlakeOpenBoardPkg, > another one is for edk2-platforms\Silicon\Intel\TigerlakeSiliconPkg= . >=20 > .../PeiFspPolicyInitLib.inf | 2 +- > .../BasePlatformHookLib/BasePlatformHookLib.c | 188 ------------------ > .../DxeSiliconPolicyUpdateLate.c | 2 +- > 3 files changed, 2 insertions(+), 190 deletions(-) >=20 > diff --git > a/Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyIni= tLi > b/PeiFspPolicyInitLib.inf > b/Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyIni= tLi > b/PeiFspPolicyInitLib.inf > index 9d85d855f5..708fbac08f 100644 > --- > a/Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyIni= tLi > b/PeiFspPolicyInitLib.inf > +++ > b/Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyIni= tLi > b/PeiFspPolicyInitLib.inf > @@ -52,7 +52,7 @@ > MdeModulePkg/MdeModulePkg.dec > IntelFsp2Pkg/IntelFsp2Pkg.dec > TigerlakeSiliconPkg/SiPkg.dec > - TigerLakeFspBinPkg/TigerLakeFspBinPkg.dec > + TigerLakeFspBinPkg/Client/TigerLakeFspBinPkg.dec > TigerlakeOpenBoardPkg/OpenBoardPkg.dec > UefiCpuPkg/UefiCpuPkg.dec > IntelSiliconPkg/IntelSiliconPkg.dec > diff --git > a/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/BasePl > atformHookLib.c > b/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/BasePl > atformHookLib.c > index 6209e50450..cc5337698b 100644 > --- > a/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/BasePl > atformHookLib.c > +++ > b/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/BasePl > atformHookLib.c > @@ -94,194 +94,6 @@ GLOBAL_REMOVE_IF_UNREFERENCED EFI_SIO_TABLE > mSioTableWinbond_x374[] =3D { > {0x30, 0x01} // Enable it with Activation bit > }; >=20 > -/** > - Detect if a National 393 SIO is docked. If yes, enable the docked SIO > - and its serial port, and disable the onboard serial port. > - > - @retval EFI_SUCCESS Operations performed successfully. > -**/ > -STATIC > -VOID > -CheckNationalSio ( > - VOID > - ) > -{ > - UINT8 Data8; > - > - // > - // Pc87393 access is through either (0x2e, 0x2f) or (0x4e, 0x4f). > - // We use (0x2e, 0x2f) which is determined by BADD default strapping > - // > - > - // > - // Read the Pc87393 signature > - // > - IoWrite8 (0x2e, 0x20); > - Data8 =3D IoRead8 (0x2f); > - > - if (Data8 =3D=3D 0xea) { > - // > - // Signature matches - National PC87393 SIO is docked > - // > - > - // > - // Enlarge the LPC decode scope to accommodate the Docking LPC Switc= h > - // Register (SIO_DOCKING_LPC_SWITCH_REGISTER_ADDRESS is allocated at > - // SIO_BASE_ADDRESS + 0x10) > - // > - PchLpcGenIoRangeSet ((FixedPcdGet16 (PcdSioBaseAddress) & > (UINT16)~0x7F), 0x20); > - > - // > - // Enable port switch > - // > - IoWrite8 (SIO_DOCKING_LPC_SWITCH_REGISTER_ADDRESS, 0x06); > - > - // > - // Turn on docking power > - // > - IoWrite8 (FixedPcdGet16 (PcdSioBaseAddress) + 0x0E, 0x8c); > - > - IoWrite8 (FixedPcdGet16 (PcdSioBaseAddress) + 0x0E, 0x9c); > - > - IoWrite8 (FixedPcdGet16 (PcdSioBaseAddress) + 0x0E, 0xBc); > - > - // > - // Enable port switch > - // > - IoWrite8 (SIO_DOCKING_LPC_SWITCH_REGISTER_ADDRESS, 0x7); > - > - // > - // GPIO setting > - // > - IoWrite8 (0x2e, 0x24); > - IoWrite8 (0x2f, 0x29); > - > - // > - // Enable chip clock > - // > - IoWrite8 (0x2e, 0x29); > - IoWrite8 (0x2f, 0x1e); > - > - > - // > - // Enable serial port > - // > - > - // > - // Select com1 > - // > - IoWrite8 (0x2e, 0x7); > - IoWrite8 (0x2f, 0x3); > - > - // > - // Base address: 0x3f8 > - // > - IoWrite8 (0x2e, 0x60); > - IoWrite8 (0x2f, 0x03); > - IoWrite8 (0x2e, 0x61); > - IoWrite8 (0x2f, 0xf8); > - > - // > - // Interrupt: 4 > - // > - IoWrite8 (0x2e, 0x70); > - IoWrite8 (0x2f, 0x04); > - > - // > - // Enable bank selection > - // > - IoWrite8 (0x2e, 0xf0); > - IoWrite8 (0x2f, 0x82); > - > - // > - // Activate > - // > - IoWrite8 (0x2e, 0x30); > - IoWrite8 (0x2f, 0x01); > - > - // > - // Disable onboard serial port > - // > - IoWrite8 (FixedPcdGet16 (PcdLpcSioConfigDefaultPort), 0x55); > - > - // > - // Power Down UARTs > - // > - IoWrite8 (PcdGet16 (PcdLpcSioIndexPort), 0x2); > - IoWrite8 (PcdGet16 (PcdLpcSioDataPort), 0x00); > - > - // > - // Dissable COM1 decode > - // > - IoWrite8 (PcdGet16 (PcdLpcSioIndexPort), 0x24); > - IoWrite8 (PcdGet16 (PcdLpcSioDataPort), 0); > - > - // > - // Disable COM2 decode > - // > - IoWrite8 (PcdGet16 (PcdLpcSioIndexPort), 0x25); > - IoWrite8 (PcdGet16 (PcdLpcSioDataPort), 0); > - > - // > - // Disable interrupt > - // > - IoWrite8 (PcdGet16 (PcdLpcSioIndexPort), 0x28); > - IoWrite8 (PcdGet16 (PcdLpcSioDataPort), 0x0); > - > - IoWrite8 (FixedPcdGet16 (PcdLpcSioConfigDefaultPort), 0xAA); > - > - // > - // Enable floppy > - // > - > - // > - // Select floppy > - // > - IoWrite8 (0x2e, 0x7); > - IoWrite8 (0x2f, 0x0); > - > - // > - // Base address: 0x3f0 > - // > - IoWrite8 (0x2e, 0x60); > - IoWrite8 (0x2f, 0x03); > - IoWrite8 (0x2e, 0x61); > - IoWrite8 (0x2f, 0xf0); > - > - // > - // Interrupt: 6 > - // > - IoWrite8 (0x2e, 0x70); > - IoWrite8 (0x2f, 0x06); > - > - // > - // DMA 2 > - // > - IoWrite8 (0x2e, 0x74); > - IoWrite8 (0x2f, 0x02); > - > - // > - // Activate > - // > - IoWrite8 (0x2e, 0x30); > - IoWrite8 (0x2f, 0x01); > - > - } else { > - > - // > - // No National pc87393 SIO is docked, turn off dock power and > - // disable port switch > - // > - // IoWrite8 (SIO_BASE_ADDRESS + 0x0E, 0xbf); > - // IoWrite8 (0x690, 0); > - > - // > - // If no National pc87393, just return > - // > - return ; > - } > -} > - > /** > Check whether the IT8628 SIO present on LPC. If yes, enable its serial p= orts >=20 > diff --git > a/Platform/Intel/TigerlakeOpenBoardPkg/Policy/Library/DxeSiliconPolicyUpd= at > eLib/DxeSiliconPolicyUpdateLate.c > b/Platform/Intel/TigerlakeOpenBoardPkg/Policy/Library/DxeSiliconPolicyUpd= at > eLib/DxeSiliconPolicyUpdateLate.c > index 2eee9958be..410a8d1073 100644 > --- > a/Platform/Intel/TigerlakeOpenBoardPkg/Policy/Library/DxeSiliconPolicyUpd= at > eLib/DxeSiliconPolicyUpdateLate.c > +++ > b/Platform/Intel/TigerlakeOpenBoardPkg/Policy/Library/DxeSiliconPolicyUpd= at > eLib/DxeSiliconPolicyUpdateLate.c > @@ -88,8 +88,8 @@ SiliconPolicyUpdateLate ( > // GOP Dxe Policy Initialization > // > Status =3D GopPolicyInitDxe (gImageHandle); > - RETURN_ERROR (Status); > DEBUG ((DEBUG_INFO, "GOP Dxe Policy Initialization done\n")); > + ASSERT_EFI_ERROR (Status); > } >=20 > return Policy; > -- > 2.30.1