From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web09.1671.1614133447952240272 for ; Tue, 23 Feb 2021 18:24:08 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=rTJd6cbo; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: heng.luo@intel.com) IronPort-SDR: BYeceYklk+ZkRlSO9P+11ZAC9SKPLorGbcF5slw8qJ8e8RDgIWogOwGWEAI4o6/nJb62wLw/rk z0P0NoPhNqlw== X-IronPort-AV: E=McAfee;i="6000,8403,9904"; a="185074929" X-IronPort-AV: E=Sophos;i="5.81,201,1610438400"; d="scan'208";a="185074929" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2021 18:24:07 -0800 IronPort-SDR: FBNedO5sfEpC6ZeQWtnU9EPcmZJZFJGvT/iX1T3lJ8cfwXB+hiEB5ApBowxNFMLDXT/RYgwqLA WRhdzsnY/tkA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,201,1610438400"; d="scan'208";a="431207086" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by FMSMGA003.fm.intel.com with ESMTP; 23 Feb 2021 18:24:06 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 23 Feb 2021 18:24:06 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 23 Feb 2021 18:24:06 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 23 Feb 2021 18:24:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H8obczmKsNBDtYV0jpzIeIus3HaHk3K8cT6/PsNGdE5IdNSW61Dm5ejDYHHBEzBStLLKZJEGSmksCXyOkhjb2/1gN+gH1gw4VBPaSLHKwN418AFMDfVPiLBa3mTupdvY0iEsaY39+3jpSuQrd68876vyXTJTbks4qcyexZqJ2MER6hy7Q2hSWPy2YWHWFw6s1vMwCXPKSiigkRmvRmZGiEAbRjUwMkr1DKPguC49ykvfxkTH/ZKQ0/pAH2w653XkCAN7ypJ8M7qyLcpL8z4iTwGjugUwdN66PG9eVa5mwdOIu3aGXC4U1SkP/cXJb1fcn+hHriK/kiEb3s0O3cxE8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8rIzFtCSSWJQKgtePfq5vlLzN3x2FuJVsucsX9x2IPg=; b=dqVkMbw9xEowCa9d+OkA4BdIqQsouKbE/QXh36afMO2AcGfvJ8s6ywbg7ziRT8w7RSpnBzxx+WnqRA/lUlb367uyVuGcsxjoyU1xIZX0H5J7g67CtRuWy4nkQN3oqewHsN/vukRzKURKPX7ZaBDoQ7llIulLa2mQP5sAwNslUIA45xIxAjBV7B0xjk4NzJtfd29Q/cQxhGDC+PjT30FCjEpRrkZ0YJmVY50g5slETGQhDhaKwlHMRPUe5dBcdIjTnWAi+Yfc8upmuNWRvGkVwCgakziddh9EaztZqSokKqRdJurF4ixCnFF6LCGEKBl1XQ5zHao9xiYQ5F0p65EerA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8rIzFtCSSWJQKgtePfq5vlLzN3x2FuJVsucsX9x2IPg=; b=rTJd6cboF3yRGpoMuE6IKOX0apwsIFOZcN4rK/qG6lHpXS2bt/2BJwTbMbGVD0faswQvj2HUzJ+nmlOhMDm8dcY8T6QMWY7tjkpbPge+QTXqbwO/uwl8kvvKM+1H17VcjPvx34Yatl9jU3bYkt7591UTczljlNhcNe4MyK5nY1w= Received: from DM5PR1101MB2362.namprd11.prod.outlook.com (2603:10b6:3:9d::16) by DM5PR11MB1322.namprd11.prod.outlook.com (2603:10b6:3:d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.33; Wed, 24 Feb 2021 02:24:05 +0000 Received: from DM5PR1101MB2362.namprd11.prod.outlook.com ([fe80::755a:8a81:4583:1554]) by DM5PR1101MB2362.namprd11.prod.outlook.com ([fe80::755a:8a81:4583:1554%3]) with mapi id 15.20.3846.048; Wed, 24 Feb 2021 02:24:05 +0000 From: "Heng Luo" To: "devel@edk2.groups.io" , "naitaku@gmail.com" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" Subject: Re: [edk2-devel] [PATCH edk2-platforms v1 1/2] TigerlakeSiliconPkg: Fix build error with GCC5 Thread-Topic: [edk2-devel] [PATCH edk2-platforms v1 1/2] TigerlakeSiliconPkg: Fix build error with GCC5 Thread-Index: AQHXCk3eBvNG1+VEtEuEmAcGO1vrdqpmk5Mg Date: Wed, 24 Feb 2021 02:24:05 +0000 Message-ID: References: <20210224013736.74815-1-naitaku@gmail.com> <20210224013736.74815-2-naitaku@gmail.com> In-Reply-To: <20210224013736.74815-2-naitaku@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 10e0becd-c062-446b-04a0-08d8d86b4203 x-ms-traffictypediagnostic: DM5PR11MB1322: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:628; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lwFedwkoj3hKikZTZX90h2IsBnJ4VYibSdqSuC6/VjtR3KYmcdJLs581PzyA4u2CnuljTTvv5YYEpuH/G8eqQXyDeOt8xL/tYETLb4/8KGV80tLtN6isnMn/Ixk40M7Bkaqk0Wxa94bhM/Tp+39e+rBHSqnc1blpNxa+Cr7p/G8pIY2ggoXqXE9xw66gnVK1JuoVspuDFc7sl+cDWhYgePeZKvvS78V37sMWLXKT0Kk0QPI+B8LSe8HU3DMrcsEfFC9FXR0f35DkDrL+Oquqp03Syqd6T8OVSaHOeEhRJo9NzzBWBQSmP18RrAAVjn8wxPyuP7QfP43ScyenDfL0vuEC3IRILFKNIZ6DZDPFPfEvTE23NUymkS9pm8ubbCQXZR3psXZdXpVby8aK1een/WKGM9KVgKXHV7fKi4pJiuLKZuphLtSPLAZun+9MTm6VGEI8NLK1VHqwd3cGyr37cZMjmCOp5Z8Qb0LicRBtl/cSTzmt6+FhVgLWFAK0oeTl2/QGgpPdINyhonvpuB3826FPqr6091/5szgyhccZilvLPjkVEkX/pyQC1LdAbhN2TymsFu+M1hhZwrlXm7QnDTI9ZRvx6GVwqfuIPLyknSA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR1101MB2362.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(396003)(346002)(366004)(136003)(376002)(86362001)(107886003)(4326008)(9686003)(8676002)(33656002)(53546011)(7696005)(6506007)(2906002)(71200400001)(478600001)(26005)(52536014)(316002)(186003)(66556008)(66946007)(64756008)(76116006)(110136005)(66446008)(54906003)(966005)(8936002)(66476007)(55016002)(83380400001)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?EM5KEAemViiMhZiXD4Ccx3ePqybeaJVc9N/HGVNb9NgmT6TFbMJm5NAD2X9P?= =?us-ascii?Q?jK0ENgX4Ibsts5jITsqDKa8veEivUKtYrRAmxqdwSeAYaNKboekFjDeMptWi?= =?us-ascii?Q?EVej4FwCs4HlCyPYYhzttzNq6mEmK4DusUi/1xMYBFGNcQDLBT7yZ4GSmmU1?= =?us-ascii?Q?z9izFYjhpxUlivqj9evugYX1fyofX6Ml32Z1V0w+xqDt+KguMsMjD0KSUePb?= =?us-ascii?Q?MUGTsc9WpxjhtitA75+3FhrV3jP0/mUllMMk5XI+uX79zyLKhrbdXbBFw6Q0?= =?us-ascii?Q?jCPLsPNxKjsr19cOAy7ANrZpvdV2fbwd/7MmF0vaZ7zzlPFyznjgVVrWwC2l?= =?us-ascii?Q?rg10NuHC6KMK3aq9+nadbJyh6NPOyDHa+1I7Vc0at7pDcEFQGS5rTDeHqAuh?= =?us-ascii?Q?a3IZMog8ufaF4bcYnTcpCPCvyzjhEFR07JeRiHtMEsFOW9xxuWMhQDXKFSr+?= =?us-ascii?Q?XuCrZzgoDj+sff0ZsDJ2B9ICKHOKui647ZsHgIq9G2GmYUQjdATPaNcbKrDC?= =?us-ascii?Q?c+MS/Lmr1c3OIvq+uPzHnz4u6eGheVzaDXi1CBuJPMRScm5TOdNTaadxXZ/d?= =?us-ascii?Q?uBdlIw6qQGyyJRJZQ1oWJA465ZYfYlxlIk24DdMpG5tsnlnXfpqQevI+DHu+?= =?us-ascii?Q?Z5F5sbJVYDqlyF43we3pox616j1MabJGQg1PHuz8twIOCt9J/qTiX+ck5rQT?= =?us-ascii?Q?KYp77dg8EyYAQHQkV+RJEPo/UQ25x2Fas5xjPQxl1TP6Syx4BUAjtfhShglr?= =?us-ascii?Q?ByZa+Grk/KMBqj6dV72POW7RhD/zGDIddu/afhq8KFcngb9DAOZijXgS1/UF?= =?us-ascii?Q?PDBhWy5xTZljPS8o1LE4xeYgpr5MOhFSatC/WOooXv08Hmsx1+ObtknknwsM?= =?us-ascii?Q?7qQl2ZV+xXqwPyiViXZBrEiK6YKqok4GyK5kJk27KSse6BnrXNqXngc26iof?= =?us-ascii?Q?ixd0hdDKqdiFANqQUEbzZhua6aEdrPlND0Zht8vE/qxeyOnmN5MXIhf4adsI?= =?us-ascii?Q?eAW67eq6QuQQyNE4xfeD4yXEpyTL4EX3XAkChkuggzVJmSesBmvcApDX2iPD?= =?us-ascii?Q?dLJIrA6ikxj50PyETRE0bOUmESMkJ2B8DRp5taJMo2oGYBWbrucQ2YwSPMeL?= =?us-ascii?Q?umcMbEUg9JXSulFFt7+GHwTov0Q/JvfOn87cw2XXfTX/ZDmZhJwY/9hvmvQ3?= =?us-ascii?Q?vZhtdV+d5auq3Z6fI+ZPwTRZ0drNDq6y9Cf3nsMLtpkqg1//n//dAFrHUqo/?= =?us-ascii?Q?Uykc4wVTfYb+GgFmJZWheKWHQVw9XYjXFs46jX2GnauURu8XFMZHnGfoW//J?= =?us-ascii?Q?z4Ren3gk+KXHbqQv7jpna6ab?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2362.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10e0becd-c062-446b-04a0-08d8d86b4203 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2021 02:24:05.2270 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cHL+c0p23lDupu6Abs0nTfg3MDJ5k5vNwAdeRxmYWa0NgeljpBheJx03ozhqTySikzhiAgIlZyYg2GUQPhFIlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1322 Return-Path: heng.luo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Heng Luo > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Takuto > Naito > Sent: Wednesday, February 24, 2021 9:38 AM > To: devel@edk2.groups.io > Cc: Takuto Naito ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > ; Luo, Heng > Subject: [edk2-devel] [PATCH edk2-platforms v1 1/2] TigerlakeSiliconPkg:= Fix > build error with GCC5 >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3224 >=20 > Fix build errors caused by "-Werror=3Dunused-but-set-variable" with GCC5= . > These build errors occur only with DEBUG target because > RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but > DEBUG_GCC5_X64_CC_FLAGS doesn't. >=20 > Cc: Sai Chaganty > Cc: Nate DeSimone > Cc: Heng Luo > Signed-off-by: Takuto Naito > --- > .../PcieRp/LibraryPrivate/PcieClientRpLib/PcieClientRpLib.c | 2 -- > .../IpBlock/Vtd/LibraryPrivate/DxeVtdInitLib/DxeVtdInitLib.c | 5 ----- > .../Pch/PchSmiDispatcher/Smm/PchSmiHelperClient.c | 2 -- > 3 files changed, 9 deletions(-) >=20 > diff --git > a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PcieCl= ientR > pLib/PcieClientRpLib.c > b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PcieCl= ientR > pLib/PcieClientRpLib.c > index 15d295a573..231cb367bc 100644 > --- > a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PcieCl= ientR > pLib/PcieClientRpLib.c > +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/Pc > +++ ieClientRpLib/PcieClientRpLib.c > @@ -104,12 +104,10 @@ ConfigureRpLtrOverride ( > UINT32 OvrEn; > UINT32 OvrVal; > BOOLEAN IsCpuPcie; > - UINT32 LtrCfgLock; >=20 > IsCpuPcie =3D FALSE; > OvrEn =3D 0; > OvrVal =3D 0; > - LtrCfgLock =3D 0; >=20 > if (DevNum =3D=3D SA_PEG0_DEV_NUM || DevNum =3D=3D SA_PEG3_DEV_NUM) { > IsCpuPcie =3D TRUE; > diff --git > a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/DxeVtdIni= tLib/ > DxeVtdInitLib.c > b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/DxeVtdIni= tLib/ > DxeVtdInitLib.c > index faac07c45d..e88abe550f 100644 > --- > a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/DxeVtdIni= tLib/ > DxeVtdInitLib.c > +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Vtd/LibraryPrivate/DxeVt > +++ dInitLib/DxeVtdInitLib.c > @@ -313,8 +313,6 @@ DmarTableUpdate ( > UINTN Offset; > UINTN StructureLen; > UINT64 McD0BaseAddress; > - UINT32 GttMmAdr; > - UINT64 McD2BaseAddress; > UINT16 IgdMode; > UINT16 GttMode; > UINT32 IgdMemSize; > @@ -381,9 +379,6 @@ DmarTableUpdate ( > GttMemSize =3D (1 << GttMode) * (1024) * (1024); > } >=20 > - McD2BaseAddress =3D PCI_SEGMENT_LIB_ADDRESS (SA_SEG_NUM, > IGD_BUS_NUM, IGD_DEV_NUM, IGD_FUN_NUM, 0); > - GttMmAdr =3D (PciSegmentRead32 (McD2BaseAddress + > R_SA_IGD_GTTMMADR)) & 0xFFFFFFF0; > - > DmarTable->RmrrIgd.RmrrHeader.ReservedMemoryRegionBaseAddress =3D > (PciSegmentRead32 (McD0BaseAddress + R_SA_BGSM) & ~(0x01)); > DmarTable->RmrrIgd.RmrrHeader.ReservedMemoryRegionLimitAddress =3D > DmarTable->RmrrIgd.RmrrHeader.ReservedMemoryRegionBaseAddress + > IgdMemSize + GttMemSize - 1; > DEBUG ((DEBUG_INFO, "RMRR Base address IGD %016lX\n", DmarTable- > >RmrrIgd.RmrrHeader.ReservedMemoryRegionBaseAddress)); > diff --git > a/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmiHelpe > rClient.c > b/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmiHelpe > rClient.c > index 7693e76683..3adc05ce89 100644 > --- > a/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmiHelpe > rClient.c > +++ b/Silicon/Intel/TigerlakeSiliconPkg/Pch/PchSmiDispatcher/Smm/PchSmiH > +++ elperClient.c > @@ -29,8 +29,6 @@ GetPcieRpNumber ( > OUT UINTN *RpNumber > ) > { > - UINT64 RpBase; > - RpBase =3D PCI_SEGMENT_LIB_ADDRESS (SA_SEG_NUM, SA_MC_BUS, RpDev, > RpFun, 0); > GetPchPcieRpNumber (RpDev, RpFun, RpNumber); } >=20 > -- > 2.30.1 >=20 >=20 >=20 >=20 >=20