From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web09.1674.1614133459259848912 for ; Tue, 23 Feb 2021 18:24:19 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=bbzIxRzZ; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: heng.luo@intel.com) IronPort-SDR: DbaONEeOOH28TXUkD/FSi7loe79RC4T+UTjTW+rIChOwHHBBq4pwn0bt+og6LM/1JHOgI/FP7E AYcYu2JstHQA== X-IronPort-AV: E=McAfee;i="6000,8403,9904"; a="185074969" X-IronPort-AV: E=Sophos;i="5.81,201,1610438400"; d="scan'208";a="185074969" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2021 18:24:18 -0800 IronPort-SDR: aXc/aYs2UUeoDu0zKh71+Fhso+57Wryl0A640YZvnpqy67DEmrlg7WFmy75CPtMkl3tVtLYXYS gox59qF+j+ig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,201,1610438400"; d="scan'208";a="431207141" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by FMSMGA003.fm.intel.com with ESMTP; 23 Feb 2021 18:24:18 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 23 Feb 2021 18:24:17 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 23 Feb 2021 18:24:17 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 23 Feb 2021 18:24:17 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 23 Feb 2021 18:24:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VhEIk2Ybg/eV1EvsB7UszaYuhPNaLMIfnOFC2mo0f7B7mCUVLwBFqOZOJaA70Lc8m8QaQKlr8ArKlJvtmmvB+GHgA/tHlkv5ZZZ+5bbFE67pNYS3i5Dd9rHSLMmeZEC/I3axjcs5ujN/scGhFxYGyBSNYfx6PzrzSm2nW4DFgc1oaUZhhw+SR+txZ83VUpDVwWu21quROjq595nAtbv+AXacEIQ5fznB0pMNzYWKRQStkJJgCeqMa5eM7VKrLQD0yfT0hygp0uD/W61ga9P/Yx5hgXJVxr7jShTKHp6ctSU2TBxkCv3/O0+XiDYBnH3PhtCtGf/YSbhjba/o3NPTaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZZLKKMLRhY9mfQO1aEry+3zvAbGJ49VfULPAQRi3Jb0=; b=Of1N9nfHCM5lY4KLmW1aJB85kmdbgtVetPjxDGTEMIPf1rxe8gV8dUPs/bOG8yY/6AQNqAZ4y1ErC3ZjOFaITdpgPR1Ec+47jq1QbEXXiuBhOSdWhYjKi917BYtopKrRtJKVRPHSFt+35AUa+BXjZE2DNNtNu+ZmdKXUCQXggbvaYmmXM0I8Nt8/xwkyYAJBs2HGWa5nsKSw2AlCVpT/GJKXpMK9YVwP5DqfNRUweS1mY7poc2AoUCQVRcjedDOKyhRMs19dcgzz/9FBurXdr2NGEgQ9NuuYQsJO/hbG+2epYUu6TlmeeUFy9b6KTWhN8oDIaWFvEX3ioO6sQpekFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZZLKKMLRhY9mfQO1aEry+3zvAbGJ49VfULPAQRi3Jb0=; b=bbzIxRzZQ0dcXRUyXmIcKg11KcdI+t8fB2WquQf34Nbo6HtbjIeieQFQ3uk1gZzKNxCuED/KXh0INONIQfwX98PYLAWLT7GeT2xa6oY8BCYZpIeVB+U48t6TatrtbI12xmEe27IKbJCd2ahlUUCciVOXS+G03iEV9mK0RL0U9Kk= Received: from DM5PR1101MB2362.namprd11.prod.outlook.com (2603:10b6:3:9d::16) by DM6PR11MB2553.namprd11.prod.outlook.com (2603:10b6:5:bf::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.29; Wed, 24 Feb 2021 02:24:16 +0000 Received: from DM5PR1101MB2362.namprd11.prod.outlook.com ([fe80::755a:8a81:4583:1554]) by DM5PR1101MB2362.namprd11.prod.outlook.com ([fe80::755a:8a81:4583:1554%3]) with mapi id 15.20.3846.048; Wed, 24 Feb 2021 02:24:16 +0000 From: "Heng Luo" To: "devel@edk2.groups.io" , "naitaku@gmail.com" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" Subject: Re: [edk2-devel] [PATCH edk2-platforms v1 2/2] TigerlakeOpenBoardPkg: Fix build error with GCC5 Thread-Topic: [edk2-devel] [PATCH edk2-platforms v1 2/2] TigerlakeOpenBoardPkg: Fix build error with GCC5 Thread-Index: AQHXCk3pW9V9kCXj6UioaIFKevs1Wqpmk6kw Date: Wed, 24 Feb 2021 02:24:15 +0000 Message-ID: References: <20210224013736.74815-1-naitaku@gmail.com> <20210224013736.74815-3-naitaku@gmail.com> In-Reply-To: <20210224013736.74815-3-naitaku@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c3cd1e86-1a8a-432b-3447-08d8d86b4874 x-ms-traffictypediagnostic: DM6PR11MB2553: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L3CvvwBCROUkEIjUt0nUjbeJX2r42qdohWvRRhbRF1jLyVtx+bb+FLFH87BBbBWi0JTMbAX8RoxKcTsVwkpKwzMMSJlfaBL3qYWB90L/2j0ar7hNPEmQgichRqS2a16IHOKINohWeXcdPgROFEjM2JJMnExtzV31s40b3T6fCSiByl2zEp/yYkcvyy7R+SqwR/3jXvwKf18NbdjwBWFtNVR1F+Q6XIJTAjrh25VqlAUHmRiFjglSYn2kwykjlTPgJjX3xeqWhX52lKCeXH9H8bw+9jZRLXMcHnmq/ZueXimL1xghb0rJhaWcM92rcLvgIujQ65FXj7nRxAKBBJDdv7HeDJi7CccqWDF4lcqWkwoiQTY6Rx0A8STq2aKH84VhiRyTpIFM2N+B45qKR+Z3Xp5CixxywXVN8wxDW3JgsVUJaKbNCKWcKj4HcKQiBR/9Vz/OZ3UeRmOoh+RAkKvkBmyL4gZz04Gw8Kt5X9T7Y/SrIDQhHMMIU5mIcD/J4qV8VauO8ccC9rdHMPC7ohPuLGtvn9fOOX/MyF8XCZlcjzEw6i+LZrfFkeFV3zVzjq2C3osBpKaQ6dRpGXhAkslzbj8sT3Yr6G6FafxzytmnkIs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR1101MB2362.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(376002)(346002)(396003)(39860400002)(136003)(478600001)(8936002)(19627235002)(66556008)(66476007)(86362001)(966005)(64756008)(66446008)(4326008)(5660300002)(52536014)(71200400001)(53546011)(76116006)(107886003)(26005)(6506007)(83380400001)(66946007)(186003)(110136005)(55016002)(7696005)(8676002)(9686003)(2906002)(54906003)(316002)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?laEvghryvnvt47FvIBna9rF9CZIEyZ4FgneK/1QJyYU8ceN+VZgkR+fw0Yft?= =?us-ascii?Q?FAwp59O02RdH6b5HFm2rlqDUUb7ZTTKiYP4BNKSpI6AzU/oVNABAij6xfHbj?= =?us-ascii?Q?kJ5lltY5B1ATOHLZMEM0OLJpzkTrEUJqi8h1Xf9FmwHo+FUJy0tXqsIx34XF?= =?us-ascii?Q?BOfjCHT9GEsuGwJU5KengVrJfXx1zyFMghIl3JUR5+BYloTJTSUQ6oQsK1f7?= =?us-ascii?Q?tjtjBmy30vbslW651EUmdfLWycLmlUpc2F6GobSFCikc5zbtugs90rzoc4qj?= =?us-ascii?Q?ic7L8K3q2vrN191jLs8jxkVQlryGoxCjfT96NhcMAFQUuGVj1hdGOqRAhldv?= =?us-ascii?Q?97sNbSgrscRkoL2+IwLNMDUS2KQeq/h1AZdp1JliUPDOE/g8zoLXitbpOHex?= =?us-ascii?Q?UavcoR7apeE92b/uPu3xG6NB64ic4zgNb5VQm7P047PpwW8yzlSkev9cT3yK?= =?us-ascii?Q?HjyTN48AejhfZTsweWZPGhfDdoPK0AbS+8gbVEvIg5wdlw+GDoNWU2VhPhPl?= =?us-ascii?Q?IyhexYAsvfN+SbTJRK+MWluNxt1c2oqFe9F9d8Z4DWgfJB3uDgL8FGdSENBs?= =?us-ascii?Q?g3RwUT+qxzdGOUlBjiEwqqYDH/p8zLIw1gEmcX3fJBeXSkOcEpC0MZ17fdej?= =?us-ascii?Q?WGlFpPTh+gfp+QwYsa3f1Z7B6m1dD7j5V3s9/+hXdL9FrBpDwhQJaLZusgJW?= =?us-ascii?Q?AIoYFV8C899/lHqJw0gWnNrCxJiua0AYYludc4/lV14ZP1+hhgf1hiRvSCea?= =?us-ascii?Q?zDPmMeIH72UHl8B/2ul+4UQfUlj1YOE5thnQx9hUpZqN09H6Li6yr0CuvAA7?= =?us-ascii?Q?MIUsDgXO3id5pRnbm1AU4Y9CmNbU/w/YzO847sv+l6D+m2WRZ5i1+noAfdco?= =?us-ascii?Q?vSNHripmtM1Cf1RHPs2tHHeXzHbVz9qtiF63/uvIAeXbRcuLwRaXQxLI5qRd?= =?us-ascii?Q?j1l7yqyU7tU/SF7aioOv1pYFEGVZ2UcNe1t19Rhb/ntpdWy87wJE/TSUXl6l?= =?us-ascii?Q?fJ2ekrB9U1OmZnYI2beepdGPtytgY5EIIdU49IaTys/OezGyvSWo1LAJxr/n?= =?us-ascii?Q?cOiqUY4Kkck8vEJdUENtlp+iVchaXYCW+guIYMQHVjtvmGTTabEzxbLTPwzF?= =?us-ascii?Q?nmnk1WatJXjpM6vvaqMxaqP8k5vYwZqcOEVK6o+Avu2grXu9kA5bhSp6HaCl?= =?us-ascii?Q?Vrk05CwdqdETiHhIoJPkuXaoXjiUoCxIbqnsVYuL9S0e0kOgJ9LbDiGp6iaH?= =?us-ascii?Q?FogYYdEjlBGDIPyVAkvQ1ZcW6zQXUjDH3pPEEkJNUvWOtd74/zabMbQLRGbo?= =?us-ascii?Q?QHNFikOmffJV/PcCUhWDhguZ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2362.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3cd1e86-1a8a-432b-3447-08d8d86b4874 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2021 02:24:16.0241 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yvR26H+1XgNKsrYFLYFRkSjNFXUVpAxw/qhu1+ZZXtP/whsupXCzJUIIBwmi67vMR+4w2/W0+pqgzRfAVXmiOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2553 Return-Path: heng.luo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Heng Luo > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Takuto > Naito > Sent: Wednesday, February 24, 2021 9:38 AM > To: devel@edk2.groups.io > Cc: Takuto Naito ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > ; Luo, Heng > Subject: [edk2-devel] [PATCH edk2-platforms v1 2/2] TigerlakeOpenBoardPk= g: > Fix build error with GCC5 >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3224 >=20 > Fix build errors caused by "-Werror=3Dunused-but-set-variable" with GCC5= . > These build errors occur only with DEBUG target because > RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but > DEBUG_GCC5_X64_CC_FLAGS doesn't. >=20 > Cc: Sai Chaganty > Cc: Nate DeSimone > Cc: Heng Luo > Signed-off-by: Takuto Naito > --- > .../Library/BasePlatformHookLib/BasePlatformHookLib.c | 8 -------- > .../Library/BoardInitLib/PeiTigerlakeURvpInitPreMemLib.c | 2 ++ > 2 files changed, 2 insertions(+), 8 deletions(-) >=20 > diff --git > a/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/Base > PlatformHookLib.c > b/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/Bas > ePlatformHookLib.c > index cc5337698b..0baee8795d 100644 > --- > a/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/Base > PlatformHookLib.c > +++ > b/Platform/Intel/TigerlakeOpenBoardPkg/Library/BasePlatformHookLib/B > +++ asePlatformHookLib.c > @@ -182,14 +182,6 @@ PlatformHookSerialPortInitialize ( > VOID > ) > { > - UINT16 IndexPort; > - UINT16 DataPort; > - UINT8 Index; > - > - IndexPort =3D 0; > - DataPort =3D 0; > - Index =3D 0; > - > // > // Enable I/O decoding for COM1(3F8h-3FFh), COM2(2F8h-2FFh), I/O port > 2Eh/2Fh, 4Eh/4Fh, 60h/64Fh and 62h/66h. > // > diff --git > a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/BoardInitLi > b/PeiTigerlakeURvpInitPreMemLib.c > b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/BoardInitLi > b/PeiTigerlakeURvpInitPreMemLib.c > index 2ad229c1cd..0bba41e6d4 100644 > --- > a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/BoardInitLi > b/PeiTigerlakeURvpInitPreMemLib.c > +++ > b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Library/BoardIn > +++ itLib/PeiTigerlakeURvpInitPreMemLib.c > @@ -393,6 +393,7 @@ TigerlakeURvpInitPreMem ( > /// Performing PlatformInitPreMemCallBack after PeiReadOnlyVariable2 = PPI > produced > /// > Status =3D PeiServicesNotifyPpi (&mPreMemNotifyList); > + ASSERT_EFI_ERROR (Status); >=20 > /// > /// After code reorangized, memorycallback will run because the PPI i= s > already @@ -400,6 +401,7 @@ TigerlakeURvpInitPreMem ( > /// done before. > /// > Status =3D PeiServicesNotifyPpi (&mMemDiscoveredNotifyList); > + ASSERT_EFI_ERROR (Status); >=20 > DEBUG ((DEBUG_INFO, "TigerlakeURvpInitPreMem End!\n")); >=20 > -- > 2.30.1 >=20 >=20 >=20 >=20 >=20