From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web09.46070.1640742776174580313 for ; Tue, 28 Dec 2021 17:52:57 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=gdNn1UMd; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: star.zeng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640742776; x=1672278776; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=30HaxOcNq8/3XcPN7JRrxONcoJwlrdoqLz7JHKDkyVw=; b=gdNn1UMdqMWOGX/7Lc00cpdjfxbTHJidBtbRTjr/3q4jWz8gjZ6+BDbZ pSWOQP+U7aQSFEFNlaF7K0Z82rpT3lyzYqFg2WWYwr4E+4gnAZa2CD+vu fmI982FjsMhZqjHSGL3DXMVXgI7atGDcclB+22wgAHCejaTJnAn8e1zhM 0H2MvxOkgUAD7NBOWivqN35R5G8wtDkehkuKMUJzpKvRRIGFT8Gu6lxwX NsOTe75HmZFtpOz2IJWLfq5F+WEtvLxDalSXHfQmyXCRaX07E6rwTDPqI RYO29GhQIZiN6w8i3EqJTEpXglWZ1CHENv/AKFQ3+tzpq8badJG3gK/S9 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10211"; a="228752140" X-IronPort-AV: E=Sophos;i="5.88,244,1635231600"; d="scan'208";a="228752140" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2021 17:52:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,244,1635231600"; d="scan'208";a="761243792" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 28 Dec 2021 17:52:54 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 28 Dec 2021 17:52:54 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 28 Dec 2021 17:52:53 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 28 Dec 2021 17:52:53 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 28 Dec 2021 17:52:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UQW8OwxFRPDG5+5FJFaAsYaZwjiGzMm2OkmWdfCIRRxjtiLw0z9zxC4FCC1pgCQXAeEr1ob4TqeIsgiJRCKt8BaRGwr9mwaKAMCGaAcpdWE7IkbxRWNZV8oqY324mg3xfvVdX1E3KD+6bUvOGvcIdhwhGIHNKVhZswHfTvIGyH2gcfrFeRSIwH6VgAhwHE5RaGRssOAEoCwOQUxk1uUUiG/FlOAhXYeTNyItwanvCfWqC5vLRkALKipjjycNn1lG/5klVWmMnQyzJBlf2Mpd7K3kd4vIMYOf4Z+W+m/0KtmWelPsJIMAcY1cqV2ipY+1xoI6vGgUbcXqq+utHCxAsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YUMKETucWKo3cWf4ILm9i0on9+y5LxlMg5bgwmTvKoU=; b=JpZf/7b0uqCX8CN89FKaOBjEQAo6iGMX9Htu7SRSnMxLse0pS/Tp/0WqKgQ8l2Ga4+fqWoWOUMbx9m0fg13iQ8/BVXbVebjaUA95j1rhsPv+JkJDl0sNGDL6x8xKcdLpODkf7xL3sp/+vy4y7/fE2S/2RW837OQiMmnQSmYekhDqiA67otE4aNlYLucFYOwIsPbjsa//wrpZR/02nAo19QeXBsZbVJV2JXDn2BC1KNFxw/1Y5PjbvCXRHhVg6ymco4zxm422f4q9ACA5A/XaHtJJEKuEWQDjREaWGJeoEiszuCwFU00TkBWw6rp2iiV5ZSFbpKNH7QVqkpqpJmhVjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1244.namprd11.prod.outlook.com (2603:10b6:3:13::7) by DM5PR11MB1787.namprd11.prod.outlook.com (2603:10b6:3:112::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.21; Wed, 29 Dec 2021 01:52:52 +0000 Received: from DM5PR11MB1244.namprd11.prod.outlook.com ([fe80::cc3:8a67:455a:c06f]) by DM5PR11MB1244.namprd11.prod.outlook.com ([fe80::cc3:8a67:455a:c06f%7]) with mapi id 15.20.4823.023; Wed, 29 Dec 2021 01:52:52 +0000 From: "Zeng, Star" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [PATCH] IntelFsp2Pkg/FspSecCore: ExtendedImageRevision was not printed. Thread-Topic: [PATCH] IntelFsp2Pkg/FspSecCore: ExtendedImageRevision was not printed. Thread-Index: AQHX+9nLjGsE+qckmUignmjuvwb/nqxItcPw Date: Wed, 29 Dec 2021 01:52:52 +0000 Message-ID: References: <20211228105749.1934-1-chasel.chiu@intel.com> In-Reply-To: <20211228105749.1934-1-chasel.chiu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f666a5fa-cf02-49df-5c72-08d9ca6decdc x-ms-traffictypediagnostic: DM5PR11MB1787:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:800; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lFq4GMyLoSLcklAaqZONk+4kpJgJ2nrcKAnEE+fuCNWUWAM5TFm1hbu8qWK1IEfCaTyl9gaxErTAPLC0efleWABLi9skFvGmLLk/er/cSw4Xa9jVJ8XGBz8Fcx476IkO5LLjzu7BMbGq5y0SrivKQnUSZQVRjnrCyAjgB7cU+5N7qDBhoCrpbQtylXzUQexM04bcS2xhsmr/8IYj266aptgLy/JzFh/slYcGqhenQ5h/sT4ps5zgO3H9Cu5P0+k59egQo69SvAbIvIBpNyVdEOsFGSaMKJV3hVz8WbfV24seiRCQCzWIEYprHsaQFpLrUqzJyf5hoI19e5ky0eiTFm96rGxC+xvs1K4mM14EY0w3ECtc28FmdFKBt326Lhkh4nhCawfRz43V+hv7wC74AzdcIApunF6CI91I+RezmSF4j8Nln/Ili5tnL7C3eauWdpn5VbdkE/nNqP972ej7U0P5coLPt1bYltOMtFiAY9Ju2R9ghWg8wj5CFDE3dUW19p72tTDEWLhMvZy6msws612TL4lpAJ2cWCFskVdaelgFF+rzKOchWfhyRIRrvNzh4dcmqLztB2iSKzXKVf+hbfkx1kJb86rK7ZpfXF61hOQgzf4W24uNiC1fH1J3Yn3fMRjUQYyfbMG+3emfue5RRVMjhCDj5gl6mOJeyUfUZS4ZGBD1dw7HbmMmSUzXksCBNv0njOcjkrnhqE04YUt1qTncAl0Psl1pfBunm/1O+ckgaN+pUuQ+0VQJaOY9Azyoxdqsym8GJR3PbS5YCSuaAEn4eLsc5EvEdV5+PGkOtNw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB1244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(76116006)(52536014)(86362001)(9686003)(83380400001)(66476007)(64756008)(66446008)(66556008)(66946007)(82960400001)(19627235002)(33656002)(107886003)(55016003)(4326008)(38070700005)(122000001)(38100700002)(110136005)(71200400001)(508600001)(8676002)(966005)(316002)(8936002)(7696005)(5660300002)(6506007)(53546011)(186003)(54906003)(2906002)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?aHBSblY4c1dLNHdTNTF0QW1kcTZNN0NJY25OVG5wYzM4VysySE8rSjd2?= =?iso-2022-jp?B?QUtrd2R0ZzB2UDNWd3ZzZlg2MzBkcFJScDQ5dFIvT05IN2gwblQ3WlVY?= =?iso-2022-jp?B?emJ1bnpIN1RNUXg0OGVGQXlVL20wcFB4U3M5SklxakYzWU1udkxHalIr?= =?iso-2022-jp?B?bVdJeEFRWitjczVLbmRiSVVVSm5ZUDhlZFc2cG03MllFcXIvN3dGeUUw?= =?iso-2022-jp?B?VDVkekdXV2tnY1ViQ0VRTEVBZW1sNlM5NWxETlRzUjloVmQxcmZQOXpx?= =?iso-2022-jp?B?NVV2VldOdk9PK0h1a0Z0WDBoZzZSMEpPRjhBK282RWZpSjd3RTQ0THhy?= =?iso-2022-jp?B?aVlhRnhkMWpVdldac3N5TGMrOVN2am84c3ZoZC8vWjczYUNOWkRtYmZ4?= =?iso-2022-jp?B?OE5NSUpoY3g3OWVGZ2NvazE5elVIcmNPL28yM3kxc1hsVDZDU2dQNVdp?= =?iso-2022-jp?B?c1E0d1BFMUpzSE43alptbXVXZmtJeGoyV2plZm1OVkJRUlFCY1FyWGxu?= =?iso-2022-jp?B?dEYxRjI1NmN6TDdvRGlBL1lHa0d1T1FDRDRHTDZ6eStkcHlXRFY3cmR4?= =?iso-2022-jp?B?RzhFMWhseDdVQVd5VW04cVJYWWxXWHZSQjRWMktjTnRmbk0yazB0NWp5?= =?iso-2022-jp?B?a0xua3M2d2R6N1A1bjFldTVsWUVydXJSakxzdG45VmlTdERKRmU0eTN0?= =?iso-2022-jp?B?azJ6ZUZSMzNOOWxCRnhEbXVtQmxWcnhHWjFlcVFtZDFpYUtuY0hjN0s3?= =?iso-2022-jp?B?UHRDRUt6QXdDajBrVzhNTjRReUNLMjBCTGZXNjh4eEYyNGZYN25OM1RJ?= =?iso-2022-jp?B?TzBTZ21hRTB1dDJIU0JBMkFLRk5KT3BlQll1V3NYeW5qRlJrQVFUWEhH?= =?iso-2022-jp?B?SndiQjM4dEpHdW5mMmYxZk11LzhKangxQVZFL3c3emhrMytDVm1PYW1V?= =?iso-2022-jp?B?TUY0RnFMUmhUNGpHc1RQYnBucGFxZHZJVG4wd2prSGVZaFdMcVlmTmh3?= =?iso-2022-jp?B?NnZ1MnFlMGEyZzBkTWZCWWpGZnRRbjZDcjB3VGk3b252d3dZbyt4VC9j?= =?iso-2022-jp?B?SERDZmlrTm9LQWlhNnNBS0JtOWgrT2ZkK01rdjlGY0N2QWdoYWpNLzdY?= =?iso-2022-jp?B?T2t6QS9jRThQMExHV3U5cVh4T3hCSHVIN1FBRnEwUEZUK3k4cFBxa0R2?= =?iso-2022-jp?B?YTZiTjBrRDJrTTBkeVgzczc5dmdGbWsxeUt2eWRuUDBCaC9MVjQrbm4z?= =?iso-2022-jp?B?QnRIcEJuSHY5VVRFWUprVFFoSndEdG1TQlhZQjZ3bTlNNkNtbXdzOFZ5?= =?iso-2022-jp?B?S29yU2NxYUcxeXphelpaQURaZmQwalJLTUNzYytjK1pvOXFzajJ6RUE0?= =?iso-2022-jp?B?N1JKTzNTRDR5ZWhESEZwMWpOazBibGM1aVFzdWtpZmRuWThmK2N1Lzc0?= =?iso-2022-jp?B?Mkx2SEZMdEI5UXpIOUlzTG9sZjRLWXZsdm5xcUljWW1oSlUrYmVQWEEv?= =?iso-2022-jp?B?anZTOFVsL3M4dlZFQzdzeCtXY2pHakEwNFdWUDFub2dNbTlVblVtVTJn?= =?iso-2022-jp?B?REhEaVRFMEJXWjVOZHBTcHc2ZFVkYkIwM0g2elZFUGJ6S3RCMVVjdjh4?= =?iso-2022-jp?B?SFc3a1haNlVzYVYvc2pmdW9uenJuRFFnVnE3ZVNDSm40RUFnSlBFRGgr?= =?iso-2022-jp?B?SC95T2JQVWxheFVBVUFWUTFtLzdReDl1RTBCcVZGN0VmREE3eEpNM0hE?= =?iso-2022-jp?B?bktQSm1ZQTBHR1RDWjBNQ0drbUx3bTNiSlBZVXlyNmI3dnRlRnYwbUQ1?= =?iso-2022-jp?B?Qk8yelNhOWRhUzRnUTI0T09yeEJya0ZYeEl2L0ZvcitidFpHOU5za0Q4?= =?iso-2022-jp?B?LzA2SXlkOEZTSGN5aWdERktNczhpMFZYR1pnM0E4ZHIvc0lCdWJDZXF1?= =?iso-2022-jp?B?U2hWU21vMVQxZlpScnlVZHVsL2FxY0ZCbnBmUjA2UjdqdXFNMkNmOXpE?= =?iso-2022-jp?B?R2FnSy9zKzlCK29lOUtLNk5GSlZQd2RSdmdsRDF6MGhmK2t4TjdWaFVs?= =?iso-2022-jp?B?MFR3NzFObEhjUHFZVGViekUwQXJubGx3QnNIcnVYUzR5MmVaZWd4a2Qv?= =?iso-2022-jp?B?UnkxVEdlNnB3Qnl4ZFpXeDlXK0N3Nkl6YWhoQ3BKc3ZKSVI2TXl6SGd2?= =?iso-2022-jp?B?akxHRm1YYnZNdWtzeE92Yi80TXV4WUozTVd4L0FVckV5ZEhyUjRDazF4?= =?iso-2022-jp?B?NjJOKzBzWkp6MG1wWjdQc0FUcC9sQlZ0YzgrVjRwRWxOYkduODFwLy9R?= =?iso-2022-jp?B?UzltNE5aVUlVZVdGTnM0cDhrQXF6S3FYUDVxTTV1bGp2MGZyWVA3QldE?= =?iso-2022-jp?B?R0s3UFE9?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f666a5fa-cf02-49df-5c72-08d9ca6decdc X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2021 01:52:52.2340 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: erDTJcJGC8B9nJgQyln/p4RYOzl5w5qZ2weph5n4wr3G0s1X65hT7BCHtcoNvShxbLzRR/0DDeiKutZN/K6m8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1787 Return-Path: star.zeng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Reviewed-by: Star Zeng -----Original Message----- From: Chiu, Chasel =20 Sent: 2021=1B$BG/=1B(B12=1B$B7n=1B(B28=1B$BF|=1B(B 18:58 To: devel@edk2.groups.io Cc: Chiu, Chasel ; Ma, Maurice ; Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH] IntelFsp2Pkg/FspSecCore: ExtendedImageRevision was not pri= nted. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3791 ExtendedImageRevision should be printed when Header revision >=3D 6. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/FspSecCore/SecFsp.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/IntelFsp2Pkg/FspSecCore/SecFsp.c b/IntelFsp2Pkg/FspSecCore/Sec= Fsp.c index ae03fa228e..f79d45900e 100644 --- a/IntelFsp2Pkg/FspSecCore/SecFsp.c +++ b/IntelFsp2Pkg/FspSecCore/SecFsp.c @@ -1,6 +1,6 @@ /** @file =20 - Copyright (c) 2014 - 2020, Intel Corporation. All rights reserved.
+ Copyright (c) 2014 - 2021, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -199,8 +199,12 @@ FspGlobalDataInit ( ImageId, \ (PeiFspData->FspInfoHeader->ImageRevision >> 24) & 0xFF, \ (PeiFspData->FspInfoHeader->ImageRevision >> 16) & 0xFF, \ - (PeiFspData->FspInfoHeader->ImageRevision >> 8) & 0xFF, \ - PeiFspData->FspInfoHeader->ImageRevision & 0xFF + (PeiFspData->FspInfoHeader->HeaderRevision >=3D 6) ? \ + (((PeiFspData->FspInfoHeader->ImageRevision >> 8) & 0xFF) | (PeiFspD= ata->FspInfoHeader->ExtendedImageRevision & 0xFF00)) :\ + ((PeiFspData->FspInfoHeader->ImageRevision >> 8) & 0xFF), \ + (PeiFspData->FspInfoHeader->HeaderRevision >=3D 6) ? \ + ((PeiFspData->FspInfoHeader->ImageRevision & 0xFF) | ((PeiFspData->F= spInfoHeader->ExtendedImageRevision & 0xFF) << 8)): \ + (PeiFspData->FspInfoHeader->ImageRevision & 0xFF) )); } =20 --=20 2.28.0.windows.1