From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web09.25389.1649648599989326931 for ; Sun, 10 Apr 2022 20:43:20 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=MmwdQS33; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: star.zeng@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649648600; x=1681184600; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=QnmDXPKzfrrh+PMn3soMzJN6a1AkAP+e8VcuH9jPyNQ=; b=MmwdQS33efGmkJXC98SlyLxpVJcjjDBYGRJHrtDGKHuaUy6zL6XVRwwZ 9nzvmQxWXBro38pvXtXxw4V7Qbz11ErwJP5Z1iFjvK3tNLB4NtG/7gYM8 OLXou0Sg5q03pq8fJWI0JUEW0fjaFudHGlIrMQ0CMsizRgwWhIe3siUgN uaTG0WSZl7Qo8p7Fj1Agj25FtDe+fsVFOd4ais0ji0atFTNJUBo2KqeYE rD8KuEMZEUZtm+aNFR6i4GltU0+Wn6LpoB/v1qpqdotn8q2NsERxM7rv8 tjij5pr7qWX3RIeiAJcua8Dmznkbuz84+BBdehG9P1M7raAUaE7JQof96 Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10313"; a="260871722" X-IronPort-AV: E=Sophos;i="5.90,250,1643702400"; d="scan'208";a="260871722" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2022 20:43:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,250,1643702400"; d="scan'208";a="550951196" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 10 Apr 2022 20:43:19 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 10 Apr 2022 20:43:18 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 10 Apr 2022 20:43:18 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 10 Apr 2022 20:43:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TSpc7PcfvNKcCT16Kp1+1hAa8sD9dTEDYg9L2IhvIXrkZAhY26pIObHvK0b1ESgH7tztAIeInybgpszyU9MQxBGVgGpRowH2PPqsPolF5An4K034fFkiQ8WPYAKcj47EMY9TdUG58Mk8QGYn0zcZH5qm+TslIo7ZUHqlSobwKVvBwVDifS9luKnprTuojgUYftREUBajVuxNvEIWWyx+rcp31f1mKFbK+z8K8Rf0+ZY5iULGlrvKEV+cGq65FmSKE+Xspm/nAwAWED0SfEAYgWdMj3QdHi18ru/1uRQ74W5zajMV9O7JL0HSpa+GXSDke2bEGTYitWOc/ZGBGFktOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GWXyI1ThnKMKusaB1P9RroCZZalN8KyaxJZS4PQws4g=; b=alqIqyV4G0Xh3OAsZ5HBtHN/T2EZxwLNK9Sz2Pr9jQQHkhItfYuJXUt90yTbaXpuvVCel1D3TKc8LLC66dfRO49EN/ENfZrRa7AvEt6vnVN6pHlVILKjHT0xi3aMP9UU0u4JtyNSjd0OitPtKUBgjoJShl/z6xgS5rJCH5wTsWD9te1S5++N8qRaZ2Nb+PWWpy4NLiRM8c1vzKLTDyZGJpOb/4l1UYFD3bci54OykC2YqWYU4HXC5Uq+JrkQ0dDRkaWTwJzPLJeSqW3SgBH59Q4YfGXhx198r3BJpPtBKJZMuk4Y85FmT+6uNOyM6aI9sqWE4sxNBch4h5oFDIpRdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1244.namprd11.prod.outlook.com (2603:10b6:3:13::7) by SA2PR11MB5052.namprd11.prod.outlook.com (2603:10b6:806:fa::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr 2022 03:43:17 +0000 Received: from DM5PR11MB1244.namprd11.prod.outlook.com ([fe80::6db3:abf2:446e:b18]) by DM5PR11MB1244.namprd11.prod.outlook.com ([fe80::6db3:abf2:446e:b18%6]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022 03:43:17 +0000 From: "Zeng, Star" To: "Ke, Bo-ChangX" , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Ni, Ray" , "Gao, Zhichao" Subject: Re: [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields Thread-Topic: [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields Thread-Index: AQHYS2VmVXNzG4JgcEyH+HBksOEh+azqFSzw Date: Mon, 11 Apr 2022 03:43:17 +0000 Message-ID: References: <09ec3fc0f59eae4eec5682cd19dbd8cb552e61ac.1649435086.git.bo-changx.ke@intel.com> In-Reply-To: <09ec3fc0f59eae4eec5682cd19dbd8cb552e61ac.1649435086.git.bo-changx.ke@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b3f327f5-ab2a-40ea-de1a-08da1b6d6a20 x-ms-traffictypediagnostic: SA2PR11MB5052:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: E8F8ByUyxY8tfQ2yFhiTC/RiF+KhpE3Dv33a35dbPldJMibwO1FrIQ7jCsP3QdVI5E6eYscEaxeg9DXlkz4/fSKlPtu8+pWkgk/wKxZa9TfJk4I6TFx3H7wki51m6ymJ7fMOrzHnhncgwHT3R7+rq/P37QwVGNpSAlNX5gmYkSeeaWsaJTGbaxdnbySA+TPNULp8np9TuWZqkezW5UOBfpFvfUaD7B/iVPiOdEoXdPzGM7SFGc61OM8Pq7TSLU/EsqsMyCYoJafno8Q9nn8AQaavekCzyPYBhexhd1sqpsNqnHYomkUOP5qmmPMsLnqumVsoz2ulq5axyjHS5br7IfSyv5y6oEEIck829OBbA/crC2wDVnIieMkmhYYX2x0lDMJ7NuNq+gm8kudLz6mpw7aFkMU91r8Bvz8usoKK4YbpuAKbgGrqluOSNJ3iR56Q71xB7w5SP9lyidCNR4tL7myOHxd0fIpH9jzYwGHJE8MoXM5pyrks6OMSiLZ2oPiyGTbtP2NkvyClPPJ0YepfvTnSz4ML5QTzkvstlMvZECq/kBon1vk+dyI9xr00bg1i2vzY3kofzG4eCHy8QmjXYlV2f244deduHHXLfqyVlr04JZTiCLQyEREFa0WoxhBLH1fJ8E7GJCPzsdx/6T8sydOB0LArcYfKR2RSz/Lp7JBRzbEuWyFY4Elp5wRYiPCJfNtjwaIYWsgJc6ZdhNvQOEp18VBqpSfl+ngBG7GEbzc97H6xbNxXVblUaGaAM2mqWFlZpQCGRcdlqkUAP9pzmZBw0BKSkSnrqRVHwDIZwDo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB1244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(107886003)(8676002)(4326008)(66946007)(86362001)(64756008)(54906003)(66476007)(110136005)(66556008)(66446008)(52536014)(316002)(186003)(76116006)(38100700002)(122000001)(7696005)(6506007)(9686003)(53546011)(82960400001)(71200400001)(508600001)(8936002)(38070700005)(33656002)(83380400001)(15650500001)(2906002)(55016003)(26005)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AKgBCuX8xF8hQr7Mg07P9zVlCwtWRIQX0zHDk69Cpf70ePKrn+oSh7cSZ6+Q?= =?us-ascii?Q?KPjm43HHJvxQoH6iieF+Ug8JwYeTY530FRRFQ57sFn+OU0v7qyaIhI4tvsHU?= =?us-ascii?Q?+KHjRzvW42y124oSFd9t7Vowja5Un6K64i9pNyJCZNlQyKZKTxYJtovHGrQU?= =?us-ascii?Q?+8zo78mS4ELby+cgs2jxIyM7MWVc3OjPATCOoabbniG6qPqXBQbK886AyXsg?= =?us-ascii?Q?/0rG2FsW40cDu6oEFoHqDt+Tv7fenp9oNUGWhtHbhUp4KFld7zssZ+0HQxZr?= =?us-ascii?Q?MiPaP19kimNNYdK71tjSGxdlQRUhESSsuRqzfj1dIACiDps50pSSUUk68oV1?= =?us-ascii?Q?scyFByZSz37cbPNZnDAXjh7dv/1FQff+RYlPsR+PT0JABiX3APcoYQO9Cl6X?= =?us-ascii?Q?4cLzhWSg9aoLQe4fMhlAwTL+YJa1djOJJgDB+/mzotJedLKJmE2Dn0MXvMQ2?= =?us-ascii?Q?o8kysXPiJjeZIHWK79WABlLmGFqw0qakUoj8VoUSwYAitJTeJ6WK3UqacPAV?= =?us-ascii?Q?2ktqDxaQM8yUSmbeE2+bQzEt8A9tQi4zQew/FQbIYx51JLEj6zkla76a7OQP?= =?us-ascii?Q?HoQKOGiyN1EL6MkExxSWMdCF/8C8/z0i0j2WnKJrSkPd+1u1Mpot8uPGlOPC?= =?us-ascii?Q?Sb+SzkJlLHrDel3YjxN/nu/aSrphsAdnRBspNYxDBJoMv+AHbmQdlhufaAPN?= =?us-ascii?Q?+KNyoXAZXfl4/l4HfM+R/tnF13fxk6p5evcglcrwIBX/q2iDrmMKkRFAjTNY?= =?us-ascii?Q?zLTZ7mZiNSiS0s+jsZ2i0AJpCyoHENudhzjsnPzZrePOw0+Ht0ygdkNZqrGr?= =?us-ascii?Q?X+pv8KXKZ9unjhKT9/Z1KXiA6v8Xt7fOY0JoI41OW3rb+tzkU7vTYiDHNjMb?= =?us-ascii?Q?yy4I2ASXMQXzB5+FZHn3hXWvrkKrcdwb3Y8CVPiMIMip8b8Uqk/YIgtLA4En?= =?us-ascii?Q?4YVVXl0cS5YWIEmsm9Q6GdDaq/koEFNk77cQMGMk0/uu1lyXQ/NE8v8VOxx8?= =?us-ascii?Q?xzkuFrT+TsF2yY4cVEtIjPlg9ytAOss1dGmFsmmM87mizVWx9ps60xH/H/H+?= =?us-ascii?Q?6jnmFSiOg40SC3Q4hGoWb0wFTklvc/8deDsS3aPwoSAuZ+vwPvOpoYGU0RBg?= =?us-ascii?Q?uEIZZ6p+PbWCaUS7O9cVpfSajumnaBog+J86XP5hrZatGulloqeif0SmQ+mH?= =?us-ascii?Q?i/3bUxgsy8S4RSro+ekkDZZcewwx95exhrugcNaiUXYw3NgV7JmLwjR0tZiE?= =?us-ascii?Q?L3pGe2U2Ex2dQ4QLrLY8NgReJYX1RQmxqr2UfJJdg9ilrckWPcLBY9P0LvUP?= =?us-ascii?Q?I7NEgAn/yiM5/mFmAi1bPRDTNXi36itLi48ZRGS7Zn63+bCiL8KwtEnc+C+X?= =?us-ascii?Q?X11eX6UhEAne4wXRFwYpiHLE3okGSobiiLZ47XBPU24+AcdHgWQsNBUUgzXt?= =?us-ascii?Q?uX47JmE16F1ga2TP1kTnP5B7tnuQHRh+jUaMDaHhnV9QfZmsgl5LQ39dEfjB?= =?us-ascii?Q?eQrlz+QwP09evvRSLKVw+IWAddLFbPH1PdBvS/rU/bw2X0Njmz+n8zLZB5tA?= =?us-ascii?Q?v9TMPMSWNuIWILyiJ8nDHWrJbJ2srxY3MhjaBENzPpt1KgxosWMh549rfzZn?= =?us-ascii?Q?q/jgN94AKhWZsXNlPafGwJWFdiUIvzrR7YOvjtJs9UA2z7LLXfdIEGtQA17U?= =?us-ascii?Q?F9DjD4stu36nJQbDEVidztVGhTPLnIW6YbT4T9dpVzn2526I+2dHumVonqh5?= =?us-ascii?Q?ReHsNAICgA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3f327f5-ab2a-40ea-de1a-08da1b6d6a20 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2022 03:43:17.0552 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iikNXtQgdPvdVXAPn9VrsnjCTn9PeY/DfH9vxSpRgCqN1jnkvrb4ivZvDGBrquVRE9jRv2+lGlldHkGtiu/ntA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5052 Return-Path: star.zeng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Personally, I think "eMMC" should be enough to instead " embedded Multi-Med= ia Controller ". Others look good to me. And you'd better to get RB from ShellPkg's maintainer (Cced). Thanks, Star -----Original Message----- From: Ke, Bo-ChangX =20 Sent: Saturday, April 9, 2022 12:26 AM To: devel@edk2.groups.io Cc: Bi, Dandan ; Zeng, Star Subject: [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3900 update smbiosview type 41 related fileds. Signed-off-by: Bo Chang Ke Cc: Dandan Bi Cc: Star Zeng --- .../SmbiosView/QueryTable.c | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTa= ble.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c index c4a6acb167..7ec6d2b5f1 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c @@ -1766,6 +1766,30 @@ TABLE_ITEM OnboardDeviceTypesTable[] =3D { 0x0A, L" Sas Controller" }, + { + 0x0B, + L" Wireless LAN" + }, + { + 0x0C, + L" Bluetooth" + }, + { + 0x0D, + L" WWAN" + }, + { + 0x0E, + L" embedded Multi-Media Controller" + }, + { + 0x0F, + L" NVMe Controller" + }, + { + 0x10, + L" UFS Controller" + } }; =20 TABLE_ITEM SELTypesTable[] =3D { --=20 2.32.0.windows.1