From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.2213.1626745521549129249 for ; Mon, 19 Jul 2021 18:45:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=EPhZpu5t; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: jiaxin.wu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10050"; a="232938537" X-IronPort-AV: E=Sophos;i="5.84,253,1620716400"; d="scan'208";a="232938537" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2021 18:45:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,253,1620716400"; d="scan'208";a="500122839" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by FMSMGA003.fm.intel.com with ESMTP; 19 Jul 2021 18:45:20 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 19 Jul 2021 18:45:19 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 19 Jul 2021 18:45:19 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.49) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 19 Jul 2021 18:45:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CcK3KAgSQRTQTCiA/KPWACJeXUnUCW45VSst1iP8rI0cpD7jTbeo+YauUlJnscXu5TtLrx4eMD6oTShidRKMEspjzlMfeBba8i1n9X9NkMuZF6ebOCNNz96d19+c9uRKqyiN3wu975rJ812SZkdC4PBNaFbXkqXXecaYDE3xpcr0sxQ8SJdaXzpydCfOJMVZDst79Y5nM9bj47RO+CDs37GCZlj1mvRrIfSja5H1XimenGPT13852XToKE6jWgYQgC4/AinoL+KzjxoIfJfdkNwMfJhOzTDC5GSy+axX59GtgCoHMfA836mpv9bgmyB4+GjK2RELEazTz4Cwxx/NXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vg0A4gemmwMhiryMDJA7g1vvDtwfvfNcQP1OwcPWTtg=; b=kTr+C7h+VnabGx2VG827Aqcr9fMZIOLcuaO7xBYss5POClD2qDXFP3o2UTz9JAYisXB3M2Jf0TbjJFZW5+8P8u4MyEyyCEvQvoy9MDgfjOp8d4QaPvUulefpFgn32Nv7CrLq/E9XL3ELPsivK2q37fkfcrNP3xDBHbSIoodK38q6kgJfSGeN0oYblEA9PUuqVOc85bcP2s6fvbq4oHEzLOrYQt4fT8ABuAWZjxVlJoTMSf8qXykdLkl8joE3bMi+GkyTqzCSQ+L7yBByKyBfGhIAfYYoA+75hHRskhmvjnFKjZm+ITA4el5+7CL9j1D0kjz/0akt+Ve38Gf0OrSi6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vg0A4gemmwMhiryMDJA7g1vvDtwfvfNcQP1OwcPWTtg=; b=EPhZpu5tBFX88Haj9dCVkC58KIUFgteCnox594n8R11cFb1McbUe7lZGeywk77r3JBlBDYMQguX+p7suza/Amn/VqVipvAz7W8raig/vHQsNkLFOoHseBhf590EjiAYtPYb/dR8/O7KTcFMYYuFLEYroyk/iDx4gwAMUhUyDoKc= Received: from DM5PR11MB1372.namprd11.prod.outlook.com (2603:10b6:3:11::14) by DM6PR11MB4057.namprd11.prod.outlook.com (2603:10b6:5:19d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21; Tue, 20 Jul 2021 01:45:17 +0000 Received: from DM5PR11MB1372.namprd11.prod.outlook.com ([fe80::e482:9be2:c3fc:c22d]) by DM5PR11MB1372.namprd11.prod.outlook.com ([fe80::e482:9be2:c3fc:c22d%11]) with mapi id 15.20.4331.033; Tue, 20 Jul 2021 01:45:17 +0000 From: "Wu, Jiaxin" To: "Luo, Heng" , "devel@edk2.groups.io" CC: Maciej Rabeda , "Fu, Siyuan" Subject: Re: [PATCH] NetworkPkg: Add HTTP Additional Event Notifications Thread-Topic: [PATCH] NetworkPkg: Add HTTP Additional Event Notifications Thread-Index: AQHXfJaUJI4c1gbgX0OEHRhUylLM7KtLFIaw Date: Tue, 20 Jul 2021 01:45:16 +0000 Message-ID: References: <20210719120629.805-1-heng.luo@intel.com> In-Reply-To: <20210719120629.805-1-heng.luo@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: da3e37c8-be7f-4435-05cd-08d94b2006a1 x-ms-traffictypediagnostic: DM6PR11MB4057: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nGxjAmMiFcW3VeqJtumAW/YGVctKY7wygBHPYA/HsuYyl891ebJwVUgU4Vx1xhIs9Sx/P3y7jhDEddLVbKTtYDGbcxzPqWQPJVFDH+3dgc7fs6HRsxMKvfTPXWy6cXqde3shJtAtv4Rb06g3laZup/ST4E4wlQxhPPueoy64Qx/6N2MaexfFpAFKCp6Vc1Yz87hwmZpN7edo4mD+wpA2j920hZD+h2KKSmNLURa9/XBr3NQ9oA67PNca266tNEkUXFPaAVLGBrTAg9tzDqnXi2TFtL8a84HjhW5G0lRqDgDLP8F3thrXwsVwyLyAI50OxYRkRwiTxrZ2io4Z/GSHdal0RYB761Ytva7X5jvRZVMJ5uZ0zsj4O/Pt5bckjop5WfYIEDxQkBK5UdSIjEjsLykl7cUMhAGbowQkIPvCeWB+A40ITsrxJluXnx1uh16Mn9cXTJIzI2pRnzbkXQRHkQMjK6m8EeT3zL4zTOeeMSyN+MP/TLump6Ibs/TU/ZLi8/qCTnLOUqB2I0Tv21C7qIzYvPlXXLIPbwJVymMmJd9duFuk/0jREYmZLR2XtBnksYXQCQ0djkMRX1HWiOVvXum6mNs/scZMs8knD5scGChpxCZdj6uLoVHA3nv4zjQhzIczYZ8QhZSAUrjw7yJ2S02N5cb/AWEcLup4tJ/AuYMFZZP5VQXNPtRowAZYyU8A8QVcY0c5QY69c1nAUpDzdg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB1372.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(396003)(136003)(39860400002)(346002)(52536014)(5660300002)(66476007)(66556008)(66946007)(76116006)(64756008)(66446008)(71200400001)(86362001)(110136005)(9686003)(6506007)(83380400001)(33656002)(38100700002)(478600001)(7696005)(55016002)(4326008)(8676002)(122000001)(8936002)(54906003)(186003)(2906002)(316002)(26005)(38070700004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?r27chs5JawOL6F7cObFyK9spWnCDrMGU3iD2cnjnUqZb/mPLDGsjeixULedS?= =?us-ascii?Q?EbP4y7h8NORjsaA7ngEnWJoI6SI8oxxzIPLUdN4Dn863jPdNUZMCglSYg+uP?= =?us-ascii?Q?zXMXXpLv8MjVttzpG+xE0eH/AN7pL2hwU03GqiiujvoDOk+5vCxUC5WxhziP?= =?us-ascii?Q?OQ+lfs50u1esBtGZB4TtTiMHrFtutV1pTjhLkIEsdJxvdCIFUOzsC56E7t36?= =?us-ascii?Q?EtmiTKLEeayZkET+qGNFNPYT71iJQeticDE7sPFsYMWr5u7h1/csN3F+G2h5?= =?us-ascii?Q?JLB/iZybT/m88MJPxxK0EVZKXB+Lyiv4LfxbujMZ9EmkyPI+E9dcPVr48IZE?= =?us-ascii?Q?jFqIZ2BUfOzW3kms5B5oGGEZCZ2cOAXNFuGfryzCtcNv7NeIuSxWJ7IBbUbZ?= =?us-ascii?Q?vCy+lcVk0IHrl/YfqPp/ndMYYSytvtFyTyqhjhN6IsKfnK381VrbQYQ4n1hN?= =?us-ascii?Q?PfX2MbzQCBdqXQAE2rgdatIHJRoSPK0K8hukgsmwAxzmpD1PIQNNIzJKgoUu?= =?us-ascii?Q?ZoxURwRpoKP3IFN3BAR7Flhp1KS80CnxqgliCAIS07xAnnTQb2IJc0ypaHet?= =?us-ascii?Q?2nlusCB+9HiXCXP34k+YHUz/hGpk/vLpHYna1DnXSeyyjKMZuegJBYN4BeWh?= =?us-ascii?Q?SByJL8V9jH6EKDbb9nBRS1O9OGq9DqjT9qd4ywJ06FsUADNcv+jMCBu6MQd8?= =?us-ascii?Q?gHpYY0+ZWVNf07wX7l11RDOj/z6cEl7/5aUEDsGItJhWOCXcgVSNtLFVlFZs?= =?us-ascii?Q?Al4UHafPvMLt5ZrRmajHtDDeM9ftmpNdC61jpUKGrl98YgoAW0eY2UCVMGV5?= =?us-ascii?Q?HNcFLZE0qkv5yrX76Dd9u0048SA0JQZNBVaukHkiJuhT9YDBSjNL90KweCzF?= =?us-ascii?Q?v4B6tE306gXegzmRuTfZRnjxcrjbQ3m6ck1520+WLA5tO47pNoniER2uikq6?= =?us-ascii?Q?NMv8crf6xfx5cVDTEODxLfEXNWLfjwvn4IL+VjyqkyUhD9Wy9ltzCk+K98EI?= =?us-ascii?Q?tBSBfJQC04QNfRR6YchVEneTVDvsHIy/XOVk0EkBNb/Jdo8LPCfPjHG2Fn8h?= =?us-ascii?Q?u3SrGcwNgzq95LseD7AZSvdA1wspADDI7OhfieR6f0B4hYw12MFqtmYg34am?= =?us-ascii?Q?UFAe8nAddsrtCU+p3bZCbxvknsu2mIvP1azGn768rLfN0WyiRhkRpNgP3DCq?= =?us-ascii?Q?Golycic5PcGJ0Yt+KBjCR0+3b/4+13glQQrQ8pBy7MMc39ABhRJyF000qhLZ?= =?us-ascii?Q?2ZHIqHXZlg17nMndlWgau1SGhxyguvC92weD0tmFmaRQG+s4F0emvEaaA7n0?= =?us-ascii?Q?iBZFwQi+lv7SMnNCxavu+3DJ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1372.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: da3e37c8-be7f-4435-05cd-08d94b2006a1 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2021 01:45:16.9289 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Mks4eZAcKJG2Fs8UWkjYuYwvjTB/gH/uv3EYbX+A9xsIsswR7IPmOmg864ZkWqYHGTCFrbkqC9WzYBO8FuvwwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4057 Return-Path: jiaxin.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For the below EDKII_HTTP_CALLBACK_EVENT definition: All event is to retrieve the event Status, so the comments should be made c= learly and align with code returned status, for example,=20 > + /// Retrieve the host address, EventStatus: There might be the misunderstanding you want the host address, but actually= , you only want the status. It's better to be: > + /// The Status of DNS Event to retrieve the host address. The same to all event. With above changes, the patch is good to me. Thanks, Jiaxin=20 >=20 > +/// >=20 > +/// EDKII_HTTP_CALLBACK_EVENT >=20 > +/// >=20 > +typedef enum { >=20 > + /// >=20 > + /// Retrieve the host address, EventStatus: >=20 > + /// EFI_SUCCESS Operation succeeded. >=20 > + /// EFI_OUT_OF_RESOURCES Failed to allocate needed resources. >=20 > + /// EFI_DEVICE_ERROR An unexpected network error occurred. >=20 > + /// Others Other errors as indicated. >=20 > + /// >=20 > + HttpEventDns, >=20 > + >=20 > + /// >=20 > + /// Initiate a nonblocking TCP connection request, EventStatus: >=20 > + /// EFI_SUCCESS The connection request is successfully init= iated. >=20 > + /// EFI_NOT_STARTED This EFI TCP Protocol instance has not been > configured. >=20 > + /// EFI_DEVICE_ERROR An unexpected system or network error > occurred. >=20 > + /// Others Other errors as indicated. >=20 > + /// >=20 > + HttpEventConnectTcp, >=20 > + >=20 > + /// >=20 > + /// Connect one TLS session by finishing the TLS handshake process, > EventStatus: >=20 > + /// EFI_SUCCESS The TLS session is established. >=20 > + /// EFI_OUT_OF_RESOURCES Can't allocate memory resources. >=20 > + /// EFI_ABORTED TLS session state is incorrect. >=20 > + /// Others Other error as indicated. >=20 > + /// >=20 > + HttpEventTlsConnectSession, >=20 > + >=20 > + /// >=20 > + /// Initialize Http session >=20 > + /// EFI_SUCCESS The initialization of session is done. >=20 > + /// Others Other error as indicated. >=20 > + /// >=20 > + HttpEventInitSession >=20 > +} EDKII_HTTP_CALLBACK_EVENT; >=20 > +