From: "Wu, Jiaxin" <jiaxin.wu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"abner.chang@hpe.com" <abner.chang@hpe.com>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>, Nickle Wang <nickle.wang@hpe.com>
Subject: Re: [edk2-devel] [Rest Ex Definition PATCH 2/2] RedfishPkg/Include: PCD definitions of Host Interface EFI device path
Date: Mon, 12 Oct 2020 08:54:01 +0000 [thread overview]
Message-ID: <DM5PR11MB13723B96B84506A1EE71372AFE070@DM5PR11MB1372.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201012070415.5878-3-abner.chang@hpe.com>
Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner
> Chang
> Sent: Monday, October 12, 2020 3:04 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Nickle Wang
> <nickle.wang@hpe.com>
> Subject: [edk2-devel] [Rest Ex Definition PATCH 2/2] RedfishPkg/Include:
> PCD definitions of Host Interface EFI device path
>
> The definitions of Host Interface EFI device path structure PCD.
>
> Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
> Signed-off-by: Siyuan Fu <siyuan.fu@intel.com>
> Signed-off-by: Fan Wang <fan.wang@intel.com>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> ---
> .../Include/Pcd/RestExServiceDevicePath.h | 38 +++++++++++++++++++
> RedfishPkg/RedfishPkg.dec | 3 ++
> 2 files changed, 41 insertions(+)
> create mode 100644 RedfishPkg/Include/Pcd/RestExServiceDevicePath.h
>
> diff --git a/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h
> b/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h
> new file mode 100644
> index 0000000000..89de3b1a21
> --- /dev/null
> +++ b/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h
> @@ -0,0 +1,38 @@
> +/** @file
> + This library defines the UEFI device path data of network device for REST
> + service to decide which should be used as the Redfish host interface.
> +
> + Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> + (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> +
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#ifndef REST_EX_SERVICE_DEVICE_PATH_H_
> +#define REST_EX_SERVICE_DEVICE_PATH_H_
> +
> +#include <Protocol/DevicePath.h>
> +
> +typedef enum {
> + DEVICE_PATH_MATCH_MAC_NODE = 1,
> + DEVICE_PATH_MATCH_PCI_NODE = 2,
> + DEVICE_PATH_MATCH_MODE_MAX
> +} DEVICE_PATH_MATCH_MODE;
> +
> +typedef struct {
> + UINT32 DevicePathMatchMode;
> + UINT32 DevicePathNum;
> + //
> + // Example:
> + // {DEVICE_PATH("PciRoot(0)/Pci(0,0)/MAC(005056C00002,0x1)")}
> + // DevicePath will be parsed as below:
> + // {0x02,0x01,0x0c,0x00,0xd0,0x41,0x03,0x0a,0x00,0x00,0x00,0x00,
> + // 0x01,0x01,0x06,0x00,0x00,0x00,
> + //
> 0x03,0x0b,0x25,0x00,0x00,0x50,0x56,0xc0,0x00,0x02,0x00,0x00,0x00,0x00,0x0
> 0,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0
> x00,0x00,0x00,0x00,0x00,0x00,0x00,0x01,
> + // 0x7f,0xff,0x04,0x00}
> + //
> + EFI_DEVICE_PATH_PROTOCOL DevicePath[];
> +} REST_EX_SERVICE_DEVICE_PATH_DATA;
> +
> +#endif
> diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec
> index e95ec5fe10..de3611252e 100644
> --- a/RedfishPkg/RedfishPkg.dec
> +++ b/RedfishPkg/RedfishPkg.dec
> @@ -13,6 +13,9 @@
> PACKAGE_GUID = c432b76e-5232-11e7-9010-005056c00008
> PACKAGE_VERSION = 1.0
>
> +[Includes]
> + Include
> +
> [Guids]
> gEfiRedfishPkgTokenSpaceGuid = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88,
> 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
>
> --
> 2.17.1
>
>
>
>
>
prev parent reply other threads:[~2020-10-12 8:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 7:04 [Rest Ex Definition PATCH 0/2] The definitions for EFI REST EX Abner Chang
2020-10-12 7:04 ` [Rest Ex Definition PATCH 1/2] MdePkg/Include: Definitions of EFI REST EX Protocol Abner Chang
2020-10-12 8:53 ` [edk2-devel] " Wu, Jiaxin
2020-10-14 5:36 ` 回复: " gaoliming
2020-10-14 11:38 ` Abner Chang
[not found] ` <163DD8E0887FF220.5123@groups.io>
2020-10-15 1:12 ` Abner Chang
2020-10-12 7:04 ` [Rest Ex Definition PATCH 2/2] RedfishPkg/Include: PCD definitions of Host Interface EFI device path Abner Chang
2020-10-12 8:15 ` Nickle Wang
2020-10-12 8:54 ` Wu, Jiaxin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR11MB13723B96B84506A1EE71372AFE070@DM5PR11MB1372.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox