Re: [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when reset

["Wu, Jiaxin" <jiaxin.wu@intel.com>]

Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>

Thanks,
Jiaxin

> -----Original Message-----
> From: Abner Chang <abner.chang@hpe.com>
> Sent: Monday, September 28, 2020 2:30 PM
> To: devel@edk2.groups.io
> Cc: abner.chang@hpe.com; Maciej Rabeda <maciej.rabeda@linux.intel.com>;
> Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Nickle
> Wang <nickle.wang@hpe.com>
> Subject: [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when
> reset
> 
> BZ #2909,
> https://bugzilla.tianocore.org/show_bug.cgi?id=2909
> 
> When Http->Configure() is invoked with HttpConfigData set to
> NULL to reset the EFI HTTP instance, TLS child instance is
> destroyed but HttpInstance->TlsChildHandle is not set to
> NULL. After reconfiguring HTTP through Http->Configure()
> and sending the HTTP request to HTTPS URL, TLS child
> instance is not recreated because
> HttpInstance->TlsChildHandle is not NULL.
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> 
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> ---
>  NetworkPkg/HttpDxe/HttpProto.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/NetworkPkg/HttpDxe/HttpProto.c
> b/NetworkPkg/HttpDxe/HttpProto.c
> index 3c7c6ff9f0c..afc7db5a726 100644
> --- a/NetworkPkg/HttpDxe/HttpProto.c
> +++ b/NetworkPkg/HttpDxe/HttpProto.c
> @@ -873,6 +873,7 @@ HttpCleanProtocol (
>      // Destroy the TLS instance.
>      //
>      HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, HttpInstance-
> >TlsChildHandle);
> +    HttpInstance->TlsChildHandle = NULL;
>    }
> 
>    if (HttpInstance->Tcp4ChildHandle != NULL) {
> --
> 2.21.0.windows.1