From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.31077.1601277714315508324 for ; Mon, 28 Sep 2020 00:21:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=J6O1RxMc; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: jiaxin.wu@intel.com) IronPort-SDR: TarXTmqwcYT/4D12O86OZc/8O9NFKRh0IYJMIBVuOX6v/sZ8uNH7bZCB3OgS+46Y9cL+zylc7W JCybjS+qCG4w== X-IronPort-AV: E=McAfee;i="6000,8403,9757"; a="159297273" X-IronPort-AV: E=Sophos;i="5.77,313,1596524400"; d="scan'208";a="159297273" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 00:21:53 -0700 IronPort-SDR: vAEEdSTSv9n/JzA8gzeFstOMz+290YDjhY+EEsOYDSjuFiBmrp8VSsj3WX2YXBfwDIr6jpzo1V fYu/GZVQ2/rA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,313,1596524400"; d="scan'208";a="293793694" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 28 Sep 2020 00:21:53 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 28 Sep 2020 00:21:52 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 28 Sep 2020 00:21:52 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 28 Sep 2020 00:21:52 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.57) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 28 Sep 2020 00:21:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ByfQ/HAx56PEoRBKcWE1n/5W9xNbOFqLdvvpIryvfzCQnlUtk7lnKrhkcLRMZLJ5PgzaOdGewifJVkxvRYU0hKz5mKpY7j7tLY+Q61uzhhek9xrCGuQ57T2rIZmgHV9qd4+8UFTWXpWGDm8E+hLyOaz/zMVJTtVp+RKhccXmtJ3rf+w902bY74c6vXs06BQ3y09Aced5vcGK4AsHSFjecLDdGO3fz2lDdpgVpvRjEUmJjOTLY5dklhtVrgphRIqykG3kbsZg7xFV4ONjZVC+nny1dF3u4ubpDnnRmUlDNinu5QXS7RwmlGUkN1dfcVzciCIRf/Hq0P4Rosp3bC4TlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XbOAL0F4J077ag99P8HIf/PdcDJQVZ8ghaK5VrPRBZg=; b=WuEtS5swnY43ybpJE0fpUI7Cmz+cPN5ecIbGzNUbn6DxE5Dsk6zOxw1uz32QvbV2NysPH9vhMipXxftZPbw0OoEJxvJpgsz1Q5rTCwO6uUW1Igp1iN8jPzVrFqob1QvZg4pWiY49fAreD3vpxBiDT9ySUiZ6jN/HpcN0gdXshF302imlx0nQXqWUah6U81NozRcE7bt53RGxy7bPVesejov++f3zeDJwm64Hx/Oe2MuFTCDioQ5o4Mxtz0E0cygjKBZAPcfEewA20VL2IMAp6D/ja3fQWu7eXScV1AccQygp1dJUqxbdTfOUdmF087y06g3F3Ax7nJaiy2G8Qeq1Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XbOAL0F4J077ag99P8HIf/PdcDJQVZ8ghaK5VrPRBZg=; b=J6O1RxMcbnBU8EjFMp+ZCpxzUsn78dK5PbysnrUpZT/t+WqpSOM/wu1uAs7TpGivFxyFwBQE0/6ACbb684ufvUQYssUEDduwf5Bysl6L8p0wT/JoFuQoOZnO+1xWEROwV1NZfJzmr+g0rUNpNHdeFl5VlBAht7wdilmzXy4yar8= Received: from DM5PR11MB1372.namprd11.prod.outlook.com (2603:10b6:3:11::14) by DM6PR11MB4060.namprd11.prod.outlook.com (2603:10b6:5:196::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.28; Mon, 28 Sep 2020 07:21:48 +0000 Received: from DM5PR11MB1372.namprd11.prod.outlook.com ([fe80::69b5:a015:f372:8127]) by DM5PR11MB1372.namprd11.prod.outlook.com ([fe80::69b5:a015:f372:8127%10]) with mapi id 15.20.3412.029; Mon, 28 Sep 2020 07:21:48 +0000 From: "Wu, Jiaxin" To: Abner Chang , "devel@edk2.groups.io" CC: Maciej Rabeda , "Fu, Siyuan" , Nickle Wang Subject: Re: [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when reset Thread-Topic: [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when reset Thread-Index: AQHWlWDClK9inTc+4km3BiKFa9cM16l9pSew Date: Mon, 28 Sep 2020 07:21:47 +0000 Message-ID: References: <20200928062934.505108-1-abner.chang@hpe.com> In-Reply-To: <20200928062934.505108-1-abner.chang@hpe.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGQ4M2VhZjktNDlmYi00ODY1LTgzMmItYTEyNzg4OGI2NjY1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicjRFWG5sZ3ZsT1h4NGFqRHZKMUNqRVwvMUdncjRLcFh2eWVpK0g0RzNiODRWV0RXRDJmMkJ1VDkxcm1lZlFwUmgifQ== dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action authentication-results: hpe.com; dkim=none (message not signed) header.d=none;hpe.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.215] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8fe857bb-69b1-44f0-d9c9-08d8637f2974 x-ms-traffictypediagnostic: DM6PR11MB4060: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2089; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tgrJ3sYckWdoXJKQ1dQ55vhN9GlWu/VR5rM8z8jLW8WaIQuKYJLjX3bHAQBw/ObZLIYQqwb3p/7s8ZdiHOgdgCA4QTnvO/mU3XOINtNpSuMSTXc+k/dr9Q8hSuNao//Ngv42ldpzj8ANEHAUgV89ADO1zjUY5lDqg7RO0QlWjxE7zGNDN9/R/vCTl5F+te6KpNmcFYf+pYEDlL6F1oKH58hYLi4XkrQURYlF0dcTQPo7qT8MMnRRzYlnUpHq2AZC2NXJPzIciK19mEcu1lkn81mSpkIBatuKbLQrc6InSIAv1RU+RJMiS02u1J+a9wBIfCnalnkGnBOcbO6iAwHS5aEWZiSh1gixcb/9uHW7yjX3wYXQYS+9b/E1vVawZCbSIBuXViZ3cuPLNJ1Y7kcun9KG8uAMfnQ4op+BHf+E8kVIeVyvvgsaczdchex3KgIldsPd4Db82saFbpBgWErDZQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB1372.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(136003)(396003)(39860400002)(366004)(83380400001)(2906002)(76116006)(66946007)(296002)(7696005)(71200400001)(316002)(5660300002)(33656002)(52536014)(8676002)(110136005)(6506007)(86362001)(8936002)(54906003)(55016002)(53546011)(9686003)(4326008)(26005)(186003)(478600001)(64756008)(66556008)(66446008)(66476007)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: ysYOtnGHpNq8Z5mhud17VCtVvedIQAAjql+8vS9GGuOXqEkCxM72c9RNdK8Eice7jBa8yyXKUFcrfy17JkRlxo4piftg/fhBzdXPB8P/1S7hVzEix21oDpeI33eKNnC7ukazRbmpDUjtFsHYVyhaJzCyqsVqo2nsLMJw8fNPLpk5VwU29yLRka6a3TzFNACK8EzMbI6eySr4WZmdmQbx8A+KP1qKcsQfnRjxtubvWMabGXY0+8jO+nRHEMyHngUJhcRI0ttkrbzjU1JkIbaxDbgZJDYIggT1w86Zcb1KMeXhjwnToiVjuk9XIWYMbt0iB2x6DWQaxNxtoQcWYdLKQ0U+3eI7JSR5OY1q2ZBr2Yma/VO8w1hT73VDxq0dhK/hNvxFyh4IrHKvibTWnBh81QK4bAEiqAHgs1dB65Ezn3cSkGEYSGVZsrsfUnBvylNy628rjqKIXWHeSZ4VKA5vySPYKmdrVbpPh8OJg747R3vGoj6hkjs8b9FQM7S+/ej6RwaoJiPAXG/p5V1qMrj8+PgspJQnCseuuniIyC9GZGIRsU1DfE5IrHE4vPf9sQLB9xY0iBaScKy/Y5+yYsn9/egZ1BzYujxoJv5oLSMZ26nNStTpcVcWiSTCXNhxjQJ822UemQo8VAbBnoiOpRp90A== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1372.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8fe857bb-69b1-44f0-d9c9-08d8637f2974 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2020 07:21:47.9565 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: V53mE3RGiUvbF/0+8FO01uE7Mo7v2w998Fo0EvHc1SmcHzCjs/dLEG1rUHTlleudpZX76L8eYZGbFYc/nImNJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4060 Return-Path: jiaxin.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Wu Jiaxin Thanks, Jiaxin > -----Original Message----- > From: Abner Chang > Sent: Monday, September 28, 2020 2:30 PM > To: devel@edk2.groups.io > Cc: abner.chang@hpe.com; Maciej Rabeda ; > Wu, Jiaxin ; Fu, Siyuan ; Nickl= e > Wang > Subject: [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when > reset >=20 > BZ #2909, > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2909 >=20 > When Http->Configure() is invoked with HttpConfigData set to > NULL to reset the EFI HTTP instance, TLS child instance is > destroyed but HttpInstance->TlsChildHandle is not set to > NULL. After reconfiguring HTTP through Http->Configure() > and sending the HTTP request to HTTPS URL, TLS child > instance is not recreated because > HttpInstance->TlsChildHandle is not NULL. >=20 > Signed-off-by: Abner Chang >=20 > Cc: Maciej Rabeda > Cc: Wu Jiaxin > Cc: Fu Siyuan > Cc: Nickle Wang > --- > NetworkPkg/HttpDxe/HttpProto.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/NetworkPkg/HttpDxe/HttpProto.c > b/NetworkPkg/HttpDxe/HttpProto.c > index 3c7c6ff9f0c..afc7db5a726 100644 > --- a/NetworkPkg/HttpDxe/HttpProto.c > +++ b/NetworkPkg/HttpDxe/HttpProto.c > @@ -873,6 +873,7 @@ HttpCleanProtocol ( > // Destroy the TLS instance. > // > HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, HttpInstance= - > >TlsChildHandle); > + HttpInstance->TlsChildHandle =3D NULL; > } >=20 > if (HttpInstance->Tcp4ChildHandle !=3D NULL) { > -- > 2.21.0.windows.1