From: "Yuwei Chen" <yuwei.chen@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"xiewenyi2@huawei.com" <xiewenyi2@huawei.com>,
"Feng, Bob C" <bob.c.feng@intel.com>,
"gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>
Cc: "songdongkuang@huawei.com" <songdongkuang@huawei.com>
Subject: Re: [edk2-devel] [PATCH EDK2 v1 1/1] BaseTools: Remove dependence of libuuid
Date: Mon, 23 Aug 2021 00:56:36 +0000 [thread overview]
Message-ID: <DM5PR11MB15941D488DCF55C12E54BCBE96C49@DM5PR11MB1594.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1628240795-130638-2-git-send-email-xiewenyi2@huawei.com>
Reviewed-by: Yuwei Chen<yuwei.chen@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> wenyi,xie via groups.io
> Sent: Friday, August 6, 2021 5:07 PM
> To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>;
> gaoliming@byosoft.com.cn; Chen, Christine <yuwei.chen@intel.com>
> Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
> Subject: [edk2-devel] [PATCH EDK2 v1 1/1] BaseTools: Remove dependence
> of libuuid
>
> The uuid.h only included in file GenFvInternalLib.c, but no interface from
> libuuid is used in this file.
> So remove this include and link to libuuid.
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> ---
> BaseTools/Source/C/GenFv/GenFvInternalLib.c | 5 -----
> BaseTools/Source/C/DevicePath/GNUmakefile | 4 ----
> BaseTools/Source/C/GenFv/GNUmakefile | 4 ----
> BaseTools/Source/C/GenFw/GNUmakefile | 4 ----
> BaseTools/Source/C/GenSec/GNUmakefile | 4 ----
> 5 files changed, 21 deletions(-)
>
> diff --git a/BaseTools/Source/C/GenFv/GenFvInternalLib.c
> b/BaseTools/Source/C/GenFv/GenFvInternalLib.c
> index 6e296b8ad6b2..80bab7fb1381 100644
> --- a/BaseTools/Source/C/GenFv/GenFvInternalLib.c
> +++ b/BaseTools/Source/C/GenFv/GenFvInternalLib.c
> @@ -13,11 +13,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent //
> Include files //
>
> -#if defined(__FreeBSD__)
> -#include <uuid.h>
> -#elif defined(__GNUC__)
> -#include <uuid/uuid.h>
> -#endif
> #ifdef __GNUC__
> #include <sys/stat.h>
> #endif
> diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile
> b/BaseTools/Source/C/DevicePath/GNUmakefile
> index 7ca08af9662d..1271555df8d5 100644
> --- a/BaseTools/Source/C/DevicePath/GNUmakefile
> +++ b/BaseTools/Source/C/DevicePath/GNUmakefile
> @@ -18,7 +18,3 @@ ifeq ($(CYGWIN), CYGWIN)
> LIBS += -L/lib/e2fsprogs -luuid
> endif
>
> -ifeq ($(LINUX), Linux)
> - LIBS += -luuid
> -endif
> -
> diff --git a/BaseTools/Source/C/GenFv/GNUmakefile
> b/BaseTools/Source/C/GenFv/GNUmakefile
> index 7c7b95ba1be2..fd8f16903ade 100644
> --- a/BaseTools/Source/C/GenFv/GNUmakefile
> +++ b/BaseTools/Source/C/GenFv/GNUmakefile
> @@ -17,7 +17,3 @@ ifeq ($(CYGWIN), CYGWIN)
> LIBS += -L/lib/e2fsprogs -luuid
> endif
>
> -ifeq ($(LINUX), Linux)
> - LIBS += -luuid
> -endif
> -
> diff --git a/BaseTools/Source/C/GenFw/GNUmakefile
> b/BaseTools/Source/C/GenFw/GNUmakefile
> index 76cda7e7a3f6..3b9a781b5cf6 100644
> --- a/BaseTools/Source/C/GenFw/GNUmakefile
> +++ b/BaseTools/Source/C/GenFw/GNUmakefile
> @@ -17,7 +17,3 @@ ifeq ($(CYGWIN), CYGWIN)
> LIBS += -L/lib/e2fsprogs -luuid
> endif
>
> -ifeq ($(LINUX), Linux)
> - LIBS += -luuid
> -endif
> -
> diff --git a/BaseTools/Source/C/GenSec/GNUmakefile
> b/BaseTools/Source/C/GenSec/GNUmakefile
> index 9f0844c1b8fe..c2f440f21ebf 100644
> --- a/BaseTools/Source/C/GenSec/GNUmakefile
> +++ b/BaseTools/Source/C/GenSec/GNUmakefile
> @@ -17,7 +17,3 @@ ifeq ($(CYGWIN), CYGWIN)
> LIBS += -L/lib/e2fsprogs -luuid
> endif
>
> -ifeq ($(LINUX), Linux)
> - LIBS += -luuid
> -endif
> -
> --
> 2.20.1.windows.1
>
>
>
>
>
prev parent reply other threads:[~2021-08-23 0:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 9:06 [PATCH EDK2 v1 0/1] BaseTools: Remove dependence of libuuid wenyi,xie
2021-08-06 9:06 ` [PATCH EDK2 v1 1/1] " wenyi,xie
2021-08-23 0:56 ` Yuwei Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR11MB15941D488DCF55C12E54BCBE96C49@DM5PR11MB1594.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox