From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.17674.1629680200486022648 for ; Sun, 22 Aug 2021 17:56:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=vPxIoqKV; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: yuwei.chen@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10084"; a="278026747" X-IronPort-AV: E=Sophos;i="5.84,343,1620716400"; d="scan'208";a="278026747" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2021 17:56:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,343,1620716400"; d="scan'208";a="492381136" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga008.fm.intel.com with ESMTP; 22 Aug 2021 17:56:38 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 22 Aug 2021 17:56:38 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 22 Aug 2021 17:56:37 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Sun, 22 Aug 2021 17:56:37 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sun, 22 Aug 2021 17:56:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HEztnNGuNEumYpMTBgae0fsA6xBpfbAdTeJnYpmIYh7UTYPc15E0HuIbAYZwaAw6rln4ZjX4BZ42Ids93MZXJ4LV+Wvnj5KhylesRJ0dhJmecE0HCBO0/1s98nTnvm0VuG35Y00jTODaaQFsMYH7lP9GBMItF9wsfzgBGTMBuEOVfhXXIh6IXJ3jnQ5XzmqYC1Roe4UD3bZt7beKzQXdPrUIAb3QShUxqCPqUb+FKPzFLc9XoiBMWng0u+z6IzOWSiVLmTwcYZFsOpYbemKh7usjUXy3XpQg+MmlNhQQ9Ncit+u2m90Wsd56q0oFqGCqiD1ylXZ7UCSIOqUd1xn/1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cx7H6XJJHWZnwrMnhtX2Iag5eQN98txAAhP5P+AJ1gY=; b=PGYat/pxINz4jj/4O7tJTykrlhNzDy/aSFzedSuickWY+ZaH6s/Z+AIlSCP7pJcsqlEEyrCmSXV0XbaG4IyHmFe5o+EGRmZS6Y86quOWrnUVRlpR0Llvz+ZsIj1R9tLcIeHKdQzTNJaXebln56HdPbiWgjbHUZUuHRPTqvofBzl4LJYjcVAphBzcJWF86JyX53Rba3SJYt6sjNOsDklbo+gG22g2Rcf75wmWT0PJi9xHtBvDe/N0Bm5WOd2GOECev4sU5UkUPUG0uRc92Nzi6k/OiJ0mDZM0IaPSv7Irh1a5hjMe1w9169IZRXjX1FUI3y39SLjnYvlFovCWEZ1sjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cx7H6XJJHWZnwrMnhtX2Iag5eQN98txAAhP5P+AJ1gY=; b=vPxIoqKVIxv/MBc9ZBs9vh081x1fGxMhYxh9jAZ3ukHK1tS9i2z1CrwOHFxM1EOl951Z5uCbxobj/giKzMrllBzLC/UJE3QlyDLfOR7HCw/HnWE8vRM3Q8ejuZoOvMJzSWAMHTZHPPWNAdDIbyLBj0ebUyY7X2a63WafKyMWDZY= Received: from DM5PR11MB1594.namprd11.prod.outlook.com (2603:10b6:4:5::16) by DM4PR11MB5327.namprd11.prod.outlook.com (2603:10b6:5:392::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19; Mon, 23 Aug 2021 00:56:36 +0000 Received: from DM5PR11MB1594.namprd11.prod.outlook.com ([fe80::c800:980e:6984:16fd]) by DM5PR11MB1594.namprd11.prod.outlook.com ([fe80::c800:980e:6984:16fd%9]) with mapi id 15.20.4436.024; Mon, 23 Aug 2021 00:56:36 +0000 From: "Yuwei Chen" To: "devel@edk2.groups.io" , "xiewenyi2@huawei.com" , "Feng, Bob C" , "gaoliming@byosoft.com.cn" CC: "songdongkuang@huawei.com" Subject: Re: [edk2-devel] [PATCH EDK2 v1 1/1] BaseTools: Remove dependence of libuuid Thread-Topic: [edk2-devel] [PATCH EDK2 v1 1/1] BaseTools: Remove dependence of libuuid Thread-Index: AQHXiqMRdGe+SWcVkU+sffEAJXZLZauAXh0Q Date: Mon, 23 Aug 2021 00:56:36 +0000 Message-ID: References: <1628240795-130638-1-git-send-email-xiewenyi2@huawei.com> <1628240795-130638-2-git-send-email-xiewenyi2@huawei.com> In-Reply-To: <1628240795-130638-2-git-send-email-xiewenyi2@huawei.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a9403aba-48b7-4dda-1528-08d965d0dbd6 x-ms-traffictypediagnostic: DM4PR11MB5327: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1247; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +ACPxANZmGoSq0c23NLsVDg849RP9lTXuFPpMZJfkt0bFFN+ctpGiaoSm6GJZIHec2jNFJRZ8EtEJhOpYUJOtq17bDOyNiR7BOxHCFBFNOQvTCPRB75djfSbOPXgvpoP2tKnM3jrFu2BmKDmV0e5fNC6vmIqyz4q7Q4iXY4/vjercDYtyv+8MLtPOBPDT7wbwZ0Qq8PsDqUu6y8b3E3gPvFXmHfY0QkN3HM71H9zA+lKRsqK+FQR4FHht5UEMlqTFiYm+TEPOUxPOr/iHSXRJTauojKyMKsK2N+Dd4mS+OlmON4qyhTxuTyr9EP+J5fs22d3cgeRybv+kQQYVMeYTEE47fC1ZqmceXb9kXXFAuhldVcnCCKa2HD8NqtU4vGzSKBfkoPGUTroJO+G1b7PFFH3P8vGs+dLiMLG9+xSbUcAylhccip7omAhTYhMHpuids6ABOGSWE8HaeXYyyCN1f/8n9aKJ5qOBJ5Fk9AycLvJzV0Pm69G32PWLYmnRPfWBC9YqzWfi8xXL1XIU7gjuLtgZWJ90ZkWTFF5liaAEZ15EaNCII+HssQ4WQKIvu7orFCqVYbVdiFSBcHA5qNOnQXH+uGjq+QWTHw5vLMNasGHBMZS5k25enggSTtEw/IsxU0yQiWu4OkWeadkP229yXp/rWfk76wJbvJcIesO8pSyHCzc0rP9NjHlrdmyZojd4ze1YZs45OyAxYHXofTppwFntPwG7f/Nzt8MlyQrjwVDPtmd/khO0yN4IfM6UGJ5TjVuHlUaUTZ2xG5XtFR4lSYHikpULuxIxl4oFOznXcZehoyARLI6Zda3Zq9jvUu0+kMCNVqGzXnCVpaH8zJkRQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB1594.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(39860400002)(396003)(136003)(71200400001)(316002)(122000001)(478600001)(7696005)(26005)(8676002)(52536014)(4326008)(8936002)(966005)(38100700002)(38070700005)(5660300002)(110136005)(55016002)(33656002)(186003)(66946007)(86362001)(83380400001)(64756008)(76116006)(6506007)(66476007)(66556008)(66446008)(53546011)(2906002)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?W3mU1PC0XmpFeYeIZ/6a7mJQsnxkPpV0x+mM+YODOTMDzc20ZUoKkiTa9uGQ?= =?us-ascii?Q?PH3hN8BQR66CQJl46AgkoEmpEel37/hWuEOryUq98mGetSevGNeiFwo7vIDY?= =?us-ascii?Q?TDbT765g4RHw5eIyNUMBjNUKfsTuUZh+wXg6OF44QptEN01a79x1jXCBvEol?= =?us-ascii?Q?sv0x6z7Ya2XyIGnJDJ8xX9cctdoEW0tiBaEStPIhKHfICfkw0YnKCWG0ijtQ?= =?us-ascii?Q?1gn3t7aE83ZLoYYYgWen/pxQaADZbe1cWMC1U42UmIXLbTbXiH0bc3evaXUT?= =?us-ascii?Q?u0xxFMDm9Vkcgvr/Ux2SHbbpcEFmg6aXX5Sr0CrgfENN3DQ9OdOKsGkSj1rV?= =?us-ascii?Q?TraPKaftp5Hkg1s+ZgtxF45R4OrwF2QtNW56NjnZJRYx2vAm7YuX7x1En9Uu?= =?us-ascii?Q?SCkrv14GFvIbLaCnUz69YLlLDu9xFnZwwOz4ceYUt9fKzF8d6ub6xDfzBtsA?= =?us-ascii?Q?ybHvnaU31DIW2Ry8i4ps4r++KfioymoA9EieG7au8RhYQZn7/VpDLGS/vgGh?= =?us-ascii?Q?9FtXT1iToxPsTV7si+Oz+wgKAmDYZNC01AmBygU4sNbLu5HHkoMShlUk/QL6?= =?us-ascii?Q?as82QOhuKtkwKJiItm1MKZTYMy6sPY7SiV/wPsgLLU89fXltl29TMyXQK0MQ?= =?us-ascii?Q?qSuroiaKiLSiGjTmtX99d41g5NvN6nrwVjqO02e0WqJGWR4cwMYEfKcPZENh?= =?us-ascii?Q?pl5aFZ9lwj4AFRDbLNox4aF7bjHVnLDZ3pC9VXRZP4IlslUTBbdjgYXagLnK?= =?us-ascii?Q?GR1ZGLZahmUscE0ACgCzLWO19Fp9gOAQyOtsXLHPWoS5orEKQzUPrgAfJ1A2?= =?us-ascii?Q?hKXa43BcCJNruUh7IN2SVsvx2a25uCMPn62oMRGcFddHr6rG0xCYC0sQmsXW?= =?us-ascii?Q?dqPkLJEXWGcEfD9/w9tdndD/Cc19OiJddUZ4adGuhLYSd1P7JGxhCOiu4Ep+?= =?us-ascii?Q?Ft2c0A3r26tYOJqmeN+zhbZXC/P0FMzerXGd4uoD1YZnZoGXSDZ7pVdvIRea?= =?us-ascii?Q?/hFMYhZ8ee5sL91J6PDVB+iK3zmo3kgIa9OWMBm6Uy9svxj18pkhE9u/tKmR?= =?us-ascii?Q?5Y5Fhp9bhBULDHi9pRoW0ajjad8/2kB7vWjSPDW0Pn4zH8Ga1FYp/7cu7v1c?= =?us-ascii?Q?whyaPz1azANNZAZfkdlMKt7xK6Va3HzM2gZ0Nh8wNA/Fc8Utg2omZE5hkwJc?= =?us-ascii?Q?TL5F6SKKYuZzm/UvEjcXEugHrIwAXeGPWk10AkO6KMgApor5ATLqT7s3gkjR?= =?us-ascii?Q?7OJTaWgJB4uwomM/OAh4AB4dHe8j4nPGBRVzdLjAAXnvfMHmnjx4YYznGwKj?= =?us-ascii?Q?0NJ6+FvrEhf5s8/Am7eNyVPv?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1594.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9403aba-48b7-4dda-1528-08d965d0dbd6 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2021 00:56:36.2870 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sMycax5TuHm3VqBiJGMKzbSSHfQuYntJ7a79mkUjKYsO8UCeDLN/CAup+NVrZ1WwScgFT+26h+m1GPndgzpLmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5327 Return-Path: yuwei.chen@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Yuwei Chen > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > wenyi,xie via groups.io > Sent: Friday, August 6, 2021 5:07 PM > To: devel@edk2.groups.io; Feng, Bob C ; > gaoliming@byosoft.com.cn; Chen, Christine > Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com > Subject: [edk2-devel] [PATCH EDK2 v1 1/1] BaseTools: Remove dependence > of libuuid >=20 > The uuid.h only included in file GenFvInternalLib.c, but no interface fro= m > libuuid is used in this file. > So remove this include and link to libuuid. >=20 > Cc: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > Signed-off-by: Wenyi Xie > --- > BaseTools/Source/C/GenFv/GenFvInternalLib.c | 5 ----- > BaseTools/Source/C/DevicePath/GNUmakefile | 4 ---- > BaseTools/Source/C/GenFv/GNUmakefile | 4 ---- > BaseTools/Source/C/GenFw/GNUmakefile | 4 ---- > BaseTools/Source/C/GenSec/GNUmakefile | 4 ---- > 5 files changed, 21 deletions(-) >=20 > diff --git a/BaseTools/Source/C/GenFv/GenFvInternalLib.c > b/BaseTools/Source/C/GenFv/GenFvInternalLib.c > index 6e296b8ad6b2..80bab7fb1381 100644 > --- a/BaseTools/Source/C/GenFv/GenFvInternalLib.c > +++ b/BaseTools/Source/C/GenFv/GenFvInternalLib.c > @@ -13,11 +13,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent // > Include files // >=20 > -#if defined(__FreeBSD__) > -#include > -#elif defined(__GNUC__) > -#include > -#endif > #ifdef __GNUC__ > #include > #endif > diff --git a/BaseTools/Source/C/DevicePath/GNUmakefile > b/BaseTools/Source/C/DevicePath/GNUmakefile > index 7ca08af9662d..1271555df8d5 100644 > --- a/BaseTools/Source/C/DevicePath/GNUmakefile > +++ b/BaseTools/Source/C/DevicePath/GNUmakefile > @@ -18,7 +18,3 @@ ifeq ($(CYGWIN), CYGWIN) > LIBS +=3D -L/lib/e2fsprogs -luuid > endif >=20 > -ifeq ($(LINUX), Linux) > - LIBS +=3D -luuid > -endif > - > diff --git a/BaseTools/Source/C/GenFv/GNUmakefile > b/BaseTools/Source/C/GenFv/GNUmakefile > index 7c7b95ba1be2..fd8f16903ade 100644 > --- a/BaseTools/Source/C/GenFv/GNUmakefile > +++ b/BaseTools/Source/C/GenFv/GNUmakefile > @@ -17,7 +17,3 @@ ifeq ($(CYGWIN), CYGWIN) > LIBS +=3D -L/lib/e2fsprogs -luuid > endif >=20 > -ifeq ($(LINUX), Linux) > - LIBS +=3D -luuid > -endif > - > diff --git a/BaseTools/Source/C/GenFw/GNUmakefile > b/BaseTools/Source/C/GenFw/GNUmakefile > index 76cda7e7a3f6..3b9a781b5cf6 100644 > --- a/BaseTools/Source/C/GenFw/GNUmakefile > +++ b/BaseTools/Source/C/GenFw/GNUmakefile > @@ -17,7 +17,3 @@ ifeq ($(CYGWIN), CYGWIN) > LIBS +=3D -L/lib/e2fsprogs -luuid > endif >=20 > -ifeq ($(LINUX), Linux) > - LIBS +=3D -luuid > -endif > - > diff --git a/BaseTools/Source/C/GenSec/GNUmakefile > b/BaseTools/Source/C/GenSec/GNUmakefile > index 9f0844c1b8fe..c2f440f21ebf 100644 > --- a/BaseTools/Source/C/GenSec/GNUmakefile > +++ b/BaseTools/Source/C/GenSec/GNUmakefile > @@ -17,7 +17,3 @@ ifeq ($(CYGWIN), CYGWIN) > LIBS +=3D -L/lib/e2fsprogs -luuid > endif >=20 > -ifeq ($(LINUX), Linux) > - LIBS +=3D -luuid > -endif > - > -- > 2.20.1.windows.1 >=20 >=20 >=20 >=20 >=20