From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.12065.1601347187257785339 for ; Mon, 28 Sep 2020 19:39:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=cqN48oL4; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: yuwei.chen@intel.com) IronPort-SDR: aa3Oc+LT2xGT2VI0ESuzNnj8MdelHT77FZB41drfsR4bX4TyEHr2iqdnE6EPakCWU7+vEXSoHJ mcxdDuhYEEgg== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="162160474" X-IronPort-AV: E=Sophos;i="5.77,316,1596524400"; d="scan'208";a="162160474" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 19:39:46 -0700 IronPort-SDR: fpEv5kxZcQKVijfxPvuO5TLdAne2cDmoOOpLXKjYgcdHlZpbqFIoA/3FWZ4Xd3kjufu7/J890A tK0keaAJOV0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,316,1596524400"; d="scan'208";a="488856524" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga005.jf.intel.com with ESMTP; 28 Sep 2020 19:39:46 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 28 Sep 2020 19:39:45 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 28 Sep 2020 19:39:45 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 28 Sep 2020 19:39:45 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 28 Sep 2020 19:39:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iqYwR/GEzAJIUnjCfgG1PRBghgw0FtFquNsMsF49RcvmEjNpGXsnlOkXE6G/Yn6jTaF4bZBdB/kQkFH/bf1oJPW6+XJP+K8HxSW3ohEgZLqiN+Dz6FdWw+SAEO81r5AKkmKQgJngXaCgVDE+gvL8f6MHW4yf82/n4PW2Gtl/7/W0ii+J21x97GaDt4UVBbSgFQFXFQ7ozgAWVdQAH3r14KqeyU1Lpamggbzi89+K5RDlOzePB6Sz779qGgnAOd1MNJd0HS0St2RdSZ3YbgYbau1xtPGwFQxa5LSB5f5Q52CrBB/069YaDfrTQOgv9HAVCMl/iaMyX9CHk3kOtgXFsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U9cxGkb+s4TLm5fe7+vBDCsvXbjyRKOFJpCNjxSSpCs=; b=V8ZHJU4dZTJew/JU2zq2sXCmefJ2i70Fub42/dpdgYZ3w3B5/LvdK8krNqXRvqJFdtYGxUgzCxqRkzSVUAXgykVdPoWMICZKaAvoS2p2PTKrHQM7XnsFaUPI6YuC5TxU8XmiNEvBv16vUhTQO0hRpHp1LAuK8XtlHC0YB9k9TNjLv9bM2rqBfIYrFpnCKkwsc5b1jSHG6+b7fNdf2+UaZ0eWgwZFyRON5refUAPNRpNBV5jmoVphLuEVv0MbSgp72yf2tlUkocDgtNq3CCOo1UX9WEsix9VRuc7h8Vz5KMK9ruahGwweg5ZYpxMqEL/csbZHuGPVEOp9MyT2JqOhCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U9cxGkb+s4TLm5fe7+vBDCsvXbjyRKOFJpCNjxSSpCs=; b=cqN48oL42U322FY88+QDD4whpmDJOfpo7IuxiXCfE/jx99MOw7D58HUy5IVmLt0LhEtm1mYh73obKPtk206mxfUDrUHrORN27liX1AsrF+/xktEYudBQ0aechTgoXAWROtKjf5lRNX/DIc99AQuDDyaYzWJQsEIdiVHNW5Oyy0g= Received: from DM5PR11MB1594.namprd11.prod.outlook.com (2603:10b6:4:5::16) by DM5PR11MB0059.namprd11.prod.outlook.com (2603:10b6:4:62::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15; Tue, 29 Sep 2020 02:39:44 +0000 Received: from DM5PR11MB1594.namprd11.prod.outlook.com ([fe80::952e:51d:d3db:b10a]) by DM5PR11MB1594.namprd11.prod.outlook.com ([fe80::952e:51d:d3db:b10a%12]) with mapi id 15.20.3412.029; Tue, 29 Sep 2020 02:39:44 +0000 From: "Yuwei Chen" To: "devel@edk2.groups.io" , "gaoliming@byosoft.com.cn" CC: "Feng, Bob C" Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Move C tool flags before the common flags Thread-Topic: [edk2-devel] [PATCH 1/1] BaseTools: Move C tool flags before the common flags Thread-Index: AQHWi8UuUZHJdqABDU+UEQ048OFWOKl+/ADw Date: Tue, 29 Sep 2020 02:39:44 +0000 Message-ID: References: <20200916010301.1247-1-gaoliming@byosoft.com.cn> In-Reply-To: <20200916010301.1247-1-gaoliming@byosoft.com.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4ca266a1-6914-49c1-ddfa-08d86420ec6c x-ms-traffictypediagnostic: DM5PR11MB0059: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:215; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1BGVrtK2df/HFG7NFc3ynmGsAeVy8lhbiAnfpPetc/A6p7uZb4ax+rpgJvd4Nu2g0vIalnLVipP2WjCBcXKwDtgnd694sBM/FjeMUqalfzk4W8b31eN52Kr3I2+v+FReCpvN4gGuBIPcXyQ+ZC0awtN7vo1XZmE0fjFAQqNnNMwylC5S0iIclJJ+U/87+3cDujdLKhKq+Hf4+vHYptImzGYMIrLh+hjM5w6COqna/KADgXRyK6jIWZv8VtFc+HHWLdBQqTJMdwDj3fjzViiUbKxwk8ecXYR4FgD5h8WdCWiI8gtj/twq6b33R4nYv002pQPG1xtpkgw9aqPfKwu1U2VNV4AeeVcuiladWQZNRmobGsavMo8WktkynRkJDtJCHU2SfVJSjELEM2BeRDgoU9e7Uyf6XyMMii9FaN/Qp/VuQz3BQDA0wUci62pVDVYvmRMtrmsDwvHWbGsbAye6OrgDaYt/aFdEoMNTQZL1RmTm0Tdd2w1e+iv1Dx31TFBIUo4RWX+SjKVvtjOPs+RRuQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB1594.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(136003)(366004)(346002)(39860400002)(396003)(66446008)(33656002)(66946007)(2906002)(76116006)(55016002)(71200400001)(110136005)(8676002)(26005)(966005)(9686003)(8936002)(478600001)(186003)(52536014)(7696005)(64756008)(66476007)(66556008)(53546011)(6506007)(86362001)(107886003)(4326008)(5660300002)(316002)(83380400001)(545624004)(460985005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: xpVXdvFjCzDJ4XTZtWTBqqUeQmLtXgRuJpXiHgBIJ3zLP+Xc3wexS4ug8y/4go0zsAjYlGqk71eIC6xPR77usnww5k0DQVmXkiQt+jUU6XyqqjFCoxbfOYkeZu9qyWfPAEKieGbwPB0Ybr8CWWemp8PAThs77+NATObwx1YqCixQ+EGuRHdsbGKhG9TiCobQ+5+EbFcU8m/ffrtwoUK9WEXDYiUTC/lhZPkaTmslFWpSUhtl1NSPo8xpibCpPLw7MS02Voh7idqaEjwPJ4Joch3Am+LOfz1kw+PPGNIx1Mc1tWAjpB9A2GfR+Ai6b4kv/uebll6liBFb2F1BiNBT4+ltDTkkSUN7+1N+pUkQg8r0EQX1P18yFvE3qQoiUsMNpKsQIoFhy07Cj8XU5Y6On8QgmZH8PfUxpw5+5Cv+sWChdmeTUFYexdreVslI9jWNirZgFoUY521nBQylXKGVgVGO3jsFoF3opGdJF+UMtsSdaSsdepgMoCRW3XP4gF2qE3RH+Ol5m2JrKIeKz7FbA6wVuq7vi/6XPRDDZIKTY7pS9pZH/YYt52OJJjImnQdgboI2Y0UZ+DhqIwF82Y6h345BCyZg28wH1XxqkSccsuT48MdOrj+ZluPjOF8F3WdGuJrWmWAX08dv6TZtoFX5vA== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1594.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ca266a1-6914-49c1-ddfa-08d86420ec6c X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2020 02:39:44.0834 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6C2lXczK9hx49SPFtOLbs18/A/FtKDPht04AQT8lSwxDSrvGHzU556wS9l0d4/054WbtrLNwOENl1XD2fT6yRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB0059 Return-Path: yuwei.chen@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Yuwei Chen > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > gaoliming > Sent: Wednesday, September 16, 2020 9:03 AM > To: devel@edk2.groups.io > Cc: Chen, Christine ; Feng, Bob C > > Subject: [edk2-devel] [PATCH 1/1] BaseTools: Move C tool flags before th= e > common flags >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2938 >=20 > C tool may add the additional INC include path. They should have high pr= iority > than the common INC include path. > This fix is to resolve the structure PCD issue to refer to the same head= er file > defined in BaseTools and MdePkg. The one in MdePkg should be used. >=20 > Cc: Yuwei Chen > Cc: Bob Feng > Signed-off-by: Liming Gao > --- > BaseTools/Source/C/Makefiles/ms.common | 2 +- > BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/BaseTools/Source/C/Makefiles/ms.common > b/BaseTools/Source/C/Makefiles/ms.common > index f5f77fdc0bc5..b2dbcf376c04 100644 > --- a/BaseTools/Source/C/Makefiles/ms.common > +++ b/BaseTools/Source/C/Makefiles/ms.common > @@ -55,7 +55,7 @@ AR =3D lib.exe > LD =3D link.exe > LINKER =3D $(LD) >=20 > -INC =3D -I . -I $(SOURCE_PATH)\Include -I $(ARCH_INCLUDE) -I > $(SOURCE_PATH)\Common $(INC) > +INC =3D $(INC) -I . -I $(SOURCE_PATH)\Include -I $(ARCH_INCLUDE) -I > +$(SOURCE_PATH)\Common >=20 > CFLAGS =3D $(CFLAGS) /nologo /Zi /c /O2 /MT /W4 /WX /D > _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE > CPPFLAGS =3D $(CPPFLAGS) /EHsc /nologo /Zi /c /O2 /MT /D > _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE diff -- > git a/BaseTools/Source/Python/Workspace/DscBuildData.py > b/BaseTools/Source/Python/Workspace/DscBuildData.py > index 1afbd3eefc6c..eba65625337a 100644 > --- a/BaseTools/Source/Python/Workspace/DscBuildData.py > +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py > @@ -2639,7 +2639,7 @@ class DscBuildData(PlatformBuildClassObject): > else: > MakeApp =3D MakeApp + PcdGccMakefile > MakeApp =3D MakeApp + 'APPFILE =3D %s/%s\n' % (self.OutputP= ath, > PcdValueInitName) + 'APPNAME =3D %s\n' % (PcdValueInitName) + 'OBJECTS > =3D %s/%s.o %s.o\n' % (self.OutputPath, PcdValueInitName, > os.path.join(self.OutputPath, PcdValueCommonName)) + \ > - 'include $(MAKEROOT)/Makefiles/app.makefile\n' + = 'INCLUDE > +=3D' > + 'include $(MAKEROOT)/Makefiles/app.makefile\n' + > 'TOOL_INCLUDE +=3D' >=20 > IncSearchList =3D [] > PlatformInc =3D OrderedDict() > -- > 2.27.0.windows.1 >=20 >=20 >=20 >=20 >=20 >=20