From: "Yuwei Chen" <yuwei.chen@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"crobinso@redhat.com" <crobinso@redhat.com>
Subject: Re: [edk2-devel] [PATCH 3/3] BaseTools: Drop check for distutils.utils
Date: Mon, 26 Jul 2021 06:20:42 +0000 [thread overview]
Message-ID: <DM5PR11MB15945ABE8CB8D629CB029D8E96E89@DM5PR11MB1594.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1a3162c86b5bdda83505ee074ad7bcdc932b92d7.1627070203.git.crobinso@redhat.com>
This patch looks good to me.
Reviewed-by: Yuwei Chen<yuwei.chen@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Cole
> Sent: Saturday, July 24, 2021 4:02 AM
> To: devel@edk2.groups.io
> Cc: Cole Robinson <crobinso@redhat.com>
> Subject: [edk2-devel] [PATCH 3/3] BaseTools: Drop check for distutils.utils
>
> distutils.utils is no longer used anywhere, so this check can be dropped.
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> BaseTools/Tests/RunTests.py | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/BaseTools/Tests/RunTests.py b/BaseTools/Tests/RunTests.py
> index 81af736cd8..934683a446 100644
> --- a/BaseTools/Tests/RunTests.py
> +++ b/BaseTools/Tests/RunTests.py
> @@ -13,13 +13,6 @@ import os
> import sys
> import unittest
>
> -try:
> - import distutils.util
> -except ModuleNotFoundError:
> - sys.exit('''
> -Python reported: "No module named 'distutils.util"
> -''')
> -
> import TestTools
>
> def GetCTestSuite():
> --
> 2.31.1
>
>
>
>
>
next prev parent reply other threads:[~2021-07-26 6:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 20:02 [PATCH 0/3] BaseTools: fix some python DeprecationWarnings Cole
2021-07-23 20:02 ` [PATCH 1/3] build: Fix python3.10 threading DeprecationWarnings Cole
2021-07-23 20:02 ` [PATCH 2/3] python: Replace distutils.utils.split_quotes with shlex.split Cole
2021-07-23 20:02 ` [PATCH 3/3] BaseTools: Drop check for distutils.utils Cole
2021-07-26 6:20 ` Yuwei Chen [this message]
2021-07-26 3:52 ` [edk2-devel] [PATCH 0/3] BaseTools: fix some python DeprecationWarnings Bob Feng
2021-08-10 7:48 ` Yuwei Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR11MB15945ABE8CB8D629CB029D8E96E89@DM5PR11MB1594.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox